gviz 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86acea43cf9f96125e9e319effb7e0b5cfd83dbe
-  data.tar.gz: 0d9ce484c6e2a4d5078f586a5e8de88fb48786ae
+  metadata.gz: 111365e7127ce64d1645957d112c7ea204dd6aed
+  data.tar.gz: 5784cd73f99d927fa79378d020e176f742717546
 SHA512:
-  metadata.gz: aa0642cb0fbb8fb0ff3ff1ad80c1b5ff52dc887630382d2e8eca790431ea0cdb82118f0539464f32bb332f7c18bb1262c86c769143e521fe714bc0f87e536b34
-  data.tar.gz: f50bf997cd60c46469ef0465a7999b3eef0afac3aa0b2ede4514c24627fd93558d1c1d895426ef3a5af248970f38d6c571b0aa54fda0d6ec263bf668b3795897
+  metadata.gz: a239468f16cbbb6583724c8752da66b29227551b51727607ad69dfef87137e22f0ad0ce9c5f02dc53e66a66e2df7d03c606d2ea4841f1157cdafc1a03b1fe7d1
+  data.tar.gz: 1daf776b599733172e81f856eec100039d0a2083a2f8731547cae76a21e2695489cc39f794b0a598affc9e9b02caf3fe8ed7cc5110edce30dddfefd3956279a7

data/lib/gviz/core.rb

@@ -242,7 +242,7 @@ class Gviz
   def build_attrs(attrs, join=true)
     return nil if attrs.empty?
     arr = attrs.map { |k, v|
-      if v.match(/^\s*<.*>\s*$/)  # accept HTML labels
+      if v.to_s.match(/^\s*<.*>\s*$/)  # accept HTML labels
         "#{k}=<#{v}>".gsub("\n", '').gsub(/\s+</, '<')
       else
         %(#{k}="#{v}").gsub("\n", "\\n")

data/lib/gviz/version.rb

@@ -1,3 +1,3 @@
 class Gviz
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

data/spec/gviz_spec.rb

@@ -271,6 +271,46 @@ describe Gviz do
     end
   end
 
+  describe "#build_attrs" do
+    context "with non-string values" do
+      it "converts float to string" do
+        expect( gv.send("build_attrs", {width:1.0}) ).to eq "[width=\"1.0\"]"
+      end
+    end
+
+    context "handling newline characters in values" do
+      it "accepts as newline" do
+        expect( gv.send("build_attrs", {label:"hello\nworld"}) ).to eq "[label=\"hello\\nworld\"]"
+      end
+    end
+
+    context "with unicode" do
+      it "accepts as unicode values" do
+        expect( gv.send("build_attrs", {label:"こんにちは、世界！"}) ).to eq "[label=\"こんにちは、世界！\"]"
+      end
+    end
+
+    context "with HTML tag values" do
+      tag = '<TABLE><TR><TD><IMG SRC="logo.gif" /></TD></TR></TABLE>'
+      it "accepts as HTML tags" do
+        expect( gv.send("build_attrs", {label:tag}) ).to eq "[label=<<TABLE><TR><TD><IMG SRC=\"logo.gif\" /></TD></TR></TABLE>>]"
+      end
+    end
+
+    context "with HTML tag values passed by heredoc" do
+      tag =<<-HTML
+      <TABLE>
+        <TR>
+          <TD><IMG SRC="logo2.gif" /></TD>
+        </TR>
+      </TABLE>
+      HTML
+      it "accepts as HTML tags" do
+        expect( gv.send("build_attrs", {label:tag}) ).to eq "[label=<<TABLE><TR><TD><IMG SRC=\"logo2.gif\" /></TD></TR></TABLE>>]"
+      end
+    end
+  end
+
   describe "#to_s" do
     context "without attrs" do
       before do
@@ -399,60 +439,6 @@ describe Gviz do
       end
     end
 
-    context "when a label include `\\n`" do
-      before { gv.node(:a, label:"hello\nworld") }
-      subject { gv.to_s }
-      it do
-        should eql ~<<-EOS
-          digraph G {
-            a[label="hello\\nworld"];
-          }
-          EOS
-      end
-    end
-
-    context "when a label include unicode" do
-      before { gv.node(:a, label:"こんにちは、世界！") }
-      subject { gv.to_s }
-      it do
-        should eql ~<<-EOS
-          digraph G {
-            a[label="こんにちは、世界！"];
-          }
-          EOS
-      end
-    end
-
-    context "when a label include HTML-like tags" do
-      before { gv.node(:a, label:'<TABLE><TR><TD><IMG SRC="logo.gif" /></TD></TR></TABLE>') }
-      subject { gv.to_s }
-      it do
-        should eql ~<<-EOS
-          digraph G {
-            a[label=<<TABLE><TR><TD><IMG SRC="logo.gif" /></TD></TR></TABLE>>];
-          }
-          EOS
-      end
-    end
-
-    context "when a label include HTML-like tags with heredoc" do
-      before { gv.node(:a, label:<<-HTML) }
-      <TABLE>
-        <TR>
-          <TD><IMG SRC="logo2.gif" /></TD>
-        </TR>
-      </TABLE>
-      HTML
-      subject { gv.to_s }
-      it do
-        should eql ~<<-EOS
-          digraph G {
-            a[label=<<TABLE><TR><TD><IMG SRC="logo2.gif" /></TD></TR></TABLE>>];
-          }
-          EOS
-      end
-    end
-
     context "take ports on edges" do
       before do
         gv.route(:a => [:b, :c])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gviz
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - kyoendo