gv_fsm 0.2.3 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48a490d68d563a441424cfdd79c6c6051d30d4b6e55765239936aed794a898a5
-  data.tar.gz: fc16d72b89d439ae9b18f021e46a9cbf1c5caf4b48ed71a45bad2db72998005b
+  metadata.gz: 3b5c409a59baa14a81f425617228e69a99e08c6914aba00156516bb6d58f4b01
+  data.tar.gz: 88f01660fdc03e5b7e439e8eb5c471990de71f0ab32cd5fd6d6a6e93879294ec
 SHA512:
-  metadata.gz: ff52872fa8b822d0b63085cf1721bff88123d64112d3ba1103bdaf6da7e5eb1e801f5fed4526d029128b0853ab1527c45f1fc625d61cc37a9350c81709c5a578
-  data.tar.gz: 2d4c28d766e9c34bbe379af163f3302f53501870497df608142c7b67e9f02059846944d17ecac780c4d732a68be00eb790625ffbbd6d2d90b4040c764ea6dcea
+  metadata.gz: 68c7c63845e630d6b17e5d9ec7a7dac42bbd4045c9e6bd41f25bfcd8d1edc12e3b6dea3518179fe1bea72400a865e4a1fd0112980ea4625b3df3e2185cb651dd
+  data.tar.gz: 8c47fdce73aafb70871ad87cddf1a5a359021b2e1cd1f619212186d1fda7b552b30858f958ad818ab4b6a491d47e27501bb7ccd50777d1d5686be17d9c9062af

data/bin/gv_fsm

@@ -28,7 +28,7 @@ op = OptionParser.new do |parser|
     sm.cname = f
   end
 
-  parser.on("-h", "--header-only", "Only generate header file") do
+  parser.on("-e", "--header-only", "Only generate header file") do
     options[:source] = false
   end
 
@@ -44,7 +44,7 @@ op = OptionParser.new do |parser|
     sm.ino = true
   end
 
-  parser.on("-l", "--no-syslog", "Omit syslog calls in stub functions") do
+  parser.on("-l", "--no-log", "Omit log calls in stub functions") do
     sm.syslog = false
   end
 
@@ -60,28 +60,40 @@ op.parse!
 unless ARGV[0]
   STDERR.puts "ERROR: I need the path to a Graphviz file!\n\n"
   STDERR.puts op
-  exit
+  exit 1
 end
-unless File.extname(ARGV[0]) == ".dot"
+if !File.extname(ARGV[0]) == ".dot" or !File.exist? ARGV[0] then
   STDERR.puts "ERROR: #{ARGV[0]} does not look like a Graphviz file!\n\n"
   STDERR.puts op
-  exit
+  exit 2
 end
 
-sm.parse(ARGV[0])
+unless sm.parse(ARGV[0]) then
+  puts "Error parsing the file #{ARGV[0]}: #{sm.error}"
+  exit 3
+end
 
-puts "Parsed #{sm.dotfile}.\nGenerating C stub for states: #{sm.states_list.join(", ")}."
-if sm.ino then
-  sm.generate_ino
-  puts "Generated .ino file #{sm.cname}.ino"
-else
-  if options[:header] then
-    sm.generate_h 
-    puts "Generated header #{sm.cname}.h"
-  end
-  if options[:source] then
-    sm.generate_c 
-    puts "Generated source #{sm.cname}.c"
-  end
+puts "Parsed #{sm.dotfile}"
+top = sm.topology
+puts "Graph topology:"
+puts "  Pure source nodes: #{top[:sources].join(', ')}"
+puts "  Pure sink nodes:   #{top[:sinks].empty? ? "<none>" : top[:sinks].join(', ')}"
+
+if !(top[:sources].count == 1 and top[:sinks].count <= 1) then
+  puts "Topology error: there must be exactly one source and zero or one sink"
+  exit 4
+end
+
+puts "Generating C functions for states: #{sm.states_list.join(", ")}."
+puts "                   for transition: #{sm.transition_functions_list.join(", ")}."
+
+
+if options[:header] then
+  name = sm.generate_h 
+  puts "Generated header #{name}"
+end
+if options[:source] then
+  name = sm.generate_c
+  puts "Generated source #{name}"
 end
 

data/lib/gv_fsm.rb

@@ -2,13 +2,14 @@
 
 require 'ruby-graphviz'
 require 'erb'
-require 'pry'
+require 'matrix'
+
 require File.expand_path('../templates.rb', __FILE__)
 require File.expand_path("../version.rb", __FILE__)
 
 module GV_FSM
   class FSM
-    attr_reader :states, :transitions, :dotfile, :prefix
+    attr_reader :states, :transitions, :dotfile, :prefix, :error
     attr_accessor :project_name, :description, :cname, :syslog, :ino
     include GV_FSM::Templates
 
@@ -16,6 +17,9 @@ module GV_FSM
       @prefix = ""
       @syslog = true
       @ino = false
+      @error = nil
+      @matrix = nil
+      @nodemap = {}
       parse(filename) if filename
     end
 
@@ -29,14 +33,37 @@ module GV_FSM
       @dotfile = filename
       @states = []
       @transitions = []
-      GraphViz.parse(filename) do |g|
+      graph = GraphViz.parse(filename) do |g|
+        if g.graph_count > 1 then
+          @error = "Only one graph in the dot file is permitted"
+          return nil
+        end
+        unless g.type == "digraph" then
+          @error = "Graph is not directed"
+          return nil
+        end
+        n = g.node_count
+        if n == 0 then
+          @error = "Graph is empty"
+          return nil
+        end
+        @matrix = Matrix.zero(n, n)
+        @description = g.name
+        i = 0
         g.each_node do |id|
           n = g.get_node(id)
-          binding.pry
-          label = n[:label].source.empty? ? "do_#{id}" : n[:label].source
+          if n[:label].source.empty? or
+            (n[:label].source == id and !n[:label].source.match(/^do_/)) then
+            label = "do_#{id}"
+          else
+            label = n[:label].source
+          end
+          @nodemap[id] = i
+          i += 1
           @states << {id: id, function: @prefix+label}
         end
         g.each_edge do |e|
+          @matrix[@nodemap[e.node_one], @nodemap[e.node_two]] += 1
           from = e.node_one
           to = e.node_two
           unless e[:label] then
@@ -54,6 +81,11 @@ module GV_FSM
           @transitions << {from: from, to: to, function: label ? @prefix+label : nil}
         end
       end
+      unless graph then 
+        @error = "Parsing error"
+        return nil
+      end
+      return graph
     end
 
     def state_functions_list
@@ -104,27 +136,34 @@ module GV_FSM
     end
 
     def generate_c(filename = @cname)
-      File.open("#{filename}.c", "w") do |f|
+      ext = @ino ? "cpp" : "c"
+      fname = "#{filename}.#{ext}"
+      File.open(fname, "w") do |f|
         f.puts ERB.new(HEADER, 0, "<>").result(binding)
         f.puts ERB.new(CC, 0, "<>").result(binding)
       end
+      return fname
     end
 
     def generate_h(filename = @cname)
-      File.open("#{filename}.h", "w") do |f|
+      fname = "#{filename}.h"
+      File.open(fname, "w") do |f|
         f.puts ERB.new(HEADER, 0, "<>").result(binding)
         f.puts ERB.new(HH, 0, "<>").result(binding)
       end
+      return fname
     end
 
-    def generate_ino(filename=@cname)
-      @syslog = false
-      File.open("#{filename}.ino", "w") do |f|
-        f.puts ERB.new(HEADER, 0, "<>").result(binding)
-        f.puts ERB.new(HH, 0, "<>").result(binding)
-        f.puts ERB.new(CC, 0, "<>").result(binding)
-      end
+    def topology
+      res = {matrix: @matrix}
+      # rows have the number of froms, columns the number of tos
+      res[:froms] = @matrix.row_vectors.map {|v| v.sum }
+      res[:tos] = @matrix.column_vectors.map {|v| v.sum }
+      res[:sinks] = res[:froms].each_index.select {|i| res[:froms][i] == 0}.map {|i| @nodemap.keys[i]}
+      res[:sources] = res[:tos].each_index.select {|i| res[:tos][i] == 0}.map {|i| @nodemap.keys[i]}
+      return res
     end
+
   end
 
 end

data/lib/templates.rb

@@ -26,6 +26,8 @@ module GV_FSM
       #ifndef <%= @cname.upcase %>_H
       #define <%= @cname.upcase %>_H
       #include <stdlib.h>
+      <% else %>
+      #include <arduino.h>
       <% end %>
 
       // State data object
@@ -100,10 +102,13 @@ module GV_FSM
     CC =<<~EOC
       <% if !@ino then %>
       <% if @syslog then %>
+      <% log = :syslog %>
       #include <syslog.h>
       <% end %>
-      #include "<%= @cname %>.h"
+      <% else %>
+      <% if @syslog then log = :ino end %>
       <% end %>
+      #include "<%= @cname %>.h"
       
       <% placeholder = "Your Code Here" %>
       // SEARCH FOR <%= placeholder %> FOR CODE INSERTION POINTS!
@@ -159,8 +164,10 @@ module GV_FSM
       <%= @prefix %>state_t <%= s[:function] %>(<%= @prefix %>state_data_t *data) {
         <%= @prefix %>state_t next_state = <%= dest[s[:id]].first %>;
 
-      <% if @syslog then %>
+      <% if log == :syslog then %>
         syslog(LOG_INFO, "[FSM] In state <%= s[:id] %>");
+      <% elsif log == :ino then %>
+        Serial.println("[FSM] In state <%= s[:id] %>");
       <% end %>
         /* <%= placeholder %> */
         
@@ -170,8 +177,12 @@ module GV_FSM
       <% end %>
             break;
           default:
-      <% if @syslog then %>
+      <% if log == :syslog then %>
             syslog(LOG_WARNING, "[FSM] Cannot pass from <%= s[:id] %> to %s, remaining in this state", state_names[next_state]);
+      <% elsif log == :ino then %>
+            Serial.print("[FSM] Cannot pass from <%= s[:id] %> to ");
+            Serial.print(state_names[next_state]);
+            Serial.println(", remaining in this state");
       <% end %>
             next_state = <%= @prefix.upcase %>NO_CHANGE;
         }
@@ -202,8 +213,10 @@ module GV_FSM
       // <%= i+1 %>. from <%= e[:from] %> to <%= e[:to] %>
       <% end %>
       void <%= t %>(<%= @prefix %>state_data_t *data) {
-      <% if @syslog then %>
+      <% if log == :syslog then %>
         syslog(LOG_INFO, "[FSM] State transition <%= t %>");
+      <% elsif log == :ino then %>
+        Serial.println("[FSM] State transition <%= t %>");
       <% end %>
         /* <%= placeholder %> */
       }
@@ -226,6 +239,7 @@ module GV_FSM
 
       <%= @prefix %>state_t <%= @prefix %>run_state(<%= @prefix %>state_t cur_state, <%= @prefix %>state_data_t *data) {
         <%= @prefix %>state_t new_state = <%= @prefix %>state_table[cur_state](data);
+        if (new_state == <%= @prefix.upcase %>NO_CHANGE) new_state = cur_state;
       <% if transition_functions_list.count > 0 then %>
         transition_func_t *transition = <%= @prefix %>transition_table[cur_state][new_state];
         if (transition)
@@ -236,12 +250,19 @@ module GV_FSM
 
       <% if @ino then %>
       /* Example usage:
+      <%= @prefix %>state_data_t data = {count: 1};
+
+      void loop() {
+        static <%= @prefix %>state_t cur_state = <%= @prefix.upcase %>STATE_INIT;
+        cur_state = <%= @prefix %>run_state(cur_state, &data);
+      }
+      */
       <% else %>
+      <% nsinks = topology[:sinks].count %>
       #ifdef TEST_MAIN
       #include <unistd.h>
       int main() {
-      <% end %>
-        <%= @prefix %>state_t cur_state = <%= @prefix.upcase %>STATE_INIT;
+        <%= @prefix %>state_t cur_state = <%= @prefix.upcase %>STATE_<%= @states.first[:id].upcase %>;
       <% if @syslog then %>
         openlog("SM", LOG_PID | LOG_PERROR, LOG_USER);
         syslog(LOG_INFO, "Starting SM");
@@ -249,13 +270,15 @@ module GV_FSM
         do {
           cur_state = <%= @prefix %>run_state(cur_state, NULL);
           sleep(1);
-        } while (cur_state != <%= @prefix.upcase %>STATE_STOP);
-      <% if !@ino then %>
+      <% if nsinks == 1 %>
+        } while (cur_state != <%= @prefix.upcase %>STATE_<%= topology[:sinks][0].upcase %>);
+        <%= @prefix %>run_state(cur_state, NULL);
+      <% else %>
+        } while (1);
+      <% end %>
         return 0;
       }
       #endif
-      <% else %>
-      */
       <% end %>
     EOC
   end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module GV_FSM
-  VERSION = "0.2.3"
+  VERSION = "0.2.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gv_fsm
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.8
 platform: ruby
 authors:
 - Paolo Bosetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-09 00:00:00.000000000 Z
+date: 2020-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-graphviz