gutentag 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: adb59cbc5cd83581ef775e99cb94b81f45cb5ecc9ba75f2e6fe961cdcd955eb2
-  data.tar.gz: 0cce71108169f9801466f7448aada0b90c37f548d43b7d0b4a2f1aca1e71b090
+  metadata.gz: 5afcb64119c9fff07b6c4cb8786da632f3ad66d230ea049b45b7780440b9692a
+  data.tar.gz: ed0b54305d58152e70ec3de7b5cc324c5a443a1b0f73ade5e136cedb785b77f0
 SHA512:
-  metadata.gz: c1287091c8fc104f9e0aeef3475c1ff8c02414cc7aa27f0d9b8dd578214e3d9b2b4549e284bf56beb3f1c8438984f823542b362cf2fc86602c3e581a2dcab066
-  data.tar.gz: c3756b774873e7e0342d1371b6473566dfa136cdbf60994ccc82fbb89d8f5c2c0c70d7ec5a4faeb0c08f832c9275e4e17700cae3a54ea98218e8ac88b639f65a
+  metadata.gz: 4457511634f9ffee17502b8deab34ff6a306750dc0886864cd913c68f0e60c52873a4716ef6941ee23955477ca5b72847b3d644d8dfca6e0ccc16a8d7e27bf6f
+  data.tar.gz: 355801ea0a573f02a509ece9c9175786672c79d457e7ed5935ca6b73552a9fcc6cad065c9c65bb42b29adce1958957f73ef5dc1ef7244ac65dedfdcae7f4c772

data/.github/workflows/ci.yml

@@ -61,7 +61,7 @@ jobs:
       - name: Set up ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.0
           bundler-cache: true
       - name: Rubocop
         run: bundle exec rubocop

data/.rubocop.yml

@@ -4,7 +4,7 @@ inherit_from:
 require: rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 3.0
   Exclude:
     - gemfiles/*.gemfile
     - spec/internal/db/migrate/*

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 All notable changes to this project (at least, from v0.5.0 onwards) will be documented in this file.
 
+## 3.0.1 - 2025-11-24
+
+### Fixed
+
+* Fixed dirty state after reload is called on a tagged instance. ([Michael Grosser](https://github.com/grosser) in [#54](https://github.com/pat/gutentag/pull/92))
+
+### Changed
+
+* Updated syntax to be for Ruby 3.0 and newer.
+
 ## 3.0.0 - 2025-11-21
 
 ### Breaking

data/gutentag.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "gutentag"
-  s.version     = "3.0.0"
+  s.version     = "3.0.1"
   s.authors     = ["Pat Allan"]
   s.email       = ["pat@freelancing-gods.com"]
   s.homepage    = "https://github.com/pat/gutentag"
@@ -14,6 +14,8 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {spec}/*`.split("\n")
   s.require_paths = ["lib"]
 
+  s.required_ruby_version = ">= 3.0.0"
+
   s.add_runtime_dependency     "activerecord", ">= 3.2.0"
 
   s.add_development_dependency "appraisal",           "~> 2.5.0"
@@ -22,6 +24,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency "database_cleaner",    "~> 2.1"
   s.add_development_dependency "rails"
   s.add_development_dependency "rspec-rails",         ">= 5.1.2"
-  s.add_development_dependency "rubocop",             "~> 0.81.0"
-  s.add_development_dependency "rubocop-performance", "~> 1"
+  s.add_development_dependency "rubocop",             "~> 1.81.7"
+  s.add_development_dependency "rubocop-performance", "~> 1.26"
 end

data/lib/gutentag/active_record/instance_methods.rb

@@ -42,6 +42,11 @@ module Gutentag::ActiveRecord::InstanceMethods
     super Gutentag::TagNames.call(names)
   end
 
+  def reload(*)
+    @prepared_tag_names = false
+    super
+  end
+
   private
 
   def persist_tags

data/lib/gutentag/generators/migration_versions_generator.rb

@@ -28,11 +28,10 @@ module Gutentag
       end
 
       def known_migration_names
-        @known_migration_names ||= begin
+        @known_migration_names ||=
           Dir[File.join(__dir__, "../../../db/migrate/*.rb")].collect do |path|
-            File.basename(path).gsub(/\A\d+_/, "").gsub(/\.rb\z/, "")
+            File.basename(path).gsub(/\A\d+_/, "").delete_suffix(".rb")
           end
-        end
       end
 
       def rails_version

data/spec/acceptance/dirty_state_spec.rb

@@ -12,17 +12,11 @@ RSpec.describe "Dirty state of tag names" do
     expect(article.tag_names_changed?).to eq(true)
     expect(article.tag_names_was).to eq([])
     expect(article.tag_names_change).to eq([[], ["pancakes"]])
-
-    if ActiveRecord::VERSION::STRING.to_f > 4.0
-      expect(article.tag_names_changed?(:from => [], :to => ["pancakes"])).
-        to eq(true)
-    end
-
-    if ActiveRecord::VERSION::STRING.to_f > 5.0
-      expect(article.will_save_change_to_tag_names?).to eq(true)
-      expect(article.tag_names_change_to_be_saved).to eq([[], ["pancakes"]])
-      expect(article.tag_names_in_database).to eq([])
-    end
+    expect(article.tag_names_changed?(:from => [], :to => ["pancakes"])).
+      to eq(true)
+    expect(article.will_save_change_to_tag_names?).to eq(true)
+    expect(article.tag_names_change_to_be_saved).to eq([[], ["pancakes"]])
+    expect(article.tag_names_in_database).to eq([])
   end
 
   it "knows what tag names have changed" do
@@ -34,20 +28,14 @@ RSpec.describe "Dirty state of tag names" do
     expect(article).to_not be_changed
     expect(article.tag_names_changed?).to eq(false)
     expect(article.previous_changes["tag_names"]).to eq([[], ["pancakes"]])
-
-    if ActiveRecord::VERSION::STRING.to_f >= 5.0
-      expect(article.tag_names_previously_changed?).to eq(true)
-      expect(article.tag_names_previous_change).to eq([[], ["pancakes"]])
-    end
-
-    if ActiveRecord::VERSION::STRING.to_f > 5.0
-      expect(article.saved_change_to_tag_names?).to eq(true)
-      expect(article.saved_change_to_tag_names).to eq([[], ["pancakes"]])
-      expect(article.saved_changes["tag_names"]).to eq([[], ["pancakes"]])
-      expect(article.tag_names_before_last_save).to eq([])
-      expect(article.tag_names_change_to_be_saved).to eq(nil)
-      expect(article.tag_names_in_database).to eq(["pancakes"])
-    end
+    expect(article.tag_names_previously_changed?).to eq(true)
+    expect(article.tag_names_previous_change).to eq([[], ["pancakes"]])
+    expect(article.saved_change_to_tag_names?).to eq(true)
+    expect(article.saved_change_to_tag_names).to eq([[], ["pancakes"]])
+    expect(article.saved_changes["tag_names"]).to eq([[], ["pancakes"]])
+    expect(article.tag_names_before_last_save).to eq([])
+    expect(article.tag_names_change_to_be_saved).to eq(nil)
+    expect(article.tag_names_in_database).to eq(["pancakes"])
   end
 
   it "knows when tags have not changed" do
@@ -57,4 +45,16 @@ RSpec.describe "Dirty state of tag names" do
     article.tag_names = ["pancakes"]
     expect(article.changes).to eq({})
   end
+
+  it "knows when a saved instance is reloaded (and thus has no changes)" do
+    article.update!(:tag_names => ["pancakes"])
+    article.reload
+    article.tag_names = ["pancakes"]
+
+    expect(article).not_to be_changed
+    expect(article.changes).to eq({})
+    expect(article.tag_names_changed?).to eq(false)
+    expect(article.tag_names_was).to eq(["pancakes"])
+    expect(article.tag_names_change).to eq(nil)
+  end
 end

data/spec/acceptance/tag_names_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe "Managing tags via names" do
   end
 
   it "allows for different tag normalisation" do
-    Gutentag.normaliser = lambda { |name| name.upcase }
+    Gutentag.normaliser = lambda(&:upcase)
 
     tag = Gutentag::Tag.create(:name => "melbourne")
     expect(tag.name).to eq("MELBOURNE")

data/spec/models/gutentag/tag_spec.rb

@@ -64,12 +64,9 @@ RSpec.describe Gutentag::Tag, :type => :model do
       expect(tag.errors[:name].length).to eq(1)
     end
 
-    if ENV["DATABASE"] == "mysql" || (
-      Gem::Version.new(Rails.version) < Gem::Version.new("4.2.0")
-    )
-      # When using MySQL or Rails before 4.2, string columns convert to
-      # VARCHAR(255), therefore the column has a limit of 255, even though we
-      # did not specify a limit
+    if ENV["DATABASE"] == "mysql"
+      # When using MySQL, string columns convert to VARCHAR(255), therefore the
+      # column has a limit of 255, even though we did not specify a limit.
       it "validates the length of the name" do
         tag = Gutentag::Tag.create(:name => "a" * 256)
         expect(tag.errors[:name].length).to eq(1)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Pat Allan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-11-21 00:00:00.000000000 Z
+date: 2025-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -114,28 +114,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.81.0
+        version: 1.81.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.81.0
+        version: 1.81.7
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.26'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.26'
 description: A good, simple, solid tagging extension for ActiveRecord
 email:
 - pat@freelancing-gods.com
@@ -192,7 +192,6 @@ files:
 - spec/models/gutentag/tagging_spec.rb
 - spec/spec_helper.rb
 - spec/support/adjust_migrations.rb
-- spec/support/mysql.rb
 homepage: https://github.com/pat/gutentag
 licenses:
 - MIT
@@ -205,7 +204,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/spec/support/mysql.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require "active_record"
-
-# New versions of MySQL don't allow NULL values for primary keys, but old
-# versions of Rails do. To use both at the same time, we need to update Rails'
-# default primary key type to no longer have a default NULL value.
-#
-class PatchAdapter
-  def call
-    return unless using_mysql? && using_rails_pre_4_1?
-
-    require "active_record/connection_adapters/abstract_mysql_adapter"
-    ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::
-      NATIVE_DATABASE_TYPES[:primary_key] = "int(11) auto_increment PRIMARY KEY"
-  end
-
-  def using_mysql?
-    ENV.fetch("DATABASE", "sqlite") == "mysql"
-  end
-
-  def using_rails_pre_4_1?
-    ActiveRecord::VERSION::STRING.to_f < 4.1
-  end
-end
-
-PatchAdapter.new.call