gutentag 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ec8394c126e64edbe9df0aad9007053b1a38ebd72e179054e41ed264a87f3ab
-  data.tar.gz: bafc3147166fd46d223aaefeb4b99a82e7566cc57c5283cbcde8b11995bd043e
+  metadata.gz: 2b31660115c80a0a86d70ab6b0e77896e33b8dd81b51b4d841461a692f69b808
+  data.tar.gz: 4b3bcc20917350af7a07ec5186df2c23c6b6adee1f02700a9fcfc9c46ef9978c
 SHA512:
-  metadata.gz: 8c0145e229b2ecfa4cfff1e5dbf9d8524611c72be4f55a118682dfef6ab6eb56cfec33dfe7c1e9165337004fdcc5a8d6a2724784a65dc582bf76fb397b048481
-  data.tar.gz: 3fbaa2a22bbeb0b0f2561c413ae402fd0ba3586a1b9f3d81ae1b31c58f466f15b6b944aa6b2678c4492b55563f07ef05826df6a47fc4bb997dd588501748c9c9
+  metadata.gz: 304828039b887d1f505e4ce68fbe6d0b8d3c5b70a5fa8f3cff4e26154c2a5fa278a3c3cd3a9cc3298f5609cb1b545da1ff001ddc8aa4f4af21566959562e1135
+  data.tar.gz: 68a753b3495279474106363deec171d8ba96d97621e1d131360cbb46f4d0e4d341b483b627d90f841c0b9bf44d66c84f75f5a42b7d5ea9d1e6d2a80dfa364c13

data/.travis.yml

@@ -1,11 +1,11 @@
 language: ruby
 script: bundle exec appraisal rake
 rvm:
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
-  - jruby-9.1.13.0
+  - 2.2.10
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
+  - jruby-9.1.16.0
 before_install:
   - gem install bundler
 before_script:

data/Appraisals

@@ -31,7 +31,7 @@ appraise "rails_5_1" do
 end if RUBY_VERSION.to_f >= 2.2 && RUBY_PLATFORM != "java"
 
 appraise "rails_5_2" do
-  gem "rails",  "~> 5.2.0.rc2"
+  gem "rails",  "~> 5.2.0"
   gem "pg",     "~> 1.0",   :platform => :ruby
-  gem "mysql2", "~> 0.4.0", :platform => :ruby
+  gem "mysql2", "~> 0.5.0", :platform => :ruby
 end if RUBY_VERSION.to_f >= 2.2 && RUBY_PLATFORM != "java"

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project (at least, from v0.5.0 onwards) will be documented in this file.
 
+## 2.3.2 - 2018-04-27
+
+### Fixed
+
+* The `tagged_with` method now finds tagged objects belonging to STI models (as discussed in [#53](https://github.com/pat/gutentag/issues/53)).
+
 ## 2.3.1 - 2018-04-05
 
 ### Fixed

data/gutentag.gemspec

@@ -3,7 +3,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "gutentag"
-  s.version     = "2.3.1"
+  s.version     = "2.3.2"
   s.authors     = ["Pat Allan"]
   s.email       = ["pat@freelancing-gods.com"]
   s.homepage    = "https://github.com/pat/gutentag"

data/lib/gutentag/tagged_with/id_query.rb

@@ -5,7 +5,7 @@ class Gutentag::TaggedWith::IDQuery < Gutentag::TaggedWith::Query
 
   def taggable_ids_query
     Gutentag::Tagging.select(:taggable_id).
-      where(:taggable_type => model.name).
+      where(:taggable_type => model.base_class.name).
       where(:tag_id => values)
   end
 end

data/lib/gutentag/tagged_with/name_query.rb

@@ -11,7 +11,7 @@ class Gutentag::TaggedWith::NameQuery < Gutentag::TaggedWith::Query
 
   def taggable_ids_query
     Gutentag::Tagging.joins(:tag).select(:taggable_id).
-      where(:taggable_type => model.name).
+      where(:taggable_type => model.base_class.name).
       where(Gutentag::Tag.table_name => {:name => values})
   end
 end

data/spec/gutentag/active_record_spec.rb

@@ -159,5 +159,14 @@ describe Gutentag::ActiveRecord do
       it { is_expected.to include melbourne_article, melbourne_oregon_article }
       it { is_expected.not_to include oregon_article }
     end
+
+    it "should work on STI subclasses" do
+      thinkpiece = Thinkpiece.create! :tag_names => ["pancakes"]
+
+      expect(thinkpiece.tags.reload.collect(&:name)).to eq(["pancakes"])
+      expect(
+        Thinkpiece.tagged_with(:names => "pancakes", :match => :any).to_a
+      ).to eq([thinkpiece])
+    end
   end
 end

data/spec/internal/app/models/thinkpiece.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class Thinkpiece < Article
+  #
+end

data/spec/internal/db/schema.rb

@@ -3,6 +3,7 @@
 ActiveRecord::Schema.define do
   create_table :articles, :force => true do |t|
     t.string :title
+    t.string :type
     t.timestamps :null => false
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-04 00:00:00.000000000 Z
+date: 2018-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -168,6 +168,7 @@ files:
 - spec/gutentag/active_record_spec.rb
 - spec/gutentag_spec.rb
 - spec/internal/app/models/article.rb
+- spec/internal/app/models/thinkpiece.rb
 - spec/internal/config/database.yml
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore