gutentag 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a26cb66caf12d398610c04fd395478ad28b1274d
-  data.tar.gz: 14ee875c010f87bb3f2fafe5e4bc4076210ae7a8
+SHA256:
+  metadata.gz: f9b93bd8fe90a4f54a92e36f45bce11a65cbb1098e966522ca5c31f0f00caab4
+  data.tar.gz: c72b9b7e3bc96d6baf90a8301c2436ae8cad364990f3dedab3f498977de2e8f4
 SHA512:
-  metadata.gz: 8b6c6f02542b419644cdc30e07d776227a98aef5479528d7aa80be05fa45757fc7f6eaeacd298a64df20d72cae62b63bd9e3846d1e460a13a871faabe8c9007a
-  data.tar.gz: 6d58adf70948425b4dacb24284392bbd9faf8b84c5108fffb15b042e2edd0277cfb77d78675c4c23aefa624dc3d7e401405862534d8d6f8ab34d160c8c62ce58
+  metadata.gz: 3ba282659b71f3d3444a579ecded444bb37023355789c5567985491c2ca12ec613dacdc7f22dd6e29186252f01a11967e67be2aa0ece5334c213c9537494f63d
+  data.tar.gz: 8e2d0b6526f36d163aa926d9999f0054a9b030efee14d9c101960aaa265447bb4dd602fe7330889f2ad3e6dfd2a6fc0255860cd5a57a407871f6ff39af25bb3e

data/.travis.yml

@@ -1,9 +1,10 @@
 language: ruby
 script: bundle exec appraisal rake
 rvm:
-  - 2.2.8
-  - 2.3.5
-  - 2.4.2
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
   - jruby-9.1.13.0
 before_install:
   - gem install bundler

data/Appraisals

@@ -26,3 +26,7 @@ end if RUBY_VERSION.to_f >= 2.2 && RUBY_PLATFORM != "java"
 appraise "rails_5_1" do
   gem "rails", "~> 5.1.1"
 end if RUBY_VERSION.to_f >= 2.2 && RUBY_PLATFORM != "java"
+
+appraise "rails_5_2" do
+  gem "rails", "~> 5.2.0.beta2"
+end if RUBY_VERSION.to_f >= 2.2 && RUBY_PLATFORM != "java"

data/CHANGELOG.md

@@ -0,0 +1,63 @@
+# Changelog
+
+All notable changes to this project (at least, from v0.5.0 onwards) will be documented in this file.
+
+## 2.0.0
+
+### Changed
+
+This is **a breaking change** if you're using Gutentag without Rails: To ensure database-reliant code isn't invoked before it should be, `ActiveSupport.run_load_hooks :gutentag` should be called after your database is connected.
+
+## 1.1.0 - 2017-12-16
+
+No breaking changes.
+
+Thanks to [Robin](https://github.com/rmehner), Gutentag::Tag#name will now validate default database column lengths ([#41](https://github.com/pat/gutentag/pull/41)).
+
+## 1.0.0 - 2017-10-29
+
+Behaviour that was deprecated in 0.9.0 (`has_many_tags`, `tagged_with` arguments) have now been removed.
+
+## 0.9.0 - 2017-06-02
+
+* In your models with tags, change `has_many_tags` to `Gutentag::ActiveRecord.call self`.
+* Any calls to `tagged_with` should change from `Model.tagged_with('ruby', 'pancakes')` to `Model.tagged_with(:names => ['ruby', 'pancakes'])`.
+
+In both of the above cases, the old behaviour will continue to work for 0.9.x releases, but with a deprecation warning.
+
+## 0.8.0 - 2017-01-19
+
+No breaking changes.
+
+## 0.7.0 - 2015-08-27
+
+No breaking changes.
+
+## 0.6.0 - 2015-01-24
+
+Rails 4.2 is supported as of Gutentag 0.6.0 - but please note that due to internal changes in ActiveRecord, changes to tag_names will no longer be tracked by your model's dirty state. This feature will continue to work in Rails 3.2 through to 4.1 though.
+
+## 0.5.1 - 2014-07-29
+
+## 0.5.0 - 2013-09-10
+
+Between 0.4.0 and 0.5.0, Gutentag switched table names from `tags` and `taggings` to `gutentag_tags` and `gutentag_taggings`. This has been done to avoid conflicting with the more generic table names that may exist in Rails apps already.
+
+If you were using Gutentag 0.4.0 (or older) and now want to upgrade, you'll need to create a migration manually that renames these tables:
+
+```Ruby
+rename_table :tags,     :gutentag_tags
+rename_table :taggings, :gutentag_taggings
+```
+
+## 0.4.0 - 2013-09-03
+
+## 0.3.0 - 2013-08-07
+
+## 0.2.2 - 2013-07-25
+
+## 0.2.1 - 2013-07-25
+
+## 0.2.0 - 2013-07-15
+
+## 0.1.0 - 2013-07-11

data/README.md

@@ -6,7 +6,9 @@
 
 A good, simple, solid tagging extension for ActiveRecord.
 
-This was built partly as a proof-of-concept, and partly to see how a tagging gem could work when it's not all stuffed within models, and partly just because I wanted a simpler tagging library. If you want to know more, read [this blog post](http://freelancing-gods.com/posts/gutentag_simple_rails_tagging).
+This was initially built partly as a proof-of-concept, partly to see how a tagging gem could work when it's not all stuffed within models, and partly just because I wanted a simpler tagging library. It's now a solid little tagging Rails engine.
+
+If you want to know more, read [this blog post](http://freelancing-gods.com/posts/gutentag_simple_rails_tagging).
 
 ## Contents
 
@@ -66,10 +68,19 @@ Article.tagged_with(:ids => [tag_a.id, tag_b.id], :match => :all)
 
 <h2 id="installation">Installation</h2>
 
+### Dependencies
+
+These are the versions the test suite runs against. It's possible it may work on older versions of Ruby, but it definitely won't work on older versions of Rails.
+
+* Ruby: MRI v2.2-v2.5, JRuby v9.1
+* Rails/ActiveRecord: v3.2-v5.2
+
+### Installing
+
 Get it into your Gemfile - and don't forget the version constraint!
 
 ```Ruby
-gem 'gutentag', '~> 1.1.0'
+gem 'gutentag', '~> 2.0.0'
 ```
 
 Next: your tags get persisted to your database, so let's import and run the migrations to get the tables set up:
@@ -79,7 +90,17 @@ rake gutentag:install:migrations
 rake db:migrate
 ```
 
-If you want to use Gutentag outside of Rails, you can. However, this means you lose the migration import rake task. As a workaround, here's the expected schema (as of 0.7.0):
+### Without Rails
+
+If you want to use Gutentag outside of Rails, you can. However, there are two caveats:
+
+* You'll want to invoke this code once ActiveRecord's connected to the database:
+
+```ruby
+ActiveSupport.run_load_hooks :gutentag
+```
+
+* And you'll want to set up your database with the same schema (as importing in the migrations isn't possible without Rails). The schema from 0.7.0 onwards is below:
 
 ```Ruby
 create_table :gutentag_taggings do |t|
@@ -106,45 +127,7 @@ add_index :gutentag_tags, :taggings_count
 
 <h2 id="upgrading">Upgrading</h2>
 
-### 1.1.0
-
-No breaking changes.
-
-Thanks to [Robin](https://github.com/rmehner), Gutentag::Tag#name will now validate default database column lengths ([#41](https://github.com/pat/gutentag/pull/41)).
-
-### 1.0.0
-
-Behaviour that was deprecated in 0.9.0 (`has_many_tags`, `tagged_with` arguments) have now been removed.
-
-### 0.9.0
-
-* In your models with tags, change `has_many_tags` to `Gutentag::ActiveRecord.call self`.
-* Any calls to `tagged_with` should change from `Model.tagged_with('ruby', 'pancakes')` to `Model.tagged_with(:names => ['ruby', 'pancakes'])`.
-
-In both of the above cases, the old behaviour will continue to work for 0.9.x releases, but with a deprecation warning.
-
-### 0.8.0
-
-No breaking changes.
-
-### 0.7.0
-
-No breaking changes.
-
-### 0.6.0
-
-Rails 4.2 is supported as of Gutentag 0.6.0 - but please note that due to internal changes in ActiveRecord, changes to tag_names will no longer be tracked by your model's dirty state. This feature will continue to work in Rails 3.2 through to 4.1 though.
-
-### 0.5.0
-
-Between 0.4.0 and 0.5.0, Gutentag switched table names from `tags` and `taggings` to `gutentag_tags` and `gutentag_taggings`. This has been done to avoid conflicting with the more generic table names that may exist in Rails apps already.
-
-If you were using Gutentag 0.4.0 (or older) and now want to upgrade, you'll need to create a migration manually that renames these tables:
-
-```Ruby
-rename_table :tags,     :gutentag_tags
-rename_table :taggings, :gutentag_taggings
-```
+Please refer to the [CHANGELOG](CHANGELOG.md), which covers significant and breaking changes between versions.
 
 <h2 id="configuration">Configuration</h2>
 

data/app/models/gutentag/tag.rb

@@ -11,8 +11,6 @@ class Gutentag::Tag < ActiveRecord::Base
 
   scope :by_weight, lambda { order("gutentag_tags.taggings_count DESC") }
 
-  Gutentag.tag_validations.call self
-
   before_validation :normalise_name
 
   def self.find_by_name(name)

data/gutentag.gemspec

@@ -3,7 +3,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "gutentag"
-  s.version     = "1.1.0"
+  s.version     = "2.0.0"
   s.authors     = ["Pat Allan"]
   s.email       = ["pat@freelancing-gods.com"]
   s.homepage    = "https://github.com/pat/gutentag"

data/lib/gutentag/engine.rb

@@ -2,4 +2,8 @@
 
 class Gutentag::Engine < Rails::Engine
   engine_name :gutentag
+
+  config.after_initialize do
+    ActiveSupport.run_load_hooks :gutentag
+  end
 end

data/lib/gutentag/tag_validations.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 class Gutentag::TagValidations
+  DEFAULTS = {
+    :presence   => true,
+    :uniqueness => {:case_sensitive => false}
+  }.freeze
+
   def self.call(klass)
     new(klass).call
   end
@@ -10,15 +15,24 @@ class Gutentag::TagValidations
   end
 
   def call
-    klass.validates :name,
-      :presence   => true,
-      :uniqueness => {:case_sensitive => false}
-
-    limit = klass.columns_hash["name"].limit
-    klass.validates_length_of :name, :maximum => limit if limit.present?
+    klass.validates :name, validation_options
   end
 
   private
 
   attr_reader :klass
+
+  def add_length_validation?
+    klass.table_exists? && limit.present?
+  end
+
+  def limit
+    @limit ||= klass.columns_hash["name"].limit
+  end
+
+  def validation_options
+    return DEFAULTS unless add_length_validation?
+
+    DEFAULTS.merge :length => {:maximum => limit}
+  end
 end

data/lib/gutentag.rb

@@ -41,6 +41,11 @@ elsif ActiveRecord::VERSION::MAJOR == 4 && ActiveRecord::VERSION::MINOR < 2
   Gutentag.dirtier = Gutentag::Dirty
 end
 
+require "active_support/lazy_load_hooks"
+ActiveSupport.on_load(:gutentag) do
+  Gutentag.tag_validations.call Gutentag::Tag
+end
+
 if defined?(Rails::Engine)
   require "gutentag/engine"
 else

data/spec/spec_helper.rb

@@ -5,6 +5,7 @@ require "bundler/setup"
 Bundler.require :default, :development
 
 Combustion.initialize! :active_record
+ActiveSupport.run_load_hooks :gutentag unless defined?(Gutentag::Engine)
 
 require "rspec/rails"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-16 00:00:00.000000000 Z
+date: 2017-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -119,6 +119,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENCE
 - README.md
@@ -174,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Good Tags