gutentag 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aea053bcbf95bfcdacd4bbdf352a4b10d16ef561
-  data.tar.gz: 6cc4798a3261163ba1369ac6d7736193fd2f1798
+  metadata.gz: dda4e9077e5d19af15ad0ae9bab60a64147f4c11
+  data.tar.gz: dcd0271e7e842c8edf3fc25ba1f4254c4853369a
 SHA512:
-  metadata.gz: cfd4ef366f9dcfb50e650021689cca189e042893b76d80458350121071b31af511cafef0921ad6563e7bed781b59f40d6682682b0161ccc9154e20276e3ad804
-  data.tar.gz: 7b2731e6f5cbb60ce6ec04fba73096942c53e9a9d2a1b4a38580c3c02b9861e6d23513f32cd0f632f914081639b8d7851e910ba1fcf2218800bb53bbf07c5e81
+  metadata.gz: fc49c2eaa8236fd2991c5213fb53bce4077890135185f0cf5730331603a384813fe0ecf3427d370719e11931044095ba65297c38052a43a4343e396311e77d68
+  data.tar.gz: b734e64f5731e2458af240c09a26e650a2d103d5d9bdb8649c52a0cf9d868cb1d06f1fd0fd61271c93b4764c3a7ea0dfa79b3f61ae5e6e932e042bd6321977ff

data/README.md

@@ -1,5 +1,6 @@
 # Gutentag
 
+[![Gem Version](https://badge.fury.io/rb/gutentag.png)](http://badge.fury.io/rb/gutentag)
 [![Build Status](https://travis-ci.org/pat/gutentag.png?branch=master)](https://travis-ci.org/pat/gutentag)
 [![Code Climate](https://codeclimate.com/github/pat/gutentag.png)](https://codeclimate.com/github/pat/gutentag)
 
@@ -11,7 +12,7 @@ This was built partly as a proof-of-concept, and partly to see how a tagging gem
 
 Get it into your Gemfile - and don't forget the version constraint!
 
-    gem 'gutentag', '~> 0.2.2'
+    gem 'gutentag', '~> 0.3.0'
 
 Next: your tags get persisted to your database, so let's import and run the migrations to get the tables set up:
 
@@ -36,6 +37,11 @@ That's all it takes to get a tags association on each article. Of course, popula
     article.tag_names -= ['ruby']
     article.tag_names #=> ['pancakes', 'melbourne', 'portland']
 
+Changes to tag_names are not persisted immediately - you must save your taggable object to have the tag changes reflected in your database:
+
+    article.tag_names << 'ruby'
+    article.save
+
 ## Licence
 
 Copyright (c) 2013, Gutentag is developed and maintained by Pat Allan, and is released under the open MIT Licence.

data/gutentag.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'gutentag'
-  s.version     = '0.2.2'
+  s.version     = '0.3.0'
   s.authors     = ['Pat Allan']
   s.email       = ['pat@freelancing-gods.com']
   s.homepage    = 'https://github.com/pat/gutentag'

data/lib/gutentag.rb

@@ -4,5 +4,5 @@ end
 
 require 'gutentag/active_record'
 require 'gutentag/engine'
+require 'gutentag/persistence'
 require 'gutentag/tag_name'
-require 'gutentag/tag_names'

data/lib/gutentag/active_record.rb

@@ -9,18 +9,18 @@ module Gutentag::ActiveRecord
         :dependent => :destroy
       has_many :tags,     :class_name => 'Gutentag::Tag',
         :through => :taggings
+
+      after_save Gutentag::Persistence
+
+      attr_writer :tag_names
     end
   end
 
-  def tag_names
-    @tag_names ||= Gutentag::TagNames.new self
+  def reset_tag_names
+    @tag_names = nil
   end
 
-  def tag_names=(names)
-    if names.is_a?(Gutentag::TagNames)
-      @tag_names = names
-    else
-      @tag_names = Gutentag::TagNames.new_with_names self, names
-    end
+  def tag_names
+    @tag_names ||= tags.collect(&:name)
   end
 end

data/lib/gutentag/persistence.rb

@@ -0,0 +1,38 @@
+class Gutentag::Persistence
+  def self.after_save(taggable)
+    new(taggable).persist
+  end
+
+  def initialize(taggable)
+    @taggable = taggable
+    @existing = normalised taggable.tags.collect(&:name)
+    @changes  = normalised taggable.tag_names
+  end
+
+  def persist
+    remove_old
+    add_new
+
+    taggable.reset_tag_names
+  end
+
+  private
+
+  attr_reader :taggable, :existing, :changes
+
+  def add_new
+    (changes - existing).each do |name|
+      taggable.tags << Gutentag::Tag.find_or_create(name)
+    end
+  end
+
+  def normalised(names)
+    names.collect { |name| Gutentag::TagName.normalise(name) }.uniq
+  end
+
+  def remove_old
+    (existing - changes).each do |name|
+      taggable.tags.delete Gutentag::Tag.find_by_name(name)
+    end
+  end
+end

data/spec/acceptance/tag_names_spec.rb

@@ -8,11 +8,12 @@ describe "Managing tags via names" do
 
     article.tags << melbourne
 
-    article.tag_names.to_a.should == ['melbourne']
+    article.tag_names.should == ['melbourne']
   end
 
   it "adds tags via their names" do
     article.tag_names << 'melbourne'
+    article.save!
 
     article.tags.collect(&:name).should == ['melbourne']
   end
@@ -20,32 +21,24 @@ describe "Managing tags via names" do
   it "doesn't complain when adding an existing tag" do
     article.tag_names << 'melbourne'
     article.tag_names << 'melbourne'
+    article.save!
 
     article.tags.collect(&:name).should == ['melbourne']
   end
 
   it "accepts a completely new set of tags" do
     article.tag_names = ['portland', 'oregon']
+    article.save!
 
     article.tags.collect(&:name).should == ['portland', 'oregon']
   end
 
-  it "enumerates through tag names" do
-    article.tag_names = ['melbourne', 'victoria']
-    names = []
-
-    article.tag_names.each do |name|
-      names << name
-    end
-
-    names.should == ['melbourne', 'victoria']
-  end
-
   it "does not allow duplication of tags" do
     existing = Article.create
     existing.tags << Gutentag::Tag.create(:name => 'portland')
 
     article.tag_names = ['portland']
+    article.save!
 
     existing.tag_ids.should == article.tag_ids
   end
@@ -53,6 +46,7 @@ describe "Managing tags via names" do
   it "appends tag names" do
     article.tag_names  = ['portland']
     article.tag_names += ['oregon', 'ruby']
+    article.save!
 
     article.tags.collect(&:name).should == ['portland', 'oregon', 'ruby']
   end
@@ -60,6 +54,7 @@ describe "Managing tags via names" do
   it "does not repeat appended names that already exist" do
     article.tag_names  = ['portland', 'oregon']
     article.tag_names += ['oregon', 'ruby']
+    article.save!
 
     article.tags.collect(&:name).should == ['portland', 'oregon', 'ruby']
   end
@@ -67,6 +62,7 @@ describe "Managing tags via names" do
   it "removes a single tag name" do
     article.tag_names = ['portland', 'oregon']
     article.tag_names.delete 'oregon'
+    article.save!
 
     article.tags.collect(&:name).should == ['portland']
   end
@@ -74,32 +70,28 @@ describe "Managing tags via names" do
   it "removes tag names" do
     article.tag_names  = ['portland', 'oregon', 'ruby']
     article.tag_names -= ['oregon', 'ruby']
+    article.save!
 
     article.tags.collect(&:name).should == ['portland']
   end
 
-  it "provides union operators" do
-    article.tag_names  = ['portland', 'ruby']
-    article.tag_names |= ['ruby', 'melbourne']
-
-    article.tags.collect(&:name).should == ['portland', 'ruby', 'melbourne']
-  end
-
-  it "provides intersection operators" do
-    article.tag_names  = ['portland', 'ruby']
-    article.tag_names &= ['ruby', 'melbourne']
-
-    article.tags.collect(&:name).should == ['ruby']
-  end
-
   it "matches tag names ignoring case" do
     article.tag_names  = ['portland']
     article.tag_names += ['Portland']
+    article.save!
 
     article.tags.collect(&:name).should == ['portland']
 
     article.tag_names << 'Portland'
+    article.save!
 
     article.tags.collect(&:name).should == ['portland']
   end
+
+  it "allows setting of tag names on unpersisted objects" do
+    article = Article.new :tag_names => ['melbourne', 'pancakes']
+    article.save!
+
+    article.tag_names.should == ['melbourne', 'pancakes']
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-25 00:00:00.000000000 Z
+date: 2013-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -86,8 +86,8 @@ files:
 - lib/gutentag.rb
 - lib/gutentag/active_record.rb
 - lib/gutentag/engine.rb
+- lib/gutentag/persistence.rb
 - lib/gutentag/tag_name.rb
-- lib/gutentag/tag_names.rb
 - spec/acceptance/tag_names_spec.rb
 - spec/acceptance/tags_spec.rb
 - spec/gutentag/tag_name_spec.rb

data/lib/gutentag/tag_names.rb

@@ -1,66 +0,0 @@
-class Gutentag::TagNames
-  include Enumerable
-
-  def self.new_with_names(taggable, names)
-    new(taggable).replace names
-  end
-
-  def initialize(taggable)
-    @taggable = taggable
-  end
-
-  def to_a
-    taggable.tags.collect &:name
-  end
-
-  def +(array)
-    normalised(array).each { |name| self.<< name }
-
-    self
-  end
-
-  def -(array)
-    normalised(array).each { |name| self.delete name }
-
-    self
-  end
-
-  def <<(name)
-    tag = Gutentag::Tag.find_or_create name
-
-    taggable.tags << tag unless taggable.tags.include?(tag)
-  end
-
-  def |(array)
-    to_a | normalised(array)
-  end
-
-  def &(array)
-    to_a & normalised(array)
-  end
-
-  def clear
-    taggable.tags.clear
-  end
-
-  def delete(name)
-    taggable.tags.delete Gutentag::Tag.find_by_name(name)
-  end
-
-  def each(&block)
-    to_a.each &block
-  end
-
-  def replace(names)
-    clear
-    self.+ names
-  end
-
-  private
-
-  attr_reader :taggable
-
-  def normalised(array)
-    array.collect { |name| Gutentag::TagName.normalise(name) }
-  end
-end