gurke 2.4.2 → 3.0.0

data/lib/gurke/builder.rb

@@ -1,18 +1,17 @@
+# frozen_string_literal: true
+
 require 'gherkin'
 
 module Gurke
   class Builder
-    attr_reader :features, :keywords
+    attr_reader :features
+    attr_writer :keywords
 
     def initialize
-      # @options  = options
-      # @files    = files.map do |file|
-      #   split = file.split(':')
-      #   [split[0], split[1..-1].map{|l| Integer(l) }]
-      # end
       @language = 'en'
       @parser   = Gherkin::Parser::Parser.new(
-        self, true, 'root', false, @language)
+        self, true, 'root', false, @language
+      )
     end
 
     def keywords
@@ -45,7 +44,7 @@ module Gurke
     end
 
     def feature(raw)
-      tags = raw.tags.map{|t| Tag.new @file, t.line, t }
+      tags = raw.tags.map {|t| Tag.new @file, t.line, t }
 
       @feature  = Feature.new(@file, raw.line, tags, raw)
       @scenario = nil
@@ -62,14 +61,14 @@ module Gurke
     end
 
     def scenario(raw)
-      tags  = raw.tags.map{|t| Tag.new @file, t.line, t }
+      tags  = raw.tags.map {|t| Tag.new @file, t.line, t }
       tags += features.last.tags
 
       @scenario = Scenario.new @feature, @file, raw.line, tags, raw
       @context  = @scenario
       @type     = nil
 
-      @feature.scenarios << @scenario #unless filtered?(@scenario)
+      @feature.scenarios << @scenario
     end
 
     def step(raw)
@@ -79,7 +78,7 @@ module Gurke
     end
 
     def eof(*)
-      @features.reject!{|f| f.scenarios.empty? }
+      @features.reject! {|f| f.scenarios.empty? }
       @feature  = nil
       @scenario = nil
       @context  = nil

data/lib/gurke/capybara.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'capybara'
 require 'gurke'
 require 'capybara/dsl'

data/lib/gurke/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'trollop'
 
 module Gurke
@@ -14,8 +16,8 @@ module Gurke
     rescue Trollop::HelpNeeded
       print_help && exit
     rescue Trollop::CommandlineError => e
-      $stderr.puts "Error: #{e}"
-      $stderr.puts "Run with `-h' for more information on available arguments."
+      warn "Error: #{e}"
+      warn "Run with `-h' for more information on available arguments."
       exit 255
     end
 
@@ -24,70 +26,76 @@ module Gurke
         require File.expand_path(Gurke.root.join('gurke.rb'))
       end
 
-      options[:require].each do |r|
-        Dir[r].each{|f| require File.expand_path(f) }
-      end if options[:require].any?
+      if options[:require].any?
+        options[:require].each do |r|
+          Dir[r].each {|f| require File.expand_path(f) }
+        end
+      end
 
       files = expand_files files, options
 
       runner = if options[:drb_server]
-        Runner::DRbServer
-      elsif options[:drb]
-        Runner::DRbClient
-      else
-        Runner::LocalRunner
-      end.new Gurke.config, options
+                 Runner::DRbServer
+               elsif options[:drb]
+                 Runner::DRbClient
+               else
+                 Runner::LocalRunner
+               end.new(Gurke.config, options)
 
       Kernel.exit runner.run files
     end
 
     def print_version
-      $stdout.puts <<-EOF.gsub(/^ {8}/, '')
+      $stdout.puts <<~VSTR
         gurke v#{Gurke::VERSION}
-      EOF
+      VSTR
     end
 
     def print_help
       parser.educate($stdout)
     end
 
-    # rubocop:disable MethodLength
     def parser
       @parser ||= Trollop::Parser.new do
         opt :help, 'Print this help.'
         opt :version, 'Show program version information.'
         opt :backtrace, 'Show full error backtraces.'
         opt :formatter, 'Select a special formatter as reporter', \
-            default: 'default'
+          default: 'compact'
         opt :pattern, 'File pattern matching feature files to be run.',
-            default: 'features/**/*.feature'
-        opt :require, 'Files matching this pattern will be required after'\
+          default: 'features/**/*.feature'
+        opt :require, 'Files matching this pattern will be required after' \
                       'loading environment but before running features.',
-            default: ['features/steps/**/*.rb',
-                      'features/support/steps/**/*.rb'],
-            multi: true
-        opt :tags, 'Only run features and scenarios matching given tag '\
+          default: ['features/steps/**/*.rb',
+                    'features/support/steps/**/*.rb'],
+          multi: true
+        opt :tags, 'Only run features and scenarios matching given tag ' \
                    'filtering expression. TODO: Description.',
-            default: ['~wip'],
-            multi: true
+          default: ['~wip'],
+          multi: true
         opt :drb_server, 'Run gurke DRb server. (experimental)', short: :none
-        opt :drb, 'Run features on already started DRb server. (experimental)', short: :none
+        opt :drb, 'Run features on already started DRb server. (experimental)',
+          short: :none
       end
     end
 
     private
+
     def expand_files(files, options)
       files = Dir[options[:pattern].to_s] if files.empty? && options[:pattern]
-      files.inject([]) do |memo, input|
+      files.each_with_object([]) do |input, memo|
         if File.directory? input
           Dir[input + '/**/*'].each do |file_in_dir|
-            next if options[:pattern] && !File.fnmatch?(options[:pattern], file_in_dir)
+            if options[:pattern] &&
+               !File.fnmatch?(options[:pattern], file_in_dir)
+              next
+            end
+
             memo << File.expand_path(file_in_dir)
           end
         else
           memo << File.expand_path(input)
         end
-        memo
       end
     end
   end

data/lib/gurke/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Gurke
@@ -74,7 +76,7 @@ module Gurke
           system: HookSet.new
         }
 
-        hooks.merge! each: hooks[:scenario]
+        hooks[:each] = hooks[:scenario]
         hooks
       end
     end
@@ -126,15 +128,15 @@ module Gurke
 
       def run(context, world, &block)
         ctx = Context.new context, block
-        @before.each{|hook| hook.run world, ctx }
+        @before.each {|hook| hook.run world, ctx }
         @around.reduce Context.new(context, block) do |c, e|
-          Context.new(context, ->{ e.run world, c })
+          Context.new(context, -> { e.run world, c })
         end.call
       ensure
         @after.each do |hook|
           begin
             hook.run world, ctx
-          rescue => e
+          rescue StandardError => e
             warn "Rescued error in after hook: #{e}\n#{e.backtrace.join("\n")}"
           end
         end
@@ -144,7 +146,8 @@ module Gurke
         extend Forwardable
 
         def initialize(context, block)
-          @context, @block = context, block
+          @context = context
+          @block = block
         end
 
         def tags
@@ -171,7 +174,7 @@ module Gurke
       end
 
       def match?(context)
-        !opts.any?{|k, v| context.metadata[k] != v }
+        opts.none? {|k, v| context.metadata[k] != v }
       end
 
       def run(world, *args)

data/lib/gurke/dsl.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 module Gurke
   module DSL
     def step(pattern, method_name = nil, opts = {}, &block)
       if method_name.is_a?(Hash) && opts.empty?
-        method_name, opts = nil, method_name
+        opts = method_name
+        method_name = nil
       end
 
       if method_name && block_given?
-        raise ArgumentError.new <<-EOF.strip
+        raise ArgumentError.new <<~ERR.strip
           You can either specify a method name or given a block, not both.
-        EOF
+        ERR
       end
 
       _define_step(pattern, method_name, opts, &block)
@@ -22,9 +25,9 @@ module Gurke
       end
 
       if block_given?
-        define_method("#{step.method_name}", &block)
+        define_method(step.method_name.to_s, &block)
       elsif method_name
-        alias_method "#{step.method_name}", method_name
+        alias_method step.method_name.to_s, method_name
       end
     end
 
@@ -40,5 +43,6 @@ module Gurke
     def Then(pattern, method_name = nil, opts = {}, &block)
       step pattern, method_name, opts.merge(type: :then), &block
     end
+    # rubocop:enable MethodName
   end
 end

data/lib/gurke/feature.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gurke
   class Feature
     #
@@ -41,14 +43,6 @@ module Gurke
       @raw  = raw
     end
 
-    def name
-      raw.name
-    end
-
-    def description
-      raw.description
-    end
-
     # Return name of this feature.
     #
     # @return [String] Feature name.
@@ -57,6 +51,10 @@ module Gurke
       raw.name
     end
 
+    def description
+      raw.description
+    end
+
     def failed?
       scenarios.any?(&:failed?)
     end

data/lib/gurke/feature_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gurke
   #
   # A {FeatureList} is a list of {Feature} objects.
@@ -19,7 +21,7 @@ module Gurke
 
       reporter.invoke :after_features, self
 
-      !any?{|s| s.failed? }
+      !any?(&:failed?)
     end
 
     # @api private
@@ -28,7 +30,7 @@ module Gurke
       filter = Filter.new options, files
 
       each do |feature|
-        file, lines = files.select{|f, _| f == feature.file }.first
+        file, _lines = files.select {|f, _| f == feature.file }.first
         next unless file
 
         f = Feature.new(feature)
@@ -51,6 +53,8 @@ module Gurke
       each do |feature|
         feature.run runner, reporter
       end
+    rescue Interrupt # rubocop:disable HandleExceptions
+      # nothing
     ensure
       reporter.invoke :end_features, self
     end
@@ -65,7 +69,7 @@ module Gurke
 
       def tag_filters
         @tag_filters ||= options[:tags].map do |list|
-          list.strip.split(/[,+\s]\s*/).map{|t| TagFilter.new(t) }
+          list.strip.split(/[,+\s]\s*/).map {|t| TagFilter.new(t) }
         end
       end
 
@@ -75,16 +79,16 @@ module Gurke
 
       def filtered_by_tags?(scenario)
         !tag_filters.reduce(false) do |memo, set|
-          memo || set.all?{|rule| rule.match? scenario }
+          memo || set.all? {|rule| rule.match? scenario }
         end
       end
 
       def filtered_by_line?(scenario)
-        _, lines = files.select{|f, _| f == scenario.file }.first
+        _, lines = files.select {|f, _| f == scenario.file }.first
 
         return false if lines.empty?
 
-        !lines.any?{|l| scenario.line <= l && scenario.steps.last.line >= l }
+        lines.none? {|l| scenario.line <= l && scenario.steps.last.line >= l }
       end
 
       TagFilter = Struct.new(:tag) do
@@ -97,7 +101,7 @@ module Gurke
         end
 
         def match?(taggable)
-          negated? != taggable.tags.any?{|t| t.name == name }
+          negated? != taggable.tags.any? {|t| t.name == name }
         end
       end
     end

data/lib/gurke/reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gurke
   #
   # A {Reporter} provides callbacks that will be executed whenever
@@ -5,31 +7,32 @@ module Gurke
   #
   # @api public
   #
+  # rubocop:disable MissingCopEnableDirective
+  # rubocop:disable UnusedMethodArgument
+  #
   class Reporter
-    # rubocop:disable UnusedMethodArgument
-
     # List of all callback methods as symbols.
     #
-    CALLBACKS = [
-      :before_features,
-      :before_feature,
-      :before_scenario,
-      :before_step,
-      :start_features,
-      :start_feature,
-      :start_scenario,
-      :start_background,
-      :start_step,
-      :end_features,
-      :end_feature,
-      :end_scenario,
-      :end_background,
-      :end_step,
-      :after_features,
-      :after_feature,
-      :after_scenario,
-      :after_step
-    ]
+    CALLBACKS = %i[
+      before_features
+      before_feature
+      before_scenario
+      before_step
+      start_features
+      start_feature
+      start_scenario
+      start_background
+      start_step
+      end_features
+      end_feature
+      end_scenario
+      end_background
+      end_step
+      after_features
+      after_feature
+      after_scenario
+      after_step
+    ].freeze
 
     # Called before the execution of any feature and before any
     # before-features hook is invoked.
@@ -252,30 +255,34 @@ module Gurke
     # @visibility private
     def invoke(mth, *args)
       send mth, *args
-    rescue => e
+    rescue StandardError => e
       warn "Rescued in reporter: #{e}\n" + e.backtrace.join("\n")
     end
 
-
     # @api private
     #
+
     protected
-    def format_exception(ex)
+
+    def format_exception(ex, backtrace: true)
       s = [ex.class.to_s + ': ' + ex.message.strip]
-      if ex.backtrace.nil?
-        s << '  <no backtrace available>'
-      elsif ex.backtrace.empty?
-        s << '  <backtrace empty>'
-      else
-        ex.backtrace.each do |bt|
-          s << '  ' + bt.strip
+
+      if backtrace
+        if ex.backtrace.nil?
+          s << '  <no backtrace available>'
+        elsif ex.backtrace.empty?
+          s << '  <backtrace empty>'
+        else
+          ex.backtrace.each do |bt|
+            s << '  ' + bt.strip
+          end
         end
       end
 
       if ex.respond_to?(:cause) && ex.cause &&
-        ex.cause.respond_to?(:message) && ex.cause.respond_to?(:backtrace)
+         ex.cause.respond_to?(:message) && ex.cause.respond_to?(:backtrace)
 
-        cause = format_exception(ex.cause)
+        cause = format_exception(ex.cause, backtrace: backtrace)
         s << 'caused by: ' + cause.shift
         s += cause
       end