gupshup 0.1.5 → 0.2.0

data/README.rdoc

@@ -14,6 +14,7 @@ http://enterprise.smsgupshup.com/doc/GatewayAPIDoc.pdf
 
 == FEATURES:
 
+* V 0.2.0 Return boolean status instead of raising expectations. API_URL is now configurable.
 * V 0.1.5 Added group_post method and a generic call_api method. All methods
     now expect a hash of API params instead if individual arguments
 * V 0.1.2 Bulk file upload implemented. Only CSV format supported for now.

data/lib/gupshup.rb

@@ -7,22 +7,26 @@ require 'cgi'
 require 'httpclient'
 
 class NilClass
-  def blank?
-    true
+  unless defined? :blank?
+    def blank?
+      true
+    end
   end
 end
 
 class String
-  def blank?
-    self.empty?
+  unless defined? :blank?
+    def blank?
+      self.empty?
+    end
   end
 end
 
 module Gupshup
-  VERSION = '0.1.5'
+  VERSION = '0.2.0'
   class Enterprise
     def initialize(opts)
-      @api_url = 'http://enterprise.smsgupshup.com/GatewayAPI/rest'
+      @api_url = opts[:api_url] || 'http://enterprise.smsgupshup.com/GatewayAPI/rest'
       @api_params = {}
       @api_params[:userid] = opts[:userid]
       @api_params[:password] = opts[:password]
@@ -45,13 +49,14 @@ module Gupshup
       puts "GupShup Response: #{resp}"
 
       case res
-      when Net::HTTPSuccess, Net::HTTPRedirection
+      when Net::HTTPSuccess
         if resp.nil? || resp.include?("success") == false
-          raise "API call '#{opts[:method]}' failed: #{resp}"
+          puts "API call '#{opts[:method]}' failed: #{resp}"
+          return false, resp
         end
-        return true
+        return true, nil
       else
-        raise 'GupShup returned HTTP Error'
+        return false, "HTTP Error : #{res}"
       end
     end
 
@@ -60,11 +65,11 @@ module Gupshup
       number = opts[:send_to]
       msg_type = opts[:msg_type] || 'TEXT'
       
-      raise 'Phone Number is too short' if number.to_s.length < 12
-      raise 'Phone Number is too long' if number.to_s.length > 12
-      #raise 'Phone Number should start with "91"' if number.to_s.start_with? "91"
-      raise 'Phone Number should be numerical value' unless number.to_i.to_s == number.to_s
-      raise 'Message should be less than 725 characters long' if msg.to_s.length > 724
+      return (false, 'Phone Number is too short') if number.to_s.length < 12
+      return (false, 'Phone Number is too long') if number.to_s.length > 12
+      #return (false, 'Phone Number should start with "91"') if number.to_s.start_with? "91"
+      return (false, 'Phone Number should be numerical value') unless number.to_i.to_s == number.to_s
+      return (false, 'Message should be less than 725 characters long') if msg.to_s.length > 724
       call_api opts.merge({ :method => 'sendMessage' })
     end
 
@@ -97,9 +102,9 @@ module Gupshup
     end
     
     def group_post(opts)
-      raise "Invalid group name" if opts[:group_name].blank?
-      raise "Invalid message" if opts[:msg].blank?
-      raise "Invalid message type" if opts[:msg_type].blank?
+      return (false,"Invalid group name") if opts[:group_name].blank?
+      return (false,"Invalid message") if opts[:msg].blank?
+      return (false,"Invalid message type") if opts[:msg_type].blank?
       call_api opts.merge({:method => 'post_group'})
     end
   end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 1
-  - 5
-  version: 0.1.5
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Nilesh Trivedi
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-25 00:00:00 +05:30
+date: 2010-04-07 00:00:00 +05:30
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -60,9 +60,8 @@ homepage: http://github.com/nileshtrivedi/gupshup
 licenses: []
 
 post_install_message: PostInstall.txt
-rdoc_options: 
-- --main
-- README.rdoc
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement