gull 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6dd83076a56a80eb80bc1ff60c6952a74519d2f3
-  data.tar.gz: 4c9993c1ab28823f63face88678630c49e938074
+  metadata.gz: 23c91d51c847bc9965693fbaa088fea626fb5587
+  data.tar.gz: 08b47a82d8d1510c1c27cd16845ebbc968672f93
 SHA512:
-  metadata.gz: 865775c7a423600f941f4811a80309aa24cb3a6a8315f30f142b579899bb15ddd577d76906b2d8dbeb3ad2ec856cec993eeed62ff16fe7d0a43824298dc009f2
-  data.tar.gz: 0d2d2bc96c97ef7198cb580cf0ce08d2582efdd568ba6286af6f918177abd2d69ebe3bee9c54c12486175560b20d32f86d3eb7c08d94973558d8d4d21faf20d2
+  metadata.gz: 579c1bfb5d9bd7d1daddcfb1b086c85d91851105856f206d01ead39ac852da1aa1cb93f7d7a0ccf6b0a5429600b09d099ca6231ede8685f3dd706a2bea206e48
+  data.tar.gz: 6e6086d4239521e45f71d9fd761d0f5d04c2de2e872d5036c572ab7656e6a48eedfef78382bf09d23b48adcfac010283509f5c69a3856853437772b6a17ff9d7

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 rvm:
+- 2.2.3
+- 2.1.7
 - 2.0.0
-- 1.9.3
-- jruby-19mode
 
-script: rspec spec
+script: rspec spec

data/CHANGELOG.md

@@ -1,8 +1,12 @@
+#### 0.3.2 (11/10/2015)
+Added BadResponseError to client error handling.
+***
 #### 0.3.1 (6/25/2015)
-Added nested exception handling for other HTTPClient errors. HttpError has original attribute exposing the root exception.
+Added nested error handling for other HTTPClient errors. HttpError has original attribute exposing the root error.
+***
 #### 0.3.0 (6/23/2015)
 Added Client class for error handling (bad entries accessed via errors array). Exposed option to turn on strict XML parsing for debugging. Alert.fetch uses new Client but is backwards compatible, however it doesn't give you access to errors array.
-*** 
+***
 #### 0.2.13 (6/20/2015)
 Handle missing cap section
 ***
@@ -22,7 +26,7 @@ Added static map image to polygons.
 Introduced Polygon type.
 ***
 #### 0.1.1 (10/01/2014)
-Refectored and simplfied alert processing.
+Refactored and simplified alert processing.
 ***
 #### 0.1.0 (10/01/2014)
 Initial release, basic functionality of fetching and parsing alerts.

data/Gemfile

@@ -4,3 +4,4 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'coveralls', require: false
+gem 'simplecov', require: false

data/lib/gull/client.rb

@@ -31,8 +31,9 @@ module Gull
         return client.get_content @options[:url]
       rescue HTTPClient::TimeoutError
         raise TimeoutError, 'Timeout while connecting to NWS web service'
-      rescue HTTPClient::KeepAliveDisconnected, SocketError
-        raise HttpError, 'HTTP error while connecting to NWS web service'
+      rescue HTTPClient::KeepAliveDisconnected, HTTPClient::BadResponseError,
+             SocketError, Errno::ECONNREFUSED
+        raise HttpError, 'Could not connect to NWS web service'
       end
     end
 

data/lib/gull/version.rb

@@ -1,3 +1,3 @@
 module Gull
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

data/spec/client_spec.rb

@@ -57,25 +57,47 @@ describe Gull::Client do
     expect { client.fetch }.to raise_error(Gull::TimeoutError, message)
   end
 
-  it 'should raise own error if http error occurs' do
+  it 'should raise own error if http errors occur' do
     stub_request(:get, 'http://alerts.weather.gov/cap/us.php?x=1')
       .with(headers: { 'Accept' => '*/*' })
       .to_raise(HTTPClient::KeepAliveDisconnected)
 
-    message = 'HTTP error while connecting to NWS web service'
+    message = 'Could not connect to NWS web service'
     client = Gull::Client.new
     expect { client.fetch }.to raise_error(Gull::HttpError, message) do |error|
       expect(error.original).to be_a(HTTPClient::KeepAliveDisconnected)
     end
 
+    stub_request(:get, 'http://alerts.weather.gov/cap/us.php?x=1')
+      .with(headers: { 'Accept' => '*/*' })
+      .to_raise(HTTPClient::BadResponseError)
+
+    message = 'Could not connect to NWS web service'
+    client = Gull::Client.new
+    expect { client.fetch }.to raise_error(Gull::HttpError, message) do |error|
+      expect(error.original).to be_a(HTTPClient::BadResponseError)
+    end
+  end
+
+  it 'should raise own error if connection errors occur' do
     stub_request(:get, 'http://alerts.weather.gov/cap/us.php?x=1')
       .with(headers: { 'Accept' => '*/*' })
       .to_raise(SocketError)
 
-    message = 'HTTP error while connecting to NWS web service'
+    message = 'Could not connect to NWS web service'
     client = Gull::Client.new
     expect { client.fetch }.to raise_error(Gull::HttpError, message) do |error|
       expect(error.original).to be_a(SocketError)
     end
+
+    stub_request(:get, 'http://alerts.weather.gov/cap/us.php?x=1')
+      .with(headers: { 'Accept' => '*/*' })
+      .to_raise(Errno::ECONNREFUSED)
+
+    message = 'Could not connect to NWS web service'
+    client = Gull::Client.new
+    expect { client.fetch }.to raise_error(Gull::HttpError, message) do |error|
+      expect(error.original).to be_a(Errno::ECONNREFUSED)
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,13 @@
 require 'gull'
+require 'coveralls'
+require 'simplecov'
 require 'webmock/rspec'
 
-require 'coveralls'
-Coveralls.wear!
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gull
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Seth Deckard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-25 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient