guillaumegentil-rspactor 0.2.8 → 0.3.4

data/spec/inspector_spec.rb

@@ -0,0 +1,119 @@
+require 'rspactor/inspector'
+
+describe RSpactor::Inspector do
+  before(:all) do
+    @inspector = described_class.new('/project')
+  end
+  
+  def translate(file)
+    @inspector.translate(file)
+  end
+  
+  describe "#translate" do
+    it "should consider all controllers when application_controller changes" do
+      translate('/project/app/controllers/application_controller.rb').should == ['/project/spec/controllers']
+      translate('/project/app/controllers/application.rb').should == ['/project/spec/controllers']
+    end
+    
+    it "should translate files under 'app/' directory" do
+      translate('/project/app/controllers/foo_controller.rb').should ==
+        ['/project/spec/controllers/foo_controller_spec.rb']
+    end
+    
+    it "should translate templates" do
+      translate('/project/app/views/foo/bar.erb').should == ['/project/spec/views/foo/bar.erb_spec.rb']
+      translate('/project/app/views/foo/bar.html.haml').should ==
+        ['/project/spec/views/foo/bar.html.haml_spec.rb', '/project/spec/views/foo/bar.html_spec.rb']
+    end
+    
+    it "should consider all views when application_helper changes" do
+      translate('/project/app/helpers/application_helper.rb').should == ['/project/spec/helpers', '/project/spec/views']
+    end
+    
+    it "should consider related templates when a helper changes" do
+      translate('/project/app/helpers/foo_helper.rb').should ==
+        ['/project/spec/helpers/foo_helper_spec.rb', '/project/spec/views/foo']
+    end
+    
+    it "should translate files under deep 'lib/' directory" do
+      translate('/project/lib/awesum/rox.rb').should ==
+        ['/project/spec/lib/awesum/rox_spec.rb', '/project/spec/awesum/rox_spec.rb', '/project/spec/rox_spec.rb']
+    end
+    
+    it "should translate files under shallow 'lib/' directory" do
+      translate('lib/runner.rb').should == ['/project/spec/lib/runner_spec.rb', '/project/spec/runner_spec.rb']
+    end
+    
+    it "should handle relative paths" do
+      translate('foo.rb').should == ['/project/spec/foo_spec.rb']
+    end
+    
+    it "should handle files without extension" do
+      translate('foo').should == ['/project/spec/foo_spec.rb']
+    end
+    
+    it "should consider all controllers, helpers and views when routes.rb changes" do
+      translate('config/routes.rb').should == ['/project/spec/controllers', '/project/spec/helpers', '/project/spec/views']
+    end
+    
+    it "should consider all models when config/database.yml changes" do
+      translate('config/database.yml').should == ['/project/spec/models']
+    end
+    
+    it "should consider all models when db/schema.rb changes" do
+      translate('db/schema.rb').should == ['/project/spec/models']
+    end
+    
+    it "should consider related model when its observer changes" do
+      translate('app/models/user_observer.rb').should == ['/project/spec/models/user_observer_spec.rb', '/project/spec/models/user_spec.rb']
+    end
+    
+    it "should consider all specs when spec_helper changes" do
+      translate('spec/spec_helper.rb').should == ['/project/spec']
+    end
+    
+    it "should consider all specs when code under spec/shared/ changes" do
+      translate('spec/shared/foo.rb').should == ['/project/spec']
+    end
+    
+    it "should consider all specs when app configuration changes" do
+      translate('config/environment.rb').should == ['/project/spec']
+      translate('config/environments/test.rb').should == ['/project/spec']
+      translate('config/boot.rb').should == ['/project/spec']
+    end
+  end
+  
+  describe "#determine_spec_files" do
+    def determine(file)
+      @inspector.determine_spec_files(file)
+    end
+    
+    it "should filter out files that don't exist on the filesystem" do
+      @inspector.should_receive(:translate).with('foo').and_return(%w(valid_spec.rb invalid_spec.rb))
+      File.should_receive(:exists?).with('valid_spec.rb').and_return(true)
+      File.should_receive(:exists?).with('invalid_spec.rb').and_return(false)
+      determine('foo').should == ['valid_spec.rb']
+    end
+    
+    it "should filter out files in subdirectories that are already on the list" do
+      @inspector.should_receive(:translate).with('foo').and_return(%w(
+        spec/foo_spec.rb
+        spec/views/moo/bar_spec.rb
+        spec/views/baa/boo_spec.rb
+        spec/models/baz_spec.rb
+        spec/controllers/moo_spec.rb
+        spec/models
+        spec/controllers
+        spec/views/baa
+      ))
+      File.stub!(:exists?).and_return(true)
+      determine('foo').should == %w(
+        spec/foo_spec.rb
+        spec/views/moo/bar_spec.rb
+        spec/models
+        spec/controllers
+        spec/views/baa
+      )
+    end
+  end
+end

data/spec/listener_spec.rb

@@ -0,0 +1,39 @@
+require 'rspactor/listener'
+
+describe RSpactor::Listener do
+  before(:all) do
+    @listener = described_class.new(%w(rb erb haml))
+  end
+  
+  it "should be timestamped" do
+    @listener.last_check.should be_instance_of(Time)
+  end
+  
+  it "should not ignore regular directories" do
+    @listener.ignore_path?('/project/foo/bar').should_not be
+  end
+  
+  it "should ignore .git directories" do
+    @listener.ignore_path?('/project/.git/index').should be
+  end
+  
+  it "should ignore dotfiles" do
+    @listener.ignore_file?('/project/.foo').should be
+  end
+  
+  it "should not ignore files in directories which start with a dot" do
+    @listener.ignore_file?('/project/.foo/bar.rb').should be_false
+  end
+  
+  it "should not ignore files without extension" do
+    @listener.ignore_file?('/project/foo.rb').should be_false
+  end
+  
+  it "should ignore files without extension" do
+    @listener.ignore_file?('/project/foo').should be
+  end
+  
+  it "should ignore files with extensions that don't match those specified" do
+    @listener.ignore_file?('/project/foo.bar').should be
+  end
+end

data/spec/runner_spec.rb

@@ -0,0 +1,258 @@
+require 'rspactor/runner'
+
+describe RSpactor::Runner do
+  
+  described_class.class_eval do
+    def run_command(cmd)
+      # never shell out in tests
+      cmd
+    end
+  end
+  
+  def with_env(name, value)
+    old_value = ENV[name]
+    ENV[name] = value
+    begin
+      yield
+    ensure
+      ENV[name] = old_value
+    end
+  end
+  
+  def capture_stderr(io = StringIO.new)
+    @old_stderr, $stderr = $stderr, io
+    begin; yield ensure; restore_stderr; end if block_given?
+  end
+  
+  def restore_stderr
+    $stderr = @old_stderr
+  end
+  
+  def capture_stdout(io = StringIO.new)
+    @old_stdout, $stdout = $stdout, io
+    begin; yield ensure; restore_stdout; end if block_given?
+  end
+  
+  def restore_stdout
+    $stdout = @old_stdout
+  end
+  
+  it 'should use the current directory to run in' do
+    mock_instance = mock('RunnerInstance')
+    mock_instance.stub!(:start)
+    RSpactor::Runner.should_receive(:new).with(Dir.pwd, {}).and_return(mock_instance)
+    RSpactor::Runner.start
+  end
+  
+  it 'should take an optional directory to run in' do
+    mock_instance = mock('RunnerInstance')
+    mock_instance.stub!(:start)
+    RSpactor::Runner.should_receive(:new).with('/tmp/mu', {}).and_return(mock_instance)
+    RSpactor::Runner.start(:run_in => '/tmp/mu')
+  end
+  
+  describe "start" do
+    before(:each) do
+      @runner = described_class.new('/my/path')
+      capture_stdout
+    end
+    
+    after(:each) do
+      restore_stdout
+    end
+    
+    def setup
+      @runner.start
+    end
+    
+    context "Interactor" do
+      before(:each) do
+        @runner.stub!(:load_dotfile)
+        @runner.stub!(:start_listener)
+        @interactor = mock('Interactor')
+        @interactor.should_receive(:start_termination_handler)
+        RSpactor::Interactor.should_receive(:new).and_return(@interactor)
+      end
+      
+      it "should start Interactor" do
+        @interactor.should_receive(:wait_for_enter_key).with(instance_of(String), 3)
+        setup
+      end
+  
+      it "should run all specs if Interactor isn't interrupted" do
+        @interactor.should_receive(:wait_for_enter_key).and_return(nil)
+        @runner.should_receive(:run_spec_command).with('/my/path/spec')
+        setup
+      end
+  
+      it "should skip running all specs if Interactor is interrupted" do
+        @interactor.should_receive(:wait_for_enter_key).and_return(true)
+        @runner.should_not_receive(:run_spec_command)
+        setup
+      end
+    end
+    
+    it "should initialize Inspector" do
+      @runner.stub!(:load_dotfile)
+      @runner.stub!(:start_interactor)
+      RSpactor::Inspector.should_receive(:new).with('/my/path')
+      RSpactor::Listener.stub!(:new).and_return(mock('Listener').as_null_object)
+      setup
+    end
+    
+    context "Listener" do
+      before(:each) do
+        @runner.stub!(:load_dotfile)
+        @runner.stub!(:start_interactor)
+        @inspector = mock("Inspector")
+        RSpactor::Inspector.stub!(:new).and_return(@inspector)
+        @listener = mock('Listener')
+      end
+      
+      it "should run Listener" do
+        @listener.should_receive(:run).with('/my/path')
+        RSpactor::Listener.should_receive(:new).with(instance_of(Array)).and_return(@listener)
+        setup
+      end
+    end
+  
+    it "should output 'watching' message on start" do
+      @runner.stub!(:load_dotfile)
+      @runner.stub!(:start_interactor)
+      @runner.stub!(:start_listener)
+      setup
+      $stdout.string.chomp.should == "** RSpactor is now watching at '/my/path'"
+    end
+    
+    context "dotfile" do
+      before(:each) do
+        @runner.stub!(:start_interactor)
+        @runner.stub!(:start_listener)
+      end
+      
+      it "should load dotfile if found" do
+        with_env('HOME', '/home/moo') do
+          File.should_receive(:exists?).with('/home/moo/.rspactor').and_return(true)
+          Kernel.should_receive(:load).with('/home/moo/.rspactor')
+          setup
+        end
+      end
+    
+      it "should continue even if the dotfile raised errors" do
+        with_env('HOME', '/home/moo') do
+          File.should_receive(:exists?).and_return(true)
+          Kernel.should_receive(:load).with('/home/moo/.rspactor').and_raise(ArgumentError)
+          capture_stderr do
+            lambda { setup }.should_not raise_error
+            $stderr.string.split("\n").should include('Error while loading /home/moo/.rspactor: ArgumentError')
+          end
+        end
+      end
+    end
+  end
+  
+  describe "#run_spec_command" do
+    before(:each) do
+      @runner = described_class.new('/my/path')
+    end
+    
+    def with_rubyopt(string, &block)
+      with_env('RUBYOPT', string, &block)
+    end
+    
+    def run(paths)
+      @runner.run_spec_command(paths)
+    end
+    
+    it "should exit if the paths argument is empty" do
+      @runner.should_not_receive(:run_command)
+      run([])
+    end
+    
+    it "should specify runner spec runner with joined paths" do
+      run(%w(foo bar)).should include(' spec foo bar ')
+    end
+    
+    it "should specify default options: --color" do
+      run('foo').should include(' --color')
+    end
+    
+    it "should setup RUBYOPT environment variable" do
+      with_rubyopt(nil) do
+        run('foo').should include("RUBYOPT='-Ilib:spec' ")
+      end
+    end
+    
+    it "should concat existing RUBYOPTs" do
+      with_rubyopt('-rubygems -w') do
+        run('foo').should include("RUBYOPT='-Ilib:spec -rubygems -w' ")
+      end
+    end
+    
+    it "should include growl formatter" do
+      run('foo').should include(' -f RSpecGrowler:STDOUT')
+    end
+    
+    it "should include 'progress' formatter" do
+      run('foo').should include(' -f progress')
+    end
+    
+    it "should not include 'progress' formatter if there already are 2 or more formatters" do
+      @runner.should_receive(:formatter_opts).and_return('-f foo --format bar')
+      run('foo').should_not include('-f progress')
+    end
+    
+    it "should save status of last run" do
+      @runner.should_receive(:run_command).twice.and_return(true, false)
+      run('foo')
+      @runner.last_run_failed?.should be_false
+      run('bar')
+      @runner.last_run_failed?.should be_true
+      run([])
+      @runner.last_run_failed?.should be_false
+    end
+  end
+  
+  describe "#spec_changed_files" do
+    before(:each) do
+      @runner = described_class.new('.')
+      @runner.stub!(:inspector).and_return(mock("Inspector"))
+    end
+    
+    def set_inspector_expectation(file, ret)
+      @runner.inspector.should_receive(:determine_spec_files).with(file).and_return(ret)
+    end
+    
+    it "should find and run spec files" do
+      set_inspector_expectation('moo.rb', ['spec/moo_spec.rb'])
+      set_inspector_expectation('views/baz.haml', [])
+      set_inspector_expectation('config/bar.yml', ['spec/bar_spec.rb', 'spec/bar_stuff_spec.rb'])
+      
+      expected = %w(spec/moo_spec.rb spec/bar_spec.rb spec/bar_stuff_spec.rb)
+      @runner.should_receive(:run_spec_command).with(expected)
+      
+      capture_stdout do
+        @runner.send(:spec_changed_files, %w(moo.rb views/baz.haml config/bar.yml))
+        $stdout.string.split("\n").should == expected
+      end
+    end
+    
+    it "should run the full suite after a run succeded when the previous one failed" do
+      @runner.inspector.stub!(:determine_spec_files).and_return(['spec/foo_spec.rb'], ['spec/bar_spec.rb'])
+      @runner.stub!(:options).and_return({ :retry_failed => true })
+      
+      capture_stdout do
+        @runner.stub!(:run_spec_command)
+        @runner.should_receive(:last_run_failed?).and_return(true, false)
+        @runner.should_receive(:run_all_specs)
+        @runner.send(:spec_changed_files, %w(moo.rb))
+      end
+    end
+  end
+  
+  it "should have Runner in global namespace for backwards compatibility" do
+    defined?(::Runner).should be_true
+    ::Runner.should == described_class
+  end
+  
+end

metadata

@@ -1,60 +1,54 @@
 --- !ruby/object:Gem::Specification 
 name: guillaumegentil-rspactor
 version: !ruby/object:Gem::Version 
-  version: 0.2.8
+  version: 0.3.4
 platform: ruby
 authors: 
+- "Mislav Marohni\xC4\x87"
 - Andreas Wolff
+- Pelle Braendgaard
+- Thibaud Guillaume-Gentil
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2009-04-20 00:00:00 -07:00
-default_executable: rspactor
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: optiflag
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
-description: RSpactor is a little command line tool to automatically run your changed specs (much like autotest).
-email: treas@dynamicdudes.com
+date: 2009-07-20 00:00:00 -07:00
+default_executable: 
+dependencies: []
+
+description: 
+email: mislav.marohnic@gmail.com
 executables: 
 - rspactor
+- rspactor-system
 extensions: []
 
-extra_rdoc_files: 
-- bin/rspactor
-- lib/inspector.rb
-- lib/interactor.rb
-- lib/listener.rb
-- lib/resulting.rb
-- lib/runner.rb
+extra_rdoc_files: []
+
 files: 
-- asset/rails_fail.png
-- asset/rails_ok.png
-- bin/rspactor
-- lib/inspector.rb
-- lib/interactor.rb
-- lib/listener.rb
-- lib/resulting.rb
-- lib/runner.rb
 - Rakefile
-- Manifest
-- rspactor.gemspec
-has_rdoc: true
-homepage: http://github.com/guillaumegentil/rspactor/
+- bin/rspactor
+- bin/rspactor-system
+- lib/rspactor
+- lib/rspactor/growl.rb
+- lib/rspactor/inspector.rb
+- lib/rspactor/interactor.rb
+- lib/rspactor/listener.rb
+- lib/rspactor/runner.rb
+- lib/rspactor.rb
+- lib/rspec_growler.rb
+- images/failed.png
+- images/pending.png
+- images/success.png
+- spec/inspector_spec.rb
+- spec/listener_spec.rb
+- spec/runner_spec.rb
+- LICENSE
+has_rdoc: false
+homepage: http://github.com/mislav/rspactor
 post_install_message: 
-rdoc_options: 
-- --line-numbers
-- --inline-source
-- --title
-- Rspactor
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -67,14 +61,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      version: "1.2"
+      version: "0"
   version: 
 requirements: []
 
-rubyforge_project: rspactor
+rubyforge_project: 
 rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3
-summary: RSpactor is a little command line tool to automatically run your changed specs (much like autotest).
+summary: RSpactor is a command line tool to automatically run your changed specs (much like autotest).
 test_files: []
 

data/Manifest

@@ -1,10 +0,0 @@
-asset/rails_fail.png
-asset/rails_ok.png
-bin/rspactor
-lib/inspector.rb
-lib/interactor.rb
-lib/listener.rb
-lib/resulting.rb
-lib/runner.rb
-Rakefile
-Manifest

data/lib/inspector.rb

@@ -1,92 +0,0 @@
-# The inspector make some assumptions about how your project is structured and where your spec files are located.
-# That said: The 'spec' directory, containing all your test files, must rest in the root directory of your project.
-# Futhermore it tries to locate controller, model, helper and view specs for a rails app (or projects with an identical structure)
-# in root/spec/controllers, root/spec/models, root/spec/helpers and root/spec/views.
-
-class Inspector
-
-  attr_accessor :base_spec_root
-  
-  def self.file_is_invalid?(file)
-    return true unless File.basename(file) =~ /.rb\z|.rhtml\z|.erb\z|.haml\z/
-    false
-  end
-  
-  def find_spec_file(file)
-    begin
-      return file if file_is_a_spec?(file)
-      spec_root = find_base_spec_root_by_file(file)
-      if spec_root
-        guessed_spec_location = guess_spec_location(file, spec_root)
-        if File.exist?(guessed_spec_location)
-          @base_spec_root = spec_root
-          return guessed_spec_location
-        end
-      end
-      nil      
-    rescue => e
-      puts "Error while parsing a file: '#{file}'"
-      puts e
-    end
-  end
-  
-  def inner_spec_directory(path)
-    spec_base_root = find_base_spec_root_by_file(Dir.pwd + "/.")
-    inner_location = extract_inner_project_location(Dir.pwd, spec_base_root)
-    File.join(spec_base_root, inner_location)
-  end
-  
-  def find_base_spec_root_by_file(file)
-    if @base_spec_root
-      return @base_spec_root
-    else
-      dir_parts = File.dirname(file).split("/")
-      dir_parts.size.times do |i|
-        search_dir = dir_parts[0..dir_parts.length - i - 1].join("/") + "/"
-        if Dir.entries(search_dir).include?('spec')
-          @assumed_spec_root = search_dir + "spec" 
-          break
-        end
-      end
-      return @assumed_spec_root
-    end
-  end
-  
-  def guess_spec_location(file, spec_root)
-    inner_location = extract_inner_project_location(file, spec_root)
-    append_spec_file_extension(File.join(spec_root, inner_location))
-  end
-
-  def project_root(spec_root)
-    spec_root.split("/")[0...-1].join("/")
-  end
-  
-  def extract_inner_project_location(file, spec_root)
-    location = file.sub(project_root(spec_root), "")
-    adapt_rails_specific_app_structure(location)
-  end
-  
-  def adapt_rails_specific_app_structure(location)
-    # Removing 'app' if its a rails controller, model, helper or view
-    fu = location.split("/")
-    if fu[1] == "app" && (fu[2] == 'controllers' || fu[2] == 'routing' || fu[2] == 'helpers' || fu[2] == 'models' || fu[2] == 'views')
-      return "/" + fu[2..fu.length].join("/")
-    end
-    location
-  end
-  
-  def append_spec_file_extension(spec_file)
-    if File.extname(spec_file) == ".rb"
-      return File.join(File.dirname(spec_file), File.basename(spec_file, ".rb")) + "_spec.rb"
-    else
-      return spec_file + "_spec.rb"
-    end
-  end
-  
-  def file_is_a_spec?(file)
-    if file.split("/").include?('spec') && File.basename(file).match(/_spec.rb\z/)
-      return true
-    end
-    false
-  end
-end

data/lib/interactor.rb

@@ -1,65 +0,0 @@
-require 'timeout'
-
-class Interactor
-  
-  def initialize(options = {})
-    @options = options
-    ticker
-  end
-  
-  def wait_for_enter_key(msg, seconds_to_wait, clear = false)
-    begin
-      Timeout::timeout(seconds_to_wait) do
-        system("clear;") if clear
-        ticker(:start => true, :msg => msg)
-        $stdin.gets   
-        return true 
-      end
-    rescue Timeout::Error
-      false
-    ensure
-      ticker(:stop => true)
-    end
-  end
-  
-  def start_termination_handler
-    @main_thread = Thread.current
-    Thread.new do
-      loop do
-        sleep 0.5
-        if $stdin.gets
-          if wait_for_enter_key("** Running all specs.. Hit <enter> again to exit RSpactor", 3, @options[:clear])
-            @main_thread.exit 
-            exit
-          end
-          Runner.run_all_specs
-        end
-      end
-    end
-  end
-  
-
-  private
-
-  def ticker(opts = {})
-    if opts[:stop]
-      $stdout.puts "\n"           
-      @pointer_running = false
-    elsif opts[:start]
-      @pointer_running = true
-      write(opts[:msg]) if opts[:msg]
-    else
-      Thread.new do
-        loop do
-          write('.') if @pointer_running == true
-          sleep 1.0
-        end
-      end      
-    end
-  end
-    
-  def write(msg)
-    $stdout.print(msg)
-    $stdout.flush
-  end
-end