guard-rubocop 1.1.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: aa248932e68a78aa1fc24ae53d4d300b71640a11
-  data.tar.gz: d23806def0e10055e1aa4988dcd0138a4fa9d43a
+SHA256:
+  metadata.gz: f4fd50bb78f68a751f5fcc10f383377a222c9929ed882c62e44a93f15de13054
+  data.tar.gz: 0ec423fa69f1af3cc9e784a576ecd6c91995f3ab03afdb5ea54226a7bdf97a0e
 SHA512:
-  metadata.gz: fc9f0a685b407939a1d8ea48498d0b5be5f1886c9108281f712cb5d0cc39fb7acad86d33cf8f9fe5a0f8211c716a10178682f457c9188e6529fcfaf2a32220d5
-  data.tar.gz: d00ac9dee7125d9b4fa215953121376d2dcce500a5261e58066748732454574b1c5768c74c88798bf27c1a67ead7c64d3aa197b155360a73b9f5736d23cab798
+  metadata.gz: de52917c49a6988e46ab3c8c2a933e6c590df311252c0d0e8a5828113242448c8f0f1deeaa7c4c57a1290a91f8ae9869bafa73a36c9fdf74c840d1b199fd5f84
+  data.tar.gz: 8a9f56e402052cdbe167ddf27fd6f736e659a1dd864861d7aef07017e3c3f88b3395ac7b9e2ee2eecb57dc4fb84d72720845d2a86f3ae47b7b165ba603b7dd87

data/.github/workflows/ci.yml

@@ -0,0 +1,30 @@
+name: CI
+on: [push, pull_request]
+jobs:
+  rspec:
+    name: RSpec
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.5', '2.6', '2.7', '3.0']
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - run: bundle install
+      - run: bundle exec rspec
+      # FIXME: https://github.com/rubocop/guard-rubocop/pull/48#issuecomment-906893891
+      # - uses: coverallsapp/github-action@master
+      #   with:
+      #     github-token: ${{ secrets.GITHUB_TOKEN }}
+  rubocop:
+    name: RuboCop
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.5
+      - run: bundle install
+      - run: bundle exec rubocop

data/.gitignore

@@ -11,6 +11,7 @@ doc/
 lib/bundler/man
 pkg
 rdoc
+spec/examples.txt
 spec/reports
 test/tmp
 test/version_tmp

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/.rubocop.yml

@@ -1,7 +1,39 @@
-# The default 79 character limit is sometimes unproductive.
-LineLength:
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.5
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/LineLength:
   Max: 100
 
-# The default 10 lines limit is unrealistic.
-MethodLength:
+Lint/MissingSuper:
+  Exclude:
+    - spec/support/silence_output.rb
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Metrics/MethodLength:
   Max: 15
+
+Naming/HeredocDelimiterNaming:
+  Enabled: false
+
+Naming/RescuedExceptionsVariableName:
+  PreferredName: error
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - lib/guard/rubocop/templates/Guardfile
+
+Style/RegexpLiteral:
+  Exclude:
+    - '**/*.gemspec'
+    - '**/Guardfile'

data/.rubocop_todo.yml

@@ -0,0 +1,12 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-01-20 14:55:30 +0900 using RuboCop version 0.52.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 103

data/CHANGELOG.md

@@ -2,6 +2,24 @@
 
 ## Development
 
+## v1.5.0
+
+* Drop support Ruby 2.4. [#50](https://github.com/rubocop/guard-rubocop/pull/50)
+* Allow custom `cmd` option for rubocop. [#48](https://github.com/rubocop/guard-rubocop/pull/48)
+
+## v1.4.0
+
+* Support RuboCop 1.0
+
+## v1.3.0
+
+* Add `:launchy` option ([#21](https://github.com/yujinakayama/guard-rubocop/pull/21), [#35](https://github.com/yujinakayama/guard-rubocop/pull/35))
+* Modify the `Guardfile` template so that RuboCop can be run when `.rubocop_todo.yml` is modified ([#36](https://github.com/yujinakayama/guard-rubocop/pull/36))
+
+## v1.2.0
+
+* Add `:hide_stdout` option ([#15](https://github.com/yujinakayama/guard-rubocop/pull/15))
+
 ## v1.1.0
 
 * Use RuboCop's `--force-exclusion` option to always ignore files specified in the `Exclude` configuration in `.rubocop.yml`

data/Gemfile

@@ -1,16 +1,9 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec
 
 group :test do
-  gem 'coveralls',      '~> 0.6'
-  gem 'simplecov-rcov', '~> 0.2'
-  gem 'ci_reporter',    '~> 1.8'
-end
-
-platforms :rbx do
-  gem 'rubysl'
-  gem 'rubinius-developer_tools'
-  gem 'json'
-  gem 'racc' # Needed for RuboCop
+  gem 'simplecov-lcov'
 end

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
@@ -5,8 +7,8 @@ group :red_green_refactor, halt_on_fail: true do
   guard :rspec, all_after_pass: true, all_on_start: true, cmd: 'bundle exec rspec' do
     watch(%r{^spec/.+_spec\.rb$})
     watch(%r{^lib/(.+)\.rb$})        { |m| "spec/#{m[1]}_spec.rb" }
-    watch('spec/spec_helper.rb')     { "spec" }
-    watch(%r{^spec/support/.+\.rb$}) { "spec" }
+    watch('spec/spec_helper.rb')     { 'spec' }
+    watch(%r{^spec/support/.+\.rb$}) { 'spec' }
   end
 
   guard :rubocop do

data/README.md

@@ -1,14 +1,13 @@
-[![Gem Version](http://img.shields.io/gem/v/guard-rubocop.svg)](http://badge.fury.io/rb/guard-rubocop)
-[![Dependency Status](http://img.shields.io/gemnasium/yujinakayama/guard-rubocop.svg)](https://gemnasium.com/yujinakayama/guard-rubocop)
-[![Build Status](https://travis-ci.org/yujinakayama/guard-rubocop.svg?branch=master)](https://travis-ci.org/yujinakayama/guard-rubocop)
-[![Coverage Status](http://img.shields.io/coveralls/yujinakayama/guard-rubocop/master.svg)](https://coveralls.io/r/yujinakayama/guard-rubocop)
-[![Code Climate](http://img.shields.io/codeclimate/github/yujinakayama/guard-rubocop.svg)](https://codeclimate.com/github/yujinakayama/guard-rubocop)
+[![Gem Version](https://badge.fury.io/rb/guard-rubocop.svg)](http://badge.fury.io/rb/guard-rubocop)
+[![CI](https://github.com/rubocop/guard-rubocop/workflows/CI/badge.svg)](https://github.com/rubocop/guard-rubocop/actions)
+[![Coverage Status](https://coveralls.io/repos/rubocop/guard-rubocop/badge.svg?branch=master&service=github)](https://coveralls.io/github/rubocop/guard-rubocop?branch=master)
+[![Code Climate](https://codeclimate.com/github/rubocop/guard-rubocop/badges/gpa.svg)](https://codeclimate.com/github/rubocop/guard-rubocop)
 
 # guard-rubocop
 
-**guard-rubocop** allows you to automatically check Ruby code style with [RuboCop](https://github.com/bbatsov/rubocop) when files are modified.
+**guard-rubocop** allows you to automatically check Ruby code style with [RuboCop](https://github.com/rubocop/rubocop) when files are modified.
 
-Tested on MRI 1.9, 2.0, 2.1, JRuby in 1.9 mode and Rubinius.
+Tested on MRI 2.5 - 3.0.
 
 ## Installation
 
@@ -34,7 +33,7 @@ or install it yourself as:
 $ gem install guard-rubocop
 ```
 
-Add the default Guard::Rubocop definition to your `Guardfile` by running:
+Add the default Guard::RuboCop definition to your `Guardfile` by running:
 
 ```sh
 $ guard init rubocop
@@ -62,6 +61,11 @@ all_on_start: true     # Check all files at Guard startup.
 cli: '--rails'         # Pass arbitrary RuboCop CLI arguments.
                        # An array or string is acceptable.
                        #   default: nil
+cmd: './bin/rubocop'   # Pass custom cmd to run rubocop.
+                       #   default: rubocop
+
+hide_stdout: false     # Do not display console output (in case outputting to file).
+                       #   default: false
 keep_failed: true      # Keep failed files until they pass.
                        #   default: true
 notification: :failed  # Display Growl notification after each run.
@@ -69,6 +73,19 @@ notification: :failed  # Display Growl notification after each run.
                        #   false   - Never notify
                        #   :failed - Notify only when failed
                        #   default: :failed
+launchy: nil           # Filename to launch using Launchy after RuboCop runs.
+                       #   default: nil
+```
+
+### Using Launchy to view results
+
+guard-rubocop can be configured to launch a results file in lieu of or in addition to outputing results to the terminal.
+Configure your Guardfile with the launchy option:
+
+``` ruby
+guard :rubocop, cli: %w(--format fuubar --format html -o ./tmp/rubocop_results.html), launchy: './tmp/rubocop_results.html' do
+  # ...
+end
 ```
 
 ## Advanced Tips
@@ -79,7 +96,7 @@ you might be uncomfortable with the offense reports from RuboCop in the red-gree
 * In the red-green phase, you're not necessarily required to write clean code – you just focus writing code to pass the test. It means, in this phase, `guard-rspec` should be run but `guard-rubocop` should not.
 * In the refactor phase, you're required to make the code clean while keeping the test passing. In this phase, both `guard-rspec` and `guard-rubocop` should be run.
 
-In this case, you may think the following `Guardfile` structure useful:
+In this case, you may consider making use of the [group method](https://github.com/guard/guard/wiki/Guardfile-DSL---Configuring-Guard#group) in your `Guardfile`:
 
 ```ruby
 # This group allows to skip running RuboCop when RSpec failed.
@@ -106,6 +123,6 @@ Note: You need to use `guard-rspec` 4.2.3 or later due to a [bug](https://github
 
 ## License
 
-Copyright (c) 2013–2014 Yuji Nakayama
+Copyright (c) 2013–2020 Yuji Nakayama
 
 See the [LICENSE.txt](LICENSE.txt) for details.

data/Rakefile

@@ -1,23 +1,10 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
-Rubocop::RakeTask.new(:style)
-
-namespace :ci do
-  task :spec do
-    ENV['CI'] = 'true'
-
-    ENV['CI_REPORTS'] = 'spec/reports'
-    require 'ci/reporter/rake/rspec'
-    Rake::Task['ci:setup:rspec'].invoke
-
-    Rake::Task['spec'].invoke
-  end
-end
-
-desc 'Run RSpec and RuboCop'
-task all: [:spec, :style]
+RuboCop::RakeTask.new(:style)
 
-task default: :all
+task ci: %i[spec style]

data/guard-rubocop.gemspec

@@ -1,32 +1,35 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'guard/rubocop/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'guard-rubocop'
-  spec.version       = Guard::RubocopVersion.to_s
+  spec.version       = GuardRuboCopVersion.to_s
   spec.authors       = ['Yuji Nakayama']
   spec.email         = ['nkymyj@gmail.com']
   spec.summary       = 'Guard plugin for RuboCop'
-  spec.description   = 'Guard::Rubocop automatically checks Ruby code style with RuboCop when files are modified.'
-  spec.homepage      = 'https://github.com/yujinakayama/guard-rubocop'
+  spec.description   = 'Guard::RuboCop automatically checks Ruby code style with RuboCop ' \
+                       'when files are modified.'
+  spec.homepage      = 'https://github.com/rubocop/guard-rubocop'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.required_ruby_version = '>= 2.5'
+
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(/^spec\//)
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'guard',   '~> 2.0'
-  spec.add_runtime_dependency 'rubocop', '~> 0.20'
+  spec.add_runtime_dependency 'rubocop', '< 2.0'
 
-  spec.add_development_dependency 'bundler',     '~> 1.3'
-  spec.add_development_dependency 'rake',        '~> 10.0'
-  spec.add_development_dependency 'rspec',       '~> 3.0.0.beta1'
-  spec.add_development_dependency 'simplecov',   '~> 0.7'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'guard-rspec', '>= 4.2.3', '< 5.0'
-  spec.add_development_dependency 'ruby_gntp',   '~> 0.3'
+  spec.add_development_dependency 'launchy',     '~> 2.4'
+  spec.add_development_dependency 'rake',        '>= 12.0'
+  spec.add_development_dependency 'rspec',       '~> 3.0'
+  spec.add_development_dependency 'simplecov',   '~> 0.7'
 end

data/lib/guard/rubocop/runner.rb

@@ -1,9 +1,9 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'json'
 
 module Guard
-  class Rubocop
+  class RuboCop
     # This class runs `rubocop` command, retrieves result and notifies.
     # An instance of this class is intended to invoke `rubocop` only once in its lifetime.
     class Runner
@@ -22,14 +22,16 @@ module Guard
           notify(passed)
         end
 
+        open_launchy_if_needed
+
         passed
       end
 
       def build_command(paths)
-        command = ['rubocop']
+        command = [@options[:cmd] || 'rubocop']
 
-        unless include_formatter_for_console?(args_specified_by_user)
-          command.concat(%w(--format progress)) # Keep default formatter for console.
+        if should_add_default_formatter_for_console?
+          command.concat(%w[--format progress]) # Keep default formatter for console.
         end
 
         command.concat(['--format', 'json', '--out', json_file_path])
@@ -38,6 +40,10 @@ module Guard
         command.concat(paths)
       end
 
+      def should_add_default_formatter_for_console?
+        !@options[:hide_stdout] && !include_formatter_for_console?(args_specified_by_user)
+      end
+
       def args_specified_by_user
         @args_specified_by_user ||= begin
           args = @options[:cli]
@@ -45,7 +51,7 @@ module Guard
           when Array    then args
           when String   then args.shellsplit
           when NilClass then []
-          else fail ':cli option must be either an array or string'
+          else raise ArgumentError, ':cli option must be either an array or string'
           end
         end
       end
@@ -74,11 +80,9 @@ module Guard
       end
 
       def result
-        @result ||= begin
-          File.open(json_file_path) do |file|
-            # Rubinius 2.0.0.rc1 does not support `JSON.load` with 3 args.
-            JSON.parse(file.read, symbolize_names: true)
-          end
+        @result ||= File.open(json_file_path) do |file|
+          # Rubinius 2.0.0.rc1 does not support `JSON.load` with 3 args.
+          JSON.parse(file.read, symbolize_names: true)
         end
       end
 
@@ -109,19 +113,26 @@ module Guard
       end
 
       def pluralize(number, thing, options = {})
-        text = ''
-
-        if number == 0 && options[:no_for_zero]
-          text = 'no'
-        else
-          text << number.to_s
-        end
+        text =
+          if number.zero? && options[:no_for_zero]
+            +'no'
+          else
+            number.to_s
+          end
 
         text << " #{thing}"
         text << 's' unless number == 1
 
         text
       end
+
+      def open_launchy_if_needed
+        return unless (output_path = @options[:launchy])
+        return unless File.exist?(output_path)
+
+        require 'launchy'
+        ::Launchy.open(output_path)
+      end
     end
   end
 end

data/lib/guard/rubocop/templates/Guardfile

@@ -1,4 +1,4 @@
 guard :rubocop do
   watch(%r{.+\.rb$})
-  watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+  watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
 end

data/lib/guard/rubocop/version.rb

@@ -1,16 +1,14 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-module Guard
-  # A workaround for declaring `class Rubocop`
-  # before `class Rubocop < Guard` in rubocop.rb
-  module RubocopVersion
-    # http://semver.org/
-    MAJOR = 1
-    MINOR = 1
-    PATCH = 0
+# A workaround for declaring `class RuboCop`
+# before `class RuboCop < Guard` in rubocop.rb
+module GuardRuboCopVersion
+  # http://semver.org/
+  MAJOR = 1
+  MINOR = 5
+  PATCH = 0
 
-    def self.to_s
-      [MAJOR, MINOR, PATCH].join('.')
-    end
+  def self.to_s
+    [MAJOR, MINOR, PATCH].join('.')
   end
 end

data/lib/guard/rubocop.rb

@@ -1,12 +1,12 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'guard'
 require 'guard/plugin'
 
 module Guard
-  # This class gets API calls from `guard` and runs `rubocop` command via {Guard::Rubocop::Runner}.
+  # This class gets API calls from `guard` and runs `rubocop` command via {Guard::RuboCop::Runner}.
   # An instance of this class stays alive in a `guard` command session.
-  class Rubocop < Plugin
+  class RuboCop < Plugin
     autoload :Runner, 'guard/rubocop/runner'
 
     attr_reader :options, :failed_paths
@@ -16,9 +16,10 @@ module Guard
 
       @options = {
         all_on_start: true,
-        keep_failed:  true,
+        keep_failed: true,
         notification: :failed,
-        cli: nil
+        cli: nil,
+        hide_stdout: false
       }.merge(options)
 
       @failed_paths = []
@@ -64,7 +65,7 @@ module Guard
       passed = runner.run(paths)
       @failed_paths = runner.failed_paths
       throw :task_has_failed unless passed
-    rescue => error
+    rescue StandardError => error
       UI.error 'The following exception occurred while running guard-rubocop: ' \
                "#{error.backtrace.first} #{error.message} (#{error.class.name})"
     end
@@ -75,6 +76,7 @@ module Guard
       paths.uniq!
       paths.reject! do |path|
         next true unless File.exist?(path)
+
         included_in_other_path?(path, paths)
       end
       paths

data/spec/guard/rubocop/runner_spec.rb

@@ -1,9 +1,9 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-require 'spec_helper.rb'
+require 'launchy'
 
-describe Guard::Rubocop::Runner do
-  subject(:runner) { Guard::Rubocop::Runner.new(options) }
+RSpec.describe Guard::RuboCop::Runner do
+  subject(:runner) { Guard::RuboCop::Runner.new(options) }
   let(:options) { {} }
 
   describe '#run' do
@@ -77,43 +77,94 @@ describe Guard::Rubocop::Runner do
 
     context 'when :notification option is true' do
       let(:options) { { notification: true } }
-      include_examples 'notification', { passed: true, failed: true }
+      include_examples 'notification', passed: true, failed: true
     end
 
     context 'when :notification option is :failed' do
       let(:options) { { notification: :failed } }
-      include_examples 'notification', { passed: false, failed: true }
+      include_examples 'notification', passed: false, failed: true
     end
 
     context 'when :notification option is false' do
       let(:options) { { notification: false } }
-      include_examples 'notification', { passed: false, failed: false }
+      include_examples 'notification', passed: false, failed: false
+    end
+
+    context 'when :launchy option is present' do
+      let(:options) { { launchy: 'launchy_path' } }
+
+      before do
+        allow(File).to receive(:exist?).with('launchy_path').and_return(true)
+      end
+
+      it 'opens Launchy' do
+        expect(Launchy).to receive(:open).with('launchy_path')
+        runner.run(paths)
+      end
     end
   end
 
   describe '#build_command' do
     subject(:build_command) { runner.build_command(paths) }
-    let(:options) { { cli: %w(--debug --rails) } }
-    let(:paths) { %w(file1.rb file2.rb) }
+    let(:options) { { cli: %w[--debug --rails] } }
+    let(:paths) { %w[file1.rb file2.rb] }
 
-    context 'when :cli option includes formatter for console' do
-      let(:options) { { cli: %w(--format simple) } }
+    describe ':cmd option' do
+      context 'when set' do
+        let(:options) { { cmd: 'bin/rubocop' } }
+
+        it 'uses the supplied :cmd' do
+          expect(build_command[0]).to eq('bin/rubocop')
+        end
+      end
 
-      it 'does not add args for the default formatter for console' do
-        expect(build_command[0..2]).not_to eq(%w(rubocop --format progress))
+      context 'when not set' do
+        it 'uses the default command' do
+          expect(build_command[0]).to eq('rubocop')
+        end
       end
     end
 
-    context 'when :cli option does not include formatter for console' do
-      let(:options) { { cli: %w(--format simple --out simple.txt) } }
+    context 'when :hide_stdout is not set' do
+      context 'and :cli option includes formatter for console' do
+        before { options[:cli] = %w[--format simple] }
 
-      it 'adds args for the default formatter for console' do
-        expect(build_command[0..2]).to eq(%w(rubocop --format progress))
+        it 'does not add args for the default formatter for console' do
+          expect(build_command[0..2]).not_to eq(%w[rubocop --format progress])
+        end
+      end
+
+      context 'and :cli option does not include formatter for console' do
+        before { options[:cli] = %w[--format simple --out simple.txt] }
+
+        it 'adds args for the default formatter for console' do
+          expect(build_command[0..2]).to eq(%w[rubocop --format progress])
+        end
+      end
+    end
+
+    context 'when :hide_stdout is set' do
+      before { options[:hide_stdout] = true }
+
+      context 'and :cli option includes formatter for console' do
+        before { options[:cli] = %w[--format simple] }
+
+        it 'does not add args for the default formatter for console' do
+          expect(build_command[0..2]).not_to eq(%w[rubocop --format progress])
+        end
+      end
+
+      context 'and :cli option does not include formatter for console' do
+        before { options[:cli] = %w[--format simple --out simple.txt] }
+
+        it 'does not add args for the default formatter for console' do
+          expect(build_command[0..2]).not_to eq(%w[rubocop --format progress])
+        end
       end
     end
 
     it 'adds args for JSON formatter' do
-      expect(build_command[3..4]).to eq(%w(--format json))
+      expect(build_command[3..4]).to eq(%w[--format json])
     end
 
     it 'adds args for output file path of JSON formatter' do
@@ -126,11 +177,11 @@ describe Guard::Rubocop::Runner do
     end
 
     it 'adds args specified by user' do
-      expect(build_command[8..9]).to eq(%w(--debug --rails))
+      expect(build_command[8..9]).to eq(%w[--debug --rails])
     end
 
     it 'adds the passed paths' do
-      expect(build_command[10..-1]).to eq(%w(file1.rb file2.rb))
+      expect(build_command[10..-1]).to eq(%w[file1.rb file2.rb])
     end
   end
 
@@ -163,7 +214,7 @@ describe Guard::Rubocop::Runner do
       let(:options) { { cli: { key: 'value' } } }
 
       it 'raises error' do
-        expect { runner.args_specified_by_user }.to raise_error
+        expect { runner.args_specified_by_user }.to raise_error(ArgumentError)
       end
     end
   end
@@ -173,7 +224,7 @@ describe Guard::Rubocop::Runner do
 
     context 'when the passed args include a -f/--format' do
       context 'but does not include an -o/--output' do
-        let(:args) { %w(--format simple --debug) }
+        let(:args) { %w[--format simple --debug] }
 
         it 'returns true' do
           expect(include_formatter_for_console?).to be_truthy
@@ -181,7 +232,7 @@ describe Guard::Rubocop::Runner do
       end
 
       context 'and include an -o/--output just after the -f/--format' do
-        let(:args) { %w(--format simple --out simple.txt) }
+        let(:args) { %w[--format simple --out simple.txt] }
 
         it 'returns false' do
           expect(include_formatter_for_console?).to be_falsey
@@ -189,7 +240,7 @@ describe Guard::Rubocop::Runner do
       end
 
       context 'and include an -o/--output after the -f/--format across another arg' do
-        let(:args) { %w(--format simple --debug --out simple.txt) }
+        let(:args) { %w[--format simple --debug --out simple.txt] }
 
         it 'returns false' do
           expect(include_formatter_for_console?).to be_falsey
@@ -199,7 +250,7 @@ describe Guard::Rubocop::Runner do
 
     context 'when the passed args include a -f with its arg without separator' do
       context 'but does not include an -o/--output' do
-        let(:args) { %w(-fs --debug) }
+        let(:args) { %w[-fs --debug] }
 
         it 'returns true' do
           expect(include_formatter_for_console?).to be_truthy
@@ -207,7 +258,7 @@ describe Guard::Rubocop::Runner do
       end
 
       context 'and include an -o with its arg without separator just after the -f/--format' do
-        let(:args) { %w(-fs -osimple.txt) }
+        let(:args) { %w[-fs -osimple.txt] }
 
         it 'returns false' do
           expect(include_formatter_for_console?).to be_falsey
@@ -217,7 +268,7 @@ describe Guard::Rubocop::Runner do
 
     context 'when the passed args include multiple -f/--format' do
       context 'and all -f/--format have associated -o/--out' do
-        let(:args) { %w(--format simple --out simple.txt --format emacs --out emacs.txt) }
+        let(:args) { %w[--format simple --out simple.txt --format emacs --out emacs.txt] }
 
         it 'returns false' do
           expect(include_formatter_for_console?).to be_falsey
@@ -225,7 +276,7 @@ describe Guard::Rubocop::Runner do
       end
 
       context 'and any -f/--format has associated -o/--out' do
-        let(:args) { %w(--format simple --format emacs --out emacs.txt) }
+        let(:args) { %w[--format simple --format emacs --out emacs.txt] }
 
         it 'returns true' do
           expect(include_formatter_for_console?).to be_truthy
@@ -233,7 +284,7 @@ describe Guard::Rubocop::Runner do
       end
 
       context 'and no -f/--format has associated -o/--out' do
-        let(:args) { %w(--format simple --format emacs) }
+        let(:args) { %w[--format simple --format emacs] }
 
         it 'returns true' do
           expect(include_formatter_for_console?).to be_truthy
@@ -242,7 +293,7 @@ describe Guard::Rubocop::Runner do
     end
 
     context 'when the passed args do not include -f/--format' do
-      let(:args) { %w(--debug) }
+      let(:args) { %w[--debug] }
 
       it 'returns false' do
         expect(include_formatter_for_console?).to be_falsey
@@ -312,12 +363,10 @@ describe Guard::Rubocop::Runner do
   describe '#notify' do
     before do
       allow(runner).to receive(:result).and_return(
-        {
-          summary: {
-            offense_count: 4,
-            target_file_count: 3,
-            inspected_file_count: 2
-          }
+        summary: {
+          offense_count: 4,
+          target_file_count: 3,
+          inspected_file_count: 2
         }
       )
     end
@@ -358,12 +407,10 @@ describe Guard::Rubocop::Runner do
   describe '#summary_text' do
     before do
       allow(runner).to receive(:result).and_return(
-        {
-          summary: {
-            offense_count: offense_count,
-            target_file_count: target_file_count,
-            inspected_file_count: inspected_file_count
-          }
+        summary: {
+          offense_count: offense_count,
+          target_file_count: target_file_count,
+          inspected_file_count: inspected_file_count
         }
       )
     end
@@ -419,12 +466,10 @@ describe Guard::Rubocop::Runner do
     context 'with spelling "offence" in old RuboCop' do
       before do
         allow(runner).to receive(:result).and_return(
-          {
-            summary: {
-              offence_count: 2,
-              target_file_count: 1,
-              inspected_file_count: 1
-            }
+          summary: {
+            offence_count: 2,
+            target_file_count: 1,
+            inspected_file_count: 1
           }
         )
       end

data/spec/guard/rubocop_spec.rb

@@ -1,9 +1,7 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-require 'spec_helper.rb'
-
-describe Guard::Rubocop, :silence_output do
-  subject(:guard) { Guard::Rubocop.new(options) }
+RSpec.describe Guard::RuboCop, :silence_output do
+  subject(:guard) { Guard::RuboCop.new(options) }
   let(:options) { {} }
 
   describe '#options' do
@@ -57,13 +55,13 @@ describe Guard::Rubocop, :silence_output do
   shared_examples 'processes after running', :processes_after_running do
     context 'when passed' do
       it 'throws nothing' do
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(true)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(true)
         expect { subject }.not_to throw_symbol
       end
 
       it 'clears failed paths' do
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(true)
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:failed_paths).and_return([])
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(true)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:failed_paths).and_return([])
         subject
         expect(guard.failed_paths).to be_empty
       end
@@ -71,7 +69,7 @@ describe Guard::Rubocop, :silence_output do
 
     context 'when failed' do
       it 'throws symbol :task_has_failed' do
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(false)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(false)
         expect { subject }.to throw_symbol(:task_has_failed)
       end
 
@@ -81,8 +79,8 @@ describe Guard::Rubocop, :silence_output do
           'some_failed_file.rb',
           'dir/another_failed_file.rb'
         ]
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(false)
-        allow_any_instance_of(Guard::Rubocop::Runner)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(false)
+        allow_any_instance_of(Guard::RuboCop::Runner)
           .to receive(:failed_paths).and_return(failed_paths)
         subject
         expect(guard.failed_paths).to eq(failed_paths)
@@ -91,7 +89,7 @@ describe Guard::Rubocop, :silence_output do
 
     context 'when an exception is raised' do
       it 'prevents itself from firing' do
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_raise(RuntimeError)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_raise(RuntimeError)
         expect { subject }.not_to raise_error
       end
     end
@@ -101,17 +99,17 @@ describe Guard::Rubocop, :silence_output do
     subject { super().run_all }
 
     before do
-      allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(true)
-      allow_any_instance_of(Guard::Rubocop::Runner).to receive(:failed_paths).and_return([])
+      allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(true)
+      allow_any_instance_of(Guard::RuboCop::Runner).to receive(:failed_paths).and_return([])
     end
 
     it 'inspects all files with rubocop' do
-      expect_any_instance_of(Guard::Rubocop::Runner).to receive(:run).with([])
+      expect_any_instance_of(Guard::RuboCop::Runner).to receive(:run).with([])
       guard.run_all
     end
   end
 
-  [:run_on_additions, :run_on_modifications].each do |method|
+  %i[run_on_additions run_on_modifications].each do |method|
     describe "##{method}", :processes_after_running do
       subject { super().send(method, changed_paths) }
       let(:changed_paths) do
@@ -122,17 +120,17 @@ describe Guard::Rubocop, :silence_output do
       end
 
       before do
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:run).and_return(true)
-        allow_any_instance_of(Guard::Rubocop::Runner).to receive(:failed_paths).and_return([])
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:run).and_return(true)
+        allow_any_instance_of(Guard::RuboCop::Runner).to receive(:failed_paths).and_return([])
       end
 
       it 'inspects changed files with rubocop' do
-        expect_any_instance_of(Guard::Rubocop::Runner).to receive(:run)
+        expect_any_instance_of(Guard::RuboCop::Runner).to receive(:run)
         subject
       end
 
       it 'passes cleaned paths to rubocop' do
-        expect_any_instance_of(Guard::Rubocop::Runner).to receive(:run) do |_instance, paths|
+        expect_any_instance_of(Guard::RuboCop::Runner).to receive(:run) do |_instance, paths|
           expect(paths).to eq([
             File.expand_path('lib/guard/rubocop.rb'),
             File.expand_path('spec/spec_helper.rb')
@@ -147,7 +145,7 @@ describe Guard::Rubocop, :silence_output do
         end
 
         it 'does nothing' do
-          expect_any_instance_of(Guard::Rubocop::Runner).not_to receive(:run)
+          expect_any_instance_of(Guard::RuboCop::Runner).not_to receive(:run)
           subject
         end
       end
@@ -159,7 +157,7 @@ describe Guard::Rubocop, :silence_output do
 
         it 'also inspects paths which are failed last time' do
           guard.failed_paths << failed_path
-          expect_any_instance_of(Guard::Rubocop::Runner).to receive(:run) do |_instance, paths|
+          expect_any_instance_of(Guard::RuboCop::Runner).to receive(:run) do |_instance, paths|
             expect(paths).to include failed_path
           end
           subject
@@ -171,7 +169,7 @@ describe Guard::Rubocop, :silence_output do
 
         it 'inspects just changed paths' do
           guard.failed_paths << failed_path
-          expect_any_instance_of(Guard::Rubocop::Runner).to receive(:run) do |_instance, paths|
+          expect_any_instance_of(Guard::RuboCop::Runner).to receive(:run) do |_instance, paths|
             expect(paths).to eq([
               File.expand_path('lib/guard/rubocop.rb'),
               File.expand_path('spec/spec_helper.rb')

data/spec/spec_helper.rb

@@ -1,33 +1,33 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 RSpec.configure do |config|
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  config.mock_with :rspec do |c|
-    c.syntax = :expect
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
   end
-end
 
-Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|
-  require path
-end
+  config.filter_run_when_matching :focus
+
+  config.example_status_persistence_file_path = 'spec/examples.txt'
 
-require 'simplecov'
-SimpleCov.coverage_dir(File.join('spec', 'coverage'))
+  config.disable_monkey_patching!
 
-if ENV['TRAVIS']
-  require 'coveralls'
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-elsif ENV['CI']
-  require 'simplecov-rcov'
-  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+  config.default_formatter = 'doc' if config.files_to_run.one?
+
+  config.order = :random
+
+  Kernel.srand config.seed
 end
 
-SimpleCov.start do
-  add_filter '/spec/'
-  add_filter '/vendor/bundle/'
+Dir[File.join(File.dirname(__FILE__), 'support', '*')].sort.each do |path|
+  require path
 end
 
+# Initialize Guard for running tests.
+require 'guard'
+Guard.setup(notify: false)
+
 require 'guard/rubocop'

data/spec/support/silence_output.rb

@@ -1,6 +1,6 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-shared_context 'silence output', silence_output: true do
+RSpec.shared_context 'silence output', :silence_output do
   null_object = BasicObject.new
 
   class << null_object
@@ -9,6 +9,10 @@ shared_context 'silence output', silence_output: true do
       true
     end
 
+    def respond_to_missing?(*)
+      true
+    end
+
     def method_missing(*)
     end
   end

data/spec/support/simplecov.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'simplecov'
+
+if ENV['CI']
+  require 'simplecov-lcov'
+
+  SimpleCov::Formatter::LcovFormatter.config do |config|
+    config.report_with_single_file = true
+    config.single_report_path = 'coverage/lcov.info'
+  end
+
+  SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter
+end
+
+SimpleCov.start do
+  add_filter '/spec/'
+  add_filter '/vendor/bundle/'
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Yuji Nakayama
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-04-13 00:00:00.000000000 Z
+date: 2021-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -28,107 +28,107 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.3
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 4.2.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: launchy
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: '2.4'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.2.3
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.2.3
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: ruby_gntp
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
-description: Guard::Rubocop automatically checks Ruby code style with RuboCop when
+        version: '0.7'
+description: Guard::RuboCop automatically checks Ruby code style with RuboCop when
   files are modified.
 email:
 - nkymyj@gmail.com
@@ -136,9 +136,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop_todo.yml"
 - ".yardopts"
 - CHANGELOG.md
 - Gemfile
@@ -151,16 +153,16 @@ files:
 - lib/guard/rubocop/runner.rb
 - lib/guard/rubocop/templates/Guardfile
 - lib/guard/rubocop/version.rb
-- spec/.rubocop.yml
 - spec/guard/rubocop/runner_spec.rb
 - spec/guard/rubocop_spec.rb
 - spec/spec_helper.rb
 - spec/support/silence_output.rb
-homepage: https://github.com/yujinakayama/guard-rubocop
+- spec/support/simplecov.rb
+homepage: https://github.com/rubocop/guard-rubocop
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -168,22 +170,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.7.6.3
+signing_key:
 specification_version: 4
 summary: Guard plugin for RuboCop
 test_files:
-- spec/.rubocop.yml
 - spec/guard/rubocop/runner_spec.rb
 - spec/guard/rubocop_spec.rb
 - spec/spec_helper.rb
 - spec/support/silence_output.rb
-has_rdoc: 
+- spec/support/simplecov.rb

data/.travis.yml

@@ -1,10 +0,0 @@
-language: ruby
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
-  - jruby-19mode
-  - rbx
-script:
-  - bundle exec rspec
-  - bundle exec rubocop

data/spec/.rubocop.yml

@@ -1,5 +0,0 @@
-inherit_from: ../.rubocop.yml
-
-# Sometimes I want to indicate that “This is a hash” explicitly with #and_return.
-BracesAroundHashParameters:
-  Enabled: false