guard-rspec 4.7.0 → 4.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0fc28c16ceeddadc68019093ed5e2d48362f5c3c
-  data.tar.gz: 3b52eda168c7398bca052b5c01497b97dd2d11bd
+  metadata.gz: b6163bfd9a274c88eefd7a84f1e1f815d1191b33
+  data.tar.gz: 80deab415f449c74ec8b4f50589dae22f80ec021
 SHA512:
-  metadata.gz: c2770e272f1965dd1cce1878f5dcb9617dff9519c453f6806fa8c7945603476edfe5cf33289a4d95267f154eb15cee8ba10459263b00ca987436e94c16909736
-  data.tar.gz: 293ed7b6f57587da0b3b4df12a8b0520b0d33b2fe16b17c8222ceb09c458dae57de5a7b8da95d74d65b69e16fc8be3452adc01055ebc3bcf65bf4acbb3c70aee
+  metadata.gz: 1618cbb9b313aff920902dfd34780c12b076b627a6f287cd9b8ab38451a38ba532e1d1d3dd1ca5a34a6d8fee07394a256431806a9a67a7e1b8581ea7899e2daa
+  data.tar.gz: dff4b7a5a92c25b42a5beda572ea707958fe2e2d173f2582838d4aa790d5fa8b64f1b330703738f8e7b301b75714655c2a59ec19d6e9dfc94e28107931e1c28d

data/.hound.yml

@@ -0,0 +1,3 @@
+ruby:
+  enabled: true
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -1,2 +1,5 @@
 inherit_from:
   .rubocop_todo.yml
+
+Style/StringLiterals:
+  Enabled: false

data/.travis.yml

@@ -1,14 +1,14 @@
 language: ruby
-bundler_args: --without tool
+bundler_args: --without=tool development
 rvm:
   - 2.2.5
   - 2.3.1
-  - jruby-9.0.5.0
+  - jruby-9.1.1.0
 gemfile:
   - gemfiles/Gemfile.rspec-2.99
   - gemfiles/Gemfile.rspec-3.4
 matrix:
   allow_failures:
-    - rvm: jruby-9.0.50
+    - rvm: jruby-9.1.1.0
 sudo: false
 cache: bundler

data/Gemfile

@@ -1,18 +1,27 @@
-source "https://rubygems.org"
+# Note: on Travis, this Gemfile is only for installing
+# dependencies. The actual builds use the Gemfiles in
+# the gemspecs/* directory.
+
+filename = "gemfiles/common"
+instance_eval(IO.read(filename), filename, 1)
+
+group :test do
+  gem "rspec", "~> 3.4"
+end
 
 if ENV["USE_INSTALLED_GUARD_RSPEC"] == "1"
   gem "guard-rspec"
-  gem "launchy"
 else
-  gemspec
+  gemspec development_group: :gem_build_tools
 end
 
-group :test do
-  gem "coveralls", require: false
+# bundler + rake - always included
+group :gem_build_tools do
+  gem "bundler", "~> 1.12", "< 2.0"
+  gem "rake", "~> 11.1"
 end
 
 group :development do
-  gem "rspec", "~> 3.4"
   gem "rubocop", require: false
   gem "guard-rubocop", require: false
   gem "guard-compat", ">= 0.0.2", require: false

data/README.md

@@ -21,6 +21,28 @@ Add guard definition to your Guardfile by running this command:
 $ guard init rspec
 ```
 
+## Installing with beta versions of RSpec
+
+To install beta versions of RSpec, you need to set versions of all the dependencies, e.g:
+
+```ruby
+gem 'rspec', '= 3.5.0.beta3'
+gem 'rspec-core', '= 3.5.0.beta3'
+gem 'rspec-expectations', '= 3.5.0.beta3'
+gem 'rspec-mocks', '= 3.5.0.beta3'
+gem 'rspec-support', '= 3.5.0.beta3'
+
+gem 'guard-rspec, '~> 4.7`
+```
+
+and for Rails projects this also means adding:
+  
+```ruby
+gem 'rspec-rails', '= 3.5.0.beta3'
+```
+
+and then running `bundle update rspec rspec-core rspec-expectations rspec-mocks rspec-support rspec-rails` or just `bundle update` to update all the gems in your project.
+
 ## Usage
 
 Please read [Guard usage doc](https://github.com/guard/guard#readme).

data/Rakefile

@@ -21,7 +21,7 @@ namespace :test do
   task :all_versions do
     system(*%w(bundle install --quiet)) || abort
     system(*%w(bundle update --quiet)) || abort
-    system(*%w(bundle exec rubocop -c .hound.yml)) || abort
+    system(*%w(bundle exec rubocop -c .rubocop.yml)) || abort
 
     travis = YAML.load(IO.read(".travis.yml"))
     travis["gemfile"].each do |gemfile|

data/gemfiles/Gemfile.rspec-2.99

@@ -1,14 +1,6 @@
-source "https://rubygems.org"
-
 gemspec path: '../'
 
-gem 'rspec', '~> 2.99'
-
-group :test do
-  gem 'coveralls', require: false
-  gem "guard-compat", ">= 0.0.2", require: false
-end
+filename = "gemfiles/common"
+instance_eval(IO.read(filename), filename, 1)
 
-group :tool do
-  gem 'ruby_gntp', require: false
-end
+gem 'rspec', '~> 2.99'

data/gemfiles/Gemfile.rspec-3.4

@@ -1,14 +1,6 @@
-source "https://rubygems.org"
-
 gemspec path: '../'
 
-gem 'rspec', '~> 3.4.0'
-
-group :test do
-  gem 'coveralls', require: false
-  gem "guard-compat", ">= 0.0.2", require: false
-end
+filename = "gemfiles/common"
+instance_eval(IO.read(filename), filename, 1)
 
-group :tool do
-  gem 'ruby_gntp', require: false
-end
+gem 'rspec', '~> 3.4.0'

data/gemfiles/common

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+
+group :test do
+  gem "bundler", "~> 1.12", "< 2.0"
+  gem "rake", "~> 11.1"
+  gem 'coveralls', require: false
+  gem "launchy", "~> 2.4"
+  gem "gem_isolator", '~> 0.2', '>= 0.2.1'
+end

data/guard-rspec.gemspec

@@ -22,8 +22,4 @@ Gem::Specification.new do |s|
   s.add_dependency "guard", "~> 2.1"
   s.add_dependency "guard-compat", "~> 1.1"
   s.add_dependency "rspec", ">= 2.99.0", "< 4.0"
-
-  s.add_development_dependency "bundler", ">= 1.3.5", "< 2.0"
-  s.add_development_dependency "rake", "~> 10.1"
-  s.add_development_dependency "launchy", "~> 2.4"
 end

data/lib/guard/rspec/version.rb

@@ -1,5 +1,5 @@
 module Guard
   module RSpecVersion
-    VERSION = "4.7.0".freeze
+    VERSION = "4.7.1".freeze
   end
 end

data/lib/guard/rspec_formatter.rb

@@ -9,8 +9,6 @@ require "rspec/core/formatters/base_formatter"
 
 require_relative "rspec_formatter_results_path"
 
-require "guard/ui"
-
 module Guard
   class RSpecFormatter < ::RSpec::Core::Formatters::BaseFormatter
     UNSUPPORTED_PATTERN =
@@ -117,9 +115,9 @@ module Guard
 
     def _write(&block)
       file = RSpecFormatterResultsPath.new.path
-      if Guard.const_defined?(:Compat)
+      if ENV['GUARD_RSPEC_DEBUGGING'] == '1'
         msg = "Guard::RSpec: using results file: #{file.inspect}"
-        Guard::Compat::UI.debug(format(msg, file))
+        STDERR.puts format(msg, file)
       end
       FileUtils.mkdir_p(File.dirname(file))
       File.open(file, "w", &block)

data/spec/acceptance/fixtures/succeeding_spec.rb

@@ -0,0 +1,4 @@
+RSpec.describe "succeeding spec" do
+  it "works" do
+  end
+end

data/spec/acceptance/formatter_spec.rb

@@ -0,0 +1,46 @@
+require 'pathname'
+require 'tempfile'
+
+require 'gem_isolator'
+
+RSpec.describe "Formatter test", type: :acceptance do
+  context "when isolated" do
+    before { allow(Kernel).to receive(:system).and_call_original }
+
+    let!(:formatter) { File.expand_path('lib/guard/rspec_formatter.rb') }
+
+    context "when a valid results file path is given" do
+      around do |example|
+        Tempfile.open('results') do |tempfile|
+          @results_file = tempfile.path
+          example.run
+        end
+      end
+
+      context "when a succeeding command is given" do
+        let!(:spec) do
+          File.expand_path('spec/acceptance/fixtures/succeeding_spec.rb')
+        end
+
+        let(:rspec_args) do
+          ['-r', formatter, '-f', 'Guard::RSpecFormatter', spec]
+        end
+
+        context "when guard is not in Gemfile" do
+          let(:gems) { [%w(rspec ~>3.4)] }
+
+          it "works" do
+            GemIsolator.isolate(gems: gems) do |env, isolation|
+              env = env.merge('GUARD_RSPEC_RESULTS_FILE' => @results_file)
+
+              # TODO: I don't know why Travis needs a full path for binaries
+              # for system() to work.
+              rspec = env['PATH'].sub(/:.*/, '/rspec')
+              expect(isolation.system(env, rspec, *rspec_args)).to eq(true)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/guard/rspec/rspec_process_spec.rb

@@ -3,12 +3,6 @@ require "guard/compat/test/helper"
 require "guard/rspec/rspec_process"
 
 RSpec.describe Guard::RSpec::RSpecProcess do
-  before do
-    allow(Kernel).to receive(:spawn) do |*args|
-      raise "Not stubbed: Kernel.spawn(#{args.map(&:inspect) * ','})"
-    end
-  end
-
   let(:results) { instance_double(Guard::RSpec::Results) }
 
   let(:cmd) { "foo" }

data/spec/spec_helper.rb

@@ -29,6 +29,13 @@ end
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
+  config.register_ordering :global do |examples|
+    examples.partition { |ex| ex.metadata[:type] != :acceptance }.flatten(1)
+  end
+
+  # Use global for running acceptance tests last
+  config.order = :global
+
   config.expect_with :rspec do |expectations|
     # This option will default to `true` in RSpec 4. It makes the `description`
     # and `failure_message` of custom matchers include text for helper methods
@@ -89,12 +96,6 @@ RSpec.configure do |config|
   # particularly slow.
   # config.profile_examples = 10
 
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
   # Seed global randomization in this process using the `--seed` CLI option.
   # Setting this allows you to use `--seed` to deterministically reproduce
   # test failures related to randomization by passing the same `--seed` value
@@ -136,7 +137,7 @@ RSpec.configure do |config|
     end
 
     %w(spawn system).each do |meth|
-      allow(File).to receive(meth.to_sym) do |*args|
+      allow(Kernel).to receive(meth.to_sym) do |*args|
         abort "stub me: Kernel.#{meth}(#{args.map(&:inspect) * ','})!"
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rspec
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.7.1
 platform: ruby
 authors:
 - Thibaud Guillaume-Gentil
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-22 00:00:00.000000000 Z
+date: 2016-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -58,54 +58,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.5
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.5
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.1'
-- !ruby/object:Gem::Dependency
-  name: launchy
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
 description: Guard::RSpec automatically run your specs (much like autotest).
 email: thibaud@thibaud.gg
 executables: []
@@ -113,6 +65,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
@@ -125,6 +78,7 @@ files:
 - Rakefile
 - gemfiles/Gemfile.rspec-2.99
 - gemfiles/Gemfile.rspec-3.4
+- gemfiles/common
 - guard-rspec.gemspec
 - lib/guard/rspec.rb
 - lib/guard/rspec/command.rb
@@ -145,6 +99,8 @@ files:
 - lib/guard/rspec_defaults.rb
 - lib/guard/rspec_formatter.rb
 - lib/guard/rspec_formatter_results_path.rb
+- spec/acceptance/fixtures/succeeding_spec.rb
+- spec/acceptance/formatter_spec.rb
 - spec/lib/guard/rspec/command_spec.rb
 - spec/lib/guard/rspec/deprecator_spec.rb
 - spec/lib/guard/rspec/inspectors/base_inspector_spec.rb
@@ -186,6 +142,8 @@ signing_key:
 specification_version: 4
 summary: Guard gem for RSpec
 test_files:
+- spec/acceptance/fixtures/succeeding_spec.rb
+- spec/acceptance/formatter_spec.rb
 - spec/lib/guard/rspec/command_spec.rb
 - spec/lib/guard/rspec/deprecator_spec.rb
 - spec/lib/guard/rspec/inspectors/base_inspector_spec.rb