guard-rspec 4.3.1 → 4.4.1

data/spec/lib/guard/rspec_formatter_spec.rb

@@ -0,0 +1,144 @@
+require "guard/rspec_formatter"
+
+RSpec.describe Guard::RSpecFormatter do
+  describe "::TEMPORARY_FILE_PATH" do
+    subject { Pathname.new(described_class::TEMPORARY_FILE_PATH) }
+    it { is_expected.to be_relative }
+  end
+
+  describe "#write_summary" do
+    let(:writer) do
+      StringIO.new
+    end
+
+    let(:formatter) do
+      described_class.new(StringIO.new).tap do |formatter|
+        allow(formatter).to receive(:_write) do |&block|
+          block.call writer
+        end
+      end
+    end
+
+    let(:result) do
+      writer.rewind
+      writer.read
+    end
+
+    context "without stubbed IO" do
+      let(:formatter) do
+        described_class.new(StringIO.new)
+      end
+
+      it "creates temporary file and and writes to it" do
+        file = File.expand_path(described_class::TEMPORARY_FILE_PATH)
+
+        expect(FileUtils).to receive(:mkdir_p).
+          with(File.dirname(file)) {}
+
+        expect(File).to receive(:open).
+          with(file, "w") do |_, _, &block|
+          block.call writer
+        end
+
+        formatter.write_summary(123, 1, 2, 3)
+      end
+    end
+
+    context "with failures" do
+      let(:spec_filename) { "failed_location_spec.rb" }
+
+      let(:failed_example) do
+        double(
+          execution_result: { status: "failed" },
+          metadata: { location: spec_filename }
+        )
+      end
+
+      def expected_output(spec_filename)
+        /^3 examples, 1 failures in 123\.0 seconds\n#{spec_filename}\n$/
+      end
+
+      it "writes summary line and failed location in tmp dir" do
+        allow(formatter).to receive(:examples) { [failed_example] }
+        formatter.write_summary(123, 3, 1, 0)
+        expect(result).to match expected_output(spec_filename)
+      end
+
+      it "writes only uniq filenames out" do
+        allow(formatter).to receive(:examples).
+          and_return([failed_example, failed_example])
+
+        formatter.write_summary(123, 3, 1, 0)
+        expect(result).to match expected_output(spec_filename)
+      end
+
+      context "for rspec 3" do
+        let(:notification) do
+          Struct.new(:duration, :example_count, :failure_count, :pending_count).
+            new(123, 3, 1, 0)
+        end
+        before do
+          allow(formatter.class).to receive(:rspec_3?).and_return(true)
+        end
+
+        it "writes summary line and failed location" do
+          allow(formatter).to receive(:examples) { [failed_example] }
+          formatter.dump_summary(notification)
+          expect(result).to match expected_output(spec_filename)
+        end
+      end
+    end
+
+    it "should find the spec file for shared examples" do
+      metadata = {
+        location: "./spec/support/breadcrumbs.rb:75",
+        example_group: { location: "./spec/requests/breadcrumbs_spec.rb:218" }
+      }
+
+      result = described_class.extract_spec_location(metadata)
+      expect(result).to start_with "./spec/requests/breadcrumbs_spec.rb"
+    end
+
+    # Skip location because of rspec issue
+    # https://github.com/rspec/rspec-core/issues/1243
+    it "returns only the spec file without line number for shared examples" do
+      metadata = {
+        location: "./spec/support/breadcrumbs.rb:75",
+        example_group: { location: "./spec/requests/breadcrumbs_spec.rb:218" }
+      }
+      expect(described_class.extract_spec_location(metadata)).
+        to eq "./spec/requests/breadcrumbs_spec.rb"
+    end
+
+    context "when a shared examples has no location" do
+      it "should return location of the root spec" do
+        metadata = {
+          location: "./spec/support/breadcrumbs.rb:75",
+          example_group: {}
+        }
+
+        expect(STDERR).to receive(:puts).
+          with("no spec file found for #{metadata[:location]}") {}
+
+        expect(described_class.extract_spec_location(metadata)).
+          to eq metadata[:location]
+      end
+    end
+
+    context "with only success" do
+      it "notifies success" do
+        formatter.write_summary(123, 3, 0, 0)
+        expect(result).to match /^3 examples, 0 failures in 123\.0 seconds\n$/
+      end
+    end
+
+    context "with pending" do
+      it "notifies pending too" do
+        formatter.write_summary(123, 3, 0, 1)
+        expect(result).to match(
+          /^3 examples, 0 failures \(1 pending\) in 123\.0 seconds\n$/
+        )
+      end
+    end
+  end
+end

data/spec/lib/guard/rspec_spec.rb

@@ -1,50 +1,56 @@
-require 'spec_helper'
+require "guard/compat/test/helper"
+require "guard/rspec"
 
-describe Guard::RSpec do
+RSpec.describe Guard::RSpec do
   let(:default_options) { Guard::RSpec::Options::DEFAULTS }
   let(:options) { {} }
   let(:plugin) { Guard::RSpec.new(options) }
   let(:runner) { double(Guard::RSpec::Runner) }
-  before {
+
+  before do
     allow(Guard::UI).to receive(:info)
     allow(Guard::RSpec::Deprecator).to receive(:warns_about_deprecated_options)
     allow(Guard::RSpec::Runner).to receive(:new) { runner }
-  }
+  end
 
-  describe '.initialize' do
-    it 'instanciates with default and custom options' do
+  describe ".initialize" do
+    it "instanciates with default and custom options" do
       guard_rspec = Guard::RSpec.new(foo: :bar)
       expect(guard_rspec.options).to eq(default_options.merge(foo: :bar))
     end
 
-    it 'instanciates Runner with all default and custom options' do
-      expect(Guard::RSpec::Runner).to receive(:new).with(default_options.merge(foo: :bar))
+    it "instanciates Runner with all default and custom options" do
+      expect(Guard::RSpec::Runner).to receive(:new).
+        with(default_options.merge(foo: :bar))
       Guard::RSpec.new(foo: :bar)
     end
 
-    it 'warns deprecated options' do
-      expect(Guard::RSpec::Deprecator).to receive(:warns_about_deprecated_options).with(default_options.merge(foo: :bar))
+    it "warns deprecated options" do
+      expect(Guard::RSpec::Deprecator).
+        to receive(:warns_about_deprecated_options).
+        with(default_options.merge(foo: :bar))
+
       Guard::RSpec.new(foo: :bar)
     end
   end
 
-  describe '#start' do
+  describe "#start" do
     it "doesn't call #run_all by default" do
       expect(plugin).to_not receive(:run_all)
       plugin.start
     end
 
-    context 'with all_on_start at true' do
+    context "with all_on_start at true" do
       let(:options) { { all_on_start: true } }
 
-      it 'calls #run_all' do
+      it "calls #run_all" do
         expect(plugin).to receive(:run_all)
         plugin.start
       end
     end
   end
 
-  describe '#run_all' do
+  describe "#run_all" do
     it "runs all specs via runner" do
       expect(runner).to receive(:run_all) { true }
       plugin.run_all
@@ -57,15 +63,15 @@ describe Guard::RSpec do
     end
   end
 
-  describe '#reload' do
+  describe "#reload" do
     it "reloads via runner" do
       expect(runner).to receive(:reload)
       plugin.reload
     end
   end
 
-  describe '#run_on_modifications' do
-    let(:paths) { %w[path1 path2] }
+  describe "#run_on_modifications" do
+    let(:paths) { %w(path1 path2) }
     it "runs all specs via runner" do
       expect(runner).to receive(:run).with(paths) { true }
       plugin.run_on_modifications(paths)
@@ -84,4 +90,3 @@ describe Guard::RSpec do
   end
 
 end
-

data/spec/spec_helper.rb

@@ -1,24 +1,109 @@
-require 'rspec'
-require 'guard/rspec'
+require "rspec"
 
-if ENV['CI']
-  require 'coveralls'
+if ENV["CI"]
+  require "coveralls"
   Coveralls.wear!
 end
 
-rspec_major_version = RSpec::Version::STRING.to_i
+rspec_version = ::RSpec::Version::STRING.to_f
+old_rspec = (rspec_version < 3)
 
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  if rspec_major_version < 3
-    config.color_enabled = true
-    config.treat_symbols_as_metadata_keys_with_true_values = true
-  else
-    config.color = true
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    # be_bigger_than(2).and_smaller_than(4).description
+    #   # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #   # => "be bigger than 2"
+
+    unless old_rspec
+      if rspec_version > 3.0
+        expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+      end
+    end
   end
-  config.order = :random
-  config.filter_run focus: ENV['CI'] != 'true'
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    unless old_rspec
+      mocks.verify_partial_doubles = true
+    end
+
+  end
+
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run focus: ENV["CI"] != "true"
   config.run_all_when_everything_filtered = true
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended.
+  # For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+
+  unless old_rspec
+    config.disable_monkey_patching!
+  end
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  # config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+
+  config.raise_errors_for_deprecations!
+
+  config.before do
+    allow(Dir).to receive(:[]) do |*args|
+      abort "stub me: Dir[#{args.first}]!"
+    end
+
+    %w(directory? delete readlines).each do |meth|
+      allow(File).to receive(meth.to_sym) do |*args|
+        abort "stub me: File.#{meth}(#{args.map(&:inspect) * ","})!"
+      end
+    end
+
+    %w(mkdir).each do |meth|
+      allow(FileUtils).to receive(meth.to_sym) do |*args|
+        abort "stub me: FileUtils.#{meth}(#{args.map(&:inspect) * ","})!"
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rspec
 version: !ruby/object:Gem::Version
-  version: 4.3.1
+  version: 4.4.1
 platform: ruby
 authors:
 - Thibaud Guillaume-Gentil
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-23 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -30,7 +30,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 2.99.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -40,7 +40,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 2.99.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -99,6 +99,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
+- ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
@@ -107,12 +111,12 @@ files:
 - README.md
 - Rakefile
 - gemfiles/Gemfile.rspec-2.14
+- gemfiles/Gemfile.rspec-2.99
 - gemfiles/Gemfile.rspec-3.0
 - guard-rspec.gemspec
 - lib/guard/rspec.rb
 - lib/guard/rspec/command.rb
 - lib/guard/rspec/deprecator.rb
-- lib/guard/rspec/formatter.rb
 - lib/guard/rspec/inspectors/base_inspector.rb
 - lib/guard/rspec/inspectors/factory.rb
 - lib/guard/rspec/inspectors/focused_inspector.rb
@@ -123,9 +127,9 @@ files:
 - lib/guard/rspec/runner.rb
 - lib/guard/rspec/templates/Guardfile
 - lib/guard/rspec/version.rb
+- lib/guard/rspec_formatter.rb
 - spec/lib/guard/rspec/command_spec.rb
 - spec/lib/guard/rspec/deprecator_spec.rb
-- spec/lib/guard/rspec/formatter_spec.rb
 - spec/lib/guard/rspec/inspectors/base_inspector_spec.rb
 - spec/lib/guard/rspec/inspectors/factory_spec.rb
 - spec/lib/guard/rspec/inspectors/focused_inspector_spec.rb
@@ -134,6 +138,7 @@ files:
 - spec/lib/guard/rspec/inspectors/simple_inspector_spec.rb
 - spec/lib/guard/rspec/notifier_spec.rb
 - spec/lib/guard/rspec/runner_spec.rb
+- spec/lib/guard/rspec_formatter_spec.rb
 - spec/lib/guard/rspec_spec.rb
 - spec/spec_helper.rb
 homepage: https://rubygems.org/gems/guard-rspec
@@ -163,7 +168,6 @@ summary: Guard gem for RSpec
 test_files:
 - spec/lib/guard/rspec/command_spec.rb
 - spec/lib/guard/rspec/deprecator_spec.rb
-- spec/lib/guard/rspec/formatter_spec.rb
 - spec/lib/guard/rspec/inspectors/base_inspector_spec.rb
 - spec/lib/guard/rspec/inspectors/factory_spec.rb
 - spec/lib/guard/rspec/inspectors/focused_inspector_spec.rb
@@ -172,5 +176,6 @@ test_files:
 - spec/lib/guard/rspec/inspectors/simple_inspector_spec.rb
 - spec/lib/guard/rspec/notifier_spec.rb
 - spec/lib/guard/rspec/runner_spec.rb
+- spec/lib/guard/rspec_formatter_spec.rb
 - spec/lib/guard/rspec_spec.rb
 - spec/spec_helper.rb