guard-brakeman 0.3.2 → 0.4.0

data/README.md

@@ -2,6 +2,9 @@
 
 Guard::Brakeman allows you to automatically run [Brakeman](http://brakemanscanner.org/) tests when files are modified.
 
+Use guard-brakeman >= 0.4.0 for brakeman >= 1.5.3
+--------------
+And use < 0.4.0 for brakeman < 1.5.3
 
 ## Install
 

data/lib/guard/brakeman.rb

@@ -24,6 +24,9 @@ module Guard
 
       # TODO mixing the use of this attr, good to match?  Bad to couple?
       @options = {
+          :notifications => true,
+          :run_on_start => false,
+          :chatty => false,
           :min_confidence => 1
       }.update(options)
     end
@@ -75,19 +78,19 @@ module Guard
     private
 
     def print_failed report
-      all_warnings = report.all_warnings
+      UI.info "\n------ brakeman warnings --------\n"
 
-      unless @options[:no_console_output]
-        UI.info "\n------ brakeman warnings --------\n"
-        puts all_warnings.sort_by { |w| w.confidence }
-      end
+      icon = report.all_warnings.count > 0 ? :failed : :success
+
+      all_warnings = reject_below_threshold(report.all_warnings)
+
+      puts all_warnings.sort_by { |w| w.confidence }
 
-      icon = all_warnings.count > 0 ? :failed : :success
       message = "#{all_warnings.count} brakeman findings"
 
-      if @options[:output_file]
+      if @options[:output_files]
         write_report
-        message += "\nResults written to #{@options[:output_file]}" 
+        message += "\nResults written to #{@options[:output_files]}" 
       end
 
       if @options[:chatty] && all_warnings.any?
@@ -101,8 +104,7 @@ module Guard
       message = ""
       should_alert = false
 
-      fixed_warnings = report.fixed_warnings
-
+      fixed_warnings = reject_below_threshold(report.fixed_warnings)
       if fixed_warnings.any?
         icon = :success
         results_notification = "#{fixed_warnings.length} fixed warning(s)\n"
@@ -111,13 +113,11 @@ module Guard
         should_alert = true 
         message += results_notification
 
-        unless @options[:no_console_output]
-          puts fixed_warnings.sort_by { |w| w.confidence }
-          puts
-        end
+        puts fixed_warnings.sort_by { |w| w.confidence }
+        puts
       end
 
-      new_warnings = report.new_warnings
+      new_warnings = reject_below_threshold(report.new_warnings)
       if new_warnings.any?
         new_warning_message = "#{new_warnings.length} new warning(s)\n"
         UI.error new_warning_message
@@ -126,13 +126,11 @@ module Guard
         should_alert = true
         icon = :failed
 
-        unless @options[:no_console_output]
-          puts new_warnings.sort_by { |w| w.confidence }
-          puts
-        end
+        puts new_warnings.sort_by { |w| w.confidence }
+        puts
       end
 
-      existing_warnings = report.existing_warnings
+      existing_warnings = reject_below_threshold(report.existing_warnings)
       if existing_warnings.any?
         should_alert = true if @options[:chatty]
         icon ||= :pending
@@ -141,12 +139,14 @@ module Guard
         UI.warning existing_warning_message
         message += existing_warning_message
 
-        puts existing_warnings.sort_by { |w| w.confidence } unless @options[:no_console_output]
+        puts existing_warnings.sort_by { |w| w.confidence }
       end
 
-      if @options[:output_file]
+
+
+      if @options[:output_files]
         write_report
-        message += "\nResults written to #{@options[:output_file]}" 
+        message += "\nResults written to #{@options[:output_files]}" 
       end
 
       if @options[:notifications] && should_alert
@@ -154,9 +154,15 @@ module Guard
       end
     end
 
+    def reject_below_threshold(warnings)
+      warnings.reject {|w| w.confidence > (3 - @options[:min_confidence].to_i)}
+    end
+
     def write_report
-      File.open @options[:output_file], "w" do |f|
-        f.puts @tracker.report.send(@options[:output_format])
+      @options[:output_files].each_with_index do |output_file, i|
+        File.open output_file, "w" do |f|
+          f.puts @tracker.report.send(@options[:output_formats][i])
+        end
       end
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: guard-brakeman
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 15
   prerelease: 
   segments: 
   - 0
-  - 3
-  - 2
-  version: 0.3.2
+  - 4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Neil Matatall
@@ -16,8 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-04-09 00:00:00 -07:00
-default_executable: 
+date: 2012-05-03 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: guard
@@ -43,12 +42,12 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 7
+        hash: 5
         segments: 
         - 1
         - 5
-        - 2
-        version: 1.5.2
+        - 3
+        version: 1.5.3
   type: :runtime
   version_requirements: *id002
 description: Guard::Brakeman automatically scans your Rails app for vulnerabilities
@@ -64,7 +63,6 @@ files:
 - lib/guard/brakeman.rb
 - LICENSE
 - README.md
-has_rdoc: true
 homepage: http://rubygems.org/gems/guard-brakeman
 licenses: []
 
@@ -96,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: guard-brakeman
-rubygems_version: 1.4.2
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Guard gem for Brakeman