guard-brakeman 0.3.1 → 0.3.2

data/lib/guard/brakeman.rb

@@ -24,9 +24,6 @@ module Guard
 
       # TODO mixing the use of this attr, good to match?  Bad to couple?
       @options = {
-          :notifications => true,
-          :run_on_start => false,
-          :chatty => false,
           :min_confidence => 1
       }.update(options)
     end
@@ -78,14 +75,14 @@ module Guard
     private
 
     def print_failed report
-      UI.info "\n------ brakeman warnings --------\n"
-
-      icon = report.all_warnings.count > 0 ? :failed : :success
-
-      all_warnings = reject_below_threshold(report.all_warnings)
+      all_warnings = report.all_warnings
 
-      puts all_warnings.sort_by { |w| w.confidence }
+      unless @options[:no_console_output]
+        UI.info "\n------ brakeman warnings --------\n"
+        puts all_warnings.sort_by { |w| w.confidence }
+      end
 
+      icon = all_warnings.count > 0 ? :failed : :success
       message = "#{all_warnings.count} brakeman findings"
 
       if @options[:output_file]
@@ -104,7 +101,8 @@ module Guard
       message = ""
       should_alert = false
 
-      fixed_warnings = reject_below_threshold(report.fixed_warnings)
+      fixed_warnings = report.fixed_warnings
+
       if fixed_warnings.any?
         icon = :success
         results_notification = "#{fixed_warnings.length} fixed warning(s)\n"
@@ -113,11 +111,13 @@ module Guard
         should_alert = true 
         message += results_notification
 
-        puts fixed_warnings.sort_by { |w| w.confidence }
-        puts
+        unless @options[:no_console_output]
+          puts fixed_warnings.sort_by { |w| w.confidence }
+          puts
+        end
       end
 
-      new_warnings = reject_below_threshold(report.new_warnings)
+      new_warnings = report.new_warnings
       if new_warnings.any?
         new_warning_message = "#{new_warnings.length} new warning(s)\n"
         UI.error new_warning_message
@@ -126,11 +126,13 @@ module Guard
         should_alert = true
         icon = :failed
 
-        puts new_warnings.sort_by { |w| w.confidence }
-        puts
+        unless @options[:no_console_output]
+          puts new_warnings.sort_by { |w| w.confidence }
+          puts
+        end
       end
 
-      existing_warnings = reject_below_threshold(report.existing_warnings)
+      existing_warnings = report.existing_warnings
       if existing_warnings.any?
         should_alert = true if @options[:chatty]
         icon ||= :pending
@@ -139,11 +141,9 @@ module Guard
         UI.warning existing_warning_message
         message += existing_warning_message
 
-        puts existing_warnings.sort_by { |w| w.confidence }
+        puts existing_warnings.sort_by { |w| w.confidence } unless @options[:no_console_output]
       end
 
-
-
       if @options[:output_file]
         write_report
         message += "\nResults written to #{@options[:output_file]}" 
@@ -154,10 +154,6 @@ module Guard
       end
     end
 
-    def reject_below_threshold(warnings)
-      warnings.reject {|w| w.confidence > (3 - @options[:min_confidence].to_i)}
-    end
-
     def write_report
       File.open @options[:output_file], "w" do |f|
         f.puts @tracker.report.send(@options[:output_format])

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: guard-brakeman
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 3
-  - 1
-  version: 0.3.1
+  - 2
+  version: 0.3.2
 platform: ruby
 authors: 
 - Neil Matatall
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-13 00:00:00 -08:00
+date: 2012-04-09 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -27,12 +27,12 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 19
+        hash: 21
         segments: 
+        - 1
         - 0
-        - 2
-        - 2
-        version: 0.2.2
+        - 1
+        version: 1.0.1
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -43,12 +43,12 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 27
+        hash: 7
         segments: 
         - 1
+        - 5
         - 2
-        - 2
-        version: 1.2.2
+        version: 1.5.2
   type: :runtime
   version_requirements: *id002
 description: Guard::Brakeman automatically scans your Rails app for vulnerabilities