gs1 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24b04c0b10ceed0d1bc8745d597110030cdd3d61
-  data.tar.gz: 6960554532b52b1b2e83caa82eed49d01288b356
+  metadata.gz: 9d50c9655be44cc5487286e9bc934f75c21f3872
+  data.tar.gz: 289498f478e765b504fb6006fbe8dcd2f7010d0b
 SHA512:
-  metadata.gz: edd1c509c1cee9d40ce143f2da1a398af424edeb52d87068d70e78bac40ecac8e8c6fdd16bc6583d55c05f7cfd86d5853d8b7d9d9123b1442d5749796f57779b
-  data.tar.gz: c5bb3a874be97053f38a957030da6d163da6f3ac69c083b9404f7bcbcf24bfdf125d0bce3b9049ef0129101109f800f5dd6861b8229409bc31b53d2126ca6067
+  metadata.gz: f411ca39dc709ba23ceef51ba78984d52dc26b2130e773ebbe767fe124796a01912db4086fe8771e231921a2da9b7b45eba83a326f215d10b487f5f12d26f9ef
+  data.tar.gz: 4067cd00f2397d755b6a44b24b15b4a53487faa55906ee4a3033fa354ad834328a0ec69417ec541312cce533466101b2472451b4500e562ddf0b92f7a2eaec1d

data/gs1.gemspec

@@ -37,6 +37,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rb-readline', '~> 0.1'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.1'
+  spec.add_development_dependency 'rubocop', '~> 0.49.0'
   spec.add_development_dependency 'simplecov', '~> 0.1'
 end

data/lib/gs1/barcode/healthcare.rb

@@ -5,13 +5,16 @@ module GS1
     class Healthcare < Base
       define_records GTIN, ExpirationDate, Batch, SerialNumber
 
-      def to_s(level: AIDCMarketingLevels::ENHANCED)
+      def to_s(level: AIDCMarketingLevels::ENHANCED, separator: "\u001E")
         return unless valid?(level: level)
 
-        [gtin.to_ai,
-         expiration_date&.to_ai,
-         batch&.to_ai,
-         serial_number&.to_ai].compact.join
+        [
+          gtin.to_ai,
+          expiration_date&.to_ai,
+          batch&.to_ai,
+          separator,
+          serial_number&.to_ai
+        ].compact.join
       end
 
       def valid?(level: AIDCMarketingLevels::ENHANCED)

data/lib/gs1/definitions.rb

@@ -2,6 +2,7 @@ module GS1
   # Module for handling definitions.
   #
   module Definitions
+    class MissingLengthDefinition < StandardError; end
     class UnknownDefinition < StandardError; end
 
     def self.included(base)
@@ -72,7 +73,7 @@ module GS1
       end
 
       def lengths
-        definitions[:length]
+        definitions[:length] || raise(MissingLengthDefinition)
       end
     end
   end

data/lib/gs1/extensions/date.rb

@@ -10,15 +10,15 @@ module GS1
         base.define :length, barcode: 6
       end
 
-      def to_s
-        return data.strftime('%y%m%d') if data.is_a?(::Date)
-
-        data
+      def initialize(date)
+        if date.respond_to?(:strftime)
+          super(date.strftime('%y%m%d'))
+        else
+          super(date)
+        end
       end
 
       def to_date
-        return data if data.is_a?(::Date)
-
         ::Date.parse(data)
       end
     end

data/lib/gs1/record.rb

@@ -8,7 +8,6 @@ module GS1
     attr_reader :data
 
     def initialize(data)
-      super
       @data = data
     end
 
@@ -44,12 +43,12 @@ module GS1
     end
 
     def to_ai
-      "#{ai}#{data}"
+      "#{ai}#{to_s}" # rubocop:disable Lint/StringConversionInInterpolation
     end
 
     def ==(other)
-      self.class == other.class &&
-        to_s == other.to_s
+      self.class.equal?(other.class) &&
+        to_s.eql?(other.to_s)
     end
   end
 end

data/lib/gs1/validations.rb

@@ -25,12 +25,6 @@ module GS1
     # Adding validation instance methods.
     #
     module InstanceMethods
-      attr_reader :errors
-
-      def initialize(*)
-        @errors = []
-      end
-
       def valid?
         errors.clear
 
@@ -39,6 +33,10 @@ module GS1
         errors.empty?
       end
 
+      def errors
+        @errors ||= []
+      end
+
       def validate
         self.class.definitions.each_key do |definition|
           public_send("validate_#{definition}")

data/lib/gs1/version.rb

@@ -1,3 +1,3 @@
 module GS1
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gs1
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Stefan Åhman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-18 00:00:00.000000000 Z
+date: 2018-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement