gruff 0.21.0-java → 0.23.0-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d569a4cf8b46975563f111d9c2715da9d77da0216b5fa38d6f6be33f1ff8255c
-  data.tar.gz: b362cc9b3ebf58503cbc898a73e69ce927a559637ebc8cb89977f02221c60211
+  metadata.gz: ccbe03d82324858d43ef208c29e5fe685df853100bdd7e2a5541b5b35e9cd82e
+  data.tar.gz: 19578cbb0ca970e05c2a64a87fa9cee93398552b643dacaa2ad7ffa4737054b5
 SHA512:
-  metadata.gz: 46afebf1af13fc4b11ed067dcda1556050827c477a4dddf306d2530e264b65bb9e1dc85cc8c28295e810b4a27b38bf682a9a7e803e75720f57a5eb1a374eba25
-  data.tar.gz: 5b6b6e86e9616405b296a2c931a93c276fb773ed24963705c5e078f992eca0bd1074abdad4ee5f42aa1f88513ede0b4c9ce157a17f207a2ae7648dca61e6ef67
+  metadata.gz: f0681e1a7f9798f151de44df7af54508d9b8d4b98361357049550a3adc89bc65ffdb526c4a8576eed3f81249384e10a7e2dc97103d4afd04a0c9a80eec1001e5
+  data.tar.gz: 3eba1ccf0e2ebab141946bc814dd6a6b638a4dd4da9641988dae36f0f3ec53b0529499ac5b1f2f78fa9387251d9a98f7cda9a8c00c5a3f481aecbe06965463a2

data/.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
     - name: Install dependencies
       run: bundle install --path=vendor/bundle --jobs 4 --retry 3
     - name: RuboCop Problem Matchers
-      uses: r7kamura/rubocop-problem-matchers-action@v1
+      uses: r7kamura/rubocop-problem-matchers-action@v1.2.1
     - name: Run tests
       run: bundle exec rubocop
 

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+## 0.23.0
+- Update dependent RMagick version to 5.3.0 or later (#622)
+
+## 0.22.0
+- Fix Gruff::Bar and Gruff::SideBar in order to draw positive and negative mixed graph (#620)
+- Allow to override label margin value (#618)
+- Accept image format in Base#to_image in order to fix `no decode delegate for this image format` error (#619)
+
 ## 0.21.0
 - Fix legend color with empty label (#615)
 

data/README.md

@@ -144,8 +144,8 @@ http://www.rubydoc.info/github/topfunky/gruff/frames
 
 ## Supported Ruby Versions
 
-- Ruby 2.5 or later
-- JRuby 9.2.x or later
+- Ruby 2.6 or later
+- JRuby 9.3.x or later
 
 ## Development
 1. Build docker image

data/gruff.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
     s.platform = 'java'
     s.add_dependency 'rmagick4j'
   else
-    s.add_dependency 'rmagick', '>= 4.2'
+    s.add_dependency 'rmagick', '>= 5.3'
     s.add_development_dependency 'rubocop', '~> 1.50.2'
     s.add_development_dependency 'rubocop-minitest', '~> 0.30.0'
     s.add_development_dependency 'rubocop-performance', '~> 1.17.1'

data/lib/gruff/bar.rb

@@ -123,7 +123,7 @@ private
         right_x = left_x + (bar_width * @bar_spacing)
 
         top_y, bottom_y = conversion.get_top_bottom_scaled(bar.point)
-        if bar.point != 0
+        if top_y != bottom_y
           rect_renderer = Gruff::Renderer::Rectangle.new(renderer, color: bar.color)
           rect_renderer.render(left_x, bottom_y - AXIS_MARGIN, right_x, top_y)
         end

data/lib/gruff/base.rb

@@ -27,6 +27,9 @@ module Gruff
 
     DEFAULT_TARGET_WIDTH = 800.0
 
+    # Blank space between graph and labels. Default is +15+.
+    attr_writer :label_margin
+
     # Blank space above the graph. Default is +20+.
     attr_writer :top_margin
 
@@ -180,6 +183,7 @@ module Gruff
       @marker_font = Gruff::Font.new(size: 21.0)
       @legend_font = Gruff::Font.new(size: 20.0)
 
+      @label_margin = LABEL_MARGIN
       @top_margin = @bottom_margin = @left_margin = @right_margin = DEFAULT_MARGIN
       @legend_margin = LEGEND_MARGIN
       @title_margin = TITLE_MARGIN
@@ -497,6 +501,8 @@ module Gruff
     # Return a rendered graph image.
     # This can use RMagick's methods to adjust the image before saving.
     #
+    # @param format [String] The output image format.
+    #
     # @return [Magick::Image] The rendered image.
     #
     # @example
@@ -507,22 +513,24 @@ module Gruff
     #   image = image.resize(400, 300).quantize(128, Magick::RGBColorspace)
     #   image.write('test.png')
     #
-    def to_image
+    def to_image(format = 'PNG')
       @to_image ||= begin
         draw
         renderer.finish
-        renderer.image
+        image = renderer.image
+        image.format = format
+        image
       end
     end
 
     # Return the graph as a rendered binary blob.
     #
-    # @param image_format [String] The image format of binary blob.
+    # @param format [String] The image format of binary blob.
     #
     # @deprecated Please use +to_image.to_blob+ instead.
-    def to_blob(image_format = 'PNG')
+    def to_blob(format = 'PNG')
       warn '#to_blob is deprecated. Please use `to_image.to_blob` instead'
-      to_image.format = image_format
+      to_image.format = format
       to_image.to_blob
     end
 
@@ -646,7 +654,7 @@ module Gruff
         # X Axis
         # Centered vertically and horizontally by setting the
         # height to 1.0 and the width to the width of the graph.
-        x_axis_label_y_coordinate = @graph_bottom + (LABEL_MARGIN * 2) + labels_caps_height
+        x_axis_label_y_coordinate = @graph_bottom + (@label_margin * 2) + labels_caps_height
 
         text_renderer = Gruff::Renderer::Text.new(renderer, @x_axis_label, font: @marker_font)
         text_renderer.add_to_render_queue(@raw_columns, 1.0, 0.0, x_axis_label_y_coordinate)
@@ -674,7 +682,7 @@ module Gruff
           marker_label = (BigDecimal(index.to_s) * BigDecimal(@increment.to_s)) + BigDecimal(minimum_value.to_s)
           label = y_axis_label(marker_label, @increment)
           text_renderer = Gruff::Renderer::Text.new(renderer, label, font: @marker_font)
-          text_renderer.add_to_render_queue(@graph_left - LABEL_MARGIN, 1.0, 0.0, y, Magick::EastGravity)
+          text_renderer.add_to_render_queue(@graph_left - @label_margin, 1.0, 0.0, y, Magick::EastGravity)
         end
       end
     end
@@ -715,7 +723,7 @@ module Gruff
 
       current_y_offset = begin
         if @legend_at_bottom
-          @graph_bottom + @legend_margin + labels_caps_height + LABEL_MARGIN + (@x_axis_label ? (LABEL_MARGIN * 2) + marker_caps_height : 0)
+          @graph_bottom + @legend_margin + labels_caps_height + @label_margin + (@x_axis_label ? (@label_margin * 2) + marker_caps_height : 0)
         else
           hide_title? ? @top_margin + @title_margin : @top_margin + @title_margin + title_caps_height
         end
@@ -771,7 +779,7 @@ module Gruff
       draw_unique_label(index) do
         if x >= @graph_left && x <= @graph_right
           y = @graph_bottom
-          x_offset, y_offset = calculate_label_offset(@marker_font, @labels[index], LABEL_MARGIN, @label_rotation)
+          x_offset, y_offset = calculate_label_offset(@marker_font, @labels[index], @label_margin, @label_rotation)
 
           draw_label_at(1.0, 1.0, x + x_offset, y + y_offset, @labels[index], gravity: gravity, rotation: @label_rotation)
           yield if block
@@ -899,10 +907,10 @@ module Gruff
         if !@has_left_labels && (@hide_line_markers || @hide_line_numbers)
           0.0
         else
-          longest_left_label_width + LABEL_MARGIN
+          longest_left_label_width + @label_margin
         end
       end
-      y_axis_label_width = @y_axis_label.nil? ? 0.0 : marker_caps_height + (LABEL_MARGIN * 2)
+      y_axis_label_width = @y_axis_label.nil? ? 0.0 : marker_caps_height + (@label_margin * 2)
 
       bottom_label_width = extra_left_room_for_long_label
 
@@ -962,10 +970,10 @@ module Gruff
     end
 
     def setup_bottom_margin
-      graph_bottom_margin = hide_bottom_label_area? ? @bottom_margin : @bottom_margin + labels_caps_height + LABEL_MARGIN
+      graph_bottom_margin = hide_bottom_label_area? ? @bottom_margin : @bottom_margin + labels_caps_height + @label_margin
       graph_bottom_margin += (calculate_legend_height + @legend_margin) if @legend_at_bottom
 
-      x_axis_label_height = @x_axis_label.nil? ? 0.0 : marker_caps_height + (LABEL_MARGIN * 2)
+      x_axis_label_height = @x_axis_label.nil? ? 0.0 : marker_caps_height + (@label_margin * 2)
       @raw_rows - graph_bottom_margin - x_axis_label_height
     end
 

data/lib/gruff/dot.rb

@@ -59,7 +59,7 @@ private
       unless @hide_line_numbers
         label = y_axis_label(marker_label, @increment)
         text_renderer = Gruff::Renderer::Text.new(renderer, label, font: @marker_font)
-        text_renderer.add_to_render_queue(0, 0, x, @graph_bottom + (LABEL_MARGIN * 1.5), Magick::CenterGravity)
+        text_renderer.add_to_render_queue(0, 0, x, @graph_bottom + (@label_margin * 1.5), Magick::CenterGravity)
       end
     end
   end
@@ -69,7 +69,7 @@ private
 
   def draw_label(y_offset, index)
     draw_unique_label(index) do
-      draw_label_at(@graph_left - LABEL_MARGIN, 1.0, 0.0, y_offset, @labels[index], gravity: Magick::EastGravity)
+      draw_label_at(@graph_left - @label_margin, 1.0, 0.0, y_offset, @labels[index], gravity: Magick::EastGravity)
     end
   end
 end

data/lib/gruff/net.rb

@@ -112,8 +112,8 @@ private
   def draw_label(center_x, center_y, angle, radius, amount)
     x_offset = center_x # + 15 # The label points need to be tweaked slightly
     y_offset = center_y # + 0  # This one doesn't though
-    x = x_offset + ((radius + LABEL_MARGIN) * Math.sin(deg2rad(angle)))
-    y = y_offset - ((radius + LABEL_MARGIN) * Math.cos(deg2rad(angle)))
+    x = x_offset + ((radius + @label_margin) * Math.sin(deg2rad(angle)))
+    y = y_offset - ((radius + @label_margin) * Math.cos(deg2rad(angle)))
 
     draw_label_at(1.0, 1.0, x, y, amount, gravity: Magick::CenterGravity)
   end

data/lib/gruff/scatter.rb

@@ -188,7 +188,7 @@ private
         label = x_axis_label(marker_label, x_increment)
         x = @graph_left + (increment_x_scaled * index)
         y = @graph_bottom
-        x_offset, y_offset = calculate_label_offset(@marker_font, label, LABEL_MARGIN, @label_rotation)
+        x_offset, y_offset = calculate_label_offset(@marker_font, label, @label_margin, @label_rotation)
 
         draw_label_at(1.0, 1.0, x + x_offset, y + y_offset, label, rotation: @label_rotation)
       end

data/lib/gruff/side_bar.rb

@@ -90,7 +90,7 @@ private
 
       if minimum_value < 0
         _, metrics = Gruff::BarValueLabel.metrics(minimum_value, @label_formatting, proc_text_metrics)
-        width = metrics.width + LABEL_MARGIN
+        width = metrics.width + @label_margin
         @graph_left += width - @graph_left if width > @graph_left
       end
 
@@ -120,7 +120,7 @@ private
         right_y = left_y + (bar_width * @bar_spacing)
 
         bottom_x, top_x = conversion.get_top_bottom_scaled(bar.point).sort
-        if bar.point != 0
+        if bottom_x != top_x
           rect_renderer = Gruff::Renderer::Rectangle.new(renderer, color: bar.color)
           rect_renderer.render(bottom_x + AXIS_MARGIN, left_y, top_x, right_y)
         end
@@ -160,7 +160,7 @@ private
         marker_label = (BigDecimal(diff.abs.to_s) * BigDecimal(increment.to_s)) + BigDecimal(minimum_value.to_s)
         label = x_axis_label(marker_label, @increment)
         text_renderer = Gruff::Renderer::Text.new(renderer, label, font: @marker_font)
-        text_renderer.add_to_render_queue(0, 0, x, @graph_bottom + LABEL_MARGIN, Magick::CenterGravity)
+        text_renderer.add_to_render_queue(0, 0, x, @graph_bottom + @label_margin, Magick::CenterGravity)
       end
     end
   end
@@ -170,7 +170,7 @@ private
 
   def draw_label(y_offset, index)
     draw_unique_label(index) do
-      draw_label_at(@graph_left - LABEL_MARGIN, 1.0, 0.0, y_offset, @labels[index], gravity: Magick::EastGravity)
+      draw_label_at(@graph_left - @label_margin, 1.0, 0.0, y_offset, @labels[index], gravity: Magick::EastGravity)
     end
   end
 

data/lib/gruff/spider.rb

@@ -54,10 +54,10 @@ private
   def setup_graph_measurements
     super
 
-    @graph_left += LABEL_MARGIN
-    @graph_top += LABEL_MARGIN
-    @graph_right -= LABEL_MARGIN
-    @graph_bottom -= LABEL_MARGIN
+    @graph_left += @label_margin
+    @graph_top += @label_margin
+    @graph_right -= @label_margin
+    @graph_bottom -= @label_margin
 
     @graph_width = @graph_right - @graph_left
     @graph_height = @graph_bottom - @graph_top
@@ -94,7 +94,7 @@ private
     degree = rad2deg(angle)
     metrics = text_metrics(@marker_font, amount)
 
-    r_offset = LABEL_MARGIN # The distance out from the center of the pie to get point
+    r_offset = @label_margin # The distance out from the center of the pie to get point
     x_offset = center_x # The label points need to be tweaked slightly
 
     x_offset -= begin

data/lib/gruff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gruff
-  VERSION = '0.21.0'
+  VERSION = '0.23.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gruff
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.23.0
 platform: java
 authors:
 - Geoffrey Grosenbach
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-04 00:00:00.000000000 Z
+date: 2023-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement