gruff 0.19.0-java → 0.20.0-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa39c23fc44be66931c2b7f05ad88021b82a8a900ce7894eb962ddaf9ba895f3
-  data.tar.gz: c1bbf2d54c4ad2760e66352626fc07b7b3f89ee4c8d9edcaa87270c173572c4d
+  metadata.gz: 0470a845dea66723f512a991696cefcec76110bc625720c9de2e06b248968dfb
+  data.tar.gz: d6d93d5ac547d1b588e8b936b8faf1bdbdd86b1f6b05859c62569dcc2096ddf0
 SHA512:
-  metadata.gz: d82e25b5eefc2e5c8ead58a5e3968b5df4952066032d5fa7c80dd69516b726644c76e91d7e136389cc5c0a6899291b2ac6a4a57548116fd8c53ced4bf347d3b8
-  data.tar.gz: 0d9e8d013c78269a606c85fbf3313302dd9048b37c3fd3eeae55894823a1754fc389073aa4381a4598511fbb31bdc1c2d56b565bc1bc2fac922b3a38261540e8
+  metadata.gz: d57209f9c7dc7d3739feea9d1d1cfb41afd85db57d3723a768c17f37413f689becaabba7a119f33a97ed7e4fab7a4906c8a334a8d230cee537fa164d62cd3f01
+  data.tar.gz: 697e7f71c16e5c8d5351144b5cd9fff0bef80a7d9f2dee100dd5e6f90daf712ca041cf8acd581830de8763b697a9c8b66b7b3ddd51df7cd40ece16fac0bc37f7

data/.github/workflows/ci.yml

@@ -18,10 +18,10 @@ jobs:
     - uses: actions/checkout@v3
       with:
         ref: ${{ github.event.pull_request.head.sha }}
-    - name: Set up Ruby 2.5
+    - name: Set up Ruby 2.6
       uses: ruby/setup-ruby@master
       with:
-        ruby-version: '2.5'
+        ruby-version: '2.6'
         bundler-cache: true
     - name: Install dependencies
       run: bundle install --path=vendor/bundle --jobs 4 --retry 3
@@ -35,9 +35,9 @@ jobs:
     timeout-minutes: 20
     strategy:
       matrix:
-        ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1']
+        ruby-version: ['2.6', '2.7', '3.0', '3.1', '3.2']
         imagemagick-version:
-          - { full: 7.1.0-45, major-minor: '7.0' }
+          - { full: 7.1.0-55, major-minor: '7.1' }
     name: Ruby ${{ matrix.ruby-version }}
     steps:
     - uses: actions/checkout@v3
@@ -67,7 +67,7 @@ jobs:
     timeout-minutes: 20
     strategy:
       matrix:
-        ruby-version: ['9.2.21.0', '9.3.7.0']
+        ruby-version: ['9.3.10.0', '9.4.2.0']
     name: JRuby ${{ matrix.ruby-version }}
     steps:
     - uses: actions/checkout@v3

data/.rubocop.yml

@@ -1,10 +1,11 @@
 require:
+  - rubocop-minitest
   - rubocop-performance
   - rubocop-rake
 
 AllCops:
     EnabledByDefault: true
-    TargetRubyVersion: 2.5
+    TargetRubyVersion: 2.6
     Exclude:
         - 'vendor/bundle/**/*'
         - 'rails_generators/gruff/**/*'
@@ -12,6 +13,12 @@ AllCops:
 Metrics:
   Enabled: false
 
+Gemspec/DependencyVersion:
+  Enabled: false
+
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
 Gemspec/OrderedDependencies:
   Enabled: false
 
@@ -21,6 +28,9 @@ Gemspec/RequiredRubyVersion:
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent
 
+Layout/ClassStructure:
+  Enabled: false
+
 Layout/FirstMethodArgumentLineBreak:
   Enabled: false
 
@@ -111,11 +121,17 @@ Style/OptionHash:
 Style/RedundantBegin:
   Enabled: false
 
+Style/RequireOrder:
+  Enabled: false
+
 Style/SingleLineBlockParams:
   Enabled: false
 
 Style/StructInheritance:
   Enabled: false
 
+Style/YodaExpression:
+  Enabled: false
+
 Performance/ChainArrayAllocation:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 0.20.0
+- Fix legend position when blank labels present (#614)
+- Fixed NoMethodError (undefined method `format=' for Gruff::Line (#612)
+- Drop Ruby 2.5 support (#611)
+- Fix deprecation warning for Base#to_blob (#610)
+
 ## 0.19.0
 - Draw the graph starting from zero point by default (#609)
 - Improve joints in Gruff::Net using polyline method (#608)

data/gruff.gemspec

@@ -23,12 +23,13 @@ Gem::Specification.new do |s|
     s.add_dependency 'rmagick4j'
   else
     s.add_dependency 'rmagick', '>= 4.2'
-    s.add_development_dependency 'rubocop', '~> 1.28.2'
-    s.add_development_dependency 'rubocop-performance', '~> 1.13.3'
+    s.add_development_dependency 'rubocop', '~> 1.50.2'
+    s.add_development_dependency 'rubocop-minitest', '~> 0.30.0'
+    s.add_development_dependency 'rubocop-performance', '~> 1.17.1'
     s.add_development_dependency 'rubocop-rake', '~> 0.6.0'
   end
   s.add_dependency 'histogram'
-  s.required_ruby_version = '>= 2.5.0'
+  s.required_ruby_version = '>= 2.6.0'
 
   s.add_development_dependency 'rake'
   s.add_development_dependency 'minitest-reporters'

data/lib/gruff/bar.rb

@@ -48,7 +48,7 @@ class Gruff::Bar < Gruff::Base
   #
   # Default value is +0.9+.
   def spacing_factor=(space_percent)
-    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' unless (space_percent >= 0) && (space_percent <= 1)
+    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' if (space_percent < 0) || (space_percent > 1)
 
     @spacing_factor = (1 - space_percent)
   end

data/lib/gruff/base.rb

@@ -218,7 +218,7 @@ module Gruff
     #   g.labels = ['2005', nil, nil, '2006', nil, nil, '2007', nil, nil, '2008'] # same labels for columns
     def labels=(labels)
       if labels.is_a?(Array)
-        labels = labels.each_with_index.each_with_object({}) do |(label, index), hash|
+        labels = labels.each_with_index.with_object({}) do |(label, index), hash|
           hash[index] = label
         end
       end
@@ -522,9 +522,8 @@ module Gruff
     # @deprecated Please use +to_image.to_blob+ instead.
     def to_blob(image_format = 'PNG')
       warn '#to_blob is deprecated. Please use `to_image.to_blob` instead'
-      to_image.to_blob do
-        self.format = image_format
-      end
+      to_image.format = image_format
+      to_image.to_blob
     end
 
     # Draw a graph.
@@ -822,7 +821,7 @@ module Gruff
     end
 
     def clip_value_if_greater_than(value, max_value)
-      value > max_value ? max_value : value
+      [value, max_value].min
     end
 
     def significant(i)
@@ -908,7 +907,7 @@ module Gruff
       bottom_label_width = extra_left_room_for_long_label
 
       margin = line_number_width + y_axis_label_width
-      @left_margin + (margin > bottom_label_width ? margin : bottom_label_width)
+      @left_margin + [margin, bottom_label_width].max
     end
 
     def setup_right_margin
@@ -1036,7 +1035,7 @@ module Gruff
     def calculate_legend_label_widths_for_each_line(legend_labels, legend_square_width)
       label_widths = [[]]
       label_lines = [[]]
-      legend_labels.each do |label|
+      legend_labels.reject(&:empty?).each do |label|
         width = calculate_width(@legend_font, label)
         label_width = width + (legend_square_width * 2.7)
         label_widths.last.push label_width
@@ -1130,7 +1129,7 @@ module Gruff
           -(width / 2.0)
         end
       end
-      y_offset = (height / 2.0) > margin ? (height / 2.0) : margin
+      y_offset = [(height / 2.0), margin].max
 
       [x_offset, y_offset]
     end

data/lib/gruff/box.rb

@@ -23,7 +23,7 @@ class Gruff::Box < Gruff::Base
   #
   # Default value is +0.8+.
   def spacing_factor=(space_percent)
-    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' unless (space_percent >= 0) && (space_percent <= 1)
+    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' if (space_percent < 0) || (space_percent > 1)
 
     @spacing_factor = (1 - space_percent)
   end
@@ -134,7 +134,7 @@ private
     end
 
     def median
-      if points.size.zero?
+      if points.empty?
         0
       elsif points.size.odd?
         points[points.size / 2]
@@ -144,7 +144,7 @@ private
     end
 
     def first_quartile
-      if points.size.zero?
+      if points.empty?
         0
       elsif points.size.odd?
         points[points.size / 4]
@@ -154,7 +154,7 @@ private
     end
 
     def third_quartile
-      if points.size.zero?
+      if points.empty?
         0
       elsif points.size.odd?
         points[(points.size * 3) / 4]

data/lib/gruff/candlestick.rb

@@ -33,7 +33,7 @@ class Gruff::Candlestick < Gruff::Base
   #
   # Default value is +0.9+.
   def spacing_factor=(space_percent)
-    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' unless (space_percent >= 0) && (space_percent <= 1)
+    raise ArgumentError, 'spacing_factor must be between 0.00 and 1.00' if (space_percent < 0) || (space_percent > 1)
 
     @spacing_factor = (1 - space_percent)
   end
@@ -90,10 +90,10 @@ private
       Gruff::Renderer::Rectangle.new(renderer, color: color, opacity: @fill_opacity, width: @stroke_width).render(left_x, open_y, right_x, close_y)
 
       low_y, = conversion.get_top_bottom_scaled(candlestick.low)
-      y = open_y < close_y ? close_y : open_y
+      y = [open_y, close_y].max
       Gruff::Renderer::Line.new(renderer, color: color, width: @stroke_width).render(center_x, low_y, center_x, y)
       high_y, = conversion.get_top_bottom_scaled(candlestick.high)
-      y = open_y > close_y ? close_y : open_y
+      y = [open_y, close_y].min
       Gruff::Renderer::Line.new(renderer, color: color, width: @stroke_width).render(center_x, y, center_x, high_y)
     end
   end

data/lib/gruff/mini/bar.rb

@@ -12,36 +12,31 @@
 #   g.data :Science, [2, 15, 8, 11]
 #   g.write('mini_bar.png')
 #
-module Gruff
-  module Mini
-    # A class for drawing a small bar graph.
-    class Bar < Gruff::Bar
-    private
+class Gruff::Mini::Bar < Gruff::Bar
+private
 
-      include Gruff::Mini::Legend
+  include Gruff::Mini::Legend
 
-      def initialize_attributes
-        super
+  def initialize_attributes
+    super
 
-        @hide_legend = true
-        @hide_title = true
-        @hide_line_numbers = true
+    @hide_legend = true
+    @hide_title = true
+    @hide_line_numbers = true
 
-        @marker_font.size = 50.0
-        @legend_font.size = 50.0
+    @marker_font.size = 50.0
+    @legend_font.size = 50.0
 
-        @minimum_value = 0.0
-      end
+    @minimum_value = 0.0
+  end
 
-      def setup_data
-        expand_canvas_for_vertical_legend
-        super
-      end
+  def setup_data
+    expand_canvas_for_vertical_legend
+    super
+  end
 
-      def draw_graph
-        super
-        draw_vertical_legend
-      end
-    end
+  def draw_graph
+    super
+    draw_vertical_legend
   end
 end

data/lib/gruff/mini/legend.rb

@@ -1,110 +1,98 @@
 # frozen_string_literal: true
 
-module Gruff
-  module Mini
-    # A module to handle the small legend.
-    # @private
-    module Legend
-      attr_accessor :hide_mini_legend, :legend_position
-
-      def initialize(*)
-        @hide_mini_legend = false
-        @legend_position = nil
-        super
-      end
-
-      ##
-      # The canvas needs to be bigger so we can put the legend beneath it.
-
-      def expand_canvas_for_vertical_legend
-        return if @hide_mini_legend
-
-        @legend_labels = store.data.map(&:label)
-
-        legend_height = scale((store.length * calculate_line_height) + @top_margin + @bottom_margin)
-
-        @original_rows = @raw_rows
-        @original_columns = @raw_columns
-
-        case @legend_position
-        when :right
-          @rows = [@rows, legend_height].max
-          @columns += calculate_legend_width + @left_margin
-        else
-          font = @legend_font.dup
-          font.size = scale(font.size)
-          @rows += store.length * calculate_caps_height(font) * 1.7
-        end
-
-        @renderer = Gruff::Renderer.new(@columns, @rows, @scale, @theme_options)
-      end
-
-      def calculate_line_height
-        calculate_caps_height(@legend_font) * 1.7
-      end
-
-      def calculate_legend_width
-        width = @legend_labels.map { |label| calculate_width(@legend_font, label) }.max
-        scale(width + (40 * 1.7))
-      end
-
-      ##
-      # Draw the legend beneath the existing graph.
-
-      def draw_vertical_legend
-        return if @hide_mini_legend
-
-        legend_square_width = 40.0 # small square with color of this item
-        @legend_left_margin = 100.0
-        legend_top_margin = 40.0
-
-        case @legend_position
-        when :right
-          current_x_offset = @original_columns + @left_margin
-          current_y_offset = @top_margin + legend_top_margin
-        else
-          current_x_offset = @legend_left_margin
-          current_y_offset = @original_rows + legend_top_margin
-        end
-
-        @legend_labels.each_with_index do |legend_label, index|
-          # Draw label
-          x_offset = current_x_offset + (legend_square_width * 1.7)
-          label = truncate_legend_label(legend_label, x_offset)
-          text_renderer = Gruff::Renderer::Text.new(renderer, label, font: @legend_font)
-          text_renderer.add_to_render_queue(@raw_columns, 1.0, x_offset, current_y_offset, Magick::WestGravity)
-
-          # Now draw box with color of this dataset
-          rect_renderer = Gruff::Renderer::Rectangle.new(renderer, color: store.data[index].color)
-          rect_renderer.render(current_x_offset,
-                               current_y_offset - (legend_square_width / 2.0),
-                               current_x_offset + legend_square_width,
-                               current_y_offset + (legend_square_width / 2.0))
-
-          current_y_offset += calculate_line_height
-        end
-      end
-
-      ##
-      # Shorten long labels so they will fit on the canvas.
-      #
-      #   Department of Hu...
-
-      def truncate_legend_label(label, x_offset)
-        truncated_label = label.to_s
-
-        font = @legend_font.dup
-        font.size = scale(font.size)
-        max_width = @columns - scale(x_offset) - @right_margin
-        while calculate_width(font, "#{truncated_label}...") > max_width && truncated_label.length > 1
-          truncated_label = truncated_label[0..truncated_label.length - 2]
-        end
-        truncated_label + (truncated_label.length < label.to_s.length ? '...' : '')
-      end
-
-      def scale(value)
-        value * @scale
-      end
+# A module to handle the small legend.
+# @private
+module Gruff::Mini::Legend
+  attr_accessor :hide_mini_legend, :legend_position
+
+  def initialize(*)
+    @hide_mini_legend = false
+    @legend_position = nil
+    super
+  end
+
+  # The canvas needs to be bigger so we can put the legend beneath it.
+  def expand_canvas_for_vertical_legend
+    return if @hide_mini_legend
+
+    @legend_labels = store.data.map(&:label)
+
+    legend_height = scale((store.length * calculate_line_height) + @top_margin + @bottom_margin)
+
+    @original_rows = @raw_rows
+    @original_columns = @raw_columns
+
+    case @legend_position
+    when :right
+      @rows = [@rows, legend_height].max
+      @columns += calculate_legend_width + @left_margin
+    else
+      font = @legend_font.dup
+      font.size = scale(font.size)
+      @rows += store.length * calculate_caps_height(font) * 1.7
+    end
+
+    @renderer = Gruff::Renderer.new(@columns, @rows, @scale, @theme_options)
+  end
+
+  def calculate_line_height
+    calculate_caps_height(@legend_font) * 1.7
+  end
+
+  def calculate_legend_width
+    width = @legend_labels.map { |label| calculate_width(@legend_font, label) }.max
+    scale(width + (40 * 1.7))
+  end
+
+  # Draw the legend beneath the existing graph.
+  def draw_vertical_legend
+    return if @hide_mini_legend
+
+    legend_square_width = 40.0 # small square with color of this item
+    @legend_left_margin = 100.0
+    legend_top_margin = 40.0
+
+    case @legend_position
+    when :right
+      current_x_offset = @original_columns + @left_margin
+      current_y_offset = @top_margin + legend_top_margin
+    else
+      current_x_offset = @legend_left_margin
+      current_y_offset = @original_rows + legend_top_margin
     end
+
+    @legend_labels.each_with_index do |legend_label, index|
+      # Draw label
+      x_offset = current_x_offset + (legend_square_width * 1.7)
+      label = truncate_legend_label(legend_label, x_offset)
+      text_renderer = Gruff::Renderer::Text.new(renderer, label, font: @legend_font)
+      text_renderer.add_to_render_queue(@raw_columns, 1.0, x_offset, current_y_offset, Magick::WestGravity)
+
+      # Now draw box with color of this dataset
+      rect_renderer = Gruff::Renderer::Rectangle.new(renderer, color: store.data[index].color)
+      rect_renderer.render(current_x_offset,
+                           current_y_offset - (legend_square_width / 2.0),
+                           current_x_offset + legend_square_width,
+                           current_y_offset + (legend_square_width / 2.0))
+
+      current_y_offset += calculate_line_height
+    end
+  end
+
+  # Shorten long labels so they will fit on the canvas.
+  def truncate_legend_label(label, x_offset)
+    truncated_label = label.to_s
+
+    font = @legend_font.dup
+    font.size = scale(font.size)
+    max_width = @columns - scale(x_offset) - @right_margin
+    while calculate_width(font, "#{truncated_label}...") > max_width && truncated_label.length > 1
+      truncated_label = truncated_label[0..truncated_label.length - 2]
+    end
+    truncated_label + (truncated_label.length < label.to_s.length ? '...' : '')
+  end
+
+  def scale(value)
+    value * @scale
   end
 end

data/lib/gruff/mini/pie.rb

@@ -11,34 +11,29 @@
 #   g.data 'Hamburgers', 50
 #   g.write("mini_pie_keynote.png")
 #
-module Gruff
-  module Mini
-    # A class for drawing a small pie graph.
-    class Pie < Gruff::Pie
-    private
+class Gruff::Mini::Pie < Gruff::Pie
+private
 
-      include Gruff::Mini::Legend
+  include Gruff::Mini::Legend
 
-      def initialize_attributes
-        super
+  def initialize_attributes
+    super
 
-        @hide_legend = true
-        @hide_title = true
-        @hide_line_numbers = true
+    @hide_legend = true
+    @hide_title = true
+    @hide_line_numbers = true
 
-        @marker_font.size = 50.0
-        @legend_font.size = 50.0
-      end
+    @marker_font.size = 50.0
+    @legend_font.size = 50.0
+  end
 
-      def setup_data
-        expand_canvas_for_vertical_legend
-        super
-      end
+  def setup_data
+    expand_canvas_for_vertical_legend
+    super
+  end
 
-      def draw_graph
-        super
-        draw_vertical_legend
-      end
-    end
+  def draw_graph
+    super
+    draw_vertical_legend
   end
 end

data/lib/gruff/mini/side_bar.rb

@@ -19,33 +19,28 @@
 #   g.data :Science, [2, 15, 8, 11]
 #   g.write('mini_sidebar.png')
 #
-module Gruff
-  module Mini
-    # A class for drawing a small side bar graph.
-    class SideBar < Gruff::SideBar
-    private
+class Gruff::Mini::SideBar < Gruff::SideBar
+private
 
-      include Gruff::Mini::Legend
+  include Gruff::Mini::Legend
 
-      def initialize_attributes
-        super
-        @hide_legend = true
-        @hide_title = true
-        @hide_line_numbers = true
+  def initialize_attributes
+    super
+    @hide_legend = true
+    @hide_title = true
+    @hide_line_numbers = true
 
-        @marker_font.size = 50.0
-        @legend_font.size = 50.0
-      end
+    @marker_font.size = 50.0
+    @legend_font.size = 50.0
+  end
 
-      def setup_data
-        expand_canvas_for_vertical_legend
-        super
-      end
+  def setup_data
+    expand_canvas_for_vertical_legend
+    super
+  end
 
-      def draw_graph
-        super
-        draw_vertical_legend
-      end
-    end
+  def draw_graph
+    super
+    draw_vertical_legend
   end
 end

data/lib/gruff/patch/rmagick.rb

@@ -7,8 +7,8 @@ module Magick
     refine Draw do
       # Additional method to scale annotation text since Draw.scale doesn't.
       def annotate_scaled(img, width, height, x, y, text, scale)
-        scaled_width = (width * scale) >= 1 ? (width * scale) : 1
-        scaled_height = (height * scale) >= 1 ? (height * scale) : 1
+        scaled_width = [(width * scale), 1].max
+        scaled_height = [(height * scale), 1].max
 
         annotate(img,
                  scaled_width, scaled_height,

data/lib/gruff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gruff
-  VERSION = '0.19.0'
+  VERSION = '0.20.0'
 end

data/lib/gruff.rb

@@ -45,6 +45,7 @@ module Gruff
   autoload :Layer, Gruff.libpath('scene')
   autoload :Themes, Gruff.libpath('themes')
 
+  # @private
   class Renderer
     autoload :Bezier, Gruff.libpath('renderer/bezier')
     autoload :Circle, Gruff.libpath('renderer/circle')
@@ -58,12 +59,14 @@ module Gruff
     autoload :Text, Gruff.libpath('renderer/text')
   end
 
+  # @private
   class Store
     autoload :BasicData, Gruff.libpath('store/basic_data')
     autoload :XYData, Gruff.libpath('store/xy_data')
     autoload :XYPointsizeData, Gruff.libpath('store/xy_pointsizes_data')
   end
 
+  # A module for small graphs
   module Mini
     autoload :Bar, Gruff.libpath('mini/bar')
     autoload :Legend, Gruff.libpath('mini/legend')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gruff
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.20.0
 platform: java
 authors:
 - Geoffrey Grosenbach
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-21 00:00:00.000000000 Z
+date: 2023-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -183,14 +183,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.29
+rubygems_version: 3.3.25
 signing_key:
 specification_version: 4
 summary: Beautiful graphs for one or multiple datasets.