gruff 0.12.1 → 0.12.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2c91b51c13f0a433ce00a02ab66606bea2c0bb091391c47f68c2ba4ba1e0866
-  data.tar.gz: 229c79b85d56aeb4607aa74e90a1c1ce23f355c744fff97709fcd7804bd6dae1
+  metadata.gz: ea00c2968e40f335c5505b4ce5461fb9b5ec6488bfe48293829848fd2c57e2fc
+  data.tar.gz: 860569d2e37c2b14aee89671d2bd4e76b409221a8e54712008009000c054a144
 SHA512:
-  metadata.gz: 98eb0019308fa0bfdd33d500c90dd03f1da45e59b6f7ce62d3f175565f179723d1d189ca2df38c00e8d4890fa427d9edf42e89d368e4522dee835449a8352f3a
-  data.tar.gz: aa3ff8ca53dc5853a21f2d12ad4bd7f050596634f63287d53f4832fcfc3035859c9b44b59bfd95cc91d58969761b66ad685c660bdbc8ac58d115cb4fb3abbdfc
+  metadata.gz: ec50aef23be4941687dc0822b02aec8daf083f1986f50054cae56562937c1788c4e6ff4f03bff6689732b3e88787fbbf42ea3bc6324d89f4b47dddfed23bbcb3
+  data.tar.gz: 87d063e7f87081ad123e47610d173dc62e4f3c6200887021af40d389b39892b20b34d73757989eae383447308e34598198e47af33a48d1a184738c4a275361b9

data/.rubocop_todo.yml

@@ -1,11 +1,25 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-10-17 05:39:30 UTC using RuboCop version 0.93.1.
+# on 2021-03-07 06:12:58 UTC using RuboCop version 1.11.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/DateAssignment:
+  Exclude:
+    - 'gruff.gemspec'
+
+# Offense count: 1
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
+  Exclude:
+    - 'test/gruff_test_case.rb'
+
 # Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
@@ -36,13 +50,13 @@ Lint/Void:
     - 'lib/gruff/patch/rmagick.rb'
 
 # Offense count: 54
-# Configuration parameters: IgnoredMethods.
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 82
 
 # Offense count: 1
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
 Metrics/BlockLength:
   Max: 29
 
@@ -57,12 +71,12 @@ Metrics/CyclomaticComplexity:
   Max: 21
 
 # Offense count: 121
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 81
 
 # Offense count: 3
-# Configuration parameters: CountKeywordArgs.
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 7
 
@@ -88,6 +102,16 @@ Naming/MethodParameterName:
     - 'lib/gruff/pie.rb'
     - 'lib/gruff/renderer/text.rb'
 
+# Offense count: 6
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
+Naming/VariableNumber:
+  Exclude:
+    - 'test/test_bar.rb'
+    - 'test/test_bezier.rb'
+    - 'test/test_line.rb'
+
 # Offense count: 1
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
@@ -122,12 +146,18 @@ Style/CombinableLoops:
   Exclude:
     - 'test/test_line.rb'
 
+# Offense count: 3
+Style/DocumentDynamicEvalDefinition:
+  Exclude:
+    - 'test/gruff_test_case.rb'
+
 # Offense count: 132
 # Configuration parameters: RequireForNonPublicMethods.
 Style/DocumentationMethod:
   Enabled: false
 
 # Offense count: 3
+# Cop supports --auto-correct.
 Style/EvalWithLocation:
   Exclude:
     - 'test/gruff_test_case.rb'
@@ -151,3 +181,10 @@ Style/StringConcatenation:
     - 'lib/gruff/photo_bar.rb'
     - 'test/gruff_test_case.rb'
 
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: forbid_mixed_logical_operators, forbid_logical_operators
+Style/UnlessLogicalOperators:
+  Exclude:
+    - 'lib/gruff/bar.rb'
+    - 'lib/gruff/scatter.rb'

data/.travis.yml

@@ -7,7 +7,8 @@ rvm:
   - 2.5
   - 2.6
   - 2.7
-  - jruby-9.2.13.0
+  - 3.0
+  - jruby-9.2.14.0
 
 jobs:
   include:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change Log
 
+## 0.12.2
+- Avoid SEGV caused with '%S' in Draw#get_type_metrics by old ImageMagick (6.9.9 or below)  (#490)
+
 ## 0.12.0
 - Mark Gruff::Base#to_blob as deprecated (#473)
 - Add Gruff::Base#to_image method (#472)

data/gruff.gemspec

@@ -29,8 +29,8 @@ Gem::Specification.new do |s|
     s.add_dependency 'rmagick4j'
   else
     s.add_dependency 'rmagick'
-    s.add_development_dependency 'rubocop', '~> 1.0.0'
-    s.add_development_dependency 'rubocop-performance', '~> 1.8'
+    s.add_development_dependency 'rubocop', '~> 1.11.0'
+    s.add_development_dependency 'rubocop-performance', '~> 1.10.1'
   end
   s.add_dependency 'histogram'
   s.required_ruby_version = '>= 2.4.0'

data/lib/gruff/pie.rb

@@ -77,7 +77,7 @@ private
 
       slices.sort_by(&:value) if @sort
 
-      total = slices.map(&:value).sum.to_f
+      total = slices.sum(&:value).to_f
       slices.each { |slice| slice.total = total }
     end
   end

data/lib/gruff/renderer/text.rb

@@ -51,7 +51,14 @@ module Gruff
 
       draw.font_weight = font_weight
       draw.pointsize = size
-      draw.get_type_metrics(image, text.to_s)
+
+      # The old ImageMagick causes SEGV with string which has '%' + alphabet (eg. '%S').
+      # This format is used to embed value into a string using image properties.
+      # However, gruff use plain image as canvas which does not have any property.
+      # So, in here, it just escape % in order to avoid SEGV.
+      text = text.to_s.gsub(/(%+)/) { ('%' * Regexp.last_match(1).size * 2).to_s }
+
+      draw.get_type_metrics(image, text)
     end
   end
 end

data/lib/gruff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gruff
-  VERSION = '0.12.1'
+  VERSION = '0.12.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gruff
 version: !ruby/object:Gem::Version
-  version: 0.12.1
+  version: 0.12.2
 platform: ruby
 authors:
 - Geoffrey Grosenbach
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-31 00:00:00.000000000 Z
+date: 2021-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rmagick
@@ -31,28 +31,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.11.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 1.10.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 1.10.1
 - !ruby/object:Gem::Dependency
   name: histogram
   requirement: !ruby/object:Gem::Requirement