grpc 1.76.0 → 1.78.0.pre1

data/src/core/call/filter_fusion.h

@@ -23,10 +23,6 @@
 #include <type_traits>
 #include <utility>
 
-#include "absl/log/log.h"
-#include "absl/memory/memory.h"
-#include "absl/status/status.h"
-#include "absl/strings/str_join.h"
 #include "src/core/call/call_filters.h"
 #include "src/core/call/metadata.h"
 #include "src/core/lib/channel/channel_args.h"
@@ -38,6 +34,10 @@
 #include "src/core/util/manual_constructor.h"
 #include "src/core/util/status_helper.h"
 #include "src/core/util/type_list.h"
+#include "absl/log/log.h"
+#include "absl/memory/memory.h"
+#include "absl/status/status.h"
+#include "absl/strings/str_join.h"
 
 struct grpc_transport_op;
 

data/src/core/call/interception_chain.h

@@ -24,6 +24,7 @@
 #include "src/core/call/call_filters.h"
 #include "src/core/call/call_spine.h"
 #include "src/core/call/metadata.h"
+#include "src/core/filter/filter_args.h"
 #include "src/core/util/ref_counted.h"
 
 namespace grpc_core {
@@ -171,10 +172,10 @@ class InterceptionChainBuilder final {
   // call_filters.h.
   template <typename T>
   absl::enable_if_t<sizeof(typename T::Call) != 0, InterceptionChainBuilder&>
-  Add() {
+  Add(RefCountedPtr<const FilterConfig> config) {
     if (!status_.ok()) return *this;
-    auto filter =
-        T::Create(args_, {FilterInstanceId(FilterTypeId<T>()), blackboard_});
+    auto filter = T::Create(args_, {FilterInstanceId(FilterTypeId<T>()),
+                                    std::move(config), blackboard_});
     if (!filter.ok()) {
       status_ = filter.status();
       return *this;
@@ -189,9 +190,9 @@ class InterceptionChainBuilder final {
   template <typename T>
   absl::enable_if_t<std::is_base_of<Interceptor, T>::value,
                     InterceptionChainBuilder&>
-  Add() {
-    AddInterceptor(
-        T::Create(args_, {FilterInstanceId(FilterTypeId<T>()), blackboard_}));
+  Add(RefCountedPtr<const FilterConfig> config) {
+    AddInterceptor(T::Create(args_, {FilterInstanceId(FilterTypeId<T>()),
+                                     std::move(config), blackboard_}));
     return *this;
   };
 

data/src/core/call/metadata_batch.cc

@@ -20,15 +20,60 @@
 #include <algorithm>
 #include <string>
 
-#include "absl/base/no_destructor.h"
-#include "absl/container/flat_hash_set.h"
+#include "src/core/lib/transport/timeout_encoding.h"
 #include "absl/strings/escaping.h"
 #include "absl/strings/match.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "src/core/lib/transport/timeout_encoding.h"
 
 namespace grpc_core {
+
+bool IsMetadataKeyAllowedInDebugOutput(absl::string_view key) {
+  // We have intentionally not allowed for any way to add to the allow list at
+  // run time, (using a flag or some other setting) because such workarounds
+  // may lead to security issues.
+  // go/keep-sorted start
+  if (key == ContentTypeMetadata::key()) return true;
+  if (key == EndpointLoadMetricsBinMetadata::key()) return true;
+  if (key == GrpcAcceptEncodingMetadata::key()) return true;
+  if (key == GrpcEncodingMetadata::key()) return true;
+  if (key == GrpcInternalEncodingRequest::key()) return true;
+  if (key == GrpcLbClientStatsMetadata::key()) return true;
+  if (key == GrpcMessageMetadata::key()) return true;
+  if (key == GrpcPreviousRpcAttemptsMetadata::key()) return true;
+  if (key == GrpcRetryPushbackMsMetadata::key()) return true;
+  if (key == GrpcServerStatsBinMetadata::key()) return true;
+  if (key == GrpcStatusMetadata::key()) return true;
+  if (key == GrpcTagsBinMetadata::key()) return true;
+  if (key == GrpcTimeoutMetadata::key()) return true;
+  if (key == GrpcTraceBinMetadata::key()) return true;
+  if (key == HostMetadata::key()) return true;
+  if (key == HttpAuthorityMetadata::key()) return true;
+  if (key == HttpMethodMetadata::key()) return true;
+  if (key == HttpPathMetadata::key()) return true;
+  if (key == HttpSchemeMetadata::key()) return true;
+  if (key == HttpStatusMetadata::key()) return true;
+  if (key == LbCostBinMetadata::key()) return true;
+  if (key == LbTokenMetadata::key()) return true;
+  if (key == TeMetadata::key()) return true;
+  if (key == UserAgentMetadata::key()) return true;
+  if (key == W3CTraceParentMetadata::key()) return true;
+  if (key == XEnvoyPeerMetadata::key()) return true;
+  // go/keep-sorted end
+  // go/keep-sorted start
+  if (key == GrpcCallWasCancelled::DebugKey()) return true;
+  if (key == GrpcRegisteredMethod::DebugKey()) return true;
+  if (key == GrpcStatusContext::DebugKey()) return true;
+  if (key == GrpcStatusFromWire::DebugKey()) return true;
+  if (key == GrpcStreamNetworkState::DebugKey()) return true;
+  if (key == GrpcTarPit::DebugKey()) return true;
+  if (key == GrpcTrailersOnly::DebugKey()) return true;
+  if (key == PeerString::DebugKey()) return true;
+  if (key == WaitForReady::DebugKey()) return true;
+  // go/keep-sorted end
+  return false;
+}
+
 namespace metadata_detail {
 
 void DebugStringBuilder::Add(absl::string_view key, absl::string_view value) {
@@ -38,7 +83,7 @@ void DebugStringBuilder::Add(absl::string_view key, absl::string_view value) {
 
 void DebugStringBuilder::AddAfterRedaction(absl::string_view key,
                                            absl::string_view value) {
-  if (IsAllowListed(key)) {
+  if (IsMetadataKeyAllowedInDebugOutput(key)) {
     Add(key, value);
   } else {
     // If the type of metadata is not in the allow list, we want to prevent it
@@ -51,57 +96,6 @@ void DebugStringBuilder::AddAfterRedaction(absl::string_view key,
   }
 }
 
-bool DebugStringBuilder::IsAllowListed(const absl::string_view key) const {
-  // We have intentionally not allowed for any way to add to the allow list at
-  // run time, (using a flag or some other setting) because such workarounds
-  // may lead to security issues.
-  static const absl::NoDestructor<absl::flat_hash_set<std::string>> allow_list(
-      [] {
-        absl::flat_hash_set<std::string> allow_list;
-        // go/keep-sorted start
-        allow_list.insert(std::string(ContentTypeMetadata::key()));
-        allow_list.insert(std::string(EndpointLoadMetricsBinMetadata::key()));
-        allow_list.insert(std::string(GrpcAcceptEncodingMetadata::key()));
-        allow_list.insert(std::string(GrpcEncodingMetadata::key()));
-        allow_list.insert(std::string(GrpcInternalEncodingRequest::key()));
-        allow_list.insert(std::string(GrpcLbClientStatsMetadata::key()));
-        allow_list.insert(std::string(GrpcMessageMetadata::key()));
-        allow_list.insert(std::string(GrpcPreviousRpcAttemptsMetadata::key()));
-        allow_list.insert(std::string(GrpcRetryPushbackMsMetadata::key()));
-        allow_list.insert(std::string(GrpcServerStatsBinMetadata::key()));
-        allow_list.insert(std::string(GrpcStatusMetadata::key()));
-        allow_list.insert(std::string(GrpcTagsBinMetadata::key()));
-        allow_list.insert(std::string(GrpcTimeoutMetadata::key()));
-        allow_list.insert(std::string(GrpcTraceBinMetadata::key()));
-        allow_list.insert(std::string(HostMetadata::key()));
-        allow_list.insert(std::string(HttpAuthorityMetadata::key()));
-        allow_list.insert(std::string(HttpMethodMetadata::key()));
-        allow_list.insert(std::string(HttpPathMetadata::key()));
-        allow_list.insert(std::string(HttpSchemeMetadata::key()));
-        allow_list.insert(std::string(HttpStatusMetadata::key()));
-        allow_list.insert(std::string(LbCostBinMetadata::key()));
-        allow_list.insert(std::string(LbTokenMetadata::key()));
-        allow_list.insert(std::string(TeMetadata::key()));
-        allow_list.insert(std::string(UserAgentMetadata::key()));
-        allow_list.insert(std::string(W3CTraceParentMetadata::key()));
-        allow_list.insert(std::string(XEnvoyPeerMetadata::key()));
-        // go/keep-sorted end
-        // go/keep-sorted start
-        allow_list.insert(std::string(GrpcCallWasCancelled::DebugKey()));
-        allow_list.insert(std::string(GrpcRegisteredMethod::DebugKey()));
-        allow_list.insert(std::string(GrpcStatusContext::DebugKey()));
-        allow_list.insert(std::string(GrpcStatusFromWire::DebugKey()));
-        allow_list.insert(std::string(GrpcStreamNetworkState::DebugKey()));
-        allow_list.insert(std::string(GrpcTarPit::DebugKey()));
-        allow_list.insert(std::string(GrpcTrailersOnly::DebugKey()));
-        allow_list.insert(std::string(PeerString::DebugKey()));
-        allow_list.insert(std::string(WaitForReady::DebugKey()));
-        // go/keep-sorted end
-        return allow_list;
-      }());
-  return allow_list->contains(key);
-}
-
 void UnknownMap::Append(absl::string_view key, Slice value) {
   unknown_.emplace_back(Slice::FromCopiedString(key), value.Ref());
 }

data/src/core/call/metadata_batch.h

@@ -30,11 +30,6 @@
 #include <type_traits>
 #include <utility>
 
-#include "absl/container/inlined_vector.h"
-#include "absl/functional/function_ref.h"
-#include "absl/meta/type_traits.h"
-#include "absl/strings/numbers.h"
-#include "absl/strings/string_view.h"
 #include "src/core/call/custom_metadata.h"
 #include "src/core/call/metadata_compression_traits.h"
 #include "src/core/call/parsed_metadata.h"
@@ -49,6 +44,11 @@
 #include "src/core/util/packed_table.h"
 #include "src/core/util/time.h"
 #include "src/core/util/type_list.h"
+#include "absl/container/inlined_vector.h"
+#include "absl/functional/function_ref.h"
+#include "absl/meta/type_traits.h"
+#include "absl/strings/numbers.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 
@@ -630,6 +630,8 @@ struct GrpcTarPit {
   static absl::string_view DisplayValue(Empty) { return "tarpit"; }
 };
 
+bool IsMetadataKeyAllowedInDebugOutput(absl::string_view key);
+
 namespace metadata_detail {
 
 // Build a key/value formatted debug string.
@@ -646,7 +648,6 @@ class DebugStringBuilder {
   std::string TakeOutput() { return std::move(out_); }
 
  private:
-  bool IsAllowListed(absl::string_view key) const;
   void Add(absl::string_view key, absl::string_view value);
   std::string out_;
 };

data/src/core/call/metadata_info.cc

@@ -19,8 +19,8 @@
 #include <cstddef>
 #include <string>
 
-#include "absl/strings/str_cat.h"
 #include "src/core/lib/slice/slice.h"
+#include "absl/strings/str_cat.h"
 
 namespace grpc_core {
 

data/src/core/call/parsed_metadata.h

@@ -24,14 +24,14 @@
 #include <type_traits>
 #include <utility>
 
+#include "src/core/lib/slice/slice.h"
+#include "src/core/util/time.h"
 #include "absl/functional/function_ref.h"
 #include "absl/meta/type_traits.h"
 #include "absl/strings/escaping.h"
 #include "absl/strings/match.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/string_view.h"
-#include "src/core/lib/slice/slice.h"
-#include "src/core/util/time.h"
 
 namespace grpc_core {
 

data/src/core/call/request_buffer.cc

@@ -17,8 +17,8 @@
 #include <cstdint>
 #include <optional>
 
-#include "absl/strings/str_cat.h"
 #include "src/core/util/match.h"
+#include "absl/strings/str_cat.h"
 
 namespace grpc_core {
 

data/src/core/call/security_context.cc

@@ -25,7 +25,6 @@
 
 #include <algorithm>
 
-#include "absl/log/log.h"
 #include "src/core/credentials/call/call_credentials.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/debug/trace.h"
@@ -34,6 +33,7 @@
 #include "src/core/lib/surface/call.h"
 #include "src/core/util/grpc_check.h"
 #include "src/core/util/ref_counted_ptr.h"
+#include "absl/log/log.h"
 
 // --- grpc_call ---
 

data/src/core/call/security_context.h

@@ -27,7 +27,6 @@
 #include <memory>
 #include <utility>
 
-#include "absl/strings/string_view.h"
 #include "src/core/credentials/call/call_credentials.h"  // IWYU pragma: keep
 #include "src/core/lib/debug/trace.h"
 #include "src/core/lib/resource_quota/arena.h"
@@ -38,6 +37,7 @@
 #include "src/core/util/ref_counted.h"
 #include "src/core/util/ref_counted_ptr.h"
 #include "src/core/util/useful.h"
+#include "absl/strings/string_view.h"
 
 // --- grpc_security_context_extension ---
 

data/src/core/call/server_call.cc

@@ -37,7 +37,6 @@
 #include <string>
 #include <utility>
 
-#include "absl/strings/string_view.h"
 #include "src/core/call/metadata.h"
 #include "src/core/call/metadata_batch.h"
 #include "src/core/lib/promise/all_ok.h"
@@ -52,6 +51,7 @@
 #include "src/core/util/bitset.h"
 #include "src/core/util/grpc_check.h"
 #include "src/core/util/latent_see.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 

data/src/core/call/server_call.h

@@ -39,9 +39,6 @@
 #include <string>
 #include <utility>
 
-#include "absl/status/status.h"
-#include "absl/strings/str_format.h"
-#include "absl/strings/string_view.h"
 #include "src/core/call/metadata.h"
 #include "src/core/call/metadata_batch.h"
 #include "src/core/lib/promise/poll.h"
@@ -55,6 +52,9 @@
 #include "src/core/util/grpc_check.h"
 #include "src/core/util/ref_counted.h"
 #include "src/core/util/ref_counted_ptr.h"
+#include "absl/status/status.h"
+#include "absl/strings/str_format.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 
@@ -72,6 +72,7 @@ class ServerCall final : public Call, public DualRefCounted<ServerCall> {
         cq_(cq),
         server_(server) {
     global_stats().IncrementServerCallsCreated();
+    SourceConstructed();
   }
 
   void CancelWithError(grpc_error_handle error) override {
@@ -97,6 +98,7 @@ class ServerCall final : public Call, public DualRefCounted<ServerCall> {
   void InternalUnref(const char*) override { WeakUnref(); }
 
   void Orphaned() override {
+    SourceDestructing();
     if (!saw_was_cancelled_.load(std::memory_order_relaxed)) {
       CancelWithError(absl::CancelledError());
     }

data/src/core/call/simple_slice_based_metadata.h

@@ -17,9 +17,9 @@
 
 #include <grpc/support/port_platform.h>
 
-#include "absl/strings/string_view.h"
 #include "src/core/call/parsed_metadata.h"
 #include "src/core/lib/slice/slice.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 

data/src/core/call/status_util.cc

@@ -23,9 +23,9 @@
 
 #include <vector>
 
+#include "src/core/util/useful.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_join.h"
-#include "src/core/util/useful.h"
 
 struct status_string_entry {
   const char* str;

data/src/core/channelz/channel_trace.cc

@@ -26,7 +26,6 @@
 #include <memory>
 #include <utility>
 
-#include "absl/strings/str_cat.h"
 #include "google/protobuf/any.upb.h"
 #include "src/core/channelz/channelz.h"
 #include "src/core/lib/slice/slice.h"
@@ -38,6 +37,7 @@
 #include "src/core/util/upb_utils.h"
 #include "src/proto/grpc/channelz/v2/channelz.upb.h"
 #include "upb/base/string_view.h"
+#include "absl/strings/str_cat.h"
 
 namespace grpc_core {
 namespace channelz {

data/src/core/channelz/channel_trace.h

@@ -31,9 +31,6 @@
 #include <tuple>
 #include <type_traits>
 
-#include "absl/base/thread_annotations.h"
-#include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 #include "src/core/lib/debug/trace_flags.h"
 #include "src/core/util/json/json.h"
 #include "src/core/util/memory_usage.h"
@@ -41,6 +38,9 @@
 #include "src/core/util/sync.h"
 #include "src/core/util/time.h"
 #include "src/proto/grpc/channelz/v2/channelz.upb.h"
+#include "absl/base/thread_annotations.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 namespace channelz {

data/src/core/channelz/channelz.cc

@@ -30,12 +30,6 @@
 #include <string>
 #include <tuple>
 
-#include "absl/cleanup/cleanup.h"
-#include "absl/log/check.h"
-#include "absl/status/statusor.h"
-#include "absl/strings/escaping.h"
-#include "absl/strings/str_cat.h"
-#include "absl/strings/strip.h"
 #include "src/core/channelz/channelz_registry.h"
 #include "src/core/channelz/property_list.h"
 #include "src/core/lib/address_utils/parse_address.h"
@@ -52,6 +46,12 @@
 #include "src/core/util/uri.h"
 #include "src/core/util/useful.h"
 #include "src/proto/grpc/channelz/v2/channelz.upb.h"
+#include "absl/cleanup/cleanup.h"
+#include "absl/log/check.h"
+#include "absl/status/statusor.h"
+#include "absl/strings/escaping.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/strip.h"
 
 namespace grpc_core {
 namespace channelz {
@@ -177,13 +177,15 @@ void BaseNode::SerializeEntity(grpc_channelz_v2_Entity* entity,
   grpc_channelz_v2_Entity_set_id(entity, uuid());
   grpc_channelz_v2_Entity_set_kind(
       entity, StdStringToUpbString(EntityTypeToKind(type_)));
+  std::vector<WeakRefCountedPtr<BaseNode>> parent_nodes;
   {
     MutexLock lock(&parent_mu_);
-    auto* parents =
-        grpc_channelz_v2_Entity_resize_parents(entity, parents_.size(), arena);
-    for (const auto& parent : parents_) {
-      *parents++ = parent->uuid();
-    }
+    parent_nodes.assign(parents_.begin(), parents_.end());
+  }
+  auto* parents = grpc_channelz_v2_Entity_resize_parents(
+      entity, parent_nodes.size(), arena);
+  for (const auto& parent : parent_nodes) {
+    *parents++ = parent->uuid();
   }
   grpc_channelz_v2_Entity_set_orphaned(entity, orphaned_index_ != 0);
 

data/src/core/channelz/channelz.h

@@ -35,10 +35,6 @@
 #include <type_traits>
 #include <utility>
 
-#include "absl/base/thread_annotations.h"
-#include "absl/container/flat_hash_set.h"
-#include "absl/container/inlined_vector.h"
-#include "absl/strings/string_view.h"
 #include "src/core/channelz/channel_trace.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/util/dual_ref_counted.h"
@@ -53,6 +49,10 @@
 #include "src/core/util/useful.h"
 #include "src/proto/grpc/channelz/v2/channelz.upb.h"
 #include "src/proto/grpc/channelz/v2/service.upb.h"
+#include "absl/base/thread_annotations.h"
+#include "absl/container/flat_hash_set.h"
+#include "absl/container/inlined_vector.h"
+#include "absl/strings/string_view.h"
 
 // Channel arg key for channelz node.
 #define GRPC_ARG_CHANNELZ_CHANNEL_NODE \
@@ -130,6 +130,8 @@ class BaseNode : public DualRefCounted<BaseNode> {
     kSocket,
     kCall,
     kResourceQuota,
+    kMetricsDomain,
+    kMetricsDomainStorage,
   };
 
   static absl::string_view EntityTypeString(EntityType type) {
@@ -150,6 +152,10 @@ class BaseNode : public DualRefCounted<BaseNode> {
         return "call";
       case EntityType::kResourceQuota:
         return "resource_quota";
+      case EntityType::kMetricsDomain:
+        return "metrics_domain";
+      case EntityType::kMetricsDomainStorage:
+        return "metrics_domain_storage";
     }
     return "unknown";
   }
@@ -172,6 +178,10 @@ class BaseNode : public DualRefCounted<BaseNode> {
         return "call";
       case EntityType::kResourceQuota:
         return "resource_quota";
+      case EntityType::kMetricsDomain:
+        return "metrics_domain";
+      case EntityType::kMetricsDomainStorage:
+        return "metrics_domain_storage";
     }
   }
 
@@ -184,6 +194,10 @@ class BaseNode : public DualRefCounted<BaseNode> {
     if (kind == "socket") return EntityType::kSocket;
     if (kind == "call") return EntityType::kCall;
     if (kind == "resource_quota") return EntityType::kResourceQuota;
+    if (kind == "metrics_domain") return EntityType::kMetricsDomain;
+    if (kind == "metrics_domain_storage") {
+      return EntityType::kMetricsDomainStorage;
+    }
     return std::nullopt;
   }
 
@@ -788,8 +802,7 @@ class ListenSocketNode final : public BaseNode {
 
 class CallNode final : public BaseNode {
  public:
-  explicit CallNode(std::string name)
-      : BaseNode(EntityType::kCall, 0, std::move(name)) {
+  explicit CallNode() : BaseNode(EntityType::kCall, 0, std::string()) {
     NodeConstructed();
   }
 
@@ -806,6 +819,28 @@ class ResourceQuotaNode final : public BaseNode {
   Json RenderJson() override { return Json::FromString("ResourceQuota"); }
 };
 
+class MetricsDomainNode final : public BaseNode {
+ public:
+  explicit MetricsDomainNode(std::string name)
+      : BaseNode(EntityType::kMetricsDomain, 0, std::move(name)) {
+    NodeConstructed();
+  }
+
+  Json RenderJson() override { return Json::FromString("MetricsDomain"); }
+};
+
+class MetricsDomainStorageNode final : public BaseNode {
+ public:
+  explicit MetricsDomainStorageNode(std::string name)
+      : BaseNode(EntityType::kMetricsDomainStorage, 0, std::move(name)) {
+    NodeConstructed();
+  }
+
+  Json RenderJson() override {
+    return Json::FromString("MetricsDomainStorage");
+  }
+};
+
 }  // namespace channelz
 }  // namespace grpc_core
 

data/src/core/channelz/channelz_registry.cc

@@ -33,8 +33,6 @@
 #include <utility>
 #include <vector>
 
-#include "absl/log/check.h"
-#include "absl/log/log.h"
 #include "src/core/channelz/channelz.h"
 #include "src/core/config/config_vars.h"
 #include "src/core/lib/iomgr/exec_ctx.h"
@@ -43,6 +41,8 @@
 #include "src/core/util/json/json_writer.h"
 #include "src/core/util/shared_bit_gen.h"
 #include "src/core/util/sync.h"
+#include "absl/log/check.h"
+#include "absl/log/log.h"
 
 namespace grpc_core {
 namespace channelz {

data/src/core/channelz/channelz_registry.h

@@ -21,16 +21,18 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <cstddef>
 #include <cstdint>
 #include <map>
 #include <string>
 
-#include "absl/container/btree_map.h"
-#include "absl/functional/function_ref.h"
 #include "src/core/channelz/channelz.h"
 #include "src/core/util/json/json_writer.h"
 #include "src/core/util/ref_counted_ptr.h"
 #include "src/core/util/sync.h"
+#include "absl/container/btree_map.h"
+#include "absl/container/flat_hash_set.h"
+#include "absl/functional/function_ref.h"
 
 namespace grpc_core {
 namespace channelz {
@@ -115,6 +117,11 @@ class ChannelzRegistry final {
                                                 max_results);
   }
 
+  static std::vector<WeakRefCountedPtr<BaseNode>> GetDescendants(
+      BaseNode* root, size_t max_results) {
+    return Default()->InternalGetDescendants(root, max_results);
+  }
+
   static WeakRefCountedPtr<BaseNode> GetNode(intptr_t uuid) {
     return Default()->InternalGet(uuid);
   }
@@ -250,6 +257,39 @@ class ChannelzRegistry final {
         max_results);
   }
 
+  std::vector<WeakRefCountedPtr<BaseNode>> InternalGetDescendants(
+      BaseNode* root, size_t max_results) {
+    std::vector<WeakRefCountedPtr<BaseNode>> descendants;
+    if (root == nullptr || max_results == 0) return descendants;
+
+    // To prevent duplicate nodes and to prevent infinite loops.
+    absl::flat_hash_set<intptr_t> visited;
+
+    descendants.reserve(max_results);
+    visited.insert(root->uuid());
+    descendants.push_back(root->WeakRef());
+
+    size_t next_id = 0;
+
+    // BFS to find all descendants.
+    do {
+      BaseNode* current_node = descendants[next_id].get();
+
+      auto [children, _] = InternalGetChildren(
+          current_node, current_node->uuid(), max_results - descendants.size());
+
+      for (const auto& child : children) {
+        if (visited.insert(child->uuid()).second) {
+          descendants.push_back(child);
+        }
+      }
+
+      ++next_id;
+    } while (descendants.size() < max_results && next_id < descendants.size());
+
+    return descendants;
+  }
+
   std::tuple<std::vector<WeakRefCountedPtr<BaseNode>>, bool> InternalGetNodes(
       intptr_t start_node, size_t max_results) {
     return QueryNodes(