grpc 1.75.0 → 1.78.1

data/src/core/lib/event_engine/cf_engine/dns_service_resolver.h

@@ -23,11 +23,11 @@
 #include <dns_sd.h>
 #include <grpc/event_engine/event_engine.h>
 
-#include "absl/container/flat_hash_map.h"
-#include "absl/log/check.h"
 #include "src/core/lib/event_engine/cf_engine/cf_engine.h"
+#include "src/core/util/grpc_check.h"
 #include "src/core/util/ref_counted.h"
 #include "src/core/util/ref_counted_ptr.h"
+#include "absl/container/flat_hash_map.h"
 
 namespace grpc_event_engine::experimental {
 
@@ -45,7 +45,7 @@ class DNSServiceResolverImpl
   explicit DNSServiceResolverImpl(std::shared_ptr<CFEventEngine> engine)
       : engine_(std::move((engine))) {}
   ~DNSServiceResolverImpl() override {
-    CHECK(requests_.empty());
+    GRPC_CHECK(requests_.empty());
     dispatch_release(queue_);
   }
 

data/src/core/lib/event_engine/channel_args_endpoint_config.h

@@ -19,8 +19,8 @@
 
 #include <optional>
 
-#include "absl/strings/string_view.h"
 #include "src/core/lib/channel/channel_args.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/default_event_engine.cc

@@ -22,7 +22,6 @@
 #include <utility>
 #include <variant>
 
-#include "absl/functional/any_invocable.h"
 #include "src/core/config/core_configuration.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/event_engine/default_event_engine_factory.h"
@@ -31,6 +30,7 @@
 #include "src/core/util/no_destruct.h"
 #include "src/core/util/sync.h"
 #include "src/core/util/wait_for_single_owner.h"
+#include "absl/functional/any_invocable.h"
 
 #ifdef GRPC_MAXIMIZE_THREADYNESS
 #include "src/core/lib/event_engine/thready_event_engine/thready_event_engine.h"  // IWYU pragma: keep

data/src/core/lib/event_engine/event_engine.cc

@@ -14,8 +14,8 @@
 #include <grpc/event_engine/event_engine.h>
 #include <grpc/support/port_platform.h>
 
-#include "absl/strings/str_cat.h"
 #include "src/core/telemetry/context_list_entry.h"
+#include "absl/strings/str_cat.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/extensions/channelz.h

@@ -18,9 +18,9 @@
 #include <memory>
 #include <utility>
 
-#include "absl/strings/string_view.h"
 #include "src/core/channelz/channelz.h"
 #include "src/core/util/ref_counted_ptr.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 
@@ -30,7 +30,7 @@ class ChannelzExtension {
   static absl::string_view EndpointExtensionName() {
     return "io.grpc.event_engine.extension.channelz";
   }
-  virtual void AddJson(grpc_core::channelz::DataSink& sink) = 0;
+  virtual void AddData(grpc_core::channelz::DataSink& sink) = 0;
 
   void SetSocketNode(
       grpc_core::RefCountedPtr<grpc_core::channelz::SocketNode> socket_node) {
@@ -51,7 +51,7 @@ class ChannelzExtension {
     }
     ~EndpointDataSource() { SourceDestructing(); }
     void AddData(grpc_core::channelz::DataSink sink) override {
-      ep_->AddJson(sink);
+      ep_->AddData(sink);
     }
 
    private:

data/src/core/lib/event_engine/extensions/chaotic_good_extension.h

@@ -17,8 +17,8 @@
 
 #include <grpc/support/port_platform.h>
 
-#include "absl/strings/string_view.h"
 #include "src/core/lib/resource_quota/memory_quota.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/extensions/supports_fd.h

@@ -107,16 +107,16 @@ class EventEngineSupportsFdExtension {
   /// file descriptor. \a config - Additional configuration to applied to the
   /// endpoint. \a memory_allocator - The endpoint may use the provided memory
   /// allocator to track memory allocations.
-  virtual std::unique_ptr<EventEngine::Endpoint> CreatePosixEndpointFromFd(
-      int fd, const EndpointConfig& config,
-      MemoryAllocator memory_allocator) = 0;
+  virtual absl::StatusOr<std::unique_ptr<EventEngine::Endpoint>>
+  CreatePosixEndpointFromFd(int fd, const EndpointConfig& config,
+                            MemoryAllocator memory_allocator) = 0;
 
   /// Creates an EventEngine::Endpoint from an fd which is already assumed to be
   /// connected to a remote peer. See \a CreatePosixEndpointFromFd for details.
   /// This has the same behavior, but the \a memory_allocator is taken from the
   /// EndpointConfig's resource quota.
-  virtual std::unique_ptr<EventEngine::Endpoint> CreateEndpointFromFd(
-      int fd, const EndpointConfig& config) = 0;
+  virtual absl::StatusOr<std::unique_ptr<EventEngine::Endpoint>>
+  CreateEndpointFromFd(int fd, const EndpointConfig& config) = 0;
 
   /// Creates an EventEngine::Endpoint from a file descriptor that is configured
   /// and bound locally but not yet connected to a remote peer. Returns a

data/src/core/lib/event_engine/extensions/tcp_trace.h

@@ -17,8 +17,10 @@
 
 #include <memory>
 
-#include "absl/strings/string_view.h"
+#include "src/core/telemetry/instrument.h"
 #include "src/core/telemetry/tcp_tracer.h"
+#include "src/core/util/ref_counted_ptr.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 
@@ -33,6 +35,11 @@ class TcpTraceExtension {
   }
   virtual void SetTcpTracer(
       std::shared_ptr<grpc_core::TcpConnectionTracer> tracer) = 0;
+
+  // Enable TCP telemetry collection using the Instrumentation API.
+  virtual void EnableTcpTelemetry(
+      grpc_core::RefCountedPtr<grpc_core::CollectionScope> collection_scope,
+      bool is_control_endpoint) = 0;
 };
 
 }  // namespace grpc_event_engine::experimental

data/src/core/lib/event_engine/grpc_polled_fd.h

@@ -24,9 +24,9 @@
 
 #include <ares.h>
 
+#include "src/core/util/sync.h"
 #include "absl/functional/any_invocable.h"
 #include "absl/status/status.h"
-#include "src/core/util/sync.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/memory_allocator_factory.h

@@ -19,8 +19,8 @@
 #include <memory>
 #include <utility>
 
-#include "absl/strings/string_view.h"
 #include "src/core/lib/resource_quota/memory_quota.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc

@@ -22,16 +22,16 @@
 #include <atomic>
 #include <memory>
 
-#include "absl/log/check.h"
-#include "absl/log/log.h"
-#include "absl/status/status.h"
-#include "absl/status/statusor.h"
-#include "absl/strings/str_format.h"
 #include "src/core/lib/event_engine/poller.h"
 #include "src/core/lib/event_engine/posix_engine/posix_interface.h"
 #include "src/core/lib/event_engine/time_util.h"
 #include "src/core/lib/iomgr/port.h"
 #include "src/core/util/crash.h"
+#include "src/core/util/grpc_check.h"
+#include "absl/log/log.h"
+#include "absl/status/status.h"
+#include "absl/status/statusor.h"
+#include "absl/strings/str_format.h"
 
 // This polling engine is only relevant on linux kernels supporting epoll
 // epoll_create() or epoll_create1()
@@ -247,13 +247,13 @@ Epoll1Poller::Epoll1Poller(std::shared_ptr<ThreadPool> thread_pool)
     : thread_pool_(thread_pool), was_kicked_(false), closed_(false) {
   g_epoll_set_.epfd = posix_interface().EpollCreateAndCloexec().value();
   wakeup_fd_ = CreateWakeupFd(&posix_interface()).value();
-  CHECK(wakeup_fd_ != nullptr);
-  CHECK(g_epoll_set_.epfd.ready());
+  GRPC_CHECK(wakeup_fd_ != nullptr);
+  GRPC_CHECK(g_epoll_set_.epfd.ready());
   GRPC_TRACE_LOG(event_engine_poller, INFO)
       << "grpc epoll fd: " << g_epoll_set_.epfd;
   auto result = posix_interface().EpollCtlAdd(
       g_epoll_set_.epfd, false, wakeup_fd_->ReadFd(), wakeup_fd_.get());
-  CHECK(result.ok()) << result.StrError();
+  GRPC_CHECK(result.ok()) << result.StrError();
   g_epoll_set_.num_events = 0;
   g_epoll_set_.cursor = 0;
 }
@@ -330,7 +330,7 @@ bool Epoll1Poller::ProcessEpollEvents(int max_epoll_events_to_handle,
     struct epoll_event* ev = &g_epoll_set_.events[c];
     void* data_ptr = ev->data.ptr;
     if (data_ptr == wakeup_fd_.get()) {
-      CHECK(wakeup_fd_->ConsumeWakeup().ok());
+      GRPC_CHECK(wakeup_fd_->ConsumeWakeup().ok());
       was_kicked = true;
     } else {
       Epoll1EventHandle* handle = reinterpret_cast<Epoll1EventHandle*>(
@@ -453,7 +453,7 @@ void Epoll1Poller::Kick() {
     return;
   }
   was_kicked_ = true;
-  CHECK(wakeup_fd_->Wakeup().ok());
+  GRPC_CHECK(wakeup_fd_->Wakeup().ok());
 }
 
 #ifdef GRPC_ENABLE_FORK_SUPPORT
@@ -472,7 +472,7 @@ void Epoll1Poller::HandleForkInChild() {
   }
   g_epoll_set_ = {};
   g_epoll_set_.epfd = posix_interface().EpollCreateAndCloexec().value();
-  CHECK(g_epoll_set_.epfd.ready());
+  GRPC_CHECK(g_epoll_set_.epfd.ready());
   GRPC_TRACE_LOG(event_engine_poller, INFO)
       << "Post-fork grpc epoll fd: " << g_epoll_set_.epfd;
   g_epoll_set_.num_events = 0;
@@ -488,7 +488,7 @@ void Epoll1Poller::ResetKickState() {
   wakeup_fd_ = *CreateWakeupFd(&posix_interface());
   auto status = posix_interface().EpollCtlAdd(
       g_epoll_set_.epfd, false, wakeup_fd_->ReadFd(), wakeup_fd_.get());
-  CHECK(status.ok()) << status.StrError();
+  GRPC_CHECK(status.ok()) << status.StrError();
   grpc_core::MutexLock lock(&mu_);
   was_kicked_ = false;
 }

data/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.h

@@ -21,11 +21,6 @@
 #include <memory>
 #include <string>
 
-#include "absl/base/thread_annotations.h"
-#include "absl/container/flat_hash_set.h"
-#include "absl/container/inlined_vector.h"
-#include "absl/functional/function_ref.h"
-#include "absl/strings/string_view.h"
 #include "src/core/lib/event_engine/poller.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/event_engine/posix_engine/internal_errqueue.h"
@@ -33,6 +28,11 @@
 #include "src/core/lib/event_engine/thread_pool/thread_pool.h"
 #include "src/core/lib/iomgr/port.h"
 #include "src/core/util/sync.h"
+#include "absl/base/thread_annotations.h"
+#include "absl/container/flat_hash_set.h"
+#include "absl/container/inlined_vector.h"
+#include "absl/functional/function_ref.h"
+#include "absl/strings/string_view.h"
 
 #ifdef GRPC_LINUX_EPOLL
 #include <sys/epoll.h>

data/src/core/lib/event_engine/posix_engine/ev_poll_posix.cc

@@ -26,18 +26,18 @@
 #include <string>
 #include <utility>
 
-#include "absl/container/inlined_vector.h"
-#include "absl/functional/any_invocable.h"
-#include "absl/log/check.h"
-#include "absl/status/status.h"
-#include "absl/status/statusor.h"
-#include "absl/strings/str_format.h"
 #include "src/core/lib/event_engine/poller.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine_closure.h"
 #include "src/core/lib/event_engine/posix_engine/posix_interface.h"
 #include "src/core/lib/iomgr/port.h"
 #include "src/core/util/crash.h"
+#include "src/core/util/grpc_check.h"
+#include "absl/container/inlined_vector.h"
+#include "absl/functional/any_invocable.h"
+#include "absl/status/status.h"
+#include "absl/status/statusor.h"
+#include "absl/strings/str_format.h"
 
 #ifdef GRPC_POSIX_SOCKET_EV_POLL
 
@@ -239,7 +239,7 @@ EventHandle* PollPoller::CreateHandle(FileDescriptor fd,
                                       bool track_err) {
   // Avoid unused-parameter warning for debug-only parameter
   (void)track_err;
-  DCHECK(track_err == false);
+  GRPC_DCHECK(track_err == false);
   PollEventHandle* handle = new PollEventHandle(fd, shared_from_this());
   // We need to send a kick to the thread executing Work(..) so that it can
   // add this new Fd into the list of Fds to poll.
@@ -258,7 +258,7 @@ void PollEventHandle::OrphanHandle(PosixEngineClosure* on_done,
     if (release_fd != nullptr) {
       *release_fd = fd_;
     }
-    CHECK(!is_orphaned_);
+    GRPC_CHECK(!is_orphaned_);
     is_orphaned_ = true;
     // Perform shutdown operations if not already done so.
     if (!is_shutdown_) {
@@ -473,7 +473,7 @@ void PollPoller::KickExternal(bool ext) {
   }
   was_kicked_ = true;
   was_kicked_ext_ = ext;
-  CHECK(wakeup_fd_->Wakeup().ok());
+  GRPC_CHECK(wakeup_fd_->Wakeup().ok());
 }
 
 void PollPoller::Kick() { KickExternal(true); }
@@ -513,14 +513,14 @@ PollPoller::PollPoller(std::shared_ptr<ThreadPool> thread_pool,
       poll_handles_list_head_(nullptr),
       closed_(false) {
   wakeup_fd_ = *CreateWakeupFd(&posix_interface());
-  CHECK(wakeup_fd_ != nullptr);
+  GRPC_CHECK(wakeup_fd_ != nullptr);
 }
 
 PollPoller::~PollPoller() {
   // Assert that no active handles are present at the time of destruction.
   // They should have been orphaned before reaching this state.
-  CHECK_EQ(num_poll_handles_, 0);
-  CHECK_EQ(poll_handles_list_head_, nullptr);
+  GRPC_CHECK_EQ(num_poll_handles_, 0);
+  GRPC_CHECK_EQ(poll_handles_list_head_, nullptr);
 }
 
 Poller::WorkResult PollPoller::Work(
@@ -563,7 +563,7 @@ Poller::WorkResult PollPoller::Work(
 
     pfd_count = 1;
     auto wakeup_fd = posix_interface().GetFd(wakeup_fd_->ReadFd());
-    CHECK(wakeup_fd.ok()) << wakeup_fd.StrError();
+    GRPC_CHECK(wakeup_fd.ok()) << wakeup_fd.StrError();
     pfds[0].fd = *wakeup_fd;
     pfds[0].events = POLLIN;
     pfds[0].revents = 0;
@@ -575,7 +575,7 @@ Poller::WorkResult PollPoller::Work(
         // There shouldn't be any orphaned fds at this point. This is because
         // prior to marking a handle as orphaned it is first removed from
         // poll handle list for the poller under the poller lock.
-        CHECK(!head->IsOrphaned());
+        GRPC_CHECK(!head->IsOrphaned());
         if (!head->IsPollhup()) {
           if (auto file_descriptor = posix_interface().GetFd(head->WrappedFd());
               file_descriptor.ok()) {
@@ -656,7 +656,7 @@ Poller::WorkResult PollPoller::Work(
       }
     } else {
       if (pfds[0].revents & kPollinCheck) {
-        CHECK(wakeup_fd_->ConsumeWakeup().ok());
+        GRPC_CHECK(wakeup_fd_->ConsumeWakeup().ok());
       }
       for (i = 1; i < pfd_count; i++) {
         PollEventHandle* head = watchers[i];

data/src/core/lib/event_engine/posix_engine/ev_poll_posix.h

@@ -21,14 +21,14 @@
 #include <memory>
 #include <string>
 
-#include "absl/base/thread_annotations.h"
-#include "absl/functional/function_ref.h"
-#include "absl/strings/string_view.h"
 #include "src/core/lib/event_engine/poller.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/event_engine/posix_engine/wakeup_fd_posix.h"
 #include "src/core/lib/event_engine/thread_pool/thread_pool.h"
 #include "src/core/util/sync.h"
+#include "absl/base/thread_annotations.h"
+#include "absl/functional/function_ref.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/event_poller.h

@@ -19,11 +19,11 @@
 
 #include <string>
 
-#include "absl/status/status.h"
-#include "absl/strings/string_view.h"
 #include "src/core/lib/event_engine/poller.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine_closure.h"
 #include "src/core/lib/event_engine/posix_engine/posix_interface.h"
+#include "absl/status/status.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc

@@ -17,13 +17,13 @@
 #include <memory>
 #include <utility>
 
-#include "absl/strings/str_split.h"
-#include "absl/strings/string_view.h"
 #include "src/core/config/config_vars.h"
 #include "src/core/lib/event_engine/posix_engine/ev_epoll1_linux.h"
 #include "src/core/lib/event_engine/posix_engine/ev_poll_posix.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/iomgr/port.h"
+#include "absl/strings/str_split.h"
+#include "absl/strings/string_view.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/file_descriptor_collection.cc

@@ -14,10 +14,10 @@
 
 #include "src/core/lib/event_engine/posix_engine/file_descriptor_collection.h"
 
-#include "absl/strings/substitute.h"
 #include "src/core/lib/experiments/experiments.h"
 #include "src/core/util/crash.h"  // IWYU pragma: keep
 #include "src/core/util/strerror.h"
+#include "absl/strings/substitute.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/file_descriptor_collection.h

@@ -21,10 +21,10 @@
 #include <utility>
 #include <variant>
 
+#include "src/core/util/sync.h"
 #include "absl/container/flat_hash_set.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "src/core/util/sync.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/grpc_polled_fd_posix.h

@@ -20,11 +20,11 @@
 
 #include <memory>
 
-#include "absl/base/thread_annotations.h"
 #include "src/core/lib/event_engine/posix_engine/file_descriptor_collection.h"
 #include "src/core/lib/event_engine/posix_engine/posix_interface.h"
 #include "src/core/lib/iomgr/port.h"
 #include "src/core/util/sync.h"
+#include "absl/base/thread_annotations.h"
 
 #if GRPC_ARES == 1 && defined(GRPC_POSIX_SOCKET_ARES_EV_DRIVER)
 
@@ -39,12 +39,12 @@
 #include <unordered_set>
 #include <utility>
 
-#include "absl/functional/any_invocable.h"
-#include "absl/status/status.h"
-#include "absl/strings/str_cat.h"
 #include "src/core/lib/event_engine/grpc_polled_fd.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine_closure.h"
+#include "absl/functional/any_invocable.h"
+#include "absl/status/status.h"
+#include "absl/strings/str_cat.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/internal_errqueue.cc

@@ -16,9 +16,9 @@
 
 #include <grpc/support/port_platform.h>
 
-#include "absl/log/log.h"
 #include "src/core/lib/event_engine/posix_engine/posix_interface.h"
 #include "src/core/lib/iomgr/port.h"
+#include "absl/log/log.h"
 
 #ifdef GRPC_POSIX_SOCKET_TCP
 

data/src/core/lib/event_engine/posix_engine/lockfree_event.cc

@@ -19,12 +19,12 @@
 #include <atomic>
 #include <cstdint>
 
-#include "absl/log/check.h"
-#include "absl/status/status.h"
 #include "src/core/lib/event_engine/posix_engine/event_poller.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine_closure.h"
 #include "src/core/util/crash.h"
+#include "src/core/util/grpc_check.h"
 #include "src/core/util/status_helper.h"
+#include "absl/status/status.h"
 
 //  'state' holds the to call when the fd is readable or writable respectively.
 //    It can contain one of the following values:
@@ -76,7 +76,7 @@ void LockfreeEvent::DestroyEvent() {
     if (curr & kShutdownBit) {
       grpc_core::internal::StatusFreeHeapPtr(curr & ~kShutdownBit);
     } else {
-      CHECK(curr == kClosureNotReady || curr == kClosureReady);
+      GRPC_CHECK(curr == kClosureNotReady || curr == kClosureReady);
     }
     // we CAS in a shutdown, no error value here. If this event is interacted
     // with post-deletion (see the note in the constructor) we want the bit

data/src/core/lib/event_engine/posix_engine/lockfree_event.h

@@ -19,9 +19,9 @@
 #include <atomic>
 #include <cstdint>
 
-#include "absl/status/status.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine_closure.h"
 #include "src/core/lib/event_engine/thread_pool/thread_pool.h"
+#include "absl/status/status.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/native_posix_dns_resolver.cc

@@ -27,14 +27,14 @@
 #include <utility>
 #include <vector>
 
+#include "src/core/lib/event_engine/posix_engine/native_posix_dns_resolver.h"
+#include "src/core/util/host_port.h"
+#include "src/core/util/useful.h"
 #include "absl/functional/any_invocable.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "src/core/lib/event_engine/posix_engine/native_posix_dns_resolver.h"
-#include "src/core/util/host_port.h"
-#include "src/core/util/useful.h"
 
 namespace grpc_event_engine::experimental {
 

data/src/core/lib/event_engine/posix_engine/native_posix_dns_resolver.h

@@ -19,8 +19,8 @@
 
 #include <memory>
 
-#include "absl/strings/string_view.h"
 #include "src/core/lib/iomgr/port.h"
+#include "absl/strings/string_view.h"
 
 #ifdef GRPC_POSIX_SOCKET_RESOLVE_ADDRESS