grpc 1.67.0 → 1.69.0.pre1

data/src/core/service_config/service_config_channel_arg_filter.cc

@@ -17,6 +17,9 @@
 // This filter reads GRPC_ARG_SERVICE_CONFIG and populates ServiceConfigCallData
 // in the call context per call for direct channels.
 
+#include <grpc/impl/channel_arg_names.h>
+#include <grpc/support/port_platform.h>
+
 #include <functional>
 #include <memory>
 #include <string>
@@ -26,17 +29,12 @@
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/types/optional.h"
-
-#include <grpc/impl/channel_arg_names.h>
-#include <grpc/support/port_platform.h>
-
+#include "src/core/config/core_configuration.h"
 #include "src/core/ext/filters/message_size/message_size_filter.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/channel/channel_fwd.h"
 #include "src/core/lib/channel/channel_stack.h"
 #include "src/core/lib/channel/promise_based_filter.h"
-#include "src/core/lib/config/core_configuration.h"
-#include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/promise/arena_promise.h"
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/resource_quota/arena.h"
@@ -47,6 +45,8 @@
 #include "src/core/service_config/service_config_call_data.h"
 #include "src/core/service_config/service_config_impl.h"
 #include "src/core/service_config/service_config_parser.h"
+#include "src/core/util/latent_see.h"
+#include "src/core/util/ref_counted_ptr.h"
 
 namespace grpc_core {
 
@@ -107,6 +107,8 @@ const NoInterceptor ServiceConfigChannelArgFilter::Call::OnFinalize;
 
 void ServiceConfigChannelArgFilter::Call::OnClientInitialMetadata(
     ClientMetadata& md, ServiceConfigChannelArgFilter* filter) {
+  GRPC_LATENT_SEE_INNER_SCOPE(
+      "ServiceConfigChannelArgFilter::Call::OnClientInitialMetadata");
   const ServiceConfigParser::ParsedConfigVector* method_configs = nullptr;
   if (filter->service_config_ != nullptr) {
     method_configs = filter->service_config_->GetMethodParsedConfigVector(

data/src/core/service_config/service_config_impl.cc

@@ -16,6 +16,7 @@
 
 #include "src/core/service_config/service_config_impl.h"
 
+#include <grpc/support/port_platform.h>
 #include <string.h>
 
 #include <string>
@@ -25,12 +26,7 @@
 #include "absl/status/statusor.h"
 #include "absl/strings/str_cat.h"
 #include "absl/types/optional.h"
-
-#include <grpc/support/port_platform.h>
-
-#include "src/core/lib/config/core_configuration.h"
-#include "src/core/lib/gprpp/memory.h"
-#include "src/core/lib/gprpp/validation_errors.h"
+#include "src/core/config/core_configuration.h"
 #include "src/core/lib/slice/slice.h"
 #include "src/core/lib/slice/slice_internal.h"
 #include "src/core/service_config/service_config_parser.h"
@@ -39,6 +35,8 @@
 #include "src/core/util/json/json_object_loader.h"
 #include "src/core/util/json/json_reader.h"
 #include "src/core/util/json/json_writer.h"
+#include "src/core/util/memory.h"
+#include "src/core/util/validation_errors.h"
 
 namespace grpc_core {
 

data/src/core/service_config/service_config_impl.h

@@ -17,6 +17,8 @@
 #ifndef GRPC_SRC_CORE_SERVICE_CONFIG_SERVICE_CONFIG_IMPL_H
 #define GRPC_SRC_CORE_SERVICE_CONFIG_SERVICE_CONFIG_IMPL_H
 
+#include <grpc/slice.h>
+#include <grpc/support/port_platform.h>
 #include <stddef.h>
 
 #include <memory>
@@ -27,17 +29,13 @@
 #include "absl/log/check.h"
 #include "absl/status/statusor.h"
 #include "absl/strings/string_view.h"
-
-#include <grpc/slice.h>
-#include <grpc/support/port_platform.h>
-
 #include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/gprpp/ref_counted_ptr.h"
-#include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/lib/slice/slice_internal.h"
 #include "src/core/service_config/service_config.h"
 #include "src/core/service_config/service_config_parser.h"
 #include "src/core/util/json/json.h"
+#include "src/core/util/ref_counted_ptr.h"
+#include "src/core/util/validation_errors.h"
 
 // The main purpose of the code here is to parse the service config in
 // JSON form, which will look like this:

data/src/core/service_config/service_config_parser.cc

@@ -16,14 +16,13 @@
 
 #include "src/core/service_config/service_config_parser.h"
 
+#include <grpc/support/port_platform.h>
 #include <stdlib.h>
 
 #include <string>
 
 #include "absl/log/log.h"
 
-#include <grpc/support/port_platform.h>
-
 namespace grpc_core {
 
 ServiceConfigParser ServiceConfigParser::Builder::Build() {

data/src/core/service_config/service_config_parser.h

@@ -17,6 +17,7 @@
 #ifndef GRPC_SRC_CORE_SERVICE_CONFIG_SERVICE_CONFIG_PARSER_H
 #define GRPC_SRC_CORE_SERVICE_CONFIG_SERVICE_CONFIG_PARSER_H
 
+#include <grpc/support/port_platform.h>
 #include <stddef.h>
 
 #include <algorithm>
@@ -25,12 +26,9 @@
 #include <vector>
 
 #include "absl/strings/string_view.h"
-
-#include <grpc/support/port_platform.h>
-
 #include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/util/json/json.h"
+#include "src/core/util/validation_errors.h"
 
 namespace grpc_core {
 

data/src/core/telemetry/call_tracer.cc

@@ -18,14 +18,13 @@
 
 #include "src/core/telemetry/call_tracer.h"
 
+#include <grpc/support/port_platform.h>
+
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "absl/log/check.h"
-
-#include <grpc/support/port_platform.h>
-
 #include "src/core/lib/promise/context.h"
 #include "src/core/telemetry/tcp_tracer.h"
 

data/src/core/telemetry/call_tracer.h

@@ -19,18 +19,16 @@
 #ifndef GRPC_SRC_CORE_TELEMETRY_CALL_TRACER_H
 #define GRPC_SRC_CORE_TELEMETRY_CALL_TRACER_H
 
+#include <grpc/support/port_platform.h>
+#include <grpc/support/time.h>
+
 #include <memory>
 #include <string>
 
 #include "absl/status/status.h"
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
-
-#include <grpc/support/port_platform.h>
-#include <grpc/support/time.h>
-
 #include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/gprpp/ref_counted_string.h"
 #include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/resource_quota/arena.h"
@@ -38,6 +36,7 @@
 #include "src/core/lib/transport/call_final_info.h"
 #include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/telemetry/tcp_tracer.h"
+#include "src/core/util/ref_counted_string.h"
 
 namespace grpc_core {
 
@@ -213,7 +212,7 @@ class ServerCallTracerFactory {
   // instead of directly fetching it with `GetObject`.
   static ServerCallTracerFactory* Get(const ChannelArgs& channel_args);
 
-  // Registers a global ServerCallTracerFactory that wil be used by default if
+  // Registers a global ServerCallTracerFactory that will be used by default if
   // no corresponding channel arg was found. It is only valid to call this
   // before grpc_init(). It is the responsibility of the caller to maintain
   // this for the lifetime of the process.

data/src/core/telemetry/histogram_view.cc

@@ -54,9 +54,9 @@ double HistogramView::ThresholdForCountBelow(double count_below) const {
     // should lie
     lower_bound = bucket_boundaries[lower_idx];
     upper_bound = bucket_boundaries[lower_idx + 1];
-    return upper_bound - (upper_bound - lower_bound) *
-                             (count_so_far - count_below) /
-                             static_cast<double>(buckets[lower_idx]);
+    return upper_bound -
+           ((upper_bound - lower_bound) * (count_so_far - count_below) /
+            static_cast<double>(buckets[lower_idx]));
   }
 }
 

data/src/core/telemetry/histogram_view.h

@@ -15,9 +15,8 @@
 #ifndef GRPC_SRC_CORE_TELEMETRY_HISTOGRAM_VIEW_H
 #define GRPC_SRC_CORE_TELEMETRY_HISTOGRAM_VIEW_H
 
-#include <stdint.h>
-
 #include <grpc/support/port_platform.h>
+#include <stdint.h>
 
 namespace grpc_core {
 

data/src/core/telemetry/metrics.cc

@@ -14,14 +14,13 @@
 
 #include "src/core/telemetry/metrics.h"
 
+#include <grpc/support/port_platform.h>
+
 #include <memory>
 
 #include "absl/log/check.h"
 #include "absl/types/optional.h"
-
-#include <grpc/support/port_platform.h>
-
-#include "src/core/lib/gprpp/crash.h"
+#include "src/core/util/crash.h"
 
 namespace grpc_core {
 
@@ -121,27 +120,30 @@ void GlobalStatsPluginRegistry::StatsPluginGroup::AddServerCallTracers(
   }
 }
 
-NoDestruct<Mutex> GlobalStatsPluginRegistry::mutex_;
-NoDestruct<std::vector<std::shared_ptr<StatsPlugin>>>
+std::atomic<GlobalStatsPluginRegistry::GlobalStatsPluginNode*>
     GlobalStatsPluginRegistry::plugins_;
 
 void GlobalStatsPluginRegistry::RegisterStatsPlugin(
     std::shared_ptr<StatsPlugin> plugin) {
-  MutexLock lock(&*mutex_);
-  plugins_->push_back(std::move(plugin));
+  GlobalStatsPluginNode* node = new GlobalStatsPluginNode();
+  node->plugin = std::move(plugin);
+  node->next = plugins_.load(std::memory_order_relaxed);
+  while (!plugins_.compare_exchange_weak(
+      node->next, node, std::memory_order_acq_rel, std::memory_order_relaxed)) {
+  }
 }
 
 GlobalStatsPluginRegistry::StatsPluginGroup
 GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
     const experimental::StatsPluginChannelScope& scope) {
-  MutexLock lock(&*mutex_);
   StatsPluginGroup group;
-  for (const auto& plugin : *plugins_) {
+  for (GlobalStatsPluginNode* node = plugins_.load(std::memory_order_acquire);
+       node != nullptr; node = node->next) {
     bool is_enabled = false;
     std::shared_ptr<StatsPlugin::ScopeConfig> config;
-    std::tie(is_enabled, config) = plugin->IsEnabledForChannel(scope);
+    std::tie(is_enabled, config) = node->plugin->IsEnabledForChannel(scope);
     if (is_enabled) {
-      group.AddStatsPlugin(plugin, std::move(config));
+      group.AddStatsPlugin(node->plugin, std::move(config));
     }
   }
   return group;
@@ -149,14 +151,14 @@ GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
 
 GlobalStatsPluginRegistry::StatsPluginGroup
 GlobalStatsPluginRegistry::GetStatsPluginsForServer(const ChannelArgs& args) {
-  MutexLock lock(&*mutex_);
   StatsPluginGroup group;
-  for (const auto& plugin : *plugins_) {
+  for (GlobalStatsPluginNode* node = plugins_.load(std::memory_order_acquire);
+       node != nullptr; node = node->next) {
     bool is_enabled = false;
     std::shared_ptr<StatsPlugin::ScopeConfig> config;
-    std::tie(is_enabled, config) = plugin->IsEnabledForServer(args);
+    std::tie(is_enabled, config) = node->plugin->IsEnabledForServer(args);
     if (is_enabled) {
-      group.AddStatsPlugin(plugin, std::move(config));
+      group.AddStatsPlugin(node->plugin, std::move(config));
     }
   }
   return group;

data/src/core/telemetry/metrics.h

@@ -15,6 +15,9 @@
 #ifndef GRPC_SRC_CORE_TELEMETRY_METRICS_H
 #define GRPC_SRC_CORE_TELEMETRY_METRICS_H
 
+#include <grpc/support/metrics.h>
+#include <grpc/support/port_platform.h>
+
 #include <cstdint>
 #include <memory>
 #include <type_traits>
@@ -24,16 +27,12 @@
 #include "absl/functional/function_ref.h"
 #include "absl/strings/string_view.h"
 #include "absl/types/span.h"
-
-#include <grpc/support/metrics.h>
-#include <grpc/support/port_platform.h>
-
 #include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/gprpp/no_destruct.h"
-#include "src/core/lib/gprpp/sync.h"
-#include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/slice/slice.h"
 #include "src/core/telemetry/call_tracer.h"
+#include "src/core/util/no_destruct.h"
+#include "src/core/util/sync.h"
+#include "src/core/util/time.h"
 
 namespace grpc_core {
 
@@ -447,6 +446,8 @@ class GlobalStatsPluginRegistry {
       return false;
     }
 
+    size_t size() const { return plugins_state_.size(); }
+
     // Registers a callback to be used to populate callback metrics.
     // The callback will update the specified metrics.  The callback
     // will be invoked no more often than min_interval.  Multiple callbacks may
@@ -509,13 +510,15 @@ class GlobalStatsPluginRegistry {
   static StatsPluginGroup GetStatsPluginsForServer(const ChannelArgs& args);
 
  private:
+  struct GlobalStatsPluginNode {
+    std::shared_ptr<StatsPlugin> plugin;
+    GlobalStatsPluginNode* next = nullptr;
+  };
   friend class GlobalStatsPluginRegistryTestPeer;
 
   GlobalStatsPluginRegistry() = default;
 
-  static NoDestruct<Mutex> mutex_;
-  static NoDestruct<std::vector<std::shared_ptr<StatsPlugin>>> plugins_
-      ABSL_GUARDED_BY(mutex_);
+  static std::atomic<GlobalStatsPluginNode*> plugins_;
 };
 
 // A metric callback that is registered with a stats plugin group.

data/src/core/telemetry/stats.cc

@@ -18,6 +18,7 @@
 
 #include "src/core/telemetry/stats.h"
 
+#include <grpc/support/port_platform.h>
 #include <stddef.h>
 
 #include <algorithm>
@@ -26,8 +27,6 @@
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_join.h"
 
-#include <grpc/support/port_platform.h>
-
 namespace grpc_core {
 
 namespace stats_detail {

data/src/core/telemetry/stats.h

@@ -19,6 +19,7 @@
 #ifndef GRPC_SRC_CORE_TELEMETRY_STATS_H
 #define GRPC_SRC_CORE_TELEMETRY_STATS_H
 
+#include <grpc/support/port_platform.h>
 #include <stdint.h>
 
 #include <string>
@@ -26,12 +27,9 @@
 
 #include "absl/strings/string_view.h"
 #include "absl/types/span.h"
-
-#include <grpc/support/port_platform.h>
-
-#include "src/core/lib/gprpp/no_destruct.h"
 #include "src/core/telemetry/histogram_view.h"
 #include "src/core/telemetry/stats_data.h"
+#include "src/core/util/no_destruct.h"
 
 namespace grpc_core {
 

data/src/core/telemetry/stats_data.cc

@@ -16,9 +16,8 @@
 
 #include "src/core/telemetry/stats_data.h"
 
-#include <stdint.h>
-
 #include <grpc/support/port_platform.h>
+#include <stdint.h>
 
 namespace grpc_core {
 namespace {
@@ -128,6 +127,9 @@ const absl::string_view
         "client_subchannels_created",
         "server_channels_created",
         "insecure_connections_created",
+        "rq_connections_dropped",
+        "rq_calls_dropped",
+        "rq_calls_rejected",
         "syscall_write",
         "syscall_read",
         "tcp_read_alloc_8k",
@@ -165,6 +167,9 @@ const absl::string_view GlobalStats::counter_doc[static_cast<int>(
     "Number of client subchannels created",
     "Number of server channels created",
     "Number of insecure connections created",
+    "Number of connections dropped due to resource quota exceeded",
+    "Number of calls dropped due to resource quota exceeded",
+    "Number of calls rejected (never started) due to resource quota exceeded",
     "Number of write syscalls (or equivalent - eg sendmsg) made by this "
     "process",
     "Number of read syscalls (or equivalent - eg recvmsg) made by this process",
@@ -211,6 +216,16 @@ const absl::string_view
         "http2_send_message_size",
         "http2_metadata_size",
         "http2_hpack_entry_lifetime",
+        "http2_header_table_size",
+        "http2_initial_window_size",
+        "http2_max_concurrent_streams",
+        "http2_max_frame_size",
+        "http2_max_header_list_size",
+        "http2_preferred_receive_crypto_message_size",
+        "http2_stream_remote_window_update",
+        "http2_transport_remote_window_update",
+        "http2_transport_window_update_period",
+        "http2_stream_window_update_period",
         "wrr_subchannel_list_size",
         "wrr_subchannel_ready_size",
         "work_serializer_run_time_ms",
@@ -243,6 +258,17 @@ const absl::string_view GlobalStats::histogram_doc[static_cast<int>(
     "Size of messages received by HTTP2 transport",
     "Number of bytes consumed by metadata, according to HPACK accounting rules",
     "Lifetime of HPACK entries in the cache (in milliseconds)",
+    "Http2 header table size received through SETTINGS frame",
+    "Http2 initial window size received through SETTINGS frame",
+    "Http2 max concurrent streams received through SETTINGS frame",
+    "Http2 max frame size received through SETTINGS frame",
+    "Http2 max header list size received through SETTINGS frame",
+    "Http2 preferred receive crypto message size received through SETTINGS "
+    "frame",
+    "Stream window update sent by peer",
+    "Transport window update sent by peer",
+    "Period in milliseconds at which peer sends transport window update",
+    "Period in milliseconds at which peer sends stream window update",
     "Number of subchannels in a subchannel list at picker creation time",
     "Number of READY subchannels in a subchannel list at picker creation time",
     "Number of milliseconds work serializers run for",
@@ -464,6 +490,9 @@ GlobalStats::GlobalStats()
       client_subchannels_created{0},
       server_channels_created{0},
       insecure_connections_created{0},
+      rq_connections_dropped{0},
+      rq_calls_dropped{0},
+      rq_calls_rejected{0},
       syscall_write{0},
       syscall_read{0},
       tcp_read_alloc_8k{0},
@@ -523,6 +552,37 @@ HistogramView GlobalStats::histogram(Histogram which) const {
     case Histogram::kHttp2HpackEntryLifetime:
       return HistogramView{&Histogram_1800000_40::BucketFor, kStatsTable12, 40,
                            http2_hpack_entry_lifetime.buckets()};
+    case Histogram::kHttp2HeaderTableSize:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_header_table_size.buckets()};
+    case Histogram::kHttp2InitialWindowSize:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_initial_window_size.buckets()};
+    case Histogram::kHttp2MaxConcurrentStreams:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_max_concurrent_streams.buckets()};
+    case Histogram::kHttp2MaxFrameSize:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_max_frame_size.buckets()};
+    case Histogram::kHttp2MaxHeaderListSize:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_max_header_list_size.buckets()};
+    case Histogram::kHttp2PreferredReceiveCryptoMessageSize:
+      return HistogramView{
+          &Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+          http2_preferred_receive_crypto_message_size.buckets()};
+    case Histogram::kHttp2StreamRemoteWindowUpdate:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_stream_remote_window_update.buckets()};
+    case Histogram::kHttp2TransportRemoteWindowUpdate:
+      return HistogramView{&Histogram_16777216_20::BucketFor, kStatsTable6, 20,
+                           http2_transport_remote_window_update.buckets()};
+    case Histogram::kHttp2TransportWindowUpdatePeriod:
+      return HistogramView{&Histogram_100000_20::BucketFor, kStatsTable0, 20,
+                           http2_transport_window_update_period.buckets()};
+    case Histogram::kHttp2StreamWindowUpdatePeriod:
+      return HistogramView{&Histogram_100000_20::BucketFor, kStatsTable0, 20,
+                           http2_stream_window_update_period.buckets()};
     case Histogram::kWrrSubchannelListSize:
       return HistogramView{&Histogram_10000_20::BucketFor, kStatsTable10, 20,
                            wrr_subchannel_list_size.buckets()};
@@ -601,6 +661,12 @@ std::unique_ptr<GlobalStats> GlobalStatsCollector::Collect() const {
         data.server_channels_created.load(std::memory_order_relaxed);
     result->insecure_connections_created +=
         data.insecure_connections_created.load(std::memory_order_relaxed);
+    result->rq_connections_dropped +=
+        data.rq_connections_dropped.load(std::memory_order_relaxed);
+    result->rq_calls_dropped +=
+        data.rq_calls_dropped.load(std::memory_order_relaxed);
+    result->rq_calls_rejected +=
+        data.rq_calls_rejected.load(std::memory_order_relaxed);
     result->syscall_write += data.syscall_write.load(std::memory_order_relaxed);
     result->syscall_read += data.syscall_read.load(std::memory_order_relaxed);
     result->tcp_read_alloc_8k +=
@@ -661,6 +727,23 @@ std::unique_ptr<GlobalStats> GlobalStatsCollector::Collect() const {
     data.http2_metadata_size.Collect(&result->http2_metadata_size);
     data.http2_hpack_entry_lifetime.Collect(
         &result->http2_hpack_entry_lifetime);
+    data.http2_header_table_size.Collect(&result->http2_header_table_size);
+    data.http2_initial_window_size.Collect(&result->http2_initial_window_size);
+    data.http2_max_concurrent_streams.Collect(
+        &result->http2_max_concurrent_streams);
+    data.http2_max_frame_size.Collect(&result->http2_max_frame_size);
+    data.http2_max_header_list_size.Collect(
+        &result->http2_max_header_list_size);
+    data.http2_preferred_receive_crypto_message_size.Collect(
+        &result->http2_preferred_receive_crypto_message_size);
+    data.http2_stream_remote_window_update.Collect(
+        &result->http2_stream_remote_window_update);
+    data.http2_transport_remote_window_update.Collect(
+        &result->http2_transport_remote_window_update);
+    data.http2_transport_window_update_period.Collect(
+        &result->http2_transport_window_update_period);
+    data.http2_stream_window_update_period.Collect(
+        &result->http2_stream_window_update_period);
     data.wrr_subchannel_list_size.Collect(&result->wrr_subchannel_list_size);
     data.wrr_subchannel_ready_size.Collect(&result->wrr_subchannel_ready_size);
     data.work_serializer_run_time_ms.Collect(
@@ -716,6 +799,10 @@ std::unique_ptr<GlobalStats> GlobalStats::Diff(const GlobalStats& other) const {
       server_channels_created - other.server_channels_created;
   result->insecure_connections_created =
       insecure_connections_created - other.insecure_connections_created;
+  result->rq_connections_dropped =
+      rq_connections_dropped - other.rq_connections_dropped;
+  result->rq_calls_dropped = rq_calls_dropped - other.rq_calls_dropped;
+  result->rq_calls_rejected = rq_calls_rejected - other.rq_calls_rejected;
   result->syscall_write = syscall_write - other.syscall_write;
   result->syscall_read = syscall_read - other.syscall_read;
   result->tcp_read_alloc_8k = tcp_read_alloc_8k - other.tcp_read_alloc_8k;
@@ -762,6 +849,31 @@ std::unique_ptr<GlobalStats> GlobalStats::Diff(const GlobalStats& other) const {
   result->http2_metadata_size = http2_metadata_size - other.http2_metadata_size;
   result->http2_hpack_entry_lifetime =
       http2_hpack_entry_lifetime - other.http2_hpack_entry_lifetime;
+  result->http2_header_table_size =
+      http2_header_table_size - other.http2_header_table_size;
+  result->http2_initial_window_size =
+      http2_initial_window_size - other.http2_initial_window_size;
+  result->http2_max_concurrent_streams =
+      http2_max_concurrent_streams - other.http2_max_concurrent_streams;
+  result->http2_max_frame_size =
+      http2_max_frame_size - other.http2_max_frame_size;
+  result->http2_max_header_list_size =
+      http2_max_header_list_size - other.http2_max_header_list_size;
+  result->http2_preferred_receive_crypto_message_size =
+      http2_preferred_receive_crypto_message_size -
+      other.http2_preferred_receive_crypto_message_size;
+  result->http2_stream_remote_window_update =
+      http2_stream_remote_window_update -
+      other.http2_stream_remote_window_update;
+  result->http2_transport_remote_window_update =
+      http2_transport_remote_window_update -
+      other.http2_transport_remote_window_update;
+  result->http2_transport_window_update_period =
+      http2_transport_window_update_period -
+      other.http2_transport_window_update_period;
+  result->http2_stream_window_update_period =
+      http2_stream_window_update_period -
+      other.http2_stream_window_update_period;
   result->wrr_subchannel_list_size =
       wrr_subchannel_list_size - other.wrr_subchannel_list_size;
   result->wrr_subchannel_ready_size =