grpc 1.66.0 → 1.67.0.pre1

data/src/core/resolver/dns/c_ares/grpc_ares_wrapper.cc

@@ -181,11 +181,28 @@ class GrpcAresQuery final {
   const std::string name_;
 };
 
+static absl::Status AresStatusToAbslStatus(int status,
+                                           absl::string_view error_msg) {
+  switch (status) {
+    case ARES_ECANCELLED:
+      return absl::CancelledError(error_msg);
+    case ARES_ENOTIMP:
+      return absl::UnimplementedError(error_msg);
+    case ARES_ENOTFOUND:
+      return absl::NotFoundError(error_msg);
+    case ARES_ECONNREFUSED:
+      return absl::UnavailableError(error_msg);
+    default:
+      return absl::UnknownError(error_msg);
+  }
+}
+
 static grpc_ares_ev_driver* grpc_ares_ev_driver_ref(
     grpc_ares_ev_driver* ev_driver)
     ABSL_EXCLUSIVE_LOCKS_REQUIRED(&grpc_ares_request::mu) {
-  GRPC_CARES_TRACE_LOG("request:%p Ref ev_driver %p", ev_driver->request,
-                       ev_driver);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << ev_driver->request << " Ref ev_driver "
+      << ev_driver;
   gpr_ref(&ev_driver->refs);
   return ev_driver;
 }
@@ -195,11 +212,13 @@ static void grpc_ares_complete_request_locked(grpc_ares_request* r)
 
 static void grpc_ares_ev_driver_unref(grpc_ares_ev_driver* ev_driver)
     ABSL_EXCLUSIVE_LOCKS_REQUIRED(&grpc_ares_request::mu) {
-  GRPC_CARES_TRACE_LOG("request:%p Unref ev_driver %p", ev_driver->request,
-                       ev_driver);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << ev_driver->request
+      << " Unref ev_driver " << ev_driver;
   if (gpr_unref(&ev_driver->refs)) {
-    GRPC_CARES_TRACE_LOG("request:%p destroy ev_driver %p", ev_driver->request,
-                         ev_driver);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << ev_driver->request
+        << " destroy ev_driver " << ev_driver;
     CHECK_EQ(ev_driver->fds, nullptr);
     ares_destroy(ev_driver->channel);
     grpc_ares_complete_request_locked(ev_driver->request);
@@ -209,8 +228,9 @@ static void grpc_ares_ev_driver_unref(grpc_ares_ev_driver* ev_driver)
 
 static void fd_node_destroy_locked(fd_node* fdn)
     ABSL_EXCLUSIVE_LOCKS_REQUIRED(&grpc_ares_request::mu) {
-  GRPC_CARES_TRACE_LOG("request:%p delete fd: %s", fdn->ev_driver->request,
-                       fdn->grpc_polled_fd->GetName());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << fdn->ev_driver->request
+      << " delete fd: " << fdn->grpc_polled_fd->GetName();
   CHECK(!fdn->readable_registered);
   CHECK(!fdn->writable_registered);
   CHECK(fdn->already_shutdown);
@@ -276,21 +296,21 @@ static grpc_core::Timestamp calculate_next_ares_backup_poll_alarm(
   // by the c-ares code comments.
   grpc_core::Duration until_next_ares_backup_poll_alarm =
       grpc_core::Duration::Seconds(1);
-  GRPC_CARES_TRACE_LOG(
-      "request:%p ev_driver=%p. next ares process poll time in "
-      "%" PRId64 " ms",
-      driver->request, driver, until_next_ares_backup_poll_alarm.millis());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << driver->request
+      << " ev_driver=" << driver << ". next ares process poll time in "
+      << until_next_ares_backup_poll_alarm.millis() << " ms";
   return grpc_core::Timestamp::Now() + until_next_ares_backup_poll_alarm;
 }
 
 static void on_timeout(void* arg, grpc_error_handle error) {
   grpc_ares_ev_driver* driver = static_cast<grpc_ares_ev_driver*>(arg);
   grpc_core::MutexLock lock(&driver->request->mu);
-  GRPC_CARES_TRACE_LOG(
-      "request:%p ev_driver=%p on_timeout_locked. driver->shutting_down=%d. "
-      "err=%s",
-      driver->request, driver, driver->shutting_down,
-      grpc_core::StatusToString(error).c_str());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << driver->request
+      << " ev_driver=" << driver
+      << " on_timeout_locked. driver->shutting_down=" << driver->shutting_down
+      << ". err=" << grpc_core::StatusToString(error);
   if (!driver->shutting_down && error.ok()) {
     grpc_ares_ev_driver_shutdown_locked(driver);
   }
@@ -311,20 +331,20 @@ static void grpc_ares_notify_on_event_locked(grpc_ares_ev_driver* ev_driver)
 static void on_ares_backup_poll_alarm(void* arg, grpc_error_handle error) {
   grpc_ares_ev_driver* driver = static_cast<grpc_ares_ev_driver*>(arg);
   grpc_core::MutexLock lock(&driver->request->mu);
-  GRPC_CARES_TRACE_LOG(
-      "request:%p ev_driver=%p on_ares_backup_poll_alarm_locked. "
-      "driver->shutting_down=%d. "
-      "err=%s",
-      driver->request, driver, driver->shutting_down,
-      grpc_core::StatusToString(error).c_str());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << driver->request
+      << " ev_driver=" << driver
+      << " on_ares_backup_poll_alarm_locked. driver->shutting_down="
+      << driver->shutting_down << ". err=" << grpc_core::StatusToString(error);
   if (!driver->shutting_down && error.ok()) {
     fd_node* fdn = driver->fds;
     while (fdn != nullptr) {
       if (!fdn->already_shutdown) {
-        GRPC_CARES_TRACE_LOG(
-            "request:%p ev_driver=%p on_ares_backup_poll_alarm_locked; "
-            "ares_process_fd. fd=%s",
-            driver->request, driver, fdn->grpc_polled_fd->GetName());
+        GRPC_TRACE_VLOG(cares_resolver, 2)
+            << "(c-ares resolver) request:" << driver->request
+            << " ev_driver=" << driver
+            << " on_ares_backup_poll_alarm_locked; ares_process_fd. fd="
+            << fdn->grpc_polled_fd->GetName();
         ares_socket_t as = fdn->grpc_polled_fd->GetWrappedAresSocketLocked();
         ares_process_fd(driver->channel, as, as);
       }
@@ -357,8 +377,9 @@ static void on_readable(void* arg, grpc_error_handle error) {
   grpc_ares_ev_driver* ev_driver = fdn->ev_driver;
   const ares_socket_t as = fdn->grpc_polled_fd->GetWrappedAresSocketLocked();
   fdn->readable_registered = false;
-  GRPC_CARES_TRACE_LOG("request:%p readable on %s", fdn->ev_driver->request,
-                       fdn->grpc_polled_fd->GetName());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << fdn->ev_driver->request
+      << " readable on " << fdn->grpc_polled_fd->GetName();
   if (error.ok() && !ev_driver->shutting_down) {
     ares_process_fd(ev_driver->channel, as, ARES_SOCKET_BAD);
   } else {
@@ -381,8 +402,9 @@ static void on_writable(void* arg, grpc_error_handle error) {
   grpc_ares_ev_driver* ev_driver = fdn->ev_driver;
   const ares_socket_t as = fdn->grpc_polled_fd->GetWrappedAresSocketLocked();
   fdn->writable_registered = false;
-  GRPC_CARES_TRACE_LOG("request:%p writable on %s", ev_driver->request,
-                       fdn->grpc_polled_fd->GetName());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << ev_driver->request << " writable on "
+      << fdn->grpc_polled_fd->GetName();
   if (error.ok() && !ev_driver->shutting_down) {
     ares_process_fd(ev_driver->channel, ARES_SOCKET_BAD, as);
   } else {
@@ -417,8 +439,9 @@ static void grpc_ares_notify_on_event_locked(grpc_ares_ev_driver* ev_driver)
           fdn->grpc_polled_fd =
               ev_driver->polled_fd_factory->NewGrpcPolledFdLocked(
                   socks[i], ev_driver->pollset_set);
-          GRPC_CARES_TRACE_LOG("request:%p new fd: %s", ev_driver->request,
-                               fdn->grpc_polled_fd->GetName());
+          GRPC_TRACE_VLOG(cares_resolver, 2)
+              << "(c-ares resolver) request:" << ev_driver->request
+              << " new fd: " << fdn->grpc_polled_fd->GetName();
           fdn->readable_registered = false;
           fdn->writable_registered = false;
           fdn->already_shutdown = false;
@@ -433,15 +456,16 @@ static void grpc_ares_notify_on_event_locked(grpc_ares_ev_driver* ev_driver)
           GRPC_CLOSURE_INIT(&fdn->read_closure, on_readable, fdn,
                             grpc_schedule_on_exec_ctx);
           if (fdn->grpc_polled_fd->IsFdStillReadableLocked()) {
-            GRPC_CARES_TRACE_LOG("request:%p schedule direct read on: %s",
-                                 ev_driver->request,
-                                 fdn->grpc_polled_fd->GetName());
+            GRPC_TRACE_VLOG(cares_resolver, 2)
+                << "(c-ares resolver) request:" << ev_driver->request
+                << " schedule direct read on: "
+                << fdn->grpc_polled_fd->GetName();
             grpc_core::ExecCtx::Run(DEBUG_LOCATION, &fdn->read_closure,
                                     absl::OkStatus());
           } else {
-            GRPC_CARES_TRACE_LOG("request:%p notify read on: %s",
-                                 ev_driver->request,
-                                 fdn->grpc_polled_fd->GetName());
+            GRPC_TRACE_VLOG(cares_resolver, 2)
+                << "(c-ares resolver) request:" << ev_driver->request
+                << " notify read on: " << fdn->grpc_polled_fd->GetName();
             fdn->grpc_polled_fd->RegisterForOnReadableLocked(
                 &fdn->read_closure);
           }
@@ -451,9 +475,9 @@ static void grpc_ares_notify_on_event_locked(grpc_ares_ev_driver* ev_driver)
         // has not been registered with this socket.
         if (ARES_GETSOCK_WRITABLE(socks_bitmask, i) &&
             !fdn->writable_registered) {
-          GRPC_CARES_TRACE_LOG("request:%p notify write on: %s",
-                               ev_driver->request,
-                               fdn->grpc_polled_fd->GetName());
+          GRPC_TRACE_VLOG(cares_resolver, 2)
+              << "(c-ares resolver) request:" << ev_driver->request
+              << " notify write on: " << fdn->grpc_polled_fd->GetName();
           grpc_ares_ev_driver_ref(ev_driver);
           GRPC_CLOSURE_INIT(&fdn->write_closure, on_writable, fdn,
                             grpc_schedule_on_exec_ctx);
@@ -489,10 +513,11 @@ void grpc_ares_ev_driver_start_locked(grpc_ares_ev_driver* ev_driver)
       ev_driver->query_timeout_ms == 0
           ? grpc_core::Duration::Infinity()
           : grpc_core::Duration::Milliseconds(ev_driver->query_timeout_ms);
-  GRPC_CARES_TRACE_LOG(
-      "request:%p ev_driver=%p grpc_ares_ev_driver_start_locked. timeout in "
-      "%" PRId64 " ms",
-      ev_driver->request, ev_driver, timeout.millis());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << ev_driver->request
+      << " ev_driver=" << ev_driver
+      << " grpc_ares_ev_driver_start_locked. timeout in " << timeout.millis()
+      << " ms";
   grpc_ares_ev_driver_ref(ev_driver);
   GRPC_CLOSURE_INIT(&ev_driver->on_timeout_locked, on_timeout, ev_driver,
                     grpc_schedule_on_exec_ctx);
@@ -531,7 +556,8 @@ grpc_error_handle grpc_ares_ev_driver_create_locked(
   }
   int status = ares_init_options(&(*ev_driver)->channel, &opts, ARES_OPT_FLAGS);
   grpc_ares_test_only_inject_config(&(*ev_driver)->channel);
-  GRPC_CARES_TRACE_LOG("request:%p grpc_ares_ev_driver_create_locked", request);
+  GRPC_TRACE_VLOG(cares_resolver, 2) << "(c-ares resolver) request:" << request
+                                     << " grpc_ares_ev_driver_create_locked";
   if (status != ARES_SUCCESS) {
     grpc_error_handle err = GRPC_ERROR_CREATE(absl::StrCat(
         "Failed to init ares channel. C-ares error: ", ares_strerror(status)));
@@ -629,10 +655,10 @@ static grpc_ares_hostbyname_request* create_hostbyname_request_locked(
     grpc_ares_request* parent_request, const char* host, uint16_t port,
     bool is_balancer, const char* qtype)
     ABSL_EXCLUSIVE_LOCKS_REQUIRED(parent_request->mu) {
-  GRPC_CARES_TRACE_LOG(
-      "request:%p create_hostbyname_request_locked host:%s port:%d "
-      "is_balancer:%d qtype:%s",
-      parent_request, host, port, is_balancer, qtype);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << parent_request
+      << " create_hostbyname_request_locked host:" << host << " port:" << port
+      << " is_balancer:" << is_balancer << " qtype:" << qtype;
   grpc_ares_hostbyname_request* hr = new grpc_ares_hostbyname_request();
   hr->parent_request = parent_request;
   hr->host = gpr_strdup(host);
@@ -659,9 +685,10 @@ static void on_hostbyname_done_locked(void* arg, int status, int /*timeouts*/,
       static_cast<grpc_ares_hostbyname_request*>(arg);
   grpc_ares_request* r = hr->parent_request;
   if (status == ARES_SUCCESS) {
-    GRPC_CARES_TRACE_LOG(
-        "request:%p on_hostbyname_done_locked qtype=%s host=%s ARES_SUCCESS", r,
-        hr->qtype, hr->host);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " on_hostbyname_done_locked qtype=" << hr->qtype
+        << " host=" << hr->host << " ARES_SUCCESS";
     std::unique_ptr<EndpointAddressesList>* address_list_ptr =
         hr->is_balancer ? r->balancer_addresses_out : r->addresses_out;
     if (*address_list_ptr == nullptr) {
@@ -685,10 +712,11 @@ static void on_hostbyname_done_locked(void* arg, int status, int /*timeouts*/,
           addr->sin6_port = hr->port;
           char output[INET6_ADDRSTRLEN];
           ares_inet_ntop(AF_INET6, &addr->sin6_addr, output, INET6_ADDRSTRLEN);
-          GRPC_CARES_TRACE_LOG(
-              "request:%p c-ares resolver gets a AF_INET6 result: \n"
-              "  addr: %s\n  port: %d\n  sin6_scope_id: %d\n",
-              r, output, ntohs(hr->port), addr->sin6_scope_id);
+          GRPC_TRACE_VLOG(cares_resolver, 2)
+              << "(c-ares resolver) request:" << r
+              << " c-ares resolver gets a AF_INET6 result: \n"
+              << "  addr: " << output << "\n  port: " << ntohs(hr->port)
+              << "\n  sin6_scope_id: " << addr->sin6_scope_id << "\n";
           break;
         }
         case AF_INET: {
@@ -700,10 +728,10 @@ static void on_hostbyname_done_locked(void* arg, int status, int /*timeouts*/,
           addr->sin_port = hr->port;
           char output[INET_ADDRSTRLEN];
           ares_inet_ntop(AF_INET, &addr->sin_addr, output, INET_ADDRSTRLEN);
-          GRPC_CARES_TRACE_LOG(
-              "request:%p c-ares resolver gets a AF_INET result: \n"
-              "  addr: %s\n  port: %d\n",
-              r, output, ntohs(hr->port));
+          GRPC_TRACE_VLOG(cares_resolver, 2)
+              << "(c-ares resolver) request:" << r
+              << " c-ares resolver gets a AF_INET result: \n  addr: " << output
+              << "\n  port: " << ntohs(hr->port) << "\n";
           break;
         }
       }
@@ -713,10 +741,11 @@ static void on_hostbyname_done_locked(void* arg, int status, int /*timeouts*/,
     std::string error_msg = absl::StrFormat(
         "C-ares status is not ARES_SUCCESS qtype=%s name=%s is_balancer=%d: %s",
         hr->qtype, hr->host, hr->is_balancer, ares_strerror(status));
-    GRPC_CARES_TRACE_LOG("request:%p on_hostbyname_done_locked: %s", r,
-                         error_msg.c_str());
-    grpc_error_handle error = GRPC_ERROR_CREATE(error_msg);
-    r->error = grpc_error_add_child(error, r->error);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " on_hostbyname_done_locked: " << error_msg;
+    r->error = grpc_error_add_child(AresStatusToAbslStatus(status, error_msg),
+                                    r->error);
   }
   destroy_hostbyname_request_locked(hr);
 }
@@ -729,13 +758,14 @@ static void on_srv_query_done_locked(void* arg, int status, int /*timeouts*/,
   GrpcAresQuery* q = static_cast<GrpcAresQuery*>(arg);
   grpc_ares_request* r = q->parent_request();
   if (status == ARES_SUCCESS) {
-    GRPC_CARES_TRACE_LOG(
-        "request:%p on_srv_query_done_locked name=%s ARES_SUCCESS", r,
-        q->name().c_str());
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " on_srv_query_done_locked name=" << q->name() << " ARES_SUCCESS";
     struct ares_srv_reply* reply;
     const int parse_status = ares_parse_srv_reply(abuf, alen, &reply);
-    GRPC_CARES_TRACE_LOG("request:%p ares_parse_srv_reply: %d", r,
-                         parse_status);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " ares_parse_srv_reply: " << parse_status;
     if (parse_status == ARES_SUCCESS) {
       for (struct ares_srv_reply* srv_it = reply; srv_it != nullptr;
            srv_it = srv_it->next) {
@@ -759,10 +789,11 @@ static void on_srv_query_done_locked(void* arg, int status, int /*timeouts*/,
     std::string error_msg = absl::StrFormat(
         "C-ares status is not ARES_SUCCESS qtype=SRV name=%s: %s", q->name(),
         ares_strerror(status));
-    GRPC_CARES_TRACE_LOG("request:%p on_srv_query_done_locked: %s", r,
-                         error_msg.c_str());
-    grpc_error_handle error = GRPC_ERROR_CREATE(error_msg);
-    r->error = grpc_error_add_child(error, r->error);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " on_srv_query_done_locked: " << error_msg;
+    r->error = grpc_error_add_child(AresStatusToAbslStatus(status, error_msg),
+                                    r->error);
   }
   delete q;
 }
@@ -780,10 +811,10 @@ static void on_txt_done_locked(void* arg, int status, int /*timeouts*/,
   const size_t prefix_len = sizeof(g_service_config_attribute_prefix) - 1;
   struct ares_txt_ext* result = nullptr;
   struct ares_txt_ext* reply = nullptr;
-  grpc_error_handle error;
   if (status != ARES_SUCCESS) goto fail;
-  GRPC_CARES_TRACE_LOG("request:%p on_txt_done_locked name=%s ARES_SUCCESS", r,
-                       q->name().c_str());
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << r
+      << " on_txt_done_locked name=" << q->name() << " ARES_SUCCESS";
   status = ares_parse_txt_reply_ext(buf, len, &reply);
   if (status != ARES_SUCCESS) goto fail;
   // Find service config in TXT record.
@@ -811,8 +842,9 @@ static void on_txt_done_locked(void* arg, int status, int /*timeouts*/,
       service_config_len += result->length;
     }
     (*r->service_config_json_out)[service_config_len] = '\0';
-    GRPC_CARES_TRACE_LOG("request:%p found service config: %s", r,
-                         *r->service_config_json_out);
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r
+        << " found service config: " << *r->service_config_json_out;
   }
   // Clean up.
   ares_free_data(reply);
@@ -822,18 +854,19 @@ fail:
   std::string error_msg =
       absl::StrFormat("C-ares status is not ARES_SUCCESS qtype=TXT name=%s: %s",
                       q->name(), ares_strerror(status));
-  GRPC_CARES_TRACE_LOG("request:%p on_txt_done_locked %s", r,
-                       error_msg.c_str());
-  error = GRPC_ERROR_CREATE(error_msg);
-  r->error = grpc_error_add_child(error, r->error);
+  GRPC_TRACE_VLOG(cares_resolver, 2) << "(c-ares resolver) request:" << r
+                                     << " on_txt_done_locked " << error_msg;
+  r->error =
+      grpc_error_add_child(AresStatusToAbslStatus(status, error_msg), r->error);
 }
 
 grpc_error_handle set_request_dns_server(grpc_ares_request* r,
                                          absl::string_view dns_server)
     ABSL_EXCLUSIVE_LOCKS_REQUIRED(r->mu) {
   if (!dns_server.empty()) {
-    GRPC_CARES_TRACE_LOG("request:%p Using DNS server %s", r,
-                         dns_server.data());
+    GRPC_TRACE_VLOG(cares_resolver, 2)
+        << "(c-ares resolver) request:" << r << " Using DNS server "
+        << dns_server.data();
     grpc_resolved_address addr;
     if (grpc_parse_ipv4_hostport(dns_server, &addr, /*log_errors=*/false)) {
       r->dns_server_addr.family = AF_INET;
@@ -1028,10 +1061,10 @@ static grpc_ares_request* grpc_dns_lookup_hostname_ares_impl(
   r->ev_driver = nullptr;
   r->on_done = on_done;
   r->addresses_out = addrs;
-  GRPC_CARES_TRACE_LOG(
-      "request:%p c-ares grpc_dns_lookup_hostname_ares_impl name=%s, "
-      "default_port=%s",
-      r, name, default_port);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << r
+      << " c-ares grpc_dns_lookup_hostname_ares_impl name=" << name
+      << ", default_port=" << default_port;
   // Early out if the target is an ipv4 or ipv6 literal.
   if (resolve_as_ip_literal_locked(name, default_port, addrs)) {
     grpc_ares_complete_request_locked(r);
@@ -1082,8 +1115,9 @@ grpc_ares_request* grpc_dns_lookup_srv_ares_impl(
   r->ev_driver = nullptr;
   r->on_done = on_done;
   r->balancer_addresses_out = balancer_addresses;
-  GRPC_CARES_TRACE_LOG(
-      "request:%p c-ares grpc_dns_lookup_srv_ares_impl name=%s", r, name);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << r
+      << " c-ares grpc_dns_lookup_srv_ares_impl name=" << name;
   grpc_error_handle error;
   // Don't query for SRV records if the target is "localhost"
   if (target_matches_localhost(name)) {
@@ -1120,8 +1154,9 @@ grpc_ares_request* grpc_dns_lookup_txt_ares_impl(
   r->ev_driver = nullptr;
   r->on_done = on_done;
   r->service_config_json_out = service_config_json;
-  GRPC_CARES_TRACE_LOG(
-      "request:%p c-ares grpc_dns_lookup_txt_ares_impl name=%s", r, name);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << r
+      << " c-ares grpc_dns_lookup_txt_ares_impl name=" << name;
   grpc_error_handle error;
   // Don't query for TXT records if the target is "localhost"
   if (target_matches_localhost(name)) {
@@ -1170,8 +1205,9 @@ grpc_ares_request* (*grpc_dns_lookup_txt_ares)(
 static void grpc_cancel_ares_request_impl(grpc_ares_request* r) {
   CHECK_NE(r, nullptr);
   grpc_core::MutexLock lock(&r->mu);
-  GRPC_CARES_TRACE_LOG("request:%p grpc_cancel_ares_request ev_driver:%p", r,
-                       r->ev_driver);
+  GRPC_TRACE_VLOG(cares_resolver, 2)
+      << "(c-ares resolver) request:" << r
+      << " grpc_cancel_ares_request ev_driver:" << r->ev_driver;
   if (r->ev_driver != nullptr) {
     grpc_ares_ev_driver_shutdown_locked(r->ev_driver);
   }

data/src/core/resolver/dns/c_ares/grpc_ares_wrapper.h

@@ -39,13 +39,6 @@
 
 #define GRPC_DNS_ARES_DEFAULT_QUERY_TIMEOUT_MS 120000
 
-#define GRPC_CARES_TRACE_LOG(format, ...)                                      \
-  do {                                                                         \
-    if (GRPC_TRACE_FLAG_ENABLED(cares_resolver)) {                             \
-      VLOG(2) << "(c-ares resolver) " << absl::StrFormat(format, __VA_ARGS__); \
-    }                                                                          \
-  } while (0)
-
 typedef struct grpc_ares_ev_driver grpc_ares_ev_driver;
 
 struct grpc_ares_request {

data/src/core/resolver/dns/dns_resolver_plugin.cc

@@ -18,7 +18,6 @@
 #include "absl/log/log.h"
 #include "absl/strings/match.h"
 
-#include <grpc/support/log.h>
 #include <grpc/support/port_platform.h>
 
 #include "src/core/lib/config/config_vars.h"

data/src/core/resolver/dns/event_engine/event_engine_client_channel_resolver.cc

@@ -77,12 +77,6 @@ using grpc_event_engine::experimental::EventEngine;
 // TODO(hork): Add a test that checks for proper authority from balancer
 // addresses.
 
-#define GRPC_EVENT_ENGINE_RESOLVER_TRACE(format, ...)                  \
-  if (GRPC_TRACE_FLAG_ENABLED(event_engine_client_channel_resolver)) { \
-    VLOG(2) << "(event_engine client channel resolver) "               \
-            << absl::StrFormat(format, __VA_ARGS__);                   \
-  }
-
 // ----------------------------------------------------------------------------
 // EventEngineClientChannelDNSResolver
 // ----------------------------------------------------------------------------
@@ -221,9 +215,10 @@ EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
       event_engine_resolver_(std::move(event_engine_resolver)) {
   // Locking to prevent completion before all records are queried
   MutexLock lock(&on_resolved_mu_);
-  GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-      "DNSResolver::%p Starting hostname resolution for %s", resolver_.get(),
-      resolver_->name_to_resolve().c_str());
+  GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+      << "(event_engine client channel resolver) DNSResolver::"
+      << resolver_.get() << " Starting hostname resolution for "
+      << resolver_->name_to_resolve();
   is_hostname_inflight_ = true;
   event_engine_resolver_->LookupHostname(
       [self = Ref(DEBUG_LOCATION, "OnHostnameResolved")](
@@ -236,9 +231,10 @@ EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
       },
       resolver_->name_to_resolve(), kDefaultSecurePort);
   if (resolver_->enable_srv_queries_) {
-    GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-        "DNSResolver::%p Starting SRV record resolution for %s",
-        resolver_.get(), resolver_->name_to_resolve().c_str());
+    GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+        << "(event_engine client channel resolver) DNSResolver::"
+        << resolver_.get() << " Starting SRV record resolution for "
+        << resolver_->name_to_resolve();
     is_srv_inflight_ = true;
     event_engine_resolver_->LookupSRV(
         [self = Ref(DEBUG_LOCATION, "OnSRVResolved")](
@@ -252,9 +248,10 @@ EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
         absl::StrCat("_grpclb._tcp.", resolver_->name_to_resolve()));
   }
   if (resolver_->request_service_config_) {
-    GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-        "DNSResolver::%p Starting TXT record resolution for %s",
-        resolver_.get(), resolver_->name_to_resolve().c_str());
+    GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+        << "(event_engine client channel resolver) DNSResolver::"
+        << resolver_.get() << " Starting TXT record resolution for "
+        << resolver_->name_to_resolve();
     is_txt_inflight_ = true;
     event_engine_resolver_->LookupTXT(
         [self = Ref(DEBUG_LOCATION, "OnTXTResolved")](
@@ -303,8 +300,9 @@ void EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
 void EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
     OnTimeout() {
   MutexLock lock(&on_resolved_mu_);
-  GRPC_EVENT_ENGINE_RESOLVER_TRACE("DNSResolver::%p OnTimeout",
-                                   resolver_.get());
+  GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+      << "(event_engine client channel resolver) DNSResolver::"
+      << resolver_.get() << " OnTimeout";
   timeout_handle_.reset();
   event_engine_resolver_.reset();
 }
@@ -368,9 +366,10 @@ void EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
   }
   // Do a subsequent hostname query since SRV records were returned
   for (auto& srv_record : *srv_records) {
-    GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-        "DNSResolver::%p Starting balancer hostname resolution for %s:%d",
-        resolver_.get(), srv_record.host.c_str(), srv_record.port);
+    GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+        << "(event_engine client channel resolver) DNSResolver::"
+        << resolver_.get() << " Starting balancer hostname resolution for "
+        << srv_record.host << ":" << srv_record.port;
     ++number_of_balancer_hostnames_initiated_;
     event_engine_resolver_->LookupHostname(
         [host = srv_record.host,
@@ -446,9 +445,10 @@ void EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
         // Found a service config record.
         service_config_json_ =
             result->substr(kServiceConfigAttributePrefix.size());
-        GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-            "DNSResolver::%p found service config: %s",
-            event_engine_resolver_.get(), service_config_json_->c_str());
+        GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+            << "(event_engine client channel resolver) DNSResolver::"
+            << event_engine_resolver_.get()
+            << " found service config: " << service_config_json_->c_str();
       } else {
         service_config_json_ = absl::UnavailableError(absl::StrCat(
             "failed to find attribute prefix: ", kServiceConfigAttributePrefix,
@@ -492,9 +492,10 @@ void EventEngineClientChannelDNSResolver::EventEngineDNSRequestWrapper::
     return;
   }
   if (service_config->empty()) return;
-  GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-      "DNSResolver::%p selected service config choice: %s",
-      event_engine_resolver_.get(), service_config->c_str());
+  GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+      << "(event_engine client channel resolver) DNSResolver::"
+      << event_engine_resolver_.get()
+      << " selected service config choice: " << service_config->c_str();
   result->service_config =
       ServiceConfigImpl::Create(resolver_->channel_args(), *service_config);
   if (!result->service_config.ok()) {
@@ -511,20 +512,19 @@ absl::optional<Resolver::Result> EventEngineClientChannelDNSResolver::
   if (is_hostname_inflight_ || is_srv_inflight_ || is_txt_inflight_ ||
       number_of_balancer_hostnames_resolved_ !=
           number_of_balancer_hostnames_initiated_) {
-    GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-        "DNSResolver::%p OnResolved() waiting for results (hostname: %s, "
-        "srv: %s, "
-        "txt: %s, "
-        "balancer addresses: %" PRIuPTR "/%" PRIuPTR " complete",
-        this, is_hostname_inflight_ ? "waiting" : "done",
-        is_srv_inflight_ ? "waiting" : "done",
-        is_txt_inflight_ ? "waiting" : "done",
-        number_of_balancer_hostnames_resolved_,
-        number_of_balancer_hostnames_initiated_);
+    GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+        << "(event_engine client channel resolver) DNSResolver::" << this
+        << " OnResolved() waiting for results (hostname: "
+        << (is_hostname_inflight_ ? "waiting" : "done")
+        << ", srv: " << (is_srv_inflight_ ? "waiting" : "done")
+        << ", txt: " << (is_txt_inflight_ ? "waiting" : "done")
+        << ", balancer addresses: " << number_of_balancer_hostnames_resolved_
+        << "/" << number_of_balancer_hostnames_initiated_ << " complete";
     return absl::nullopt;
   }
-  GRPC_EVENT_ENGINE_RESOLVER_TRACE(
-      "DNSResolver::%p OnResolvedLocked() proceeding", this);
+  GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+      << "(event_engine client channel resolver) DNSResolver::" << this
+      << " OnResolvedLocked() proceeding";
   Resolver::Result result;
   result.args = resolver_->channel_args();
   // If both addresses and balancer addresses failed, return an error for both
@@ -538,7 +538,8 @@ absl::optional<Resolver::Result> EventEngineClientChannelDNSResolver::
       // return an error. Validation errors may be empty.
       status = absl::UnavailableError("No results from DNS queries");
     }
-    GRPC_EVENT_ENGINE_RESOLVER_TRACE("%s", status.message().data());
+    GRPC_TRACE_VLOG(event_engine_client_channel_resolver, 2)
+        << "(event_engine client channel resolver) " << status.message().data();
     result.addresses = status;
     result.service_config = status;
     return std::move(result);