grpc 1.64.0 → 1.65.0.pre2

data/src/core/load_balancing/xds/cds.cc

@@ -49,10 +49,6 @@
 #include "src/core/lib/gprpp/unique_type_name.h"
 #include "src/core/lib/gprpp/work_serializer.h"
 #include "src/core/lib/iomgr/pollset_set.h"
-#include "src/core/lib/json/json.h"
-#include "src/core/lib/json/json_args.h"
-#include "src/core/lib/json/json_object_loader.h"
-#include "src/core/lib/json/json_writer.h"
 #include "src/core/load_balancing/address_filtering.h"
 #include "src/core/load_balancing/delegating_helper.h"
 #include "src/core/load_balancing/lb_policy.h"
@@ -61,14 +57,16 @@
 #include "src/core/load_balancing/outlier_detection/outlier_detection.h"
 #include "src/core/load_balancing/xds/xds_channel_args.h"
 #include "src/core/resolver/xds/xds_dependency_manager.h"
+#include "src/core/util/json/json.h"
+#include "src/core/util/json/json_args.h"
+#include "src/core/util/json/json_object_loader.h"
+#include "src/core/util/json/json_writer.h"
 #include "src/core/xds/grpc/xds_cluster.h"
 #include "src/core/xds/grpc/xds_common_types.h"
 #include "src/core/xds/grpc/xds_health_status.h"
 
 namespace grpc_core {
 
-TraceFlag grpc_cds_lb_trace(false, "cds_lb");
-
 namespace {
 
 // TODO(roth): Remove this after the 1.63 release.
@@ -185,19 +183,19 @@ class CdsLb final : public LoadBalancingPolicy {
 //
 
 CdsLb::CdsLb(Args args) : LoadBalancingPolicy(std::move(args)) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] created", this);
   }
 }
 
 CdsLb::~CdsLb() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] destroying cds LB policy", this);
   }
 }
 
 void CdsLb::ShutdownLocked() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] shutting down", this);
   }
   shutting_down_ = true;
@@ -282,7 +280,7 @@ class PriorityEndpointIterator final : public EndpointAddressesIterator {
 absl::Status CdsLb::UpdateLocked(UpdateArgs args) {
   // Get new config.
   auto new_config = args.config.TakeAsSubclass<CdsLbConfig>();
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] received update: cluster=%s is_dynamic=%d",
             this, new_config->cluster().c_str(), new_config->is_dynamic());
   }
@@ -296,7 +294,7 @@ absl::Status CdsLb::UpdateLocked(UpdateArgs args) {
   }
   // Start dynamic subscription if needed.
   if (new_config->is_dynamic() && subscription_ == nullptr) {
-    if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+    if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
       gpr_log(GPR_INFO,
               "[cdslb %p] obtaining dynamic subscription for cluster %s", this,
               cluster_name_.c_str());
@@ -327,7 +325,7 @@ absl::Status CdsLb::UpdateLocked(UpdateArgs args) {
       // If we are already subscribed, it's possible that we just
       // recently subscribed but another update came through before we
       // got the new cluster, in which case it will still be missing.
-      if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+      if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
         gpr_log(GPR_INFO,
                 "[cdslb %p] xDS config has no entry for dynamic cluster %s, "
                 "waiting for subsequent update",
@@ -454,7 +452,7 @@ absl::Status CdsLb::UpdateLocked(UpdateArgs args) {
     }
     grpc_pollset_set_add_pollset_set(child_policy_->interested_parties(),
                                      interested_parties());
-    if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+    if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
       gpr_log(GPR_INFO, "[cdslb %p] created child policy %s (%p)", this,
               std::string((*child_config)->name()).c_str(),
               child_policy_.get());
@@ -664,7 +662,7 @@ Json CdsLb::CreateChildPolicyConfigForLeafCluster(
       {"outlier_detection_experimental",
        Json::FromObject(std::move(outlier_detection_config))},
   })});
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] generated config for child policy: %s", this,
             JsonDump(outlier_detection_policy, /*indent=*/1).c_str());
   }
@@ -697,7 +695,7 @@ Json CdsLb::CreateChildPolicyConfigForAggregateCluster(
            {"priorities", Json::FromArray(std::move(priority_priorities))},
        })},
   })});
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] generated config for child policy: %s", this,
             JsonDump(json, /*indent=*/1).c_str());
   }
@@ -716,7 +714,7 @@ void CdsLb::ResetState() {
 }
 
 void CdsLb::ReportTransientFailure(absl::Status status) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_cds_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(cds_lb)) {
     gpr_log(GPR_INFO, "[cdslb %p] reporting TRANSIENT_FAILURE: %s", this,
             status.ToString().c_str());
   }

data/src/core/load_balancing/xds/xds_cluster_impl.cc

@@ -38,7 +38,6 @@
 #include <grpc/support/port_platform.h>
 
 #include "src/core/client_channel/client_channel_internal.h"
-#include "src/core/lib/channel/call_tracer.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/config/core_configuration.h"
 #include "src/core/lib/debug/trace.h"
@@ -52,9 +51,6 @@
 #include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/lib/iomgr/pollset_set.h"
 #include "src/core/lib/iomgr/resolved_address.h"
-#include "src/core/lib/json/json.h"
-#include "src/core/lib/json/json_args.h"
-#include "src/core/lib/json/json_object_loader.h"
 #include "src/core/lib/security/credentials/xds/xds_credentials.h"
 #include "src/core/lib/transport/connectivity_state.h"
 #include "src/core/load_balancing/backend_metric_data.h"
@@ -67,6 +63,10 @@
 #include "src/core/load_balancing/xds/xds_channel_args.h"
 #include "src/core/resolver/endpoint_addresses.h"
 #include "src/core/resolver/xds/xds_dependency_manager.h"
+#include "src/core/telemetry/call_tracer.h"
+#include "src/core/util/json/json.h"
+#include "src/core/util/json/json_args.h"
+#include "src/core/util/json/json_object_loader.h"
 #include "src/core/xds/grpc/xds_bootstrap_grpc.h"
 #include "src/core/xds/grpc/xds_client_grpc.h"
 #include "src/core/xds/grpc/xds_endpoint.h"
@@ -76,8 +76,6 @@
 
 namespace grpc_core {
 
-TraceFlag grpc_xds_cluster_impl_lb_trace(false, "xds_cluster_impl_lb");
-
 namespace {
 
 using XdsConfig = XdsDependencyManager::XdsConfig;
@@ -397,7 +395,7 @@ XdsClusterImplLb::Picker::Picker(XdsClusterImplLb* xds_cluster_impl_lb,
       drop_config_(xds_cluster_impl_lb->drop_config_),
       drop_stats_(xds_cluster_impl_lb->drop_stats_),
       picker_(std::move(picker)) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_impl_lb %p] constructed new picker %p",
             xds_cluster_impl_lb, this);
   }
@@ -479,14 +477,14 @@ LoadBalancingPolicy::PickResult XdsClusterImplLb::Picker::Pick(
 XdsClusterImplLb::XdsClusterImplLb(RefCountedPtr<GrpcXdsClient> xds_client,
                                    Args args)
     : LoadBalancingPolicy(std::move(args)), xds_client_(std::move(xds_client)) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_impl_lb %p] created -- using xds client %p",
             this, xds_client_.get());
   }
 }
 
 XdsClusterImplLb::~XdsClusterImplLb() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_impl_lb %p] destroying xds_cluster_impl LB policy",
             this);
@@ -494,7 +492,7 @@ XdsClusterImplLb::~XdsClusterImplLb() {
 }
 
 void XdsClusterImplLb::ShutdownLocked() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_impl_lb %p] shutting down", this);
   }
   shutting_down_ = true;
@@ -517,7 +515,7 @@ void XdsClusterImplLb::ResetState() {
 }
 
 void XdsClusterImplLb::ReportTransientFailure(absl::Status status) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_impl_lb %p] reporting TRANSIENT_FAILURE: %s", this,
             status.ToString().c_str());
@@ -545,7 +543,7 @@ std::string GetEdsResourceName(const XdsClusterResource& cluster_resource) {
 }
 
 absl::Status XdsClusterImplLb::UpdateLocked(UpdateArgs args) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_impl_lb %p] Received update", this);
   }
   // Grab new LB policy config.
@@ -707,7 +705,7 @@ void XdsClusterImplLb::MaybeUpdatePickerLocked() {
   // whether) the child has reported.
   if (drop_config_ != nullptr && drop_config_->drop_all()) {
     auto drop_picker = MakeRefCounted<Picker>(this, picker_);
-    if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+    if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
       gpr_log(GPR_INFO,
               "[xds_cluster_impl_lb %p] updating connectivity (drop all): "
               "state=READY picker=%p",
@@ -720,7 +718,7 @@ void XdsClusterImplLb::MaybeUpdatePickerLocked() {
   // Otherwise, update only if we have a child picker.
   if (picker_ != nullptr) {
     auto drop_picker = MakeRefCounted<Picker>(this, picker_);
-    if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+    if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
       gpr_log(GPR_INFO,
               "[xds_cluster_impl_lb %p] updating connectivity: state=%s "
               "status=(%s) picker=%p",
@@ -741,8 +739,8 @@ OrphanablePtr<LoadBalancingPolicy> XdsClusterImplLb::CreateChildPolicyLocked(
       RefAsSubclass<XdsClusterImplLb>(DEBUG_LOCATION, "Helper"));
   OrphanablePtr<LoadBalancingPolicy> lb_policy =
       MakeOrphanable<ChildPolicyHandler>(std::move(lb_policy_args),
-                                         &grpc_xds_cluster_impl_lb_trace);
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+                                         &xds_cluster_impl_lb_trace);
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_impl_lb %p] Created new child policy handler %p",
             this, lb_policy.get());
@@ -770,7 +768,7 @@ absl::Status XdsClusterImplLb::UpdateChildPolicyLocked(
   update_args.args =
       args.Set(GRPC_ARG_XDS_CLUSTER_NAME, config_->cluster_name());
   // Update the policy.
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_impl_lb %p] Updating child policy handler %p", this,
             child_policy_.get());
@@ -825,7 +823,7 @@ void XdsClusterImplLb::Helper::UpdateState(
     grpc_connectivity_state state, const absl::Status& status,
     RefCountedPtr<SubchannelPicker> picker) {
   if (parent()->shutting_down_) return;
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_impl_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_impl_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_impl_lb %p] child connectivity state update: "
             "state=%s (%s) picker=%p",

data/src/core/load_balancing/xds/xds_cluster_manager.cc

@@ -49,9 +49,6 @@
 #include "src/core/lib/gprpp/work_serializer.h"
 #include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/iomgr/pollset_set.h"
-#include "src/core/lib/json/json.h"
-#include "src/core/lib/json/json_args.h"
-#include "src/core/lib/json/json_object_loader.h"
 #include "src/core/lib/transport/connectivity_state.h"
 #include "src/core/load_balancing/child_policy_handler.h"
 #include "src/core/load_balancing/delegating_helper.h"
@@ -60,11 +57,12 @@
 #include "src/core/load_balancing/lb_policy_registry.h"
 #include "src/core/resolver/endpoint_addresses.h"
 #include "src/core/resolver/xds/xds_resolver_attributes.h"
+#include "src/core/util/json/json.h"
+#include "src/core/util/json/json_args.h"
+#include "src/core/util/json/json_object_loader.h"
 
 namespace grpc_core {
 
-TraceFlag grpc_xds_cluster_manager_lb_trace(false, "xds_cluster_manager_lb");
-
 namespace {
 
 using ::grpc_event_engine::experimental::EventEngine;
@@ -251,7 +249,7 @@ XdsClusterManagerLb::XdsClusterManagerLb(Args args)
     : LoadBalancingPolicy(std::move(args)) {}
 
 XdsClusterManagerLb::~XdsClusterManagerLb() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(
         GPR_INFO,
         "[xds_cluster_manager_lb %p] destroying xds_cluster_manager LB policy",
@@ -260,7 +258,7 @@ XdsClusterManagerLb::~XdsClusterManagerLb() {
 }
 
 void XdsClusterManagerLb::ShutdownLocked() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_manager_lb %p] shutting down", this);
   }
   shutting_down_ = true;
@@ -277,7 +275,7 @@ void XdsClusterManagerLb::ResetBackoffLocked() {
 
 absl::Status XdsClusterManagerLb::UpdateLocked(UpdateArgs args) {
   if (shutting_down_) return absl::OkStatus();
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_manager_lb %p] Received update", this);
   }
   update_in_progress_ = true;
@@ -370,7 +368,7 @@ void XdsClusterManagerLb::UpdateStateLocked() {
   } else {
     connectivity_state = GRPC_CHANNEL_TRANSIENT_FAILURE;
   }
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO, "[xds_cluster_manager_lb %p] connectivity changed to %s",
             this, ConnectivityStateName(connectivity_state));
   }
@@ -380,7 +378,7 @@ void XdsClusterManagerLb::UpdateStateLocked() {
     RefCountedPtr<SubchannelPicker>& child_picker = cluster_map[cluster_name];
     child_picker = children_[cluster_name]->picker();
     if (child_picker == nullptr) {
-      if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+      if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
         gpr_log(GPR_INFO,
                 "[xds_cluster_manager_lb %p] child %s has not yet returned a "
                 "picker; creating a QueuePicker.",
@@ -410,7 +408,7 @@ XdsClusterManagerLb::ClusterChild::ClusterChild(
     : xds_cluster_manager_policy_(std::move(xds_cluster_manager_policy)),
       name_(name),
       picker_(MakeRefCounted<QueuePicker>(nullptr)) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_manager_lb %p] created ClusterChild %p for %s",
             xds_cluster_manager_policy_.get(), this, name_.c_str());
@@ -418,7 +416,7 @@ XdsClusterManagerLb::ClusterChild::ClusterChild(
 }
 
 XdsClusterManagerLb::ClusterChild::~ClusterChild() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_manager_lb %p] ClusterChild %p: destroying "
             "child",
@@ -428,7 +426,7 @@ XdsClusterManagerLb::ClusterChild::~ClusterChild() {
 }
 
 void XdsClusterManagerLb::ClusterChild::Orphan() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_manager_lb %p] ClusterChild %p %s: "
             "shutting down child",
@@ -463,8 +461,8 @@ XdsClusterManagerLb::ClusterChild::CreateChildPolicyLocked(
       std::make_unique<Helper>(this->Ref(DEBUG_LOCATION, "Helper"));
   OrphanablePtr<LoadBalancingPolicy> lb_policy =
       MakeOrphanable<ChildPolicyHandler>(std::move(lb_policy_args),
-                                         &grpc_xds_cluster_manager_lb_trace);
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+                                         &xds_cluster_manager_lb_trace);
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_manager_lb %p] ClusterChild %p %s: Created "
             "new child "
@@ -504,7 +502,7 @@ absl::Status XdsClusterManagerLb::ClusterChild::UpdateLocked(
   update_args.addresses = addresses;
   update_args.args = args;
   // Update the policy.
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(GPR_INFO,
             "[xds_cluster_manager_lb %p] ClusterChild %p %s: "
             "Updating child "
@@ -558,7 +556,7 @@ void XdsClusterManagerLb::ClusterChild::OnDelayedRemovalTimerLocked() {
 void XdsClusterManagerLb::ClusterChild::Helper::UpdateState(
     grpc_connectivity_state state, const absl::Status& status,
     RefCountedPtr<SubchannelPicker> picker) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_xds_cluster_manager_lb_trace)) {
+  if (GRPC_TRACE_FLAG_ENABLED(xds_cluster_manager_lb)) {
     gpr_log(
         GPR_INFO,
         "[xds_cluster_manager_lb %p] child %s: received update: state=%s (%s) "