grpc 1.60.0 → 1.61.0.pre2

data/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc

@@ -1,1173 +0,0 @@
-//
-// Copyright 2018 gRPC authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
-#include <grpc/support/port_platform.h>
-
-#include <inttypes.h>
-#include <stddef.h>
-
-#include <algorithm>
-#include <map>
-#include <memory>
-#include <set>
-#include <string>
-#include <type_traits>
-#include <utility>
-#include <vector>
-
-#include "absl/status/status.h"
-#include "absl/status/statusor.h"
-#include "absl/strings/str_cat.h"
-#include "absl/strings/str_join.h"
-#include "absl/strings/string_view.h"
-#include "absl/types/optional.h"
-
-#include <grpc/impl/channel_arg_names.h>
-#include <grpc/impl/connectivity_state.h>
-#include <grpc/support/json.h>
-#include <grpc/support/log.h>
-
-#include "src/core/ext/filters/client_channel/lb_policy/address_filtering.h"
-#include "src/core/ext/filters/client_channel/lb_policy/child_policy_handler.h"
-#include "src/core/ext/filters/client_channel/lb_policy/xds/xds_channel_args.h"
-#include "src/core/ext/filters/client_channel/resolver/fake/fake_resolver.h"
-#include "src/core/ext/xds/xds_bootstrap.h"
-#include "src/core/ext/xds/xds_bootstrap_grpc.h"
-#include "src/core/ext/xds/xds_client.h"
-#include "src/core/ext/xds/xds_client_grpc.h"
-#include "src/core/ext/xds/xds_client_stats.h"
-#include "src/core/ext/xds/xds_endpoint.h"
-#include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/config/core_configuration.h"
-#include "src/core/lib/debug/trace.h"
-#include "src/core/lib/gprpp/debug_location.h"
-#include "src/core/lib/gprpp/no_destruct.h"
-#include "src/core/lib/gprpp/orphanable.h"
-#include "src/core/lib/gprpp/ref_counted_ptr.h"
-#include "src/core/lib/gprpp/ref_counted_string.h"
-#include "src/core/lib/gprpp/validation_errors.h"
-#include "src/core/lib/gprpp/work_serializer.h"
-#include "src/core/lib/iomgr/pollset_set.h"
-#include "src/core/lib/json/json.h"
-#include "src/core/lib/json/json_args.h"
-#include "src/core/lib/json/json_object_loader.h"
-#include "src/core/lib/json/json_writer.h"
-#include "src/core/lib/load_balancing/delegating_helper.h"
-#include "src/core/lib/load_balancing/lb_policy.h"
-#include "src/core/lib/load_balancing/lb_policy_factory.h"
-#include "src/core/lib/load_balancing/lb_policy_registry.h"
-#include "src/core/lib/resolver/endpoint_addresses.h"
-#include "src/core/lib/resolver/resolver.h"
-#include "src/core/lib/resolver/resolver_registry.h"
-
-#define GRPC_EDS_DEFAULT_FALLBACK_TIMEOUT 10000
-
-namespace grpc_core {
-
-TraceFlag grpc_lb_xds_cluster_resolver_trace(false, "xds_cluster_resolver_lb");
-
-namespace {
-
-constexpr absl::string_view kXdsClusterResolver =
-    "xds_cluster_resolver_experimental";
-
-// Config for EDS LB policy.
-class XdsClusterResolverLbConfig : public LoadBalancingPolicy::Config {
- public:
-  struct DiscoveryMechanism {
-    std::string cluster_name;
-    absl::optional<GrpcXdsBootstrap::GrpcXdsServer> lrs_load_reporting_server;
-    uint32_t max_concurrent_requests;
-    enum DiscoveryMechanismType {
-      EDS,
-      LOGICAL_DNS,
-    };
-    DiscoveryMechanismType type;
-    std::string eds_service_name;
-    std::string dns_hostname;
-
-    Json::Array override_host_statuses;
-
-    // This is type Json::Object instead of OutlierDetectionConfig, because we
-    // don't actually need to validate the contents of the outlier detection
-    // config here.  In this case, the JSON is generated by the CDS policy
-    // instead of coming from service config, so it's not actually any better
-    // to catch the problem here than it is to catch it in the
-    // outlier_detection policy itself, so here we just act as a pass-through.
-    absl::optional<Json::Object> outlier_detection_lb_config;
-
-    bool operator==(const DiscoveryMechanism& other) const {
-      return (cluster_name == other.cluster_name &&
-              lrs_load_reporting_server == other.lrs_load_reporting_server &&
-              max_concurrent_requests == other.max_concurrent_requests &&
-              type == other.type &&
-              eds_service_name == other.eds_service_name &&
-              dns_hostname == other.dns_hostname &&
-              override_host_statuses == other.override_host_statuses &&
-              outlier_detection_lb_config == other.outlier_detection_lb_config);
-    }
-
-    static const JsonLoaderInterface* JsonLoader(const JsonArgs&);
-    void JsonPostLoad(const Json& json, const JsonArgs& args,
-                      ValidationErrors* errors);
-  };
-
-  XdsClusterResolverLbConfig() = default;
-
-  XdsClusterResolverLbConfig(const XdsClusterResolverLbConfig&) = delete;
-  XdsClusterResolverLbConfig& operator=(const XdsClusterResolverLbConfig&) =
-      delete;
-
-  XdsClusterResolverLbConfig(XdsClusterResolverLbConfig&& other) = delete;
-  XdsClusterResolverLbConfig& operator=(XdsClusterResolverLbConfig&& other) =
-      delete;
-
-  absl::string_view name() const override { return kXdsClusterResolver; }
-
-  const std::vector<DiscoveryMechanism>& discovery_mechanisms() const {
-    return discovery_mechanisms_;
-  }
-
-  const Json& xds_lb_policy() const { return xds_lb_policy_; }
-
-  static const JsonLoaderInterface* JsonLoader(const JsonArgs&);
-  void JsonPostLoad(const Json& json, const JsonArgs& args,
-                    ValidationErrors* errors);
-
- private:
-  std::vector<DiscoveryMechanism> discovery_mechanisms_;
-  Json xds_lb_policy_;
-};
-
-// Xds Cluster Resolver LB policy.
-class XdsClusterResolverLb : public LoadBalancingPolicy {
- public:
-  XdsClusterResolverLb(RefCountedPtr<XdsClient> xds_client, Args args);
-
-  absl::string_view name() const override { return kXdsClusterResolver; }
-
-  absl::Status UpdateLocked(UpdateArgs args) override;
-  void ResetBackoffLocked() override;
-  void ExitIdleLocked() override;
-
- private:
-  // Discovery Mechanism Base class
-  //
-  // Implemented by EDS and LOGICAL_DNS.
-  //
-  // Implementations are responsible for calling the LB policy's
-  // OnEndpointChanged(), OnError(), and OnResourceDoesNotExist()
-  // methods when the corresponding events occur.
-  //
-  // Must implement Orphan() method to cancel the watchers.
-  class DiscoveryMechanism : public InternallyRefCounted<DiscoveryMechanism> {
-   public:
-    DiscoveryMechanism(
-        RefCountedPtr<XdsClusterResolverLb> xds_cluster_resolver_lb,
-        size_t index)
-        : parent_(std::move(xds_cluster_resolver_lb)), index_(index) {}
-
-    XdsClusterResolverLb* parent() const { return parent_.get(); }
-    size_t index() const { return index_; }
-
-    virtual void Start() = 0;
-    virtual Json::Array override_child_policy() = 0;
-    virtual bool disable_reresolution() = 0;
-
-   private:
-    RefCountedPtr<XdsClusterResolverLb> parent_;
-    // Stores its own index in the vector of DiscoveryMechanism.
-    size_t index_;
-  };
-
-  class EdsDiscoveryMechanism : public DiscoveryMechanism {
-   public:
-    EdsDiscoveryMechanism(
-        RefCountedPtr<XdsClusterResolverLb> xds_cluster_resolver_lb,
-        size_t index)
-        : DiscoveryMechanism(std::move(xds_cluster_resolver_lb), index) {}
-    void Start() override;
-    void Orphan() override;
-    Json::Array override_child_policy() override { return Json::Array{}; }
-    bool disable_reresolution() override { return true; }
-
-   private:
-    class EndpointWatcher : public XdsEndpointResourceType::WatcherInterface {
-     public:
-      explicit EndpointWatcher(
-          RefCountedPtr<EdsDiscoveryMechanism> discovery_mechanism)
-          : discovery_mechanism_(std::move(discovery_mechanism)) {}
-      ~EndpointWatcher() override {
-        discovery_mechanism_.reset(DEBUG_LOCATION, "EndpointWatcher");
-      }
-      void OnResourceChanged(
-          std::shared_ptr<const XdsEndpointResource> update) override {
-        RefCountedPtr<EndpointWatcher> self = Ref();
-        discovery_mechanism_->parent()->work_serializer()->Run(
-            [self = std::move(self), update = std::move(update)]() mutable {
-              self->OnResourceChangedHelper(std::move(update));
-            },
-            DEBUG_LOCATION);
-      }
-      void OnError(absl::Status status) override {
-        RefCountedPtr<EndpointWatcher> self = Ref();
-        discovery_mechanism_->parent()->work_serializer()->Run(
-            [self = std::move(self), status = std::move(status)]() mutable {
-              self->OnErrorHelper(std::move(status));
-            },
-            DEBUG_LOCATION);
-      }
-      void OnResourceDoesNotExist() override {
-        RefCountedPtr<EndpointWatcher> self = Ref();
-        discovery_mechanism_->parent()->work_serializer()->Run(
-            [self = std::move(self)]() {
-              self->OnResourceDoesNotExistHelper();
-            },
-            DEBUG_LOCATION);
-      }
-
-     private:
-      // Code accessing protected methods of `DiscoveryMechanism` need to be
-      // in methods of this class rather than in lambdas to work around an MSVC
-      // bug.
-      void OnResourceChangedHelper(
-          std::shared_ptr<const XdsEndpointResource> update) {
-        std::string resolution_note;
-        if (update->priorities.empty()) {
-          resolution_note = absl::StrCat(
-              "EDS resource ", discovery_mechanism_->GetEdsResourceName(),
-              " contains no localities");
-        } else {
-          std::set<std::string> empty_localities;
-          for (const auto& priority : update->priorities) {
-            for (const auto& p : priority.localities) {
-              if (p.second.endpoints.empty()) {
-                empty_localities.insert(p.first->AsHumanReadableString());
-              }
-            }
-          }
-          if (!empty_localities.empty()) {
-            resolution_note = absl::StrCat(
-                "EDS resource ", discovery_mechanism_->GetEdsResourceName(),
-                " contains empty localities: [",
-                absl::StrJoin(empty_localities, "; "), "]");
-          }
-        }
-        discovery_mechanism_->parent()->OnEndpointChanged(
-            discovery_mechanism_->index(), std::move(update),
-            std::move(resolution_note));
-      }
-      void OnErrorHelper(absl::Status status) {
-        discovery_mechanism_->parent()->OnError(
-            discovery_mechanism_->index(),
-            absl::StrCat("EDS watcher error for resource ",
-                         discovery_mechanism_->GetEdsResourceName(), " (",
-                         status.ToString(), ")"));
-      }
-      void OnResourceDoesNotExistHelper() {
-        discovery_mechanism_->parent()->OnResourceDoesNotExist(
-            discovery_mechanism_->index(),
-            absl::StrCat("EDS resource ",
-                         discovery_mechanism_->GetEdsResourceName(),
-                         " does not exist"));
-      }
-      RefCountedPtr<EdsDiscoveryMechanism> discovery_mechanism_;
-    };
-
-    // This is necessary only because of a bug in msvc where nested class
-    // cannot access protected member in base class.
-    friend class EndpointWatcher;
-
-    absl::string_view GetEdsResourceName() const {
-      auto& config = parent()->config_->discovery_mechanisms()[index()];
-      if (!config.eds_service_name.empty()) return config.eds_service_name;
-      return config.cluster_name;
-    }
-
-    // Note that this is not owned, so this pointer must never be dereferenced.
-    EndpointWatcher* watcher_ = nullptr;
-  };
-
-  class LogicalDNSDiscoveryMechanism : public DiscoveryMechanism {
-   public:
-    LogicalDNSDiscoveryMechanism(
-        RefCountedPtr<XdsClusterResolverLb> xds_cluster_resolver_lb,
-        size_t index)
-        : DiscoveryMechanism(std::move(xds_cluster_resolver_lb), index) {}
-    void Start() override;
-    void Orphan() override;
-    Json::Array override_child_policy() override {
-      return {
-          Json::FromObject({
-              {"pick_first", Json::FromObject({})},
-          }),
-      };
-    }
-    bool disable_reresolution() override { return false; };
-
-   private:
-    class ResolverResultHandler : public Resolver::ResultHandler {
-     public:
-      explicit ResolverResultHandler(
-          RefCountedPtr<LogicalDNSDiscoveryMechanism> discovery_mechanism)
-          : discovery_mechanism_(std::move(discovery_mechanism)) {}
-
-      ~ResolverResultHandler() override {}
-
-      void ReportResult(Resolver::Result result) override;
-
-     private:
-      RefCountedPtr<LogicalDNSDiscoveryMechanism> discovery_mechanism_;
-    };
-
-    // This is necessary only because of a bug in msvc where nested class cannot
-    // access protected member in base class.
-    friend class ResolverResultHandler;
-
-    absl::string_view GetDnsHostname() const {
-      auto& config = parent()->config_->discovery_mechanisms()[index()];
-      return config.dns_hostname;
-    }
-
-    OrphanablePtr<Resolver> resolver_;
-  };
-
-  struct DiscoveryMechanismEntry {
-    OrphanablePtr<DiscoveryMechanism> discovery_mechanism;
-    // Most recent update reported by the discovery mechanism.
-    std::shared_ptr<const XdsEndpointResource> latest_update;
-    // Last resolution note reported by the discovery mechanism, if any.
-    std::string resolution_note;
-    // State used to retain child policy names for priority policy.
-    std::vector<size_t /*child_number*/> priority_child_numbers;
-    size_t next_available_child_number = 0;
-
-    const XdsClusterResolverLbConfig::DiscoveryMechanism& config() const;
-
-    // Returns the child policy name for a given priority.
-    std::string GetChildPolicyName(size_t priority) const;
-  };
-
-  class Helper : public ParentOwningDelegatingChannelControlHelper<
-                     XdsClusterResolverLb> {
-   public:
-    explicit Helper(
-        RefCountedPtr<XdsClusterResolverLb> xds_cluster_resolver_policy)
-        : ParentOwningDelegatingChannelControlHelper(
-              std::move(xds_cluster_resolver_policy)) {}
-
-    // This is a no-op, because we get the addresses from the xds
-    // client, which is a watch-based API.
-    // TODO(roth): Don't we need to propagate this for LOGICAL_DNS clusters?
-    void RequestReresolution() override {}
-  };
-
-  ~XdsClusterResolverLb() override;
-
-  void ShutdownLocked() override;
-
-  void OnEndpointChanged(size_t index,
-                         std::shared_ptr<const XdsEndpointResource> update,
-                         std::string resolution_note);
-  void OnError(size_t index, std::string resolution_note);
-  void OnResourceDoesNotExist(size_t index, std::string resolution_note);
-
-  void MaybeDestroyChildPolicyLocked();
-
-  absl::Status UpdateChildPolicyLocked();
-  OrphanablePtr<LoadBalancingPolicy> CreateChildPolicyLocked(
-      const ChannelArgs& args);
-  EndpointAddressesList CreateChildPolicyAddressesLocked();
-  std::string CreateChildPolicyResolutionNoteLocked();
-  RefCountedPtr<Config> CreateChildPolicyConfigLocked();
-  ChannelArgs CreateChildPolicyArgsLocked(const ChannelArgs& args_in);
-
-  // The xds client and endpoint watcher.
-  RefCountedPtr<XdsClient> xds_client_;
-
-  // Current channel args and config from the resolver.
-  ChannelArgs args_;
-  RefCountedPtr<XdsClusterResolverLbConfig> config_;
-
-  // Internal state.
-  bool shutting_down_ = false;
-
-  // Vector of discovery mechansism entries in priority order.
-  std::vector<DiscoveryMechanismEntry> discovery_mechanisms_;
-
-  OrphanablePtr<LoadBalancingPolicy> child_policy_;
-};
-
-//
-// XdsClusterResolverLb::EdsDiscoveryMechanism
-//
-
-void XdsClusterResolverLb::EdsDiscoveryMechanism::Start() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p] eds discovery mechanism %" PRIuPTR
-            ":%p starting xds watch for %s",
-            parent(), index(), this, std::string(GetEdsResourceName()).c_str());
-  }
-  auto watcher = MakeRefCounted<EndpointWatcher>(
-      Ref(DEBUG_LOCATION, "EdsDiscoveryMechanism"));
-  watcher_ = watcher.get();
-  XdsEndpointResourceType::StartWatch(parent()->xds_client_.get(),
-                                      GetEdsResourceName(), std::move(watcher));
-}
-
-void XdsClusterResolverLb::EdsDiscoveryMechanism::Orphan() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p] eds discovery mechanism %" PRIuPTR
-            ":%p cancelling xds watch for %s",
-            parent(), index(), this, std::string(GetEdsResourceName()).c_str());
-  }
-  XdsEndpointResourceType::CancelWatch(parent()->xds_client_.get(),
-                                       GetEdsResourceName(), watcher_);
-  Unref();
-}
-
-//
-// XdsClusterResolverLb::LogicalDNSDiscoveryMechanism
-//
-
-void XdsClusterResolverLb::LogicalDNSDiscoveryMechanism::Start() {
-  std::string target;
-  ChannelArgs args = parent()->args_;
-  auto* fake_resolver_response_generator =
-      args.GetPointer<FakeResolverResponseGenerator>(
-          GRPC_ARG_XDS_LOGICAL_DNS_CLUSTER_FAKE_RESOLVER_RESPONSE_GENERATOR);
-  if (fake_resolver_response_generator != nullptr) {
-    target = absl::StrCat("fake:", GetDnsHostname());
-    args = args.SetObject(fake_resolver_response_generator->Ref());
-  } else {
-    target = absl::StrCat("dns:", GetDnsHostname());
-  }
-  resolver_ = CoreConfiguration::Get().resolver_registry().CreateResolver(
-      target.c_str(), args, parent()->interested_parties(),
-      parent()->work_serializer(),
-      std::make_unique<ResolverResultHandler>(
-          Ref(DEBUG_LOCATION, "LogicalDNSDiscoveryMechanism")));
-  if (resolver_ == nullptr) {
-    parent()->OnResourceDoesNotExist(
-        index(),
-        absl::StrCat("error creating DNS resolver for ", GetDnsHostname()));
-    return;
-  }
-  resolver_->StartLocked();
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p] logical DNS discovery mechanism "
-            "%" PRIuPTR ":%p starting dns resolver %p",
-            parent(), index(), this, resolver_.get());
-  }
-}
-
-void XdsClusterResolverLb::LogicalDNSDiscoveryMechanism::Orphan() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(
-        GPR_INFO,
-        "[xds_cluster_resolver_lb %p] logical DNS discovery mechanism %" PRIuPTR
-        ":%p shutting down dns resolver %p",
-        parent(), index(), this, resolver_.get());
-  }
-  resolver_.reset();
-  Unref();
-}
-
-//
-// XdsClusterResolverLb::LogicalDNSDiscoveryMechanism::ResolverResultHandler
-//
-
-void XdsClusterResolverLb::LogicalDNSDiscoveryMechanism::ResolverResultHandler::
-    ReportResult(Resolver::Result result) {
-  XdsClusterResolverLb* lb_policy = discovery_mechanism_->parent();
-  size_t index = discovery_mechanism_->index();
-  if (!result.addresses.ok()) {
-    if (result.resolution_note.empty()) {
-      result.resolution_note = absl::StrCat(
-          "DNS resolution failed for ", discovery_mechanism_->GetDnsHostname(),
-          " (", result.addresses.status().ToString(), ")");
-    }
-    lb_policy->OnError(index, result.resolution_note);
-    return;
-  }
-  // Convert resolver result to EDS update.
-  auto update = std::make_shared<XdsEndpointResource>();
-  XdsEndpointResource::Priority::Locality locality;
-  locality.name = MakeRefCounted<XdsLocalityName>("", "", "");
-  locality.lb_weight = 1;
-  locality.endpoints = std::move(*result.addresses);
-  XdsEndpointResource::Priority priority;
-  priority.localities.emplace(locality.name.get(), std::move(locality));
-  update->priorities.emplace_back(std::move(priority));
-  lb_policy->OnEndpointChanged(index, std::move(update),
-                               std::move(result.resolution_note));
-}
-
-//
-// XdsClusterResolverLb::DiscoveryMechanismEntry
-//
-
-const XdsClusterResolverLbConfig::DiscoveryMechanism&
-XdsClusterResolverLb::DiscoveryMechanismEntry::config() const {
-  return discovery_mechanism->parent()
-      ->config_->discovery_mechanisms()[discovery_mechanism->index()];
-}
-
-std::string XdsClusterResolverLb::DiscoveryMechanismEntry::GetChildPolicyName(
-    size_t priority) const {
-  return absl::StrCat("{cluster=", config().cluster_name,
-                      ", child_number=", priority_child_numbers[priority], "}");
-}
-
-//
-// XdsClusterResolverLb public methods
-//
-
-XdsClusterResolverLb::XdsClusterResolverLb(RefCountedPtr<XdsClient> xds_client,
-                                           Args args)
-    : LoadBalancingPolicy(std::move(args)), xds_client_(std::move(xds_client)) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO, "[xds_cluster_resolver_lb %p] created -- xds_client=%p",
-            this, xds_client_.get());
-  }
-}
-
-XdsClusterResolverLb::~XdsClusterResolverLb() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p] destroying xds_cluster_resolver LB "
-            "policy",
-            this);
-  }
-}
-
-void XdsClusterResolverLb::ShutdownLocked() {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO, "[xds_cluster_resolver_lb %p] shutting down", this);
-  }
-  shutting_down_ = true;
-  MaybeDestroyChildPolicyLocked();
-  discovery_mechanisms_.clear();
-  xds_client_.reset(DEBUG_LOCATION, "XdsClusterResolverLb");
-  args_ = ChannelArgs();
-}
-
-void XdsClusterResolverLb::MaybeDestroyChildPolicyLocked() {
-  if (child_policy_ != nullptr) {
-    grpc_pollset_set_del_pollset_set(child_policy_->interested_parties(),
-                                     interested_parties());
-    child_policy_.reset();
-  }
-}
-
-absl::Status XdsClusterResolverLb::UpdateLocked(UpdateArgs args) {
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO, "[xds_cluster_resolver_lb %p] Received update", this);
-  }
-  const bool is_initial_update = args_ == ChannelArgs();
-  // Update config.
-  auto old_config = std::move(config_);
-  config_ = std::move(args.config);
-  // Update args.
-  args_ = std::move(args.args);
-  // Update child policy if needed.
-  absl::Status status;
-  if (child_policy_ != nullptr) status = UpdateChildPolicyLocked();
-  // Create endpoint watcher if needed.
-  if (is_initial_update) {
-    for (const auto& config : config_->discovery_mechanisms()) {
-      DiscoveryMechanismEntry entry;
-      if (config.type == XdsClusterResolverLbConfig::DiscoveryMechanism::
-                             DiscoveryMechanismType::EDS) {
-        entry.discovery_mechanism = MakeOrphanable<EdsDiscoveryMechanism>(
-            Ref(DEBUG_LOCATION, "EdsDiscoveryMechanism"),
-            discovery_mechanisms_.size());
-      } else if (config.type == XdsClusterResolverLbConfig::DiscoveryMechanism::
-                                    DiscoveryMechanismType::LOGICAL_DNS) {
-        entry.discovery_mechanism =
-            MakeOrphanable<LogicalDNSDiscoveryMechanism>(
-                Ref(DEBUG_LOCATION, "LogicalDNSDiscoveryMechanism"),
-                discovery_mechanisms_.size());
-      } else {
-        GPR_ASSERT(0);
-      }
-      discovery_mechanisms_.push_back(std::move(entry));
-    }
-    // Call start() on all discovery mechanisms after creation.
-    for (const auto& discovery_mechanism : discovery_mechanisms_) {
-      discovery_mechanism.discovery_mechanism->Start();
-    }
-  }
-  return status;
-}
-
-void XdsClusterResolverLb::ResetBackoffLocked() {
-  if (child_policy_ != nullptr) {
-    child_policy_->ResetBackoffLocked();
-  }
-}
-
-void XdsClusterResolverLb::ExitIdleLocked() {
-  if (child_policy_ != nullptr) child_policy_->ExitIdleLocked();
-}
-
-// We need at least one priority for each discovery mechanism, just so that we
-// have a child in which to create the xds_cluster_impl policy.  This ensures
-// that we properly handle the case of a discovery mechanism dropping 100% of
-// calls, the OnError() case, and the OnResourceDoesNotExist() case.
-const XdsEndpointResource::PriorityList& GetUpdatePriorityList(
-    const XdsEndpointResource& update) {
-  static const NoDestruct<XdsEndpointResource::PriorityList>
-      kPriorityListWithEmptyPriority(1);
-  if (update.priorities.empty()) return *kPriorityListWithEmptyPriority;
-  return update.priorities;
-}
-
-void XdsClusterResolverLb::OnEndpointChanged(
-    size_t index, std::shared_ptr<const XdsEndpointResource> update,
-    std::string resolution_note) {
-  if (shutting_down_) return;
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p] Received update from xds client"
-            " for discovery mechanism %" PRIuPTR " (resolution_note=\"%s\")",
-            this, index, resolution_note.c_str());
-  }
-  DiscoveryMechanismEntry& discovery_entry = discovery_mechanisms_[index];
-  const XdsEndpointResource::PriorityList& priority_list =
-      GetUpdatePriorityList(*update);
-  // Update priority_child_numbers, reusing old child numbers in an
-  // intelligent way to avoid unnecessary churn.
-  // First, build some maps from locality to child number and the reverse
-  // from the old data in the entry's update and priority_child_numbers.
-  std::map<XdsLocalityName*, size_t /*child_number*/, XdsLocalityName::Less>
-      locality_child_map;
-  std::map<size_t, std::set<XdsLocalityName*, XdsLocalityName::Less>>
-      child_locality_map;
-  if (discovery_entry.latest_update != nullptr) {
-    const auto& prev_priority_list =
-        GetUpdatePriorityList(*discovery_entry.latest_update);
-    for (size_t priority = 0; priority < prev_priority_list.size();
-         ++priority) {
-      size_t child_number = discovery_entry.priority_child_numbers[priority];
-      const auto& localities = prev_priority_list[priority].localities;
-      for (const auto& p : localities) {
-        XdsLocalityName* locality_name = p.first;
-        locality_child_map[locality_name] = child_number;
-        child_locality_map[child_number].insert(locality_name);
-      }
-    }
-  }
-  // Construct new list of children.
-  std::vector<size_t> priority_child_numbers;
-  for (size_t priority = 0; priority < priority_list.size(); ++priority) {
-    const auto& localities = priority_list[priority].localities;
-    absl::optional<size_t> child_number;
-    // If one of the localities in this priority already existed, reuse its
-    // child number.
-    for (const auto& p : localities) {
-      XdsLocalityName* locality_name = p.first;
-      if (!child_number.has_value()) {
-        auto it = locality_child_map.find(locality_name);
-        if (it != locality_child_map.end()) {
-          child_number = it->second;
-          locality_child_map.erase(it);
-          // Remove localities that *used* to be in this child number, so
-          // that we don't incorrectly reuse this child number for a
-          // subsequent priority.
-          for (XdsLocalityName* old_locality :
-               child_locality_map[*child_number]) {
-            locality_child_map.erase(old_locality);
-          }
-        }
-      } else {
-        // Remove all localities that are now in this child number, so
-        // that we don't accidentally reuse this child number for a
-        // subsequent priority.
-        locality_child_map.erase(locality_name);
-      }
-    }
-    // If we didn't find an existing child number, assign a new one.
-    if (!child_number.has_value()) {
-      for (child_number = discovery_entry.next_available_child_number;
-           child_locality_map.find(*child_number) != child_locality_map.end();
-           ++(*child_number)) {
-      }
-      discovery_entry.next_available_child_number = *child_number + 1;
-      // Add entry so we know that the child number is in use.
-      // (Don't need to add the list of localities, since we won't use them.)
-      child_locality_map[*child_number];
-    }
-    priority_child_numbers.push_back(*child_number);
-  }
-  // Save update.
-  discovery_entry.latest_update = std::move(update);
-  discovery_entry.resolution_note = std::move(resolution_note);
-  discovery_entry.priority_child_numbers = std::move(priority_child_numbers);
-  // If any discovery mechanism has not received its first update,
-  // wait until that happens before creating the child policy.
-  // TODO(roth): If this becomes problematic in the future (e.g., a
-  // secondary discovery mechanism delaying us from starting up at all),
-  // we can consider some sort of optimization whereby we can create the
-  // priority policy with only a subset of its children.  But we need to
-  // make sure not to get into a situation where the priority policy
-  // will put the channel into TRANSIENT_FAILURE instead of CONNECTING
-  // while we're still waiting for the other discovery mechanism(s).
-  for (DiscoveryMechanismEntry& mechanism : discovery_mechanisms_) {
-    if (mechanism.latest_update == nullptr) return;
-  }
-  // Update child policy.
-  // TODO(roth): If the child policy reports an error with the update,
-  // we need to propagate that error back to the resolver somehow.
-  (void)UpdateChildPolicyLocked();
-}
-
-void XdsClusterResolverLb::OnError(size_t index, std::string resolution_note) {
-  gpr_log(GPR_ERROR,
-          "[xds_cluster_resolver_lb %p] discovery mechanism %" PRIuPTR
-          " reported error: %s",
-          this, index, resolution_note.c_str());
-  if (shutting_down_) return;
-  if (discovery_mechanisms_[index].latest_update == nullptr) {
-    // Call OnEndpointChanged() with an empty update just like
-    // OnResourceDoesNotExist().
-    OnEndpointChanged(index, std::make_shared<XdsEndpointResource>(),
-                      std::move(resolution_note));
-  }
-}
-
-void XdsClusterResolverLb::OnResourceDoesNotExist(size_t index,
-                                                  std::string resolution_note) {
-  gpr_log(GPR_ERROR,
-          "[xds_cluster_resolver_lb %p] discovery mechanism %" PRIuPTR
-          " resource does not exist: %s",
-          this, index, resolution_note.c_str());
-  if (shutting_down_) return;
-  // Call OnEndpointChanged() with an empty update.
-  OnEndpointChanged(index, std::make_shared<XdsEndpointResource>(),
-                    std::move(resolution_note));
-}
-
-//
-// child policy-related methods
-//
-
-EndpointAddressesList XdsClusterResolverLb::CreateChildPolicyAddressesLocked() {
-  EndpointAddressesList addresses;
-  for (const auto& discovery_entry : discovery_mechanisms_) {
-    const auto& priority_list =
-        GetUpdatePriorityList(*discovery_entry.latest_update);
-    for (size_t priority = 0; priority < priority_list.size(); ++priority) {
-      const auto& priority_entry = priority_list[priority];
-      std::string priority_child_name =
-          discovery_entry.GetChildPolicyName(priority);
-      for (const auto& p : priority_entry.localities) {
-        const auto& locality_name = p.first;
-        const auto& locality = p.second;
-        std::vector<RefCountedStringValue> hierarchical_path = {
-            RefCountedStringValue(priority_child_name),
-            RefCountedStringValue(locality_name->AsHumanReadableString())};
-        auto hierarchical_path_attr =
-            MakeRefCounted<HierarchicalPathArg>(std::move(hierarchical_path));
-        for (const auto& endpoint : locality.endpoints) {
-          uint32_t endpoint_weight =
-              locality.lb_weight *
-              endpoint.args().GetInt(GRPC_ARG_ADDRESS_WEIGHT).value_or(1);
-          addresses.emplace_back(
-              endpoint.addresses(),
-              endpoint.args()
-                  .SetObject(hierarchical_path_attr)
-                  .Set(GRPC_ARG_ADDRESS_WEIGHT, endpoint_weight)
-                  .SetObject(locality_name->Ref())
-                  .Set(GRPC_ARG_XDS_LOCALITY_WEIGHT, locality.lb_weight));
-        }
-      }
-    }
-  }
-  return addresses;
-}
-
-std::string XdsClusterResolverLb::CreateChildPolicyResolutionNoteLocked() {
-  std::vector<absl::string_view> resolution_notes;
-  for (const auto& discovery_entry : discovery_mechanisms_) {
-    if (!discovery_entry.resolution_note.empty()) {
-      resolution_notes.push_back(discovery_entry.resolution_note);
-    }
-  }
-  return absl::StrJoin(resolution_notes, "; ");
-}
-
-RefCountedPtr<LoadBalancingPolicy::Config>
-XdsClusterResolverLb::CreateChildPolicyConfigLocked() {
-  Json::Object priority_children;
-  Json::Array priority_priorities;
-  for (const auto& discovery_entry : discovery_mechanisms_) {
-    const auto& priority_list =
-        GetUpdatePriorityList(*discovery_entry.latest_update);
-    const auto& discovery_config = discovery_entry.config();
-    for (size_t priority = 0; priority < priority_list.size(); ++priority) {
-      // Determine what xDS LB policy to use.
-      Json child_policy;
-      if (!discovery_entry.discovery_mechanism->override_child_policy()
-               .empty()) {
-        child_policy = Json::FromArray(
-            discovery_entry.discovery_mechanism->override_child_policy());
-      } else {
-        child_policy = config_->xds_lb_policy();
-      }
-      // Wrap the xDS LB policy in the xds_override_host policy.
-      Json::Object xds_override_host_lb_config = {
-          {"childPolicy", std::move(child_policy)},
-      };
-      if (!discovery_config.override_host_statuses.empty()) {
-        xds_override_host_lb_config["overrideHostStatus"] =
-            Json::FromArray(discovery_config.override_host_statuses);
-      }
-      Json::Array xds_override_host_config = {Json::FromObject({
-          {"xds_override_host_experimental",
-           Json::FromObject(std::move(xds_override_host_lb_config))},
-      })};
-      // Wrap it in the xds_cluster_impl policy.
-      Json::Array drop_categories;
-      if (discovery_entry.latest_update->drop_config != nullptr) {
-        for (const auto& category :
-             discovery_entry.latest_update->drop_config->drop_category_list()) {
-          drop_categories.push_back(Json::FromObject({
-              {"category", Json::FromString(category.name)},
-              {"requests_per_million",
-               Json::FromNumber(category.parts_per_million)},
-          }));
-        }
-      }
-      Json::Object xds_cluster_impl_config = {
-          {"clusterName", Json::FromString(discovery_config.cluster_name)},
-          {"childPolicy", Json::FromArray(std::move(xds_override_host_config))},
-          {"dropCategories", Json::FromArray(std::move(drop_categories))},
-          {"maxConcurrentRequests",
-           Json::FromNumber(discovery_config.max_concurrent_requests)},
-      };
-      if (!discovery_config.eds_service_name.empty()) {
-        xds_cluster_impl_config["edsServiceName"] =
-            Json::FromString(discovery_config.eds_service_name);
-      }
-      if (discovery_config.lrs_load_reporting_server.has_value()) {
-        xds_cluster_impl_config["lrsLoadReportingServer"] =
-            discovery_config.lrs_load_reporting_server->ToJson();
-      }
-      // Wrap it in the outlier_detection policy.
-      Json::Object outlier_detection_config;
-      if (discovery_entry.config().outlier_detection_lb_config.has_value()) {
-        outlier_detection_config =
-            discovery_entry.config().outlier_detection_lb_config.value();
-      }
-      outlier_detection_config["childPolicy"] =
-          Json::FromArray({Json::FromObject({
-              {"xds_cluster_impl_experimental",
-               Json::FromObject(std::move(xds_cluster_impl_config))},
-          })});
-      Json locality_picking_policy = Json::FromArray({Json::FromObject({
-          {"outlier_detection_experimental",
-           Json::FromObject(std::move(outlier_detection_config))},
-      })});
-      // Add priority entry, with the appropriate child name.
-      std::string child_name = discovery_entry.GetChildPolicyName(priority);
-      priority_priorities.emplace_back(Json::FromString(child_name));
-      Json::Object child_config = {
-          {"config", std::move(locality_picking_policy)},
-      };
-      if (discovery_entry.discovery_mechanism->disable_reresolution()) {
-        child_config["ignore_reresolution_requests"] = Json::FromBool(true);
-      }
-      priority_children[child_name] = Json::FromObject(std::move(child_config));
-    }
-  }
-  Json json = Json::FromArray({Json::FromObject({
-      {"priority_experimental",
-       Json::FromObject({
-           {"children", Json::FromObject(std::move(priority_children))},
-           {"priorities", Json::FromArray(std::move(priority_priorities))},
-       })},
-  })});
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(
-        GPR_INFO,
-        "[xds_cluster_resolver_lb %p] generated config for child policy: %s",
-        this, JsonDump(json, /*indent=*/1).c_str());
-  }
-  auto config =
-      CoreConfiguration::Get().lb_policy_registry().ParseLoadBalancingConfig(
-          json);
-  if (!config.ok()) {
-    // This should never happen, but if it does, we basically have no
-    // way to fix it, so we put the channel in TRANSIENT_FAILURE.
-    gpr_log(GPR_ERROR,
-            "[xds_cluster_resolver_lb %p] error parsing generated child policy "
-            "config -- "
-            "will put channel in TRANSIENT_FAILURE: %s",
-            this, config.status().ToString().c_str());
-    absl::Status status = absl::InternalError(
-        "xds_cluster_resolver LB policy: error parsing generated child policy "
-        "config");
-    channel_control_helper()->UpdateState(
-        GRPC_CHANNEL_TRANSIENT_FAILURE, status,
-        MakeRefCounted<TransientFailurePicker>(status));
-    return nullptr;
-  }
-  return std::move(*config);
-}
-
-absl::Status XdsClusterResolverLb::UpdateChildPolicyLocked() {
-  if (shutting_down_) return absl::OkStatus();
-  UpdateArgs update_args;
-  update_args.config = CreateChildPolicyConfigLocked();
-  if (update_args.config == nullptr) return absl::OkStatus();
-  update_args.addresses = CreateChildPolicyAddressesLocked();
-  update_args.resolution_note = CreateChildPolicyResolutionNoteLocked();
-  update_args.args = CreateChildPolicyArgsLocked(args_);
-  if (child_policy_ == nullptr) {
-    child_policy_ = CreateChildPolicyLocked(update_args.args);
-  }
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO, "[xds_cluster_resolver_lb %p] Updating child policy %p",
-            this, child_policy_.get());
-  }
-  return child_policy_->UpdateLocked(std::move(update_args));
-}
-
-ChannelArgs XdsClusterResolverLb::CreateChildPolicyArgsLocked(
-    const ChannelArgs& args) {
-  // Inhibit client-side health checking, since the balancer does this
-  // for us.
-  return args.Set(GRPC_ARG_INHIBIT_HEALTH_CHECKING, 1);
-}
-
-OrphanablePtr<LoadBalancingPolicy>
-XdsClusterResolverLb::CreateChildPolicyLocked(const ChannelArgs& args) {
-  LoadBalancingPolicy::Args lb_policy_args;
-  lb_policy_args.work_serializer = work_serializer();
-  lb_policy_args.args = args;
-  lb_policy_args.channel_control_helper =
-      std::make_unique<Helper>(Ref(DEBUG_LOCATION, "Helper"));
-  OrphanablePtr<LoadBalancingPolicy> lb_policy =
-      CoreConfiguration::Get().lb_policy_registry().CreateLoadBalancingPolicy(
-          "priority_experimental", std::move(lb_policy_args));
-  if (GPR_UNLIKELY(lb_policy == nullptr)) {
-    gpr_log(GPR_ERROR,
-            "[xds_cluster_resolver_lb %p] failure creating child policy", this);
-    return nullptr;
-  }
-  if (GRPC_TRACE_FLAG_ENABLED(grpc_lb_xds_cluster_resolver_trace)) {
-    gpr_log(GPR_INFO,
-            "[xds_cluster_resolver_lb %p]: Created new child policy %p", this,
-            lb_policy.get());
-  }
-  // Add our interested_parties pollset_set to that of the newly created
-  // child policy. This will make the child policy progress upon activity on
-  // this policy, which in turn is tied to the application's call.
-  grpc_pollset_set_add_pollset_set(lb_policy->interested_parties(),
-                                   interested_parties());
-  return lb_policy;
-}
-
-//
-// factory
-//
-
-const JsonLoaderInterface*
-XdsClusterResolverLbConfig::DiscoveryMechanism::JsonLoader(const JsonArgs&) {
-  static const auto* loader =
-      JsonObjectLoader<DiscoveryMechanism>()
-          // Note: Several fields requires custom processing,
-          // so they are handled in JsonPostLoad() instead.
-          .Field("clusterName", &DiscoveryMechanism::cluster_name)
-          .OptionalField("lrsLoadReportingServer",
-                         &DiscoveryMechanism::lrs_load_reporting_server)
-          .OptionalField("max_concurrent_requests",
-                         &DiscoveryMechanism::max_concurrent_requests)
-          .OptionalField("outlierDetection",
-                         &DiscoveryMechanism::outlier_detection_lb_config)
-          .OptionalField("overrideHostStatus",
-                         &DiscoveryMechanism::override_host_statuses)
-          .Finish();
-  return loader;
-}
-
-void XdsClusterResolverLbConfig::DiscoveryMechanism::JsonPostLoad(
-    const Json& json, const JsonArgs& args, ValidationErrors* errors) {
-  // Parse "type".
-  {
-    auto type_field =
-        LoadJsonObjectField<std::string>(json.object(), args, "type", errors);
-    if (type_field.has_value()) {
-      if (*type_field == "EDS") {
-        type = DiscoveryMechanismType::EDS;
-      } else if (*type_field == "LOGICAL_DNS") {
-        type = DiscoveryMechanismType::LOGICAL_DNS;
-      } else {
-        ValidationErrors::ScopedField field(errors, ".type");
-        errors->AddError(absl::StrCat("unknown type \"", *type_field, "\""));
-      }
-    }
-  }
-  // Parse "edsServiceName" if type is EDS.
-  if (type == DiscoveryMechanismType::EDS) {
-    auto value = LoadJsonObjectField<std::string>(json.object(), args,
-                                                  "edsServiceName", errors,
-                                                  /*required=*/false);
-    if (value.has_value()) eds_service_name = std::move(*value);
-  }
-  // Parse "dnsHostname" if type is LOGICAL_DNS.
-  if (type == DiscoveryMechanismType::LOGICAL_DNS) {
-    auto value = LoadJsonObjectField<std::string>(json.object(), args,
-                                                  "dnsHostname", errors);
-    if (value.has_value()) dns_hostname = std::move(*value);
-  }
-}
-
-const JsonLoaderInterface* XdsClusterResolverLbConfig::JsonLoader(
-    const JsonArgs&) {
-  static const auto* loader =
-      JsonObjectLoader<XdsClusterResolverLbConfig>()
-          // Note: The "xdsLbPolicy" field requires custom processing,
-          // so it's handled in JsonPostLoad() instead.
-          .Field("discoveryMechanisms",
-                 &XdsClusterResolverLbConfig::discovery_mechanisms_)
-          .Finish();
-  return loader;
-}
-
-void XdsClusterResolverLbConfig::JsonPostLoad(const Json& json, const JsonArgs&,
-                                              ValidationErrors* errors) {
-  // Validate discoveryMechanisms.
-  {
-    ValidationErrors::ScopedField field(errors, ".discoveryMechanisms");
-    if (!errors->FieldHasErrors() && discovery_mechanisms_.empty()) {
-      errors->AddError("must be non-empty");
-    }
-  }
-  // Parse "xdsLbPolicy".
-  {
-    ValidationErrors::ScopedField field(errors, ".xdsLbPolicy");
-    auto it = json.object().find("xdsLbPolicy");
-    if (it == json.object().end()) {
-      errors->AddError("field not present");
-    } else {
-      auto lb_config = CoreConfiguration::Get()
-                           .lb_policy_registry()
-                           .ParseLoadBalancingConfig(it->second);
-      if (!lb_config.ok()) errors->AddError(lb_config.status().message());
-      xds_lb_policy_ = it->second;
-    }
-  }
-}
-
-class XdsClusterResolverLbFactory : public LoadBalancingPolicyFactory {
- public:
-  OrphanablePtr<LoadBalancingPolicy> CreateLoadBalancingPolicy(
-      LoadBalancingPolicy::Args args) const override {
-    auto xds_client = args.args.GetObjectRef<GrpcXdsClient>(
-        DEBUG_LOCATION, "XdsClusterResolverLbFactory");
-    if (xds_client == nullptr) {
-      gpr_log(GPR_ERROR,
-              "XdsClient not present in channel args -- cannot instantiate "
-              "xds_cluster_resolver LB policy");
-      return nullptr;
-    }
-    return MakeOrphanable<XdsClusterResolverChildHandler>(std::move(xds_client),
-                                                          std::move(args));
-  }
-
-  absl::string_view name() const override { return kXdsClusterResolver; }
-
-  absl::StatusOr<RefCountedPtr<LoadBalancingPolicy::Config>>
-  ParseLoadBalancingConfig(const Json& json) const override {
-    return LoadFromJson<RefCountedPtr<XdsClusterResolverLbConfig>>(
-        json, JsonArgs(),
-        "errors validating xds_cluster_resolver LB policy config");
-  }
-
- private:
-  class XdsClusterResolverChildHandler : public ChildPolicyHandler {
-   public:
-    XdsClusterResolverChildHandler(RefCountedPtr<XdsClient> xds_client,
-                                   Args args)
-        : ChildPolicyHandler(std::move(args),
-                             &grpc_lb_xds_cluster_resolver_trace),
-          xds_client_(std::move(xds_client)) {}
-
-    ~XdsClusterResolverChildHandler() override {
-      xds_client_.reset(DEBUG_LOCATION, "XdsClusterResolverChildHandler");
-    }
-
-    bool ConfigChangeRequiresNewPolicyInstance(
-        LoadBalancingPolicy::Config* old_config,
-        LoadBalancingPolicy::Config* new_config) const override {
-      GPR_ASSERT(old_config->name() == kXdsClusterResolver);
-      GPR_ASSERT(new_config->name() == kXdsClusterResolver);
-      XdsClusterResolverLbConfig* old_xds_cluster_resolver_config =
-          static_cast<XdsClusterResolverLbConfig*>(old_config);
-      XdsClusterResolverLbConfig* new_xds_cluster_resolver_config =
-          static_cast<XdsClusterResolverLbConfig*>(new_config);
-      if (old_xds_cluster_resolver_config->discovery_mechanisms().size() !=
-          new_xds_cluster_resolver_config->discovery_mechanisms().size()) {
-        return true;
-      }
-      for (size_t i = 0;
-           i < old_xds_cluster_resolver_config->discovery_mechanisms().size();
-           ++i) {
-        auto& old_discovery_mechanism =
-            old_xds_cluster_resolver_config->discovery_mechanisms()[i];
-        auto& new_discovery_mechanism =
-            new_xds_cluster_resolver_config->discovery_mechanisms()[i];
-        if (old_discovery_mechanism.type != new_discovery_mechanism.type ||
-            old_discovery_mechanism.cluster_name !=
-                new_discovery_mechanism.cluster_name ||
-            old_discovery_mechanism.eds_service_name !=
-                new_discovery_mechanism.eds_service_name ||
-            old_discovery_mechanism.dns_hostname !=
-                new_discovery_mechanism.dns_hostname ||
-            !(old_discovery_mechanism.lrs_load_reporting_server ==
-              new_discovery_mechanism.lrs_load_reporting_server)) {
-          return true;
-        }
-      }
-      return false;
-    }
-
-    OrphanablePtr<LoadBalancingPolicy> CreateLoadBalancingPolicy(
-        absl::string_view /*name*/,
-        LoadBalancingPolicy::Args args) const override {
-      return MakeOrphanable<XdsClusterResolverLb>(
-          xds_client_->Ref(DEBUG_LOCATION, "XdsClusterResolverLb"),
-          std::move(args));
-    }
-
-   private:
-    RefCountedPtr<XdsClient> xds_client_;
-  };
-};
-
-}  // namespace
-
-void RegisterXdsClusterResolverLbPolicy(CoreConfiguration::Builder* builder) {
-  builder->lb_policy_registry()->RegisterLoadBalancingPolicyFactory(
-      std::make_unique<XdsClusterResolverLbFactory>());
-}
-
-}  // namespace grpc_core