grpc 1.56.2 → 1.57.0.pre1

data/src/core/lib/experiments/experiments.cc

@@ -19,6 +19,139 @@
 #include "src/core/lib/experiments/experiments.h"
 
 #ifndef GRPC_EXPERIMENTS_ARE_FINAL
+
+#if defined(GRPC_CFSTREAM)
+namespace {
+const char* const description_tcp_frame_size_tuning =
+    "If set, enables TCP to use RPC size estimation made by higher layers. TCP "
+    "would not indicate completion of a read operation until a specified "
+    "number of bytes have been read over the socket. Buffers are also "
+    "allocated according to estimated RPC sizes.";
+const char* const additional_constraints_tcp_frame_size_tuning = "{}";
+const char* const description_tcp_rcv_lowat =
+    "Use SO_RCVLOWAT to avoid wakeups on the read path.";
+const char* const additional_constraints_tcp_rcv_lowat = "{}";
+const char* const description_peer_state_based_framing =
+    "If set, the max sizes of frames sent to lower layers is controlled based "
+    "on the peer's memory pressure which is reflected in its max http2 frame "
+    "size.";
+const char* const additional_constraints_peer_state_based_framing = "{}";
+const char* const description_memory_pressure_controller =
+    "New memory pressure controller";
+const char* const additional_constraints_memory_pressure_controller = "{}";
+const char* const description_unconstrained_max_quota_buffer_size =
+    "Discard the cap on the max free pool size for one memory allocator";
+const char* const additional_constraints_unconstrained_max_quota_buffer_size =
+    "{}";
+const char* const description_event_engine_client =
+    "Use EventEngine clients instead of iomgr's grpc_tcp_client";
+const char* const additional_constraints_event_engine_client = "{}";
+const char* const description_monitoring_experiment =
+    "Placeholder experiment to prove/disprove our monitoring is working";
+const char* const additional_constraints_monitoring_experiment = "{}";
+const char* const description_promise_based_client_call =
+    "If set, use the new gRPC promise based call code when it's appropriate "
+    "(ie when all filters in a stack are promise based)";
+const char* const additional_constraints_promise_based_client_call = "{}";
+const char* const description_free_large_allocator =
+    "If set, return all free bytes from a \042big\042 allocator";
+const char* const additional_constraints_free_large_allocator = "{}";
+const char* const description_promise_based_server_call =
+    "If set, use the new gRPC promise based call code when it's appropriate "
+    "(ie when all filters in a stack are promise based)";
+const char* const additional_constraints_promise_based_server_call = "{}";
+const char* const description_transport_supplies_client_latency =
+    "If set, use the transport represented value for client latency in "
+    "opencensus";
+const char* const additional_constraints_transport_supplies_client_latency =
+    "{}";
+const char* const description_event_engine_listener =
+    "Use EventEngine listeners instead of iomgr's grpc_tcp_server";
+const char* const additional_constraints_event_engine_listener = "{}";
+const char* const description_schedule_cancellation_over_write =
+    "Allow cancellation op to be scheduled over a write";
+const char* const additional_constraints_schedule_cancellation_over_write =
+    "{}";
+const char* const description_trace_record_callops =
+    "Enables tracing of call batch initiation and completion.";
+const char* const additional_constraints_trace_record_callops = "{}";
+const char* const description_event_engine_dns =
+    "If set, use EventEngine DNSResolver for client channel resolution";
+const char* const additional_constraints_event_engine_dns = "{}";
+const char* const description_work_stealing =
+    "If set, use a work stealing thread pool implementation in EventEngine";
+const char* const additional_constraints_work_stealing = "{}";
+const char* const description_client_privacy = "If set, client privacy";
+const char* const additional_constraints_client_privacy = "{}";
+const char* const description_canary_client_privacy =
+    "If set, canary client privacy";
+const char* const additional_constraints_canary_client_privacy = "{}";
+const char* const description_server_privacy = "If set, server privacy";
+const char* const additional_constraints_server_privacy = "{}";
+const char* const description_unique_metadata_strings =
+    "Ensure a unique copy of strings from parsed metadata are taken. The "
+    "hypothesis here is that ref counting these are causing read buffer "
+    "lifetimes to be extended leading to memory bloat.";
+const char* const additional_constraints_unique_metadata_strings = "{}";
+const char* const description_keepalive_fix =
+    "Allows overriding keepalive_permit_without_calls. Refer "
+    "https://github.com/grpc/grpc/pull/33428 for more information.";
+const char* const additional_constraints_keepalive_fix = "{}";
+}  // namespace
+
+namespace grpc_core {
+
+const ExperimentMetadata g_experiment_metadata[] = {
+    {"tcp_frame_size_tuning", description_tcp_frame_size_tuning,
+     additional_constraints_tcp_frame_size_tuning, false, true},
+    {"tcp_rcv_lowat", description_tcp_rcv_lowat,
+     additional_constraints_tcp_rcv_lowat, false, true},
+    {"peer_state_based_framing", description_peer_state_based_framing,
+     additional_constraints_peer_state_based_framing, false, true},
+    {"memory_pressure_controller", description_memory_pressure_controller,
+     additional_constraints_memory_pressure_controller, false, true},
+    {"unconstrained_max_quota_buffer_size",
+     description_unconstrained_max_quota_buffer_size,
+     additional_constraints_unconstrained_max_quota_buffer_size, false, true},
+    {"event_engine_client", description_event_engine_client,
+     additional_constraints_event_engine_client, false, true},
+    {"monitoring_experiment", description_monitoring_experiment,
+     additional_constraints_monitoring_experiment, true, true},
+    {"promise_based_client_call", description_promise_based_client_call,
+     additional_constraints_promise_based_client_call, false, true},
+    {"free_large_allocator", description_free_large_allocator,
+     additional_constraints_free_large_allocator, false, true},
+    {"promise_based_server_call", description_promise_based_server_call,
+     additional_constraints_promise_based_server_call, false, true},
+    {"transport_supplies_client_latency",
+     description_transport_supplies_client_latency,
+     additional_constraints_transport_supplies_client_latency, false, true},
+    {"event_engine_listener", description_event_engine_listener,
+     additional_constraints_event_engine_listener, false, true},
+    {"schedule_cancellation_over_write",
+     description_schedule_cancellation_over_write,
+     additional_constraints_schedule_cancellation_over_write, false, true},
+    {"trace_record_callops", description_trace_record_callops,
+     additional_constraints_trace_record_callops, false, true},
+    {"event_engine_dns", description_event_engine_dns,
+     additional_constraints_event_engine_dns, false, false},
+    {"work_stealing", description_work_stealing,
+     additional_constraints_work_stealing, false, false},
+    {"client_privacy", description_client_privacy,
+     additional_constraints_client_privacy, false, false},
+    {"canary_client_privacy", description_canary_client_privacy,
+     additional_constraints_canary_client_privacy, false, false},
+    {"server_privacy", description_server_privacy,
+     additional_constraints_server_privacy, false, false},
+    {"unique_metadata_strings", description_unique_metadata_strings,
+     additional_constraints_unique_metadata_strings, false, true},
+    {"keepalive_fix", description_keepalive_fix,
+     additional_constraints_keepalive_fix, false, false},
+};
+
+}  // namespace grpc_core
+
+#elif defined(GPR_WINDOWS)
 namespace {
 const char* const description_tcp_frame_size_tuning =
     "If set, enables TCP to use RPC size estimation made by higher layers. TCP "
@@ -86,6 +219,15 @@ const char* const description_canary_client_privacy =
 const char* const additional_constraints_canary_client_privacy = "{}";
 const char* const description_server_privacy = "If set, server privacy";
 const char* const additional_constraints_server_privacy = "{}";
+const char* const description_unique_metadata_strings =
+    "Ensure a unique copy of strings from parsed metadata are taken. The "
+    "hypothesis here is that ref counting these are causing read buffer "
+    "lifetimes to be extended leading to memory bloat.";
+const char* const additional_constraints_unique_metadata_strings = "{}";
+const char* const description_keepalive_fix =
+    "Allows overriding keepalive_permit_without_calls. Refer "
+    "https://github.com/grpc/grpc/pull/33428 for more information.";
+const char* const additional_constraints_keepalive_fix = "{}";
 }  // namespace
 
 namespace grpc_core {
@@ -132,7 +274,143 @@ const ExperimentMetadata g_experiment_metadata[] = {
      additional_constraints_canary_client_privacy, false, false},
     {"server_privacy", description_server_privacy,
      additional_constraints_server_privacy, false, false},
+    {"unique_metadata_strings", description_unique_metadata_strings,
+     additional_constraints_unique_metadata_strings, false, true},
+    {"keepalive_fix", description_keepalive_fix,
+     additional_constraints_keepalive_fix, false, false},
 };
 
 }  // namespace grpc_core
+
+#else
+namespace {
+const char* const description_tcp_frame_size_tuning =
+    "If set, enables TCP to use RPC size estimation made by higher layers. TCP "
+    "would not indicate completion of a read operation until a specified "
+    "number of bytes have been read over the socket. Buffers are also "
+    "allocated according to estimated RPC sizes.";
+const char* const additional_constraints_tcp_frame_size_tuning = "{}";
+const char* const description_tcp_rcv_lowat =
+    "Use SO_RCVLOWAT to avoid wakeups on the read path.";
+const char* const additional_constraints_tcp_rcv_lowat = "{}";
+const char* const description_peer_state_based_framing =
+    "If set, the max sizes of frames sent to lower layers is controlled based "
+    "on the peer's memory pressure which is reflected in its max http2 frame "
+    "size.";
+const char* const additional_constraints_peer_state_based_framing = "{}";
+const char* const description_memory_pressure_controller =
+    "New memory pressure controller";
+const char* const additional_constraints_memory_pressure_controller = "{}";
+const char* const description_unconstrained_max_quota_buffer_size =
+    "Discard the cap on the max free pool size for one memory allocator";
+const char* const additional_constraints_unconstrained_max_quota_buffer_size =
+    "{}";
+const char* const description_event_engine_client =
+    "Use EventEngine clients instead of iomgr's grpc_tcp_client";
+const char* const additional_constraints_event_engine_client = "{}";
+const char* const description_monitoring_experiment =
+    "Placeholder experiment to prove/disprove our monitoring is working";
+const char* const additional_constraints_monitoring_experiment = "{}";
+const char* const description_promise_based_client_call =
+    "If set, use the new gRPC promise based call code when it's appropriate "
+    "(ie when all filters in a stack are promise based)";
+const char* const additional_constraints_promise_based_client_call = "{}";
+const char* const description_free_large_allocator =
+    "If set, return all free bytes from a \042big\042 allocator";
+const char* const additional_constraints_free_large_allocator = "{}";
+const char* const description_promise_based_server_call =
+    "If set, use the new gRPC promise based call code when it's appropriate "
+    "(ie when all filters in a stack are promise based)";
+const char* const additional_constraints_promise_based_server_call = "{}";
+const char* const description_transport_supplies_client_latency =
+    "If set, use the transport represented value for client latency in "
+    "opencensus";
+const char* const additional_constraints_transport_supplies_client_latency =
+    "{}";
+const char* const description_event_engine_listener =
+    "Use EventEngine listeners instead of iomgr's grpc_tcp_server";
+const char* const additional_constraints_event_engine_listener = "{}";
+const char* const description_schedule_cancellation_over_write =
+    "Allow cancellation op to be scheduled over a write";
+const char* const additional_constraints_schedule_cancellation_over_write =
+    "{}";
+const char* const description_trace_record_callops =
+    "Enables tracing of call batch initiation and completion.";
+const char* const additional_constraints_trace_record_callops = "{}";
+const char* const description_event_engine_dns =
+    "If set, use EventEngine DNSResolver for client channel resolution";
+const char* const additional_constraints_event_engine_dns = "{}";
+const char* const description_work_stealing =
+    "If set, use a work stealing thread pool implementation in EventEngine";
+const char* const additional_constraints_work_stealing = "{}";
+const char* const description_client_privacy = "If set, client privacy";
+const char* const additional_constraints_client_privacy = "{}";
+const char* const description_canary_client_privacy =
+    "If set, canary client privacy";
+const char* const additional_constraints_canary_client_privacy = "{}";
+const char* const description_server_privacy = "If set, server privacy";
+const char* const additional_constraints_server_privacy = "{}";
+const char* const description_unique_metadata_strings =
+    "Ensure a unique copy of strings from parsed metadata are taken. The "
+    "hypothesis here is that ref counting these are causing read buffer "
+    "lifetimes to be extended leading to memory bloat.";
+const char* const additional_constraints_unique_metadata_strings = "{}";
+const char* const description_keepalive_fix =
+    "Allows overriding keepalive_permit_without_calls. Refer "
+    "https://github.com/grpc/grpc/pull/33428 for more information.";
+const char* const additional_constraints_keepalive_fix = "{}";
+}  // namespace
+
+namespace grpc_core {
+
+const ExperimentMetadata g_experiment_metadata[] = {
+    {"tcp_frame_size_tuning", description_tcp_frame_size_tuning,
+     additional_constraints_tcp_frame_size_tuning, false, true},
+    {"tcp_rcv_lowat", description_tcp_rcv_lowat,
+     additional_constraints_tcp_rcv_lowat, false, true},
+    {"peer_state_based_framing", description_peer_state_based_framing,
+     additional_constraints_peer_state_based_framing, false, true},
+    {"memory_pressure_controller", description_memory_pressure_controller,
+     additional_constraints_memory_pressure_controller, false, true},
+    {"unconstrained_max_quota_buffer_size",
+     description_unconstrained_max_quota_buffer_size,
+     additional_constraints_unconstrained_max_quota_buffer_size, false, true},
+    {"event_engine_client", description_event_engine_client,
+     additional_constraints_event_engine_client, false, true},
+    {"monitoring_experiment", description_monitoring_experiment,
+     additional_constraints_monitoring_experiment, true, true},
+    {"promise_based_client_call", description_promise_based_client_call,
+     additional_constraints_promise_based_client_call, false, true},
+    {"free_large_allocator", description_free_large_allocator,
+     additional_constraints_free_large_allocator, false, true},
+    {"promise_based_server_call", description_promise_based_server_call,
+     additional_constraints_promise_based_server_call, false, true},
+    {"transport_supplies_client_latency",
+     description_transport_supplies_client_latency,
+     additional_constraints_transport_supplies_client_latency, false, true},
+    {"event_engine_listener", description_event_engine_listener,
+     additional_constraints_event_engine_listener, false, true},
+    {"schedule_cancellation_over_write",
+     description_schedule_cancellation_over_write,
+     additional_constraints_schedule_cancellation_over_write, false, true},
+    {"trace_record_callops", description_trace_record_callops,
+     additional_constraints_trace_record_callops, false, true},
+    {"event_engine_dns", description_event_engine_dns,
+     additional_constraints_event_engine_dns, false, false},
+    {"work_stealing", description_work_stealing,
+     additional_constraints_work_stealing, false, false},
+    {"client_privacy", description_client_privacy,
+     additional_constraints_client_privacy, false, false},
+    {"canary_client_privacy", description_canary_client_privacy,
+     additional_constraints_canary_client_privacy, false, false},
+    {"server_privacy", description_server_privacy,
+     additional_constraints_server_privacy, false, false},
+    {"unique_metadata_strings", description_unique_metadata_strings,
+     additional_constraints_unique_metadata_strings, false, true},
+    {"keepalive_fix", description_keepalive_fix,
+     additional_constraints_keepalive_fix, false, false},
+};
+
+}  // namespace grpc_core
+#endif
 #endif

data/src/core/lib/experiments/experiments.h

@@ -57,6 +57,56 @@
 namespace grpc_core {
 
 #ifdef GRPC_EXPERIMENTS_ARE_FINAL
+
+#if defined(GRPC_CFSTREAM)
+inline bool IsTcpFrameSizeTuningEnabled() { return false; }
+inline bool IsTcpRcvLowatEnabled() { return false; }
+inline bool IsPeerStateBasedFramingEnabled() { return false; }
+inline bool IsMemoryPressureControllerEnabled() { return false; }
+inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; }
+inline bool IsEventEngineClientEnabled() { return false; }
+#define GRPC_EXPERIMENT_IS_INCLUDED_MONITORING_EXPERIMENT
+inline bool IsMonitoringExperimentEnabled() { return true; }
+inline bool IsPromiseBasedClientCallEnabled() { return false; }
+inline bool IsFreeLargeAllocatorEnabled() { return false; }
+inline bool IsPromiseBasedServerCallEnabled() { return false; }
+inline bool IsTransportSuppliesClientLatencyEnabled() { return false; }
+inline bool IsEventEngineListenerEnabled() { return false; }
+inline bool IsScheduleCancellationOverWriteEnabled() { return false; }
+inline bool IsTraceRecordCallopsEnabled() { return false; }
+inline bool IsEventEngineDnsEnabled() { return false; }
+inline bool IsWorkStealingEnabled() { return false; }
+inline bool IsClientPrivacyEnabled() { return false; }
+inline bool IsCanaryClientPrivacyEnabled() { return false; }
+inline bool IsServerPrivacyEnabled() { return false; }
+inline bool IsUniqueMetadataStringsEnabled() { return false; }
+inline bool IsKeepaliveFixEnabled() { return false; }
+
+#elif defined(GPR_WINDOWS)
+inline bool IsTcpFrameSizeTuningEnabled() { return false; }
+inline bool IsTcpRcvLowatEnabled() { return false; }
+inline bool IsPeerStateBasedFramingEnabled() { return false; }
+inline bool IsMemoryPressureControllerEnabled() { return false; }
+inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; }
+inline bool IsEventEngineClientEnabled() { return false; }
+#define GRPC_EXPERIMENT_IS_INCLUDED_MONITORING_EXPERIMENT
+inline bool IsMonitoringExperimentEnabled() { return true; }
+inline bool IsPromiseBasedClientCallEnabled() { return false; }
+inline bool IsFreeLargeAllocatorEnabled() { return false; }
+inline bool IsPromiseBasedServerCallEnabled() { return false; }
+inline bool IsTransportSuppliesClientLatencyEnabled() { return false; }
+inline bool IsEventEngineListenerEnabled() { return false; }
+inline bool IsScheduleCancellationOverWriteEnabled() { return false; }
+inline bool IsTraceRecordCallopsEnabled() { return false; }
+inline bool IsEventEngineDnsEnabled() { return false; }
+inline bool IsWorkStealingEnabled() { return false; }
+inline bool IsClientPrivacyEnabled() { return false; }
+inline bool IsCanaryClientPrivacyEnabled() { return false; }
+inline bool IsServerPrivacyEnabled() { return false; }
+inline bool IsUniqueMetadataStringsEnabled() { return false; }
+inline bool IsKeepaliveFixEnabled() { return false; }
+
+#else
 inline bool IsTcpFrameSizeTuningEnabled() { return false; }
 inline bool IsTcpRcvLowatEnabled() { return false; }
 inline bool IsPeerStateBasedFramingEnabled() { return false; }
@@ -77,6 +127,10 @@ inline bool IsWorkStealingEnabled() { return false; }
 inline bool IsClientPrivacyEnabled() { return false; }
 inline bool IsCanaryClientPrivacyEnabled() { return false; }
 inline bool IsServerPrivacyEnabled() { return false; }
+inline bool IsUniqueMetadataStringsEnabled() { return false; }
+inline bool IsKeepaliveFixEnabled() { return false; }
+#endif
+
 #else
 #define GRPC_EXPERIMENT_IS_INCLUDED_TCP_FRAME_SIZE_TUNING
 inline bool IsTcpFrameSizeTuningEnabled() { return IsExperimentEnabled(0); }
@@ -124,8 +178,12 @@ inline bool IsClientPrivacyEnabled() { return IsExperimentEnabled(16); }
 inline bool IsCanaryClientPrivacyEnabled() { return IsExperimentEnabled(17); }
 #define GRPC_EXPERIMENT_IS_INCLUDED_SERVER_PRIVACY
 inline bool IsServerPrivacyEnabled() { return IsExperimentEnabled(18); }
+#define GRPC_EXPERIMENT_IS_INCLUDED_UNIQUE_METADATA_STRINGS
+inline bool IsUniqueMetadataStringsEnabled() { return IsExperimentEnabled(19); }
+#define GRPC_EXPERIMENT_IS_INCLUDED_KEEPALIVE_FIX
+inline bool IsKeepaliveFixEnabled() { return IsExperimentEnabled(20); }
 
-constexpr const size_t kNumExperiments = 19;
+constexpr const size_t kNumExperiments = 21;
 extern const ExperimentMetadata g_experiment_metadata[kNumExperiments];
 
 #endif

data/src/core/lib/gprpp/dual_ref_counted.h

@@ -49,13 +49,13 @@ class DualRefCounted : public Orphanable {
  public:
   ~DualRefCounted() override = default;
 
-  RefCountedPtr<Child> Ref() GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT RefCountedPtr<Child> Ref() {
     IncrementRefCount();
     return RefCountedPtr<Child>(static_cast<Child*>(this));
   }
 
-  RefCountedPtr<Child> Ref(const DebugLocation& location,
-                           const char* reason) GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT RefCountedPtr<Child> Ref(const DebugLocation& location,
+                                                const char* reason) {
     IncrementRefCount(location, reason);
     return RefCountedPtr<Child>(static_cast<Child*>(this));
   }
@@ -103,7 +103,7 @@ class DualRefCounted : public Orphanable {
     WeakUnref(location, reason);
   }
 
-  RefCountedPtr<Child> RefIfNonZero() GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT RefCountedPtr<Child> RefIfNonZero() {
     uint64_t prev_ref_pair = refs_.load(std::memory_order_acquire);
     do {
       const uint32_t strong_refs = GetStrongRefs(prev_ref_pair);
@@ -121,8 +121,8 @@ class DualRefCounted : public Orphanable {
     return RefCountedPtr<Child>(static_cast<Child*>(this));
   }
 
-  RefCountedPtr<Child> RefIfNonZero(const DebugLocation& location,
-                                    const char* reason) GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT RefCountedPtr<Child> RefIfNonZero(
+      const DebugLocation& location, const char* reason) {
     uint64_t prev_ref_pair = refs_.load(std::memory_order_acquire);
     do {
       const uint32_t strong_refs = GetStrongRefs(prev_ref_pair);
@@ -146,13 +146,13 @@ class DualRefCounted : public Orphanable {
     return RefCountedPtr<Child>(static_cast<Child*>(this));
   }
 
-  WeakRefCountedPtr<Child> WeakRef() GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT WeakRefCountedPtr<Child> WeakRef() {
     IncrementWeakRefCount();
     return WeakRefCountedPtr<Child>(static_cast<Child*>(this));
   }
 
-  WeakRefCountedPtr<Child> WeakRef(const DebugLocation& location,
-                                   const char* reason) GRPC_MUST_USE_RESULT {
+  GRPC_MUST_USE_RESULT WeakRefCountedPtr<Child> WeakRef(
+      const DebugLocation& location, const char* reason) {
     IncrementWeakRefCount(location, reason);
     return WeakRefCountedPtr<Child>(static_cast<Child*>(this));
   }

data/src/core/lib/gprpp/fork.cc

@@ -20,6 +20,8 @@
 
 #include "src/core/lib/gprpp/fork.h"
 
+#include <utility>
+
 #include <grpc/support/atm.h>
 #include <grpc/support/sync.h>
 #include <grpc/support/time.h>
@@ -189,19 +191,16 @@ void Fork::DoDecExecCtxCount() {
   NoDestructSingleton<ExecCtxState>::Get()->DecExecCtxCount();
 }
 
-void Fork::SetResetChildPollingEngineFunc(
+bool Fork::RegisterResetChildPollingEngineFunc(
     Fork::child_postfork_func reset_child_polling_engine) {
   if (reset_child_polling_engine_ == nullptr) {
-    reset_child_polling_engine_ = new std::vector<Fork::child_postfork_func>();
-  }
-  if (reset_child_polling_engine == nullptr) {
-    reset_child_polling_engine_->clear();
-  } else {
-    reset_child_polling_engine_->emplace_back(reset_child_polling_engine);
+    reset_child_polling_engine_ = new std::set<Fork::child_postfork_func>();
   }
+  auto ret = reset_child_polling_engine_->insert(reset_child_polling_engine);
+  return ret.second;
 }
 
-const std::vector<Fork::child_postfork_func>&
+const std::set<Fork::child_postfork_func>&
 Fork::GetResetChildPollingEngineFunc() {
   return *reset_child_polling_engine_;
 }
@@ -238,6 +237,6 @@ void Fork::AwaitThreads() {
 
 std::atomic<bool> Fork::support_enabled_(false);
 bool Fork::override_enabled_ = false;
-std::vector<Fork::child_postfork_func>* Fork::reset_child_polling_engine_ =
+std::set<Fork::child_postfork_func>* Fork::reset_child_polling_engine_ =
     nullptr;
 }  // namespace grpc_core

data/src/core/lib/gprpp/fork.h

@@ -22,7 +22,7 @@
 #include <grpc/support/port_platform.h>
 
 #include <atomic>
-#include <vector>
+#include <set>
 
 //
 // NOTE: FORKING IS NOT GENERALLY SUPPORTED, THIS IS ONLY INTENDED TO WORK
@@ -57,10 +57,11 @@ class Fork {
 
   // Provide a function that will be invoked in the child's postfork handler to
   // reset the polling engine's internal state.
-  static void SetResetChildPollingEngineFunc(
+  // Returns true if reset_child_polling_engine was not previously registered,
+  // otherwise returns false and does nothing.
+  static bool RegisterResetChildPollingEngineFunc(
       child_postfork_func reset_child_polling_engine);
-  static const std::vector<child_postfork_func>&
-  GetResetChildPollingEngineFunc();
+  static const std::set<child_postfork_func>& GetResetChildPollingEngineFunc();
 
   // Check if there is a single active ExecCtx
   // (the one used to invoke this function).  If there are more,
@@ -89,7 +90,7 @@ class Fork {
 
   static std::atomic<bool> support_enabled_;
   static bool override_enabled_;
-  static std::vector<child_postfork_func>* reset_child_polling_engine_;
+  static std::set<child_postfork_func>* reset_child_polling_engine_;
 };
 
 }  // namespace grpc_core