grpc 1.51.0 → 1.52.0.pre2

data/src/core/lib/gpr/string_posix.cc

@@ -1,20 +1,20 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
 
 #include <grpc/support/port_platform.h>
 
@@ -33,7 +33,7 @@ int gpr_asprintf(char** strp, const char* format, ...) {
   char buf[64];
   size_t strp_buflen;
 
-  /* Use a constant-sized buffer to determine the length. */
+  // Use a constant-sized buffer to determine the length.
   va_start(args, format);
   ret = vsnprintf(buf, sizeof(buf), format, args);
   va_end(args);
@@ -42,20 +42,20 @@ int gpr_asprintf(char** strp, const char* format, ...) {
     return -1;
   }
 
-  /* Allocate a new buffer, with space for the NUL terminator. */
+  // Allocate a new buffer, with space for the NUL terminator.
   strp_buflen = static_cast<size_t>(ret) + 1;
   if ((*strp = static_cast<char*>(gpr_malloc(strp_buflen))) == nullptr) {
-    /* This shouldn't happen, because gpr_malloc() calls abort(). */
+    // This shouldn't happen, because gpr_malloc() calls abort().
     return -1;
   }
 
-  /* Return early if we have all the bytes. */
+  // Return early if we have all the bytes.
   if (strp_buflen <= sizeof(buf)) {
     memcpy(*strp, buf, strp_buflen);
     return ret;
   }
 
-  /* Try again using the larger buffer. */
+  // Try again using the larger buffer.
   va_start(args, format);
   ret = vsnprintf(*strp, strp_buflen, format, args);
   va_end(args);
@@ -63,10 +63,10 @@ int gpr_asprintf(char** strp, const char* format, ...) {
     return ret;
   }
 
-  /* This should never happen. */
+  // This should never happen.
   gpr_free(*strp);
   *strp = nullptr;
   return -1;
 }
 
-#endif /* GPR_POSIX_STRING */
+#endif  // GPR_POSIX_STRING

data/src/core/lib/gpr/string_util_windows.cc

@@ -1,29 +1,29 @@
-/*
- *
- * Copyright 2016 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-/* Posix code for gpr snprintf support. */
+//
+//
+// Copyright 2016 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
+
+// Posix code for gpr snprintf support.
 
 #include <grpc/support/port_platform.h>
 
 #ifdef GPR_WINDOWS
 
-/* Some platforms (namely msys) need wchar to be included BEFORE
-   anything else, especially strsafe.h. */
+// Some platforms (namely msys) need wchar to be included BEFORE
+// anything else, especially strsafe.h.
 #include <wchar.h>
 
 #include <inttypes.h>
@@ -52,4 +52,4 @@ char* gpr_format_message(int messageid) {
   return gpr_strdup(message.c_str());
 }
 
-#endif /* GPR_WINDOWS */
+#endif  // GPR_WINDOWS

data/src/core/lib/gpr/string_windows.cc

@@ -1,22 +1,22 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
 
-/* Windows code for gpr snprintf support. */
+// Windows code for gpr snprintf support.
 
 #include <grpc/support/port_platform.h>
 
@@ -36,7 +36,7 @@ int gpr_asprintf(char** strp, const char* format, ...) {
   int ret;
   size_t strp_buflen;
 
-  /* Determine the length. */
+  // Determine the length.
   va_start(args, format);
   ret = _vscprintf(format, args);
   va_end(args);
@@ -45,14 +45,14 @@ int gpr_asprintf(char** strp, const char* format, ...) {
     return -1;
   }
 
-  /* Allocate a new buffer, with space for the NUL terminator. */
+  // Allocate a new buffer, with space for the NUL terminator.
   strp_buflen = (size_t)ret + 1;
   if ((*strp = (char*)gpr_malloc(strp_buflen)) == NULL) {
-    /* This shouldn't happen, because gpr_malloc() calls abort(). */
+    // This shouldn't happen, because gpr_malloc() calls abort().
     return -1;
   }
 
-  /* Print to the buffer. */
+  // Print to the buffer.
   va_start(args, format);
   ret = vsnprintf_s(*strp, strp_buflen, _TRUNCATE, format, args);
   va_end(args);
@@ -60,10 +60,10 @@ int gpr_asprintf(char** strp, const char* format, ...) {
     return ret;
   }
 
-  /* This should never happen. */
+  // This should never happen.
   gpr_free(*strp);
   *strp = NULL;
   return -1;
 }
 
-#endif /* GPR_WINDOWS_STRING */
+#endif  // GPR_WINDOWS_STRING

data/src/core/lib/gpr/sync.cc

@@ -1,22 +1,22 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-/* Generic implementation of synchronization primitives. */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
+
+// Generic implementation of synchronization primitives.
 
 #include <grpc/support/port_platform.h>
 
@@ -26,17 +26,17 @@
 #include <grpc/support/log.h>
 #include <grpc/support/sync.h>
 
-/* Number of mutexes to allocate for events, to avoid lock contention.
-   Should be a prime. */
+// Number of mutexes to allocate for events, to avoid lock contention.
+// Should be a prime.
 enum { event_sync_partitions = 31 };
 
-/* Events are partitioned by address to avoid lock contention. */
+// Events are partitioned by address to avoid lock contention.
 static struct sync_array_s {
   gpr_mu mu;
   gpr_cv cv;
 } sync_array[event_sync_partitions];
 
-/* This routine is executed once on first use, via event_once */
+// This routine is executed once on first use, via event_once
 static gpr_once event_once = GPR_ONCE_INIT;
 static void event_initialize(void) {
   int i;
@@ -46,7 +46,7 @@ static void event_initialize(void) {
   }
 }
 
-/* Hash ev into an element of sync_array[]. */
+// Hash ev into an element of sync_array[].
 static struct sync_array_s* hash(gpr_event* ev) {
   return &sync_array[reinterpret_cast<uintptr_t>(ev) % event_sync_partitions];
 }
@@ -119,6 +119,6 @@ void gpr_stats_inc(gpr_stats_counter* c, intptr_t inc) {
 }
 
 intptr_t gpr_stats_read(const gpr_stats_counter* c) {
-  /* don't need acquire-load, but we have no no-barrier load yet */
+  // don't need acquire-load, but we have no no-barrier load yet
   return gpr_atm_acq_load(&c->value);
 }

data/src/core/lib/gpr/sync_abseil.cc

@@ -1,20 +1,20 @@
-/*
- *
- * Copyright 2020 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
+//
+//
+// Copyright 2020 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
 
 #include <grpc/support/port_platform.h>
 
@@ -33,6 +33,8 @@
 #include <grpc/support/sync.h>
 #include <grpc/support/time.h>
 
+#include "src/core/lib/gprpp/crash.h"
+
 void gpr_mu_init(gpr_mu* mu) {
   static_assert(sizeof(gpr_mu) == sizeof(absl::Mutex),
                 "gpr_mu and Mutex must be the same size");
@@ -55,7 +57,7 @@ int gpr_mu_trylock(gpr_mu* mu) {
   return reinterpret_cast<absl::Mutex*>(mu)->TryLock();
 }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 void gpr_cv_init(gpr_cv* cv) {
   static_assert(sizeof(gpr_cv) == sizeof(absl::CondVar),
@@ -89,7 +91,7 @@ void gpr_cv_broadcast(gpr_cv* cv) {
   reinterpret_cast<absl::CondVar*>(cv)->SignalAll();
 }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 void gpr_once_init(gpr_once* once, void (*init_function)(void)) {
   static_assert(sizeof(gpr_once) == sizeof(absl::once_flag),
@@ -97,4 +99,4 @@ void gpr_once_init(gpr_once* once, void (*init_function)(void)) {
   absl::call_once(*reinterpret_cast<absl::once_flag*>(once), init_function);
 }
 
-#endif /* defined(GPR_ABSEIL_SYNC) && !defined(GPR_CUSTOM_SYNC) */
+#endif  // defined(GPR_ABSEIL_SYNC) && !defined(GPR_CUSTOM_SYNC)

data/src/core/lib/gpr/sync_posix.cc

@@ -1,20 +1,20 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
 
 #include <grpc/support/port_platform.h>
 
@@ -29,6 +29,8 @@
 #include <grpc/support/sync.h>
 #include <grpc/support/time.h>
 
+#include "src/core/lib/gprpp/crash.h"
+
 void gpr_mu_init(gpr_mu* mu) {
 #ifdef GRPC_ASAN_ENABLED
   GPR_ASSERT(pthread_mutex_init(&mu->mutex, nullptr) == 0);
@@ -75,7 +77,7 @@ int gpr_mu_trylock(gpr_mu* mu) {
   return err == 0;
 }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 void gpr_cv_init(gpr_cv* cv) {
   pthread_condattr_t attr;
@@ -147,11 +149,11 @@ void gpr_cv_broadcast(gpr_cv* cv) {
 #endif
 }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 void gpr_once_init(gpr_once* once, void (*init_function)(void)) {
   GPR_ASSERT(pthread_once(once, init_function) == 0);
 }
 
-#endif /* defined(GPR_POSIX_SYNC) && !defined(GPR_ABSEIL_SYNC) && \
-          !defined(GPR_CUSTOM_SYNC) */
+#endif  // defined(GPR_POSIX_SYNC) && !defined(GPR_ABSEIL_SYNC) && \
+       // !defined(GPR_CUSTOM_SYNC)

data/src/core/lib/gpr/sync_windows.cc

@@ -1,22 +1,22 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-/* Win32 code for gpr synchronization support. */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
+
+// Win32 code for gpr synchronization support.
 
 #include <grpc/support/port_platform.h>
 
@@ -27,6 +27,8 @@
 #include <grpc/support/sync.h>
 #include <grpc/support/time.h>
 
+#include "src/core/lib/gprpp/crash.h"
+
 void gpr_mu_init(gpr_mu* mu) {
   InitializeCriticalSection(&mu->cs);
   mu->locked = 0;
@@ -48,21 +50,21 @@ void gpr_mu_unlock(gpr_mu* mu) {
 int gpr_mu_trylock(gpr_mu* mu) {
   int result = TryEnterCriticalSection(&mu->cs);
   if (result) {
-    if (mu->locked) {                /* This thread already holds the lock. */
-      LeaveCriticalSection(&mu->cs); /* Decrement lock count. */
-      result = 0;                    /* Indicate failure */
+    if (mu->locked) {                 // This thread already holds the lock.
+      LeaveCriticalSection(&mu->cs);  // Decrement lock count.
+      result = 0;                     // Indicate failure
     }
     mu->locked = 1;
   }
   return result;
 }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 void gpr_cv_init(gpr_cv* cv) { InitializeConditionVariable(cv); }
 
 void gpr_cv_destroy(gpr_cv* cv) {
-  /* Condition variables don't need destruction in Win32. */
+  // Condition variables don't need destruction in Win32.
 }
 
 int gpr_cv_wait(gpr_cv* cv, gpr_mu* mu, gpr_timespec abs_deadline) {
@@ -98,7 +100,7 @@ void gpr_cv_signal(gpr_cv* cv) { WakeConditionVariable(cv); }
 
 void gpr_cv_broadcast(gpr_cv* cv) { WakeAllConditionVariable(cv); }
 
-/*----------------------------------------*/
+//----------------------------------------
 
 static void* phony;
 struct run_once_func_arg {
@@ -116,5 +118,5 @@ void gpr_once_init(gpr_once* once, void (*init_function)(void)) {
   InitOnceExecuteOnce(once, run_once_func, &arg, &phony);
 }
 
-#endif /* defined(GPR_WINDOWS) && !defined(GPR_ABSEIL_SYNC) && \
-          !defined(GPR_CUSTOM_SYNC) */
+#endif  // defined(GPR_WINDOWS) && !defined(GPR_ABSEIL_SYNC) && \
+       // !defined(GPR_CUSTOM_SYNC)

data/src/core/lib/gpr/time.cc

@@ -1,22 +1,22 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-/* Generic implementation of time calls. */
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
+
+// Generic implementation of time calls.
 
 #include <grpc/support/port_platform.h>
 
@@ -27,6 +27,8 @@
 #include <grpc/support/log.h>
 #include <grpc/support/time.h>
 
+#include "src/core/lib/gprpp/crash.h"
+
 int gpr_time_cmp(gpr_timespec a, gpr_timespec b) {
   int cmp = (a.tv_sec > b.tv_sec) - (a.tv_sec < b.tv_sec);
   GPR_ASSERT(a.clock_type == b.clock_type);
@@ -227,8 +229,8 @@ int32_t gpr_time_to_millis(gpr_timespec t) {
     }
     return 2147483647;
   } else if (t.tv_sec <= -2147483) {
-    /* TODO(ctiller): correct handling here (it's so far in the past do we
-       care?) */
+    // TODO(ctiller): correct handling here (it's so far in the past do we
+    // care?)
     return -2147483647;
   } else {
     return static_cast<int32_t>(t.tv_sec * GPR_MS_PER_SEC +