grover 1.2.8 → 1.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5073ac021055fe2d39ca21ffed39548b1db0defa1b873fc7da189a7c8e63b675
-  data.tar.gz: e9a8d1b23ea6a0095d1f9565293fcd5d97e539402e2b86b9b785e3c5f61f1332
+  metadata.gz: 6975e57956621f04557b7b9634611de621cfbca81f067dec8f0f302adb861cdc
+  data.tar.gz: 922fb8f8df08bbbe4870fa013e543ca332703bcf888308d894047689824a9ee5
 SHA512:
-  metadata.gz: a3967dfa189c95e870a5258557fd6bfd2a595c1407ead503e3d9b2b2d1eddfcf07b1b55a5fa12bdf115caf32dabfd298e68625cf481b8f9da8cafe2f45f83f4f
-  data.tar.gz: e68da45a7a2646baa448913d71e8f7cf0193a805947c45575872bb51694810615d3de506d55bb03ec72ab2bc8211102fbba71cf77c18211558df7e57573d1486
+  metadata.gz: fc2c71aa2cd450e562425f9f14df68c3e1fa4dfd3281a71a6d830a1acecf574c629d52c3d0b033414a6d1d9e675533f38d0300e2a97413845db2b354e559efb5
+  data.tar.gz: cc6ff7f47a9e34b7dc01d8a2a15c09482e90e7af414720eb05b64b1616829fddb10f738de696cac215cf8db5c079960cf55817ed5ff6ce8350b4762e141cb1de

data/lib/active_support_ext/object/deep_dup.rb

@@ -20,7 +20,7 @@ class Object
   end
 end
 
-class Array
+class Array # rubocop:disable Style/OneClassPerFile
   # Returns a deep copy of array.
   #
   #   array = [1, [2, 3]]
@@ -34,7 +34,7 @@ class Array
   end
 end
 
-class Hash
+class Hash # rubocop:disable Style/OneClassPerFile
   # Returns a deep copy of hash.
   #
   #   hash = { a: { b: 'b' } }

data/lib/active_support_ext/object/duplicable.rb

@@ -31,7 +31,7 @@ class Object
   end
 end
 
-class Method
+class Method # rubocop:disable Style/OneClassPerFile
   # Methods are not duplicable:
   #
   #  method(:puts).duplicable? # => false
@@ -41,7 +41,7 @@ class Method
   end
 end
 
-class UnboundMethod
+class UnboundMethod # rubocop:disable Style/OneClassPerFile
   # Unbound methods are not duplicable:
   #
   #  method(:puts).unbind.duplicable? # => false

data/lib/grover/js/processor.cjs

@@ -34,7 +34,7 @@ function GroverError(name, errors) {
 GroverError.prototype = Error.prototype;
 
 const _processPage = (async (convertAction, uriOrHtml, options) => {
-  let browser, page, tmpDir, wsConnection = false;
+  let browser, context, page, tmpDir, wsConnection = false;
   const requestErrors = [], pageErrors = [];
 
   const captureRequestError = (request) => {
@@ -114,7 +114,12 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
       browser = await puppeteer.launch(launchParams);
     }
 
-    page = await browser.newPage();
+    if (wsConnection) {
+      context = await browser.createBrowserContext();
+      page = await context.newPage();
+    } else {
+      page = await browser.newPage();
+    }
 
     // Basic auth
     const username = options.username; delete options.username
@@ -214,6 +219,11 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
       await cdp.send('Browser.setPermission', { permission: { name: 'local-network-access' }, setting: 'granted' });
     }
 
+    const javaScriptEnabled = options.javaScriptEnabled; delete options.javaScriptEnabled;
+    if (javaScriptEnabled !== undefined) {
+      await page.setJavaScriptEnabled(javaScriptEnabled);
+    }
+
     const raiseOnRequestFailure = options.raiseOnRequestFailure; delete options.raiseOnRequestFailure;
     if (raiseOnRequestFailure) {
       page.on('requestfinished', (request) => {
@@ -344,7 +354,7 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
   } finally {
     if (browser) {
       if (wsConnection) {
-        if (page) await page.close();
+        if (context) await context.close();
         await browser.disconnect();
       } else {
         await browser.close();

data/lib/grover/options_fixer.rb

@@ -9,6 +9,9 @@ class Grover
   class OptionsFixer
     FALSE_VALUES = [nil, false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF'].freeze
 
+    JAVASCRIPT_OPTIONS = %w[evaluate_on_new_document execute_script script_tag_options wait_for_function].freeze
+    private_constant :JAVASCRIPT_OPTIONS
+
     def initialize(options)
       @options = options
     end
@@ -18,6 +21,7 @@ class Grover
       fix_integer_options!
       fix_float_options!
       fix_array_options!
+      disable_javascript_options!
       @options
     end
 
@@ -35,7 +39,7 @@ class Grover
       fix_options!(
         'display_header_footer', 'full_page', 'landscape', 'omit_background', 'prefer_css_page_size',
         'print_background', 'viewport.has_touch', 'viewport.is_landscape', 'viewport.is_mobile', 'bypass_csp',
-        'raise_on_request_failure', 'raise_on_js_error'
+        'raise_on_request_failure', 'raise_on_js_error', 'javascript_enabled'
       ) { |value| !FALSE_VALUES.include?(value) }
     end
 
@@ -60,5 +64,20 @@ class Grover
         value.is_a?(String) ? YAML.safe_load(value) : value
       end
     end
+
+    def disable_javascript_options!
+      return if @options['javascript_enabled'] != false
+
+      JAVASCRIPT_OPTIONS.each do |option|
+        disable_javascript_option!(option)
+      end
+    end
+
+    def disable_javascript_option!(option)
+      return unless @options.key?(option)
+
+      @options.delete(option)
+      warn "#{self.class}: option #{option} has been disabled because javascript_enabled is set to false"
+    end
   end
 end

data/lib/grover/utils.rb

@@ -9,7 +9,8 @@ class Grover
       'css' => 'CSS',
       'csp' => 'CSP',
       'http' => 'HTTP',
-      'js' => 'JS'
+      'js' => 'JS',
+      'javascript' => 'JavaScript'
     }.freeze
     private_constant :ACRONYMS
 
@@ -94,9 +95,9 @@ class Grover
     # Regex sourced from ActiveSupport camelize
     #
     def self.normalize_key(key)
-      key.to_s.downcase.gsub(%r{(?:_|(/))([a-z\d]*)}) do
+      key.to_s.downcase.gsub(%r{(?:^|_|(/))([a-z\d]*)}) do
         "#{Regexp.last_match(1)}#{ACRONYMS[Regexp.last_match(2)] || Regexp.last_match(2).capitalize}"
-      end
+      end.sub(/^[[:alpha:]]/, &:downcase)
     end
     private_class_method :normalize_key
   end

data/lib/grover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Grover
-  VERSION = '1.2.8'
+  VERSION = '1.2.10'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.10
 platform: ruby
 authors:
 - Andrew Bromwich
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-11 00:00:00.000000000 Z
+date: 2026-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri