grover 1.2.7 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7db2892eede2403ccadf9ba0f08437a0baa981891cfa15b352a9a93540fa210e
-  data.tar.gz: 7d1e39781fb526c53f3445545ee810d275cea55c1216b08b1b3f8135027c0d58
+  metadata.gz: 4f53cae1260aa636889607929ff735fc876e1d439ad656f18a71dab32ef911a2
+  data.tar.gz: e51808378914be56bf9c9d320633ec0db33db7646d83a7edb229c7517d36540a
 SHA512:
-  metadata.gz: d54d14998ffe44d160b5b4586dc7a41a09f80a63a362b0745916052fc06d126b273c358992fc4a5273e6d7c2c668d18120cad4392409905de56ffa54e0850648
-  data.tar.gz: 58c59d86aceb48f4968bcc1c0ad6bd44b8e7602450e24304da1d61249b6e529ae9614e6c9d15c1fdad1e49f8575cd6a6c282a634af24000532573a68e03f8ca1
+  metadata.gz: dde098900baf3045083d5e60fdf431438c9fe599d373a44d21102c3bc9c2a5370fd6a7dadb580d74fd559f5cafcf2239c5249bd9849c4f2057f410b9fc88ce7f
+  data.tar.gz: b3a33f90d6658bde15d1bf9179f86fbb769d72c5c5ee3212f509aeda195def9233eb4a91ee4c17824d0646acd7e5d07907efa96374793ec23458ce4a60a1dffa

data/lib/active_support_ext/object/deep_dup.rb

@@ -20,7 +20,7 @@ class Object
   end
 end
 
-class Array
+class Array # rubocop:disable Style/OneClassPerFile
   # Returns a deep copy of array.
   #
   #   array = [1, [2, 3]]
@@ -34,7 +34,7 @@ class Array
   end
 end
 
-class Hash
+class Hash # rubocop:disable Style/OneClassPerFile
   # Returns a deep copy of hash.
   #
   #   hash = { a: { b: 'b' } }

data/lib/active_support_ext/object/duplicable.rb

@@ -31,7 +31,7 @@ class Object
   end
 end
 
-class Method
+class Method # rubocop:disable Style/OneClassPerFile
   # Methods are not duplicable:
   #
   #  method(:puts).duplicable? # => false
@@ -41,7 +41,7 @@ class Method
   end
 end
 
-class UnboundMethod
+class UnboundMethod # rubocop:disable Style/OneClassPerFile
   # Unbound methods are not duplicable:
   #
   #  method(:puts).unbind.duplicable? # => false

data/lib/grover/js/processor.cjs

@@ -104,6 +104,12 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
         launchParams.executablePath = executablePath;
       }
 
+      // Set launch timeout if given
+      const launchTimeout = options.launchTimeout; delete options.launchTimeout;
+      if (launchTimeout) {
+        launchParams.timeout = launchTimeout;
+      }
+
       // Launch the browser and create a page
       browser = await puppeteer.launch(launchParams);
     }
@@ -208,6 +214,11 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
       await cdp.send('Browser.setPermission', { permission: { name: 'local-network-access' }, setting: 'granted' });
     }
 
+    const javaScriptEnabled = options.javaScriptEnabled; delete options.javaScriptEnabled;
+    if (javaScriptEnabled !== undefined) {
+      await page.setJavaScriptEnabled(javaScriptEnabled);
+    }
+
     const raiseOnRequestFailure = options.raiseOnRequestFailure; delete options.raiseOnRequestFailure;
     if (raiseOnRequestFailure) {
       page.on('requestfinished', (request) => {

data/lib/grover/options_fixer.rb

@@ -9,6 +9,9 @@ class Grover
   class OptionsFixer
     FALSE_VALUES = [nil, false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF'].freeze
 
+    JAVASCRIPT_OPTIONS = %w[evaluate_on_new_document execute_script script_tag_options wait_for_function].freeze
+    private_constant :JAVASCRIPT_OPTIONS
+
     def initialize(options)
       @options = options
     end
@@ -18,6 +21,7 @@ class Grover
       fix_integer_options!
       fix_float_options!
       fix_array_options!
+      disable_javascript_options!
       @options
     end
 
@@ -35,13 +39,14 @@ class Grover
       fix_options!(
         'display_header_footer', 'full_page', 'landscape', 'omit_background', 'prefer_css_page_size',
         'print_background', 'viewport.has_touch', 'viewport.is_landscape', 'viewport.is_mobile', 'bypass_csp',
-        'raise_on_request_failure', 'raise_on_js_error'
+        'raise_on_request_failure', 'raise_on_js_error', 'javascript_enabled'
       ) { |value| !FALSE_VALUES.include?(value) }
     end
 
     def fix_integer_options!
       fix_options!(
-        'viewport.height', 'viewport.width', 'wait_for_timeout',
+        'viewport.height', 'viewport.width',
+        'timeout', 'launch_timeout', 'request_timeout', 'convert_timeout', 'wait_for_timeout',
         &:to_i
       )
     end
@@ -59,5 +64,20 @@ class Grover
         value.is_a?(String) ? YAML.safe_load(value) : value
       end
     end
+
+    def disable_javascript_options!
+      return if @options['javascript_enabled'] != false
+
+      JAVASCRIPT_OPTIONS.each do |option|
+        disable_javascript_option!(option)
+      end
+    end
+
+    def disable_javascript_option!(option)
+      return unless @options.key?(option)
+
+      @options.delete(option)
+      warn "#{self.class}: option #{option} has been disabled because javascript_enabled is set to false"
+    end
   end
 end

data/lib/grover/utils.rb

@@ -9,7 +9,8 @@ class Grover
       'css' => 'CSS',
       'csp' => 'CSP',
       'http' => 'HTTP',
-      'js' => 'JS'
+      'js' => 'JS',
+      'javascript' => 'JavaScript'
     }.freeze
     private_constant :ACRONYMS
 
@@ -94,9 +95,9 @@ class Grover
     # Regex sourced from ActiveSupport camelize
     #
     def self.normalize_key(key)
-      key.to_s.downcase.gsub(%r{(?:_|(/))([a-z\d]*)}) do
+      key.to_s.downcase.gsub(%r{(?:^|_|(/))([a-z\d]*)}) do
         "#{Regexp.last_match(1)}#{ACRONYMS[Regexp.last_match(2)] || Regexp.last_match(2).capitalize}"
-      end
+      end.sub(/^[[:alpha:]]/, &:downcase)
     end
     private_class_method :normalize_key
   end

data/lib/grover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Grover
-  VERSION = '1.2.7'
+  VERSION = '1.2.9'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.2.9
 platform: ruby
 authors:
 - Andrew Bromwich
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-06 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -52,7 +51,6 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -70,8 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A Ruby gem to transform HTML into PDF, PNG or JPEG by wrapping the NodeJS
   Google Puppeteer driver for Chromium