grover 1.2.2 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa11dd4c983b7d122791e035286bc18f9fdda40561f0102547b801aa4718013c
-  data.tar.gz: 77fb1776461acc88789f1405e4c3135b9857971116880239671f3302d4df0505
+  metadata.gz: 5802a16dce1cb3dea2a458c546aa944244348700a620bc7f457922929eddf4ac
+  data.tar.gz: 91106f24cc30484d869cb19d35bf2a850851cee760cb1cb5ad1ce33a5d0a3db3
 SHA512:
-  metadata.gz: d0e3ae26db5e6934bdb257c465001ac46f15404e201c1d5a431e96f03c36c4b27b1e10920337e0f67d4d012da55d9c651868b0497f20832ae191bb42eba29243
-  data.tar.gz: 5b9baa164d1fdb46b8a71dec29d68471622e9bd829742fee6975c19f2d2fc5b8a51b1f120f8ccebe7ee9ccfc1f38ed291881cb00998b7b72a90ae41bb0bd23d3
+  metadata.gz: 913c5292ae47d73bdd0e2298dbec7b0e89673371a486dcb82433f7a8e722414d50268fbcef5f724acef609f7bfe9c022c1527d150415d56b3434cfed309ce2b1
+  data.tar.gz: 5e2bb65db4893f6530a7eaed7b992078e639ee50e41a6e4234fc34c2d49666a47136772555d9993fb38b05f27e4cd5eff5ee60a82030d6640da818c1201f545b

data/lib/grover/js/processor.cjs

@@ -92,6 +92,12 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
         launchParams.args = launchParams.args.concat(args);
       }
 
+      // Set browser type if given
+      const browserType = options.browser; delete options.browser;
+      if (browserType) {
+        launchParams.browser = browserType;
+      }
+
       // Set executable path if given
       const executablePath = options.executablePath; delete options.executablePath;
       if (executablePath) {
@@ -114,7 +120,11 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
     // Setting cookies
     const cookies = options.cookies; delete options.cookies
     if (Array.isArray(cookies)) {
-      await page.setCookie(...cookies);
+      if (typeof browser.setCookie === 'function') {
+        await browser.setCookie(...cookies);
+      } else if (typeof page.setCookie === 'function') {
+        await page.setCookie(...cookies);
+      }
     }
 
     // Set caching flag (if provided)

data/lib/grover/middleware.rb

@@ -8,6 +8,13 @@ class Grover
   # @see https://github.com/pdfkit/pdfkit
   #
   class Middleware # rubocop:disable Metrics/ClassLength
+    PDF_REGEX = /\.pdf$/i
+    private_constant :PDF_REGEX
+    PNG_REGEX = /\.png$/i
+    private_constant :PNG_REGEX
+    JPEG_REGEX = /\.jpe?g$/i
+    private_constant :JPEG_REGEX
+
     def initialize(app, *args)
       @app = app
       @pdf_request = false
@@ -40,10 +47,6 @@ class Grover
 
     private
 
-    PDF_REGEX = /\.pdf$/i
-    PNG_REGEX = /\.png$/i
-    JPEG_REGEX = /\.jpe?g$/i
-
     attr_reader :pdf_request, :png_request, :jpeg_request
 
     def check_file_uri_configuration
@@ -85,7 +88,7 @@ class Grover
     end
 
     def html_content?(headers)
-      headers['content-type'] =~ %r{text/html|application/xhtml\+xml}
+      headers[lower_case_headers? ? 'content-type' : 'Content-Type'] =~ %r{text/html|application/xhtml\+xml}
     end
 
     def update_response(response, headers)
@@ -155,11 +158,12 @@ class Grover
 
     def assign_headers(headers, body, content_type)
       # Do not cache results
-      headers.delete 'etag'
-      headers.delete 'cache-control'
+      headers.delete(lower_case_headers? ? 'etag' : 'ETag')
+      headers.delete(lower_case_headers? ? 'cache-control' : 'Cache-Control')
 
-      headers['content-length'] = (body.respond_to?(:bytesize) ? body.bytesize : body.size).to_s
-      headers['content-type'] = content_type
+      headers[lower_case_headers? ? 'content-length' : 'Content-Length'] =
+        (body.respond_to?(:bytesize) ? body.bytesize : body.size).to_s
+      headers[lower_case_headers? ? 'content-type' : 'Content-Type'] = content_type
     end
 
     def configure_env_for_grover_request(env)
@@ -223,5 +227,11 @@ class Grover
       env.delete 'CONTENT_LENGTH'
       env.delete 'RAW_POST_DATA'
     end
+
+    def lower_case_headers?
+      return @lower_case_headers if defined? @lower_case_headers
+
+      @lower_case_headers = Gem::Version.new(Rack.release) >= Gem::Version.new('3')
+    end
   end
 end

data/lib/grover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Grover
-  VERSION = '1.2.2'
+  VERSION = '1.2.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.4
 platform: ruby
 authors:
 - Andrew Bromwich
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-13 00:00:00.000000000 Z
+date: 2025-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri