grover 1.1.3 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7082a7b6e05f0898404a1df133ed2f2cf3d0bb71ab0098b6707b9a29aa76e65
-  data.tar.gz: 2e458d1604e99fb8b0529982986cbffd45513fa4bf632e046ada76ae5bc30a51
+  metadata.gz: 9685b557f5d1cdc200fe5806aadc59106ccb9d6572e4d57c1660964286b3f4c7
+  data.tar.gz: b0584418598e6ca66b097b8e9ffc87ad5bbd6ae64becf74966ceef4b4d894730
 SHA512:
-  metadata.gz: 438cd6b10944fc008017fa4fd48d6e5e7919916a8d61a34cf1d7fbbaf5471215ab40b13c3a446665fa2d6bea1788532a1e0a198c776256ee9ddb444501934948
-  data.tar.gz: 76c38b2c307f7cdd41a2b8e67b854539e1ef2e34a6fda814cab64cfee911331dab7e8bfe3b468e165a2510ee679e244cf9ac8457a9fdaaef7886c3ab6ddc7256
+  metadata.gz: cfad1954989183edd8f9cd238085c6031ec9cfca25b61dbe6e83fd33bd733c4d60b97b64da59d9b6301b538aa26979e8e9813b40765fa34fd03a17f47f46897c
+  data.tar.gz: e06271f0ede0792519f7a6d1156b04e5d5465921b8b75d36438fffdf62a491c54029c73f070de6241cb4cb1654e548024115634fe27c80fa1ee1b056375d20c9

data/lib/grover/js/processor.cjs

@@ -10,34 +10,52 @@ try {
 }
 process.stdout.write("[\"ok\"]\n");
 
+const fs = require('fs');
+const os = require('os');
+const path = require('path');
+
 const _processPage = (async (convertAction, urlOrHtml, options) => {
-  let browser, errors = [];
-  try {
-    const launchParams = {
-      args: process.env.GROVER_NO_SANDBOX === 'true' ? ['--no-sandbox', '--disable-setuid-sandbox'] : []
-    };
+  let browser, errors = [], tmpDir;
 
+  try {
     // Configure puppeteer debugging options
     const debug = options.debug; delete options.debug;
-    if (typeof debug === 'object' && !!debug) {
-      if (debug.headless !== undefined) { launchParams.headless = debug.headless; }
-      if (debug.devtools !== undefined) { launchParams.devtools = debug.devtools; }
-    }
-
-    // Configure additional launch arguments
-    const args = options.launchArgs; delete options.launchArgs;
-    if (Array.isArray(args)) {
-      launchParams.args = launchParams.args.concat(args);
-    }
+    const browserWsEndpoint = options.browserWsEndpoint; delete options.browserWsEndpoint;
+    if (typeof browserWsEndpoint === "string") {
+      const connectParams = {
+        browserWSEndpoint: browserWsEndpoint,
+      };
 
-    // Set executable path if given
-    const executablePath = options.executablePath; delete options.executablePath;
-    if (executablePath) {
-      launchParams.executablePath = executablePath;
+      browser = await puppeteer.connect(connectParams);
+    } else {
+      tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'grover-'));
+
+      const launchParams = {
+        args: process.env.GROVER_NO_SANDBOX === 'true' ? ['--no-sandbox', '--disable-setuid-sandbox'] : [],
+        userDataDir: tmpDir
+      };
+  
+      if (typeof debug === 'object' && !!debug) {
+        if (debug.headless !== undefined) { launchParams.headless = debug.headless; }
+        if (debug.devtools !== undefined) { launchParams.devtools = debug.devtools; }
+      }
+  
+      // Configure additional launch arguments
+      const args = options.launchArgs; delete options.launchArgs;
+      if (Array.isArray(args)) {
+        launchParams.args = launchParams.args.concat(args);
+      }
+  
+      // Set executable path if given
+      const executablePath = options.executablePath; delete options.executablePath;
+      if (executablePath) {
+        launchParams.executablePath = executablePath;
+      }
+  
+      // Launch the browser and create a page
+      browser = await puppeteer.launch(launchParams);
     }
 
-    // Launch the browser and create a page
-    browser = await puppeteer.launch(launchParams);
     const page = await browser.newPage();
 
     // Basic auth
@@ -245,6 +263,10 @@ const _processPage = (async (convertAction, urlOrHtml, options) => {
     if (browser) {
       await browser.close();
     }
+
+    try {
+      if (tmpDir) fs.rmSync(tmpDir, { recursive: true });
+    } catch { }
   }
 });
 

data/lib/grover/options_builder.rb

@@ -8,7 +8,7 @@ class Grover
   # Build options from Grover.configuration, meta_options, and passed-in options
   #
   class OptionsBuilder < Hash
-    def initialize(options, url) # rubocop:disable Lint/MissingSuper
+    def initialize(options, url)
       @url = url
       combined = grover_configuration
       Utils.deep_merge! combined, Utils.deep_stringify_keys(options)

data/lib/grover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Grover
-  VERSION = '1.1.3'
+  VERSION = '1.1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.5
 platform: ruby
 authors:
 - Andrew Bromwich
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-20 00:00:00.000000000 Z
+date: 2023-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: combine_pdf
@@ -215,7 +215,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: A Ruby gem to transform HTML into PDF, PNG or JPEG by wrapping the NodeJS