grover 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31b9ab92a300720d35d5637e2a2462ec6e7dd733
-  data.tar.gz: b1cbe61e0db5eb406ed7991881c0702c14a059e4
+  metadata.gz: 3499ca1308bdc11b92605c7f1efb995f64f873ef
+  data.tar.gz: 4cf09e30a261f9f343369b954e7e51512fb11773
 SHA512:
-  metadata.gz: 9ade3e9c3f35ea52efc2292a842645e7e3c7f46030bf1142c7cfddafa69588bf3ea13bcfcf469130c281c5c4050d01c3348e1c002a28cbb740f87586e61b9b51
-  data.tar.gz: 4ec082e7a6cd7bce6e8d3dcf429ca86dc1b82a16d56f9fcb21f7b63b5f850e8e3033509da317c0833625d05ad9aa1da8524d730fd21ffc06e06895abf254f8f5
+  metadata.gz: f03c61dd07b4a9bd6698caad36fc9c60a1e2e07a7613c35b7e21166eacfe15c57ba65be64ce97045927b623075d4434d80d7e6bedbe17f79189dc5f90ed2b54a
+  data.tar.gz: ac097fe4fee335a54e06ed9cb12b1025463467fdddc918f8e113c6345fa73f72eb97f42bc8814e3cf29bb70f434b05afd674668706237e24c051778ee61b8c30

data/lib/grover.rb

@@ -21,28 +21,30 @@ class Grover
     dependencies puppeteer: 'puppeteer'
 
     def self.launch_params
-      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : '{}'
+      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : ''
     end
 
     method :convert_pdf, Utils.squish(<<-FUNCTION)
       async (url, options) => {
         let browser;
         try {
-          let launch_params = #{launch_params};
-          const timeout = options.timeout; delete options.timeout;
-          if (timeout) {
-            launch_params.timeout = timeout;
-          }
-          browser = await puppeteer.launch(launch_params);
+          browser = await puppeteer.launch(#{launch_params});
           const page = await browser.newPage();
 
           const cache = options.cache; delete options.cache;
           await page.setCacheEnabled(cache);
 
+          let request_options = {};
+          const timeout = options.timeout; delete options.timeout;
+          if (timeout) {
+            request_options.timeout = timeout;
+          }
           if (url.match(/^http/i)) {
-            await page.goto(url, { waitUntil: 'networkidle2' });
+            request_options.waitUntil = 'networkidle2';
+            await page.goto(url, request_options);
           } else {
-            await page.goto(`data:text/html,${url}`, { waitUntil: 'networkidle0' });
+            request_options.waitUntil = 'networkidle0';
+            await page.goto(`data:text/html,${url}`, request_options);
           }
 
           const emulateMedia = options.emulateMedia; delete options.emulateMedia;

data/lib/grover/version.rb

@@ -1,3 +1,3 @@
 class Grover
-  VERSION = '0.5.3'.freeze
+  VERSION = '0.5.4'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Andrew Bromwich