grover 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23be6a01f9d60e6aaa3e1c224a855b7424f40db5
-  data.tar.gz: 0f7e8fdeb229de987444e8e4756c8a3e09349202
+  metadata.gz: 31b9ab92a300720d35d5637e2a2462ec6e7dd733
+  data.tar.gz: b1cbe61e0db5eb406ed7991881c0702c14a059e4
 SHA512:
-  metadata.gz: 59a8240257511c3fb8afc32b6cf2842f99fd7454b48ad700c4fbc355bb81bc85db40ddb45765653d38df018a94997f1e7b7b35e213b4ca4ccf21d31ca960640e
-  data.tar.gz: 88a776f44751fc3ff49503acb98f08582d0519a472fbe36ea255aff97fce81b590302a47834a4811dc92bdc798c023c060b5e86e0eb8358db376d1198d8704ee
+  metadata.gz: 9ade3e9c3f35ea52efc2292a842645e7e3c7f46030bf1142c7cfddafa69588bf3ea13bcfcf469130c281c5c4050d01c3348e1c002a28cbb740f87586e61b9b51
+  data.tar.gz: 4ec082e7a6cd7bce6e8d3dcf429ca86dc1b82a16d56f9fcb21f7b63b5f850e8e3033509da317c0833625d05ad9aa1da8524d730fd21ffc06e06895abf254f8f5

data/lib/grover/version.rb

@@ -1,3 +1,3 @@
 class Grover
-  VERSION = '0.5.2'.freeze
+  VERSION = '0.5.3'.freeze
 end

data/lib/grover.rb

@@ -21,14 +21,19 @@ class Grover
     dependencies puppeteer: 'puppeteer'
 
     def self.launch_params
-      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : ''
+      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : '{}'
     end
 
     method :convert_pdf, Utils.squish(<<-FUNCTION)
       async (url, options) => {
         let browser;
         try {
-          browser = await puppeteer.launch(#{launch_params});
+          let launch_params = #{launch_params};
+          const timeout = options.timeout; delete options.timeout;
+          if (timeout) {
+            launch_params.timeout = timeout;
+          }
+          browser = await puppeteer.launch(launch_params);
           const page = await browser.newPage();
 
           const cache = options.cache; delete options.cache;

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Andrew Bromwich