groupped_settings 0.2.1.18711 → 0.2.2.67551

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98b5d72c5fe3fdeaceee36e13270a27a5f26ad5d73e5240c4b6a54966125055e
-  data.tar.gz: 67410e1173be82008f85ae66cca623ae0d8307c3a6d613e67c3a4ca04081bf41
+  metadata.gz: c2b3289e460b363068beab55a9a7512fe7bd46680a0a353132ed1cd94c2a2793
+  data.tar.gz: df3b8a4790c1c30a8979d52574c20a571bfe33b6b66dd4fb0229aed9fc706eae
 SHA512:
-  metadata.gz: 581e8feb560ef7711c1e0e102b9b2788fc9c6ba2699caa576219684e26a1d3b6f2488a0c889ad355b4e3e52f25ab441c3d00ea6a2976efc7580dee9027784aee
-  data.tar.gz: 1ac8925ecab3499923ef7920e62d863bedc9f7961db9906e19bab391ab434f7638a10a8e9d73a2cf90f1ee59547985dd4512ab4ee448b93400d9a5ce24c60b1d
+  metadata.gz: 5575a50cc7d0e47a5f36f5874028d7c67ebd3d0b57cebe97a33d7d2db378eb43db6d41582c6ef1fe9916086a3220ce18ca038ab95e21aef8436535634a2308d2
+  data.tar.gz: 2b79aa4b9b8e81547263e46345f74e5f2593038c4ca795b9f4c4ce70adffe34de74ef200ccf5e6085214ecce5aff3d62d8cf2ea8701b3d6600ad4c2c4d84fcdf

data/AUTHORS

@@ -0,0 +1 @@
+Samoilenko Yuri <kinnalru _at_ gmail.com>

data/lib/groupped/settings/group.rb

@@ -24,10 +24,12 @@ module Groupped
         Record.sanitize(settings).slice(*self.attribute_names)
       end
 
-      def self.load(target: nil)
-        Groupped::Settings[self.group_name, self, target: target]
+      def self.load(target: nil, settings: {})
+        Groupped::Settings[self.group_name, self, target: target, settings: settings]
       end
 
+      attr_reader :settings_record
+
       def initialize(record)
         @settings_record = record
         super(self.class.sanitize(record.settings))

data/lib/groupped/settings/version.rb

@@ -3,7 +3,7 @@
 module Groupped
   module Settings
 
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
 
   end
 end

data/lib/groupped/settings.rb

@@ -18,8 +18,8 @@ module Groupped
 
     class << self
 
-      def [](group, klass = Group, target: nil)
-        klass.new(Record.first_or_create!(group: group.downcase, target: target))
+      def [](group, klass = Group, target: nil, settings: {})
+        klass.new(Record.where(group: group.downcase, target: target).first_or_create!(settings: settings))
       end
 
       def configure

data/spec/group_spec.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+RSpec.describe Groupped::Settings::Group, type: :model do
+  class GenericGroup < Groupped::Settings::Group
+
+    self.group_name = 'generic'
+
+    attribute :key1, :integer
+    attribute :key2, :string, default: 'def'
+    attribute :key3, :string
+
+    validates :key2, length: { is: 3 }
+
+  end
+
+  describe GenericGroup do
+    let(:settings){ { key1: 1 } }
+    let(:record){ double(Groupped::Settings::Record, settings: settings) }
+
+    subject(:group){ described_class.new(record) }
+
+    it '::attribute_names should be ok' do
+      expect(described_class.attribute_names).to match(%w[key1 key2 key3])
+    end
+
+    it '::sanitize should transform keys' do
+      input = {
+        absent_key: '0',
+        key1: '1',
+        KEY2: '2',
+        'KeY3' => '3'
+      }
+
+      expect(described_class.sanitize(input)).to match('key1' => '1', 'key2' => '2', 'key3' => '3')
+    end
+
+    describe 'instance' do
+      before { expect(record).to receive(:settings).and_return(settings) }
+
+      it { expect(described_class).to receive(:sanitize).and_call_original; subject }
+      it { is_expected.to include('key1' => 1, 'key2' => 'def', 'key3' => nil) }
+      it { is_expected.to be_valid }
+      it { expect(group.changes).to be_empty }
+
+      describe '#save!' do
+        let(:save){ group.save! }
+
+        before { expect(record).to receive(:with_lock).and_yield }
+        before { expect(record).to receive(:save!).and_return(true) }
+
+        it { is_expected.to receive(:validate!).and_call_original; save }
+        it { expect(save).to eq(true) }
+
+        it do
+          group.key1 = 2
+          expect{ save }.to change{ group.changes }.from('key1' => [1, 2]).to({})
+        end
+      end
+
+
+      describe '#save' do
+        let(:save){ group.save; }
+
+        it ('success is expected to eq true') { is_expected.to receive(:save!).and_return(true); expect(save).to eq(true) }
+        it ('exception is expected to eq false'){ is_expected.to receive(:save!).and_raise('error'); expect(save).to eq(false) }
+      end
+
+      it '#to_h' do
+        expect(group.to_h).to match('key1' => 1, 'key2' => 'def', 'key3' => nil)
+      end
+
+      it '#to_hash' do
+        expect(group.to_h).to match('key1' => 1, 'key2' => 'def', 'key3' => nil)
+      end
+
+      describe 'validation' do
+        let(:settings){ { key1: 1, key2: '123123123' } }
+
+        it { is_expected.to include('key1' => 1, 'key2' => '123123123', 'key3' => nil) }
+        it { is_expected.not_to be_valid }
+        it { expect(group.changes).to be_empty }
+
+        describe '#save!' do
+          let(:save){ group.save! }
+
+          it { expect{ save }.to raise_error(ActiveModel::ValidationError) }
+        end
+
+        describe '#save' do
+          let(:save){ group.save }
+
+          it { expect(save).to eq(false) }
+        end
+      end
+    end
+  end
+end
+

data/spec/settings_spec.rb

@@ -0,0 +1,132 @@
+# frozen_string_literal: true
+
+RSpec.describe Groupped::Settings, type: :model do
+  describe '#[]' do
+    let(:group){ :test }
+    subject{ described_class[group] }
+
+    it { is_expected.to be_an(Groupped::Settings::Group) }
+    it {
+      expect{ subject }.to change{ Groupped::Settings::Record.where(group: group).count }
+        .from(0)
+        .to(1)
+    }
+  end
+
+  class TestGroup1 < Groupped::Settings::Group
+
+    self.group_name = :test1
+
+    attribute :key1, :integer
+    attribute :key2, :string, default: 'def'
+
+    validates :key2, length: { is: 3 }
+
+  end
+
+  class TestGroup2 < Groupped::Settings::Group
+
+    self.group_name = :test2
+
+    attribute :yek1, :datetime, default: 10.years.ago
+    attribute :yek2, :string
+
+    validates :yek2, presence: true
+
+  end
+
+  groups = { test1: TestGroup1, test2: TestGroup2 }
+
+  describe 'control' do
+    groups.each do |(group, klass)|
+      describe "group: #{group} -> #{klass}" do
+        it { expect(klass.group_name).to eq(group) }
+
+        it { expect(Groupped::Settings[group]).to be_an(Groupped::Settings::Group) }
+        it { expect(Groupped::Settings[:test1, klass]).to be_an(klass) }
+        it { expect(Groupped::Settings[:test1, klass].group_name).to eq(group) }
+        it { expect(klass.load).to be_an(klass) }
+        it { expect(klass.load.group_name).to eq(group) }
+      end
+    end
+  end
+
+  it 'huge integration' do
+    expect(Groupped::Settings::Record.count).to eq(0)
+
+    # groups.each do
+    s = TestGroup1.load
+    expect(s.changes).to be_empty
+    expect(s).to include('key1' => nil, 'key2' => 'def')
+    expect(Groupped::Settings::Record.count).to eq(1)
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match({})
+
+    s.save!
+    expect(s.changes).to be_empty
+    expect(s).to include('key1' => nil, 'key2' => 'def')
+    expect(Groupped::Settings::Record.count).to eq(1)
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match({})
+
+    s.key1 = 123
+    expect(s.changes).not_to be_empty
+    expect(s).to include('key1' => 123, 'key2' => 'def')
+    s.save!
+    expect(Groupped::Settings::Record.count).to eq(1)
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match('key1' => 123)
+
+    s = TestGroup1.load
+    expect(s.changes).to be_empty
+    expect(s).to include('key1' => 123, 'key2' => 'def')
+    expect(Groupped::Settings::Record.count).to eq(1)
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match('key1' => 123)
+
+    # handle missing keys
+    r = Groupped::Settings::Record.find_by_group(:test1)
+    r.settings[:absent] = true
+    r.save!
+
+    s = TestGroup1.load
+    expect(s.changes).to be_empty
+    expect(s).to include('key1' => 123, 'key2' => 'def')
+    expect(Groupped::Settings::Record.count).to eq(1)
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match('key1' => 123, 'absent' => true)
+
+    s2 = TestGroup1.load
+
+    s.key1 = 321
+    s2.key2 = 'tes'
+    s2.save!
+
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match('key1' => 123, 'absent' => true, 'key2' => 'tes')
+    s.save!
+    expect(Groupped::Settings::Record.find_by_group(:test1).settings).to match('key1' => 321, 'absent' => true, 'key2' => 'tes')
+
+    s1 = TestGroup1.load
+    s2 = TestGroup1.load
+
+    expect(s1).to match(s2)
+
+    s1.key1 = 543
+    expect(s1).not_to match(s2)
+  end
+
+  describe 'with target' do
+    let!(:user){ User.create! }
+    before do
+      User.include Groupped::Settings::Settingsable
+    end
+
+    it do
+      expect(user.groupped_settings.count).to eq(0)
+      s = user.settings_group(:base)
+      expect(user.groupped_settings.count).to eq(1)
+
+      s = user.settings_group(:base, TestGroup1)
+      s.key1 = 777
+      s.save
+      expect(user.groupped_settings.count).to eq(1)
+      expect(user.groupped_settings.first.settings).to match('key1' => 777)
+    end
+  end
+end
+

data/spec/spec_helper.rb

@@ -0,0 +1,118 @@
+# frozen_string_literal: true
+
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+
+# require 'rspec/retry'
+
+require 'simplecov'
+require 'simplecov-console'
+ENV['RACK_ENV'] ||= 'test'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
+                                                                 SimpleCov::Formatter::HTMLFormatter, # for gitlab
+                                                                 SimpleCov::Formatter::Console # for developers
+                                                               ])
+SimpleCov.start
+
+$root = File.join(File.dirname(__dir__), 'spec')
+Dir[File.join(__dir__, 'support', '**', '*.rb')].sort.each {|f| puts f; require f }
+
+require 'groupped_settings'
+
+RSpec.configure do |config|
+  # config.verbose_retry = true
+  # Try twice (retry once)
+  # config.default_retry_count = 2
+
+  config.before(:suite) do
+    Groupped::Settings.configure do |config|
+    end
+  end
+
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # config.filter_run :molot
+  config.run_all_when_everything_filtered = true
+
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # These two settings work together to allow you to limit a spec run
+  #   # to individual examples or groups you care about by tagging them with
+  #   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  #   # get run.
+  #   config.filter_run :focus
+  #   config.run_all_when_everything_filtered = true
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  #   config.disable_monkey_patching!
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
+end
+

data/spec/support/database.yml

@@ -0,0 +1,3 @@
+test:
+  adapter: sqlite3
+  database: ":memory:"

data/spec/support/database_cleaner.rb

@@ -0,0 +1,24 @@
+require 'database_cleaner'
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:all) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end
+

data/spec/support/db_helper.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'active_record'
+require 'protected_attributes' if ENV['PROTECTED_ATTRIBUTES'] == 'true'
+
+I18n.enforce_available_locales = false if I18n.respond_to?(:enforce_available_locales=)
+
+class User < ActiveRecord::Base
+  # has_settings do |s|
+  #   s.key :dashboard, :defaults => { :theme => 'blue', :view => 'monthly', :filter => true }
+  #   s.key :calendar,  :defaults => { :scope => 'company'}
+  # end
+end
+
+def setup_db
+  ActiveRecord::Base.configurations = YAML.load_file(File.dirname(__FILE__) + '/database.yml')
+  ActiveRecord::Base.establish_connection(:test)
+  ActiveRecord::Migration.verbose = false
+
+  print "Testing with ActiveRecord #{ActiveRecord::VERSION::STRING}"
+  if ActiveRecord::VERSION::MAJOR == 4
+    print " #{defined?(ProtectedAttributes) ? 'with' : 'without'} gem `protected_attributes`"
+  end
+  puts
+
+  require File.expand_path("#{$root}/../lib/generators/templates/migration.rb", __FILE__)
+  GrouppedSettingsMigration.migrate(:up)
+
+  ActiveRecord::Schema.define(version: 1) do
+    create_table :users do |t|
+      t.string :type
+      t.string :name
+    end
+  end
+end
+
+def clear_db
+  User.delete_all
+  # RailsSettings::SettingObject.delete_all
+end
+
+setup_db
+

metadata

@@ -1,49 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: groupped_settings
 version: !ruby/object:Gem::Version
-  version: 0.2.1.18711
+  version: 0.2.2.67551
 platform: ruby
 authors:
 - Samoilenko Yuri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2021-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '2.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '2.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.0.1
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +150,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- AUTHORS
 - README.md
 - lib/generators/groupped/settings/install_generator.rb
 - lib/generators/groupped/settings/migration_generator.rb
@@ -163,6 +164,12 @@ files:
 - lib/groupped/settings/settingsable.rb
 - lib/groupped/settings/version.rb
 - lib/groupped_settings.rb
+- spec/group_spec.rb
+- spec/settings_spec.rb
+- spec/spec_helper.rb
+- spec/support/database.yml
+- spec/support/database_cleaner.rb
+- spec/support/db_helper.rb
 homepage: https://github.com/RnD-Soft/groupped_settings
 licenses:
 - MIT
@@ -186,4 +193,10 @@ rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Groupped::Settings is a plugin that manage groupped settings for Rails :)
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/settings_spec.rb
+- spec/support/db_helper.rb
+- spec/support/database.yml
+- spec/support/database_cleaner.rb
+- spec/group_spec.rb