grouped_scope 0.6.1 → 3.1.0

data/test/cases/self_grouping_test.rb

@@ -0,0 +1,201 @@
+require 'helper'
+
+class GroupedScope::SelfGrouppingTest < GroupedScope::TestCase
+  
+  describe 'General behavior' do
+    
+    before do
+      @employee = FactoryGirl.create(:employee)
+    end
+    
+    it 'return #ids array' do
+      assert_equal [@employee.id], @employee.group.ids
+      e1 = FactoryGirl.create :employee, :group_id => 3
+      e2 = FactoryGirl.create :employee, :group_id => 3
+      assert_same_elements [e1.id, e2.id], e1.group.ids
+    end
+    
+    it 'return #quoted_ids string for use in sql statments' do
+      assert_equal "#{@employee.id}", @employee.group.quoted_ids
+    end
+    
+    it 'respond true to grouped associations' do
+      assert @employee.group.respond_to?(:reports)
+    end
+    
+    it 'raise a GroupedScope::NoGroupIdError exception for objects with no group_id schema' do
+      FooBar.column_names.wont_include 'group_id'
+      lambda{ GroupedScope::SelfGroupping.new(FooBar.new) }.must_raise(GroupedScope::NoGroupIdError)
+    end
+    
+    it 'return correct predicate for GroupedScope::SelfGroupping object' do
+      @employee.update_attribute :group_id, 82
+      expected_sql = /"group_id" IN \(SELECT "employees"\."id" FROM "employees"  WHERE "employees"\."group_id" = 82/
+      assert_sql(expected_sql) { Employee.where(:group_id => @employee.group).all }
+      assert_sql(expected_sql) { Employee.all(:conditions => {:group_id => @employee.group}) }
+      assert_equal [@employee], Employee.where(:group_id => @employee.group).all
+    end
+    
+    it 'allows you to ask if the group is present' do
+      @employee.update_attribute :group_id, 28
+      assert_no_queries do
+        assert @employee.group_id.present?
+        assert @employee.group.present?
+      end
+    end
+    
+    it 'allows you to ask if the group is blank' do
+      assert_no_queries do
+        assert @employee.group_id.blank?
+        assert @employee.group.blank?
+      end
+    end
+    
+    describe 'for #with_reflection' do
+      
+      before { @reflection = Employee.reflections[:reports] }
+      
+      it 'will set a reflection and always set it back to nil' do
+        assert_nil @employee.group.reflection
+        @employee.group.with_reflection(@reflection) do
+          assert_equal @reflection, @employee.group.reflection
+        end
+        assert_nil @employee.group.reflection
+      end
+      
+      it 'will use the primary key of the reflection' do
+        pk = 'association_primary_key'
+        @reflection.stubs :association_primary_key => pk
+        @employee.group.with_reflection(@reflection) do
+          assert_equal pk, @employee.group.send(:primary_key)
+        end
+      end
+      
+    end
+    
+    describe 'for Array delegates' do
+
+      it 'respond to first/last' do
+        [:first,:last].each do |method|
+          assert @employee.group.respond_to?(method), "Should respond to #{method.inspect}"
+        end
+      end
+      
+      it 'respond to each' do
+        assert @employee.group.respond_to?(:each)
+        @employee.group.each do |employee|
+          assert_instance_of Employee, employee
+        end
+      end
+      
+    end
+    
+  end
+  
+  describe 'Calling #group' do
+    
+    it 'returns a active record relation' do
+      assert_instance_of ActiveRecord::Relation, FactoryGirl.create(:employee).group
+    end
+    
+    describe 'with a NIL group_id' do
+      
+      before do
+        @employee = FactoryGirl.create(:employee)
+      end
+      
+      it 'return a collection of one' do
+        assert_equal 1, @employee.group.size
+      end
+      
+      it 'include self in group' do
+        assert @employee.group.include?(@employee)
+      end
+      
+      it 'returns a sql literal for #ids_sql scoped to single record' do
+        @employee.group.ids_sql.must_be_instance_of Arel::Nodes::SqlLiteral
+        @employee.group.ids_sql.must_match %r{SELECT \"employees\".\"id\" FROM \"employees\"  WHERE \"employees\".\"id\" = #{@employee.id}}
+      end
+      
+    end
+    
+    describe 'with a set group_id' do
+      
+      before do
+        @employee = FactoryGirl.create(:employee, :group_id => 1)
+      end
+      
+      it 'return a collection of one' do
+        assert_equal 1, @employee.group.size
+      end
+      
+      it 'include self in group' do
+        assert @employee.group.include?(@employee)
+      end
+      
+      it 'returns a sql literal for #ids_sql scoped to group' do
+        new_group_id = 420
+        e1 = FactoryGirl.create :employee, :group_id => new_group_id
+        e2 = FactoryGirl.create :employee, :group_id => new_group_id
+        e1.group.ids_sql.must_be_instance_of Arel::Nodes::SqlLiteral
+        e1.group.ids_sql.must_match %r{SELECT \"employees\".\"id\" FROM \"employees\"  WHERE \"employees\".\"group_id\" = #{new_group_id}}
+      end
+      
+      it 'allows the group to be further scoped' do
+        new_group_id = 420
+        e1 = FactoryGirl.create :employee, :group_id => new_group_id, :name => 'Ken', :email => 'ken@actionmoniker.com'
+        e2 = FactoryGirl.create :employee, :group_id => new_group_id, :name => 'Hostmaster', :email => 'hostmaster@actionmoniker.com'
+        e3 = FactoryGirl.create :employee, :group_id => new_group_id, :name => 'Ken', :email => 'ken@metaskills.net'
+        assert_same_elements [e1, e2], e1.group.email_for_actionmoniker
+      end
+      
+    end
+    
+    describe 'with different groups available' do
+      
+      before do
+        @e1 = FactoryGirl.create(:employee_with_reports, :group_id => 1)
+        @e2 = FactoryGirl.create(:employee, :group_id => 1)
+        @e3 = FactoryGirl.create(:employee_with_reports, :group_id => 2)
+        @e4 = FactoryGirl.create(:employee, :group_id => 2)
+      end
+      
+      it 'return a collection of group members' do
+        assert_equal 2, @e1.group.size
+      end
+      
+      it 'include all group members' do
+        assert_same_elements [@e1,@e2], @e1.group
+      end
+      
+      it 'allow member to find grouped associations of other member' do
+        assert_same_elements @e1.reports, @e2.group.reports
+      end
+      
+      it 'allow proxy owner to define all grouped which ignores group_id schema' do
+        @e2.stubs :all_grouped? => true
+        assert_same_elements [@e1,@e2,@e3,@e4], @e2.group
+        assert_same_elements @e1.reports + @e3.reports, @e2.group.reports
+      end
+      
+    end
+    
+    describe 'with different groups in legacy schema' do
+      
+      before do
+        @e1 = FactoryGirl.create(:legacy_employee_with_reports, :group_id => 1)
+        @e2 = FactoryGirl.create(:legacy_employee, :group_id => 1)
+        @e3 = FactoryGirl.create(:legacy_employee_with_reports, :group_id => 2)
+        @e4 = FactoryGirl.create(:legacy_employee, :group_id => 2)
+      end
+      
+      it 'honor legacy reports association options like class_name and foreign_key' do
+        @e2.group.reports.all? { |r| r.is_a?(LegacyReport) }
+      end
+      
+    end
+    
+  end
+  
+  
+end

data/test/helper.rb

@@ -3,28 +3,40 @@ require 'bundler'
 require "bundler/setup"
 Bundler.require(:default, :development, :test)
 require 'grouped_scope'
-require 'mini_shoulda'
 require 'minitest/autorun'
 require 'factories'
+require 'logger'
 
-WillPaginate.enable_activerecord
 
-ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__)+'/debug.log')
+ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__),'debug.log'))
 ActiveRecord::Base.establish_connection :adapter => 'sqlite3', :database => ':memory:'
-ActiveRecord::Base.connection.class.class_eval do
-  IGNORED_SQL = [/^PRAGMA/, /^SELECT currval/, /^SELECT CAST/, /^SELECT @@IDENTITY/, /^SELECT @@ROWCOUNT/]
-  def execute_with_query_record(sql, name = nil, &block)
-    $queries_executed ||= []
-    $queries_executed << sql unless IGNORED_SQL.any? { |r| sql =~ r }
-    execute_without_query_record(sql, name, &block)
+module ActiveRecord
+  class SQLCounter
+    cattr_accessor :ignored_sql
+    self.ignored_sql = [/^PRAGMA table_info\(.*\)/, /^SELECT currval/, /^SELECT CAST/, /^SELECT @@IDENTITY/, /^SELECT @@ROWCOUNT/, /^SAVEPOINT/, /^ROLLBACK TO SAVEPOINT/, /^RELEASE SAVEPOINT/, /^SHOW max_identifier_length/, /^BEGIN/, /^COMMIT/]
+    ignored_sql.concat [/^select .*nextval/i, /^SAVEPOINT/, /^ROLLBACK TO/, /^\s*select .* from all_triggers/im]
+    def initialize
+      $queries_executed = []
+    end
+    def call(name, start, finish, message_id, values)
+      sql = values[:sql]
+      unless 'CACHE' == values[:name]
+        $queries_executed << sql unless self.class.ignored_sql.any? { |r| sql =~ r }
+      end
+    end
   end
-  alias_method_chain :execute, :query_record
+  ActiveSupport::Notifications.subscribe('sql.active_record', SQLCounter.new)
 end
 
 
 module GroupedScope
   class TestCase < MiniTest::Spec
     
+    include Mocha::API
+    
+    before { setup_environment }
+    after  { mocha_teardown }
+    
     def setup_environment(options={})
       options.reverse_merge! :group_column => :group_id
       setup_database(options)
@@ -47,23 +59,24 @@ module GroupedScope
     def assert_sql(*patterns_to_match)
       $queries_executed = []
       yield
+      $queries_executed
     ensure
       failed_patterns = []
       patterns_to_match.each do |pattern|
         failed_patterns << pattern unless $queries_executed.any?{ |sql| pattern === sql }
       end
-      assert failed_patterns.empty?, "Query pattern(s) #{failed_patterns.map(&:inspect).join(', ')} not found in:\n#{$queries_executed.inspect}"
+      assert failed_patterns.empty?, "Query pattern(s) #{failed_patterns.map{ |p| p.inspect }.join(', ')} not found.#{$queries_executed.size == 0 ? '' : "\nQueries:\n#{$queries_executed.join("\n")}"}"
     end
 
     def assert_queries(num = 1)
       $queries_executed = []
       yield
     ensure
-      assert_equal num, $queries_executed.size, "#{$queries_executed.size} instead of #{num} queries were executed."
+      assert_equal num, $queries_executed.size, "#{$queries_executed.size} instead of #{num} queries were executed.#{$queries_executed.size == 0 ? '' : "\nQueries:\n#{$queries_executed.join("\n")}"}"
     end
 
-    def assert_no_queries(&block)
-      assert_queries(0, &block)
+    def assert_no_queries
+      assert_queries(0) { yield }
     end
     
     def setup_database(options)
@@ -108,44 +121,44 @@ module GroupedScope
   end
 end
 
-class Employee < ActiveRecord::Base
-  has_many :reports do ; def urgent ; find(:all,:conditions => {:title => 'URGENT'}) ; end ; end
-  has_many :taxonomies, :as => :classable
+class Department < ActiveRecord::Base
+  scope :it, where(:name => 'IT')
+  scope :hr, where(:name => 'Human Resources')
+  scope :finance, where(:name => 'Finance')
   has_many :department_memberships
-  has_many :departments, :through => :department_memberships
-  grouped_scope :reports, :departments
+  has_many :employees, :through => :department_memberships
+end
+
+class DepartmentMembership < ActiveRecord::Base
+  belongs_to :employee
+  belongs_to :department
 end
 
 class Report < ActiveRecord::Base
-  named_scope :with_urgent_title, :conditions => {:title => 'URGENT'}
-  named_scope :with_urgent_body, :conditions => "body LIKE '%URGENT%'"
+  scope :with_urgent_title, where(:title => 'URGENT')
+  scope :with_urgent_body, where("body LIKE '%URGENT%'")
   belongs_to :employee
   def urgent_title? ; self[:title] == 'URGENT' ; end
   def urgent_body? ; self[:body] =~ /URGENT/ ; end
 end
 
-class Department < ActiveRecord::Base
-  named_scope :it, :conditions => {:name => 'IT'}
-  named_scope :hr, :conditions => {:name => 'Human Resources'}
-  named_scope :finance, :conditions => {:name => 'Finance'}
-  has_many :department_memberships
-  has_many :employees, :through => :department_memberships
+class LegacyReport < ActiveRecord::Base
+  belongs_to :employee, :class_name => 'LegacyEmployee', :foreign_key => 'email'
 end
 
-class DepartmentMembership < ActiveRecord::Base
-  belongs_to :employee
-  belongs_to :department
+class Employee < ActiveRecord::Base
+  scope :email_for_actionmoniker, where("email LIKE '%@actionmoniker.com'")
+  has_many :reports do ; def urgent ; find(:all,:conditions => {:title => 'URGENT'}) ; end ; end
+  has_many :taxonomies, :as => :classable
+  has_many :department_memberships
+  has_many :departments, :through => :department_memberships
+  grouped_scope :reports, :departments
 end
 
 class LegacyEmployee < ActiveRecord::Base
   set_primary_key :email
   has_many :reports, :class_name => 'LegacyReport', :foreign_key => 'email'
   grouped_scope :reports
-  alias_method :email=, :id=
-end
-
-class LegacyReport < ActiveRecord::Base
-  belongs_to :employee, :class_name => 'LegacyEmployee', :foreign_key => 'email'
 end
 
 class FooBar < ActiveRecord::Base

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: grouped_scope
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 3
   prerelease: 
   segments: 
-  - 0
-  - 6
+  - 3
   - 1
-  version: 0.6.1
+  - 0
+  version: 3.1.0
 platform: ruby
 authors: 
 - Ken Collins
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-11 00:00:00 -04:00
-default_executable: 
+date: 2011-12-07 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord
@@ -26,12 +25,12 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 31
+        hash: 5
         segments: 
-        - 2
         - 3
-        - 14
-        version: 2.3.14
+        - 1
+        - 3
+        version: 3.1.3
   type: :runtime
   version_requirements: *id001
 description: Extends has_many associations to group scope. For ActiveRecord 2.3.x!
@@ -45,30 +44,29 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .travis.yml
 - CHANGELOG
 - Gemfile
 - MIT-LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - lib/grouped_scope.rb
-- lib/grouped_scope/association_reflection.rb
-- lib/grouped_scope/class_methods.rb
-- lib/grouped_scope/core_ext.rb
+- lib/grouped_scope/arish/associations/association_scope.rb
+- lib/grouped_scope/arish/associations/builder/grouped_association.rb
+- lib/grouped_scope/arish/associations/builder/grouped_collection_association.rb
+- lib/grouped_scope/arish/associations/collection_association.rb
+- lib/grouped_scope/arish/base.rb
+- lib/grouped_scope/arish/reflection.rb
+- lib/grouped_scope/arish/relation/predicate_builer.rb
 - lib/grouped_scope/errors.rb
-- lib/grouped_scope/grouping.rb
-- lib/grouped_scope/has_many_association.rb
-- lib/grouped_scope/has_many_through_association.rb
-- lib/grouped_scope/instance_methods.rb
 - lib/grouped_scope/self_grouping.rb
 - lib/grouped_scope/version.rb
+- test/cases/has_many_test.rb
+- test/cases/has_many_through_test.rb
+- test/cases/reflection_test.rb
+- test/cases/self_grouping_test.rb
 - test/factories.rb
-- test/grouped_scope/association_reflection_test.rb
-- test/grouped_scope/class_methods_test.rb
-- test/grouped_scope/has_many_association_test.rb
-- test/grouped_scope/has_many_through_association_test.rb
-- test/grouped_scope/self_grouping_test.rb
 - test/helper.rb
-has_rdoc: true
 homepage: http://github.com/metaskills/grouped_scope/
 licenses: []
 
@@ -98,15 +96,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Extends has_many associations to group scope.
 test_files: 
+- test/cases/has_many_test.rb
+- test/cases/has_many_through_test.rb
+- test/cases/reflection_test.rb
+- test/cases/self_grouping_test.rb
 - test/factories.rb
-- test/grouped_scope/association_reflection_test.rb
-- test/grouped_scope/class_methods_test.rb
-- test/grouped_scope/has_many_association_test.rb
-- test/grouped_scope/has_many_through_association_test.rb
-- test/grouped_scope/self_grouping_test.rb
 - test/helper.rb