groupdate 4.1.1 → 4.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bdc7848103a019e737a44e522ae42dcdb521c2ae136d9a52d1bafba795127d4
-  data.tar.gz: fccb9acee92d478d605ac8022e75173bccd4825ad5118a32d5aaaf3ef34c5349
+  metadata.gz: 28ba8881c2af7869f774eceebed739e851e81d7d28b53473762260e7c4297134
+  data.tar.gz: e0031f94b52b53255bdbe01c0f72d5c7abcb20d94b02d81bf9e31344a957919a
 SHA512:
-  metadata.gz: 9ad47038f6ec8193721ebc56509c1bda0feff36ecb65a7c08e63859592d55de1387e3e0fb907ac55c16329bf8c275265492ab45b6d7217643203d1c94419d324
-  data.tar.gz: c53eb19f798e162eef984cf6dc32b8be7b3b9e40008dfed445653fae618ae0d1db65e1420db6896f254f5c48daf49f3e97e163c5ed41958e75ad98c7d77590a0
+  metadata.gz: cb863625ed13dea87c18b31bf897f0e6d6c00bb02b3c41aaf08a11221cc52a8cbfea5cb4f8fe991d33552b0f9294c9c2c04bfb1c220bdcfb8688dbacc848ceed
+  data.tar.gz: 805c5290d0652b2f82c3426fb253dc962bc9c2e4903b3edb1aa2451dc252f0c94bbc7737d3c1b8ddd429c5844ca99c8c01b1e872f1efd4980a747eb4cd2c4294

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 4.1.2
+
+- Fixed error with empty data and `current: false`
+- Fixed error in time zone check for Rails < 5.2
+- Prevent infinite loop with endless ranges
+
 ## 4.1.1
 
 - Made column resolution consistent with `group`

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013-2018 Andrew Kane
+Copyright (c) 2013-2019 Andrew Kane
 
 MIT License
 

data/README.md

@@ -17,7 +17,17 @@ Supports PostgreSQL, MySQL, and Redshift, plus arrays and hashes (and limited su
 
 [![Build Status](https://travis-ci.org/ankane/groupdate.svg?branch=master)](https://travis-ci.org/ankane/groupdate)
 
-## Get Started
+## Installation
+
+Add this line to your application’s Gemfile:
+
+```ruby
+gem 'groupdate'
+```
+
+For MySQL and SQLite, also follow [these instructions](#additional-instructions).
+
+## Getting Started
 
 ```ruby
 User.group_by_day(:created_at).count
@@ -221,15 +231,9 @@ Count
 Hash[ users.group_by_day { |u| u.created_at }.map { |k, v| [k, v.size] } ]
 ```
 
-## Installation
-
-Add this line to your application’s Gemfile:
-
-```ruby
-gem 'groupdate'
-```
+## Additional Instructions
 
-#### For MySQL
+### For MySQL
 
 [Time zone support](https://dev.mysql.com/doc/refman/5.7/en/time-zone-support.html) must be installed on the server.
 
@@ -247,7 +251,7 @@ SELECT CONVERT_TZ(NOW(), '+00:00', 'Pacific/Honolulu');
 
 It should return the time instead of `NULL`.
 
-#### For SQLite
+### For SQLite
 
 Groupdate has limited support for SQLite.
 
@@ -301,3 +305,5 @@ Everyone is encouraged to help improve this project. Here are a few ways you can
 - Fix bugs and [submit pull requests](https://github.com/ankane/groupdate/pulls)
 - Write, clarify, or fix documentation
 - Suggest or add new features
+
+To get started with development and testing, check out the [Contributing Guide](CONTRIBUTING.md).

data/lib/groupdate/magic.rb

@@ -13,6 +13,7 @@ module Groupdate
 
       raise Groupdate::Error, "Unrecognized time zone" unless time_zone
       raise Groupdate::Error, "Unrecognized :week_start option" if period == :week && !week_start
+      raise Groupdate::Error, "Cannot use endless range for :range option" if options[:range].is_a?(Range) && !options[:range].end
     end
 
     def time_zone
@@ -110,7 +111,8 @@ module Groupdate
 
       def time_zone_support?(relation)
         if relation.connection.adapter_name =~ /mysql/i
-          sql = relation.send(:sanitize_sql_array, ["SELECT CONVERT_TZ(NOW(), '+00:00', ?)", time_zone.tzinfo.name])
+          # need to call klass for Rails < 5.2
+          sql = relation.klass.send(:sanitize_sql_array, ["SELECT CONVERT_TZ(NOW(), '+00:00', ?)", time_zone.tzinfo.name])
           !relation.connection.select_all(sql).first.values.first.nil?
         else
           true

data/lib/groupdate/series_builder.rb

@@ -158,7 +158,7 @@ module Groupdate
               end
 
             tr = sorted_keys.first..sorted_keys.last
-            if options[:current] == false && round_time(now) >= tr.last
+            if options[:current] == false && sorted_keys.any? && round_time(now) >= tr.last
               tr = tr.first...round_time(now)
             end
             tr

data/lib/groupdate/version.rb

@@ -1,3 +1,3 @@
 module Groupdate
-  VERSION = "4.1.1"
+  VERSION = "4.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: groupdate
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.1.2
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -112,16 +112,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.0
 description: 
 email: andrew@chartkick.com
 executables: []
@@ -160,8 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: The simplest way to group temporal data