groovy 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2e735dd501cd86a3ee2ab21b111bf7aa4ab3d76d9d14acf8be86b97e34335b1
-  data.tar.gz: 97b3b88d1f297ab6d74b9818858272c8fa711a27a3c0d64964508988a3304b85
+  metadata.gz: 5ebda26142ef67b09916291cafb3941fd34db0310b259aaf5c2ecf1b5fee3596
+  data.tar.gz: 5ee7f4f6c39b0237b281c1d04f27c3cd77ce1d9bb840a34fe8de88aa5114d28b
 SHA512:
-  metadata.gz: deb85e6549f328555d795e542e282c6e3a50c574fdac769530648c69292f02ed469bc293304db863b7c9ac28a5bb653bd85eb79a7652f6390b3f5309fc492552
-  data.tar.gz: 7546011290684eca615cf4823df5886908fe823c9bee086a80504a01a7d3aa846a0fd34dc05efc023a061078ac3645d352618c64a03b614989cb51bc3ca4c5c9
+  metadata.gz: 4a10d18486ab2f434fd83b46c2d74da3851a80a227af4a42caff4a070d3d7701716a202e52b26591041cd7c57cdb144b9c2abee06186415aeebbdb0b276df55d
+  data.tar.gz: af55ec1bb42eaf1fec2de9431fe9b16369348f000a3d8740abb6ec1b02297297826b97cec34c1955615901366427d87bf1b02192320faf92c8d1e1a255c44477

data/lib/groovy/model.rb

@@ -221,6 +221,12 @@ module Groovy
         set_timestamp(attributes, :created_at)
         set_timestamp(attributes, :updated_at)
 
+        # remove nil attributes for integer columns, otherwise
+        # we get a TypeError (no implicit conversion from nil to integer)
+        attributes.each do |k, v|
+          attributes.delete(k) if v.nil? # && schema.integer_columns.include?(k)
+        end
+
         if table.support_key?
           raise "Key required" if key.nil?
           table.add(key, attributes)
@@ -297,7 +303,7 @@ module Groovy
       else
         attrs ||= {}
         unless attrs.is_a?(Hash)
-          raise ArgumentError.new("Attributes should be a Hash")
+          raise ArgumentError.new("Attributes should be a Hash, not a #{attrs.class}")
         end
 
         # don't call set_attributes since we don't want to call
@@ -411,7 +417,7 @@ module Groovy
 
     def get_record_attribute(key)
       val = record[key]
-      if self.class.schema.time_column?(key)
+      if self.class.schema.time_columns.include?(key)
         fix_time_value(val)
       else
         val

data/lib/groovy/schema.rb

@@ -56,14 +56,25 @@ module Groovy
     end
 
     def time_columns
-      # @time_columns ||=
-      get_names(table.columns.select { |c| c.column? && c.range.name == 'Time' })
+      columns_by_type('Time')
     end
 
-    def time_column?(name)
-      time_columns.include?(name)
+    def integer_columns
+      columns_by_type('Int32')
     end
 
+    def boolean_columns
+      columns_by_type('Bool')
+    end
+
+    def columns_by_type(type)
+      get_names(table.columns.select { |c| c.column? && c.range.name == type })
+    end
+
+    # def time_column?(name)
+    #   time_columns.include?(name)
+    # end
+
     def rebuild!
       log("Rebuilding!")
       # remove_table! if table

data/lib/groovy/version.rb

@@ -1,3 +1,3 @@
 module Groovy
-  VERSION = '0.4.2'.freeze
+  VERSION = '0.4.3'.freeze
 end

data/spec/model_spec.rb

@@ -17,7 +17,7 @@ describe Groovy::Model do
   describe '.scope' do
 
     before :all do
-      TestProduct.class_eval do 
+      TestProduct.class_eval do
         scope :with_name, -> (name) { where(name: name) if name }
         scope :by_price_asc, -> { sort_by(price: :asc) }
         scope :cheapest, -> { by_price_asc }
@@ -49,6 +49,13 @@ describe Groovy::Model do
   end
 
   describe '.create' do
+
+    it 'does not explode when inserting nil values for columns' do
+      expect do
+        TestProduct.create({ price: nil })
+      end.not_to raise_error
+    end
+
   end
 
   describe '.find' do
@@ -60,6 +67,7 @@ describe Groovy::Model do
   describe '.delete_all' do
 
     before do
+      TestProduct.delete_all
       @first  = TestProduct.create!(name: 'A product', price: 100)
       @second = TestProduct.create!(name: 'Another product', price: 200)
       expect(TestProduct.count).to eq(2)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: groovy
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Tomás Pollak