groovehq 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43f043143339184bc705dda2e5fa561531a5c010
-  data.tar.gz: d0a3a58f8a05e824e43b49a0c2614d085814ef5f
+  metadata.gz: f1d33c98f5eeed19a68361f560b4144aa2d62b5e
+  data.tar.gz: 8f7114a49e403d5400483235fbe06f8813cb5b9d
 SHA512:
-  metadata.gz: c049b74da9379131aa2e86f4a40c30096a29ee2492e73bb0b09330b10b226df377fbcd0b27e8629ad402854fbe511fc6ceda7408e724c6665aa1486baf754321
-  data.tar.gz: 796ae8ac97aebf7902d6750577e34dc96426278131fce0790d1b75ab3d4d945e2077466308ed798784d9a662bd87dc955a30c0562bf70edbdf4396aec2fa6e8f
+  metadata.gz: 17d1e534f9be1813e1a14d2ec9af872e9d795db2253fcd16f4e702a74d742fa1c4461abb20634a3a8b0f0704836500e8c40bc5bbb3a4759d5d4c7fd323de7cee
+  data.tar.gz: caf3432e838bfc7dea918292024db05dc050e59e54e0e17d2c723ae0e635aa8ee28023b3bc3d92d99f80469bd1ddc4c107d08ffa97f565bd9668078a0fc420c7

data/.gitignore

@@ -12,3 +12,5 @@
 *.o
 *.a
 mkmf.log
+.ruby-gemset
+.ruby-version

data/lib/groovehq/client/tickets.rb

@@ -36,7 +36,7 @@ module GrooveHQ
       end
 
       def update_ticket_priority(ticket_number, priority)
-        put("/tickets/#{ticket_number}/assignee", priority: priority)
+        put("/tickets/#{ticket_number}/priority", priority: priority)
       end
 
       def update_ticket_assigned_group(ticket_number, assigned_group)

data/lib/groovehq/resource.rb

@@ -10,8 +10,8 @@ module GrooveHQ
 
       data = data.with_indifferent_access
 
-      links        = data.delete(:links) { Hash.new }
-      links[:self] = data.delete(:href) if data.has_key?(:href)
+      links        = data.delete(:links) { ActiveSupport::HashWithIndifferentAccess.new }
+      links[:self] = { href: data.delete(:href) } if data.has_key?(:href)
 
       @data   = OpenStruct.new(data.with_indifferent_access)
 
@@ -20,7 +20,7 @@ module GrooveHQ
 
     def parse_links(links)
       (links || {}).each_with_object({}) do |(relation, value), result|
-        result[relation] = Relation.new(@client, value["href"])
+        result[relation] = Relation.new(@client, value[:href])
       end
     end
 

data/lib/groovehq/version.rb

@@ -1,3 +1,3 @@
 module GrooveHQ
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/groovehq/client/connection_spec.rb

@@ -3,14 +3,28 @@ require 'spec_helper'
 describe GrooveHQ::Client::Connection do
 
   let(:client) { GrooveHQ::Client.new("phantogram") }
+  let(:api_groovehq_url) { "https://api.groovehq.com/v1" }
+
+  before(:each) do
+    stub_request(:get, "#{api_groovehq_url}#{resource_path}").to_return(body: response)
+  end
+
+  subject { client.get(resource_path) }
+
+  context "empty response" do
+
+    let(:resource_path) { "/tickets" }
+    let(:response) { '' }
+
+    it "returns nil" do
+      expect(subject).to eql(nil)
+    end
 
-  it "returns nil for empty response" do
-    stub_request(:get, "https://api.groovehq.com/v1/tickets").to_return(body: "")
-    expect(client.get("/tickets")).to eql(nil)
   end
 
   context "nested hash as response with single root key" do
 
+    let(:resource_path) { "/tickets/1" }
     let(:response) do
       {
         ticket: {
@@ -25,38 +39,32 @@ describe GrooveHQ::Client::Connection do
       }.to_json
     end
 
-    before(:each) do
-      stub_request(:get, "https://api.groovehq.com/v1/tickets/1").to_return(body: response)
-    end
-
     it "returns resource for single root key" do
-      expect(client.get("/tickets/1")).to be_instance_of(GrooveHQ::Resource)
+      expect(subject).to be_instance_of(GrooveHQ::Resource)
     end
 
     it "returns resource with correct relations" do
-      expect(client.get("/tickets/1").rels[:assignee].href).to eql("https://api.groovehq.com/v1/agents/matt@groovehq.com")
+      expect(subject.rels[:assignee].href).to eql("https://api.groovehq.com/v1/agents/matt@groovehq.com")
     end
 
   end
 
   context "single key-value pair in response" do
 
+    let(:resource_path) { "/tickets/1/state" }
     let(:response) do
       { state: "open" }.to_json
     end
 
-    before(:each) do
-      stub_request(:get, "https://api.groovehq.com/v1/tickets/1/state").to_return(body: response)
-    end
-
     it "returns response as it is" do
-      expect(client.get("/tickets/1/state")).to eql "open"
+      expect(subject).to eql "open"
     end
 
   end
 
   context "multiple root key-value pairs in response" do
 
+    let(:resource_path) { "/tickets/count" }
     let(:response) do
       {
         "728525" => 1,
@@ -65,18 +73,15 @@ describe GrooveHQ::Client::Connection do
       }.to_json
     end
 
-    before(:each) do
-      stub_request(:get, "https://api.groovehq.com/v1/tickets/count").to_return(body: response)
-    end
-
     it "returns response as it is" do
-      expect(client.get("/tickets/count").data.to_h.keys.count).to eql 3
+      expect(subject.data.to_h.keys.count).to eql 3
     end
 
   end
 
   context "array of hashes in response" do
 
+    let(:resource_path) { "/tickets" }
     let(:response) do
       {
         tickets: [
@@ -93,16 +98,12 @@ describe GrooveHQ::Client::Connection do
       }.to_json
     end
 
-    before(:each) do
-      stub_request(:get, "https://api.groovehq.com/v1/tickets").to_return(body: response)
-    end
-
     it "builds array of resources from response" do
-      expect(client.get("/tickets").data[:collection].count).to eql 3
+      expect(subject.data[:collection].count).to eql 3
     end
 
     it "returns relations for pagination" do
-      expect(client.get("/tickets").rels[:next]).to be_instance_of(GrooveHQ::Relation)
+      expect(subject.rels[:next]).to be_instance_of(GrooveHQ::Relation)
     end
 
   end

data/spec/groovehq/resource_collection_spec.rb

@@ -7,7 +7,7 @@ describe GrooveHQ::Resource do
   context "#data" do
 
     it "returns empty data for invalid input" do
-      resource = GrooveHQ::ResourceCollection.new(self, "")
+      resource = GrooveHQ::ResourceCollection.new(client, "")
       expect(resource.count).to eql(0)
     end
 
@@ -15,7 +15,7 @@ describe GrooveHQ::Resource do
       data = {
         tickets: [ { name: "When I am small" } ]
       }
-      resource = GrooveHQ::ResourceCollection.new(self, data)
+      resource = GrooveHQ::ResourceCollection.new(client, data)
       expect(resource.first.name).to eql "When I am small"
     end
 
@@ -35,7 +35,7 @@ describe GrooveHQ::Resource do
           }
         }
       }
-      resource = GrooveHQ::ResourceCollection.new(self, data)
+      resource = GrooveHQ::ResourceCollection.new(client, data)
       expect(resource.rels[:next]).to be_instance_of(GrooveHQ::Relation)
     end
 

data/spec/groovehq/resource_spec.rb

@@ -7,7 +7,7 @@ describe GrooveHQ::Resource do
   context "#data" do
 
     it "returns empty data for invalid input" do
-      resource = GrooveHQ::Resource.new(self, "")
+      resource = GrooveHQ::Resource.new(client, "")
       expect(resource.data.to_h).to eql({})
     end
 
@@ -15,7 +15,7 @@ describe GrooveHQ::Resource do
       data = {
         name: "When I am small"
       }
-      resource = GrooveHQ::Resource.new(self, data)
+      resource = GrooveHQ::Resource.new(client, data)
       expect(resource.data[:name]).to eql "When I am small"
     end
 
@@ -23,7 +23,7 @@ describe GrooveHQ::Resource do
       data = {
         name: "When I am small"
       }
-      resource = GrooveHQ::Resource.new(self, data)
+      resource = GrooveHQ::Resource.new(client, data)
       expect(resource.name).to eql "When I am small"
     end
   end
@@ -38,16 +38,18 @@ describe GrooveHQ::Resource do
           }
         }
       }
-      resource = GrooveHQ::Resource.new(self, data)
+      resource = GrooveHQ::Resource.new(client, data)
       expect(resource.rels[:assignee]).to be_instance_of(GrooveHQ::Relation)
+      expect(resource.rels[:assignee].href).to eq("https://api.groovehq.com/v1/agents/matt@groovehq.com")
     end
 
     it "parses self relation correctly" do
       data = {
         href: "https://api.groovehq.com/v1/agents/matt@groovehq.com"
       }
-      resource = GrooveHQ::Resource.new(self, data)
+      resource = GrooveHQ::Resource.new(client, data)
       expect(resource.rels[:self]).to be_instance_of(GrooveHQ::Relation)
+      expect(resource.rels[:self].href).to eq("https://api.groovehq.com/v1/agents/matt@groovehq.com")
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: groovehq
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Kirill Shirinkin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-12 00:00:00.000000000 Z
+date: 2015-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -119,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Client library for GrooveHQ API.
@@ -128,4 +128,3 @@ test_files:
 - spec/groovehq/resource_collection_spec.rb
 - spec/groovehq/resource_spec.rb
 - spec/spec_helper.rb
-has_rdoc: