groonga-query-log 1.6.7 → 1.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5fc818af1a75fea77eee79dc2b7852598ef14796e67a14d043449eebd31b3a15
-  data.tar.gz: 6c101e1c990a46aabc47208b1625db3db90152cbba9c7163fc5ee0e201b7f7a1
+  metadata.gz: b9d218a019817b6222c63db7cb6dcde54452d56dba3ad1026e678e0d64a8ca1c
+  data.tar.gz: 4755e11de2ab221a1db0a1d6c2fa86c3bf05e18c3cd30e451096160bf870e169
 SHA512:
-  metadata.gz: 942d6b83901dcc4b2bccf8c8639da85cfac8472db3bd59738a8f386b9811c7bb141a7718a3140043b68cef0c71e3434cafabd9686e18a685ca49e0918da24321
-  data.tar.gz: 23c25f00387e3755908222434477d487c7f5f1a707c54f4a86d2969a17c3bb2fcfffbfe88bee7e157651665956b42aa3d27b1d54f2ac9d5246361886be235028
+  metadata.gz: 1380025523bbb3debb587da39f774f7e2cb7aab6301e2d6f66ebf9c7fed3baccbfa5e4fc57202db3e1d00c53a37686196d1165df560ba9c824cce68efd21af03
+  data.tar.gz: ed36cd1e75dc79eb701238bad818ee0a42531d1ff47ebaba255bdfeb68574f173f49e44f0e38e786d45d41981d720c6ac2e5d32f6a84fa8abebdcde0adebe8bb

data/doc/text/news.md

@@ -1,8 +1,47 @@
 # News
 
+## 1.7.2: 2020-06-02
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification
+    doesn't try 5 times.
+
+## 1.7.1: 2020-06-01
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification with
+    `--stop-onlfailre` doesn't work.
+
+  * `run-regression-test`: Fixed a bug that failure is ignored.
+
+## 1.7.0: 2020-05-31
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification
+    doesn't work.
+
+## 1.6.9: 2020-05-30
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification
+    doesn't work.
+
+## 1.6.8: 2020-05-30
+
+### Improvements
+
+  * `server-verifier`: Stopped sorting elapsed times.
+
+  * `run-regression-test`: Ensured killing Groonga server on start up
+    error.
+
 ## 1.6.7: 2020-05-30
 
-### Improves
+### Improvements
 
   * `extract`: Added support for no command request case such as `/`.
 

data/lib/groonga-query-log/command/run-regression-test.rb

@@ -559,6 +559,7 @@ module GroongaQueryLog
           @host = "127.0.0.1"
           @port = find_unused_port
           @options = options
+          @pid = nil
         end
 
         def run
@@ -579,25 +580,28 @@ module GroongaQueryLog
           spawn_args << @database_path.to_s
           @pid = spawn(*spawn_args)
 
-          n_retries = 10
           begin
-            send_command("status")
-          rescue SystemCallError
-            sleep(1)
-            n_retries -= 1
-            raise if n_retries.zero?
-            retry
-          end
+            n_retries = 60
+            begin
+              send_command("status")
+            rescue SystemCallError
+              sleep(1)
+              n_retries -= 1
+              raise if n_retries.zero?
+              retry
+            end
 
-          if @options[:warm_up]
-            send_command("dump?dump_records=no")
-            warm_up_commands = @options[:warm_up_commands] || []
-            warm_up_commands.each do |command|
-              send_command(command)
+            if @options[:warm_up]
+              send_command("dump?dump_records=no")
+              warm_up_commands = @options[:warm_up_commands] || []
+              warm_up_commands.each do |command|
+                send_command(command)
+              end
             end
+          rescue
+            shutdown
+            raise
           end
-
-          yield if block_given?
         end
 
         def ensure_database
@@ -688,11 +692,14 @@ module GroongaQueryLog
         end
 
         def shutdown
+          return if @pid.nil?
           begin
             send_command("shutdown")
           rescue SystemCallError
+            Process.kill(:KILL, @pid)
           end
           Process.waitpid(@pid)
+          @pid = nil
         end
 
         def n_leaked_objects
@@ -769,7 +776,6 @@ module GroongaQueryLog
           @n_clients = options[:n_clients] || 1
           @stop_on_failure = options[:stop_on_failure]
           @options = options
-          @n_ready_waits = 2
           @n_executed_commands = 0
         end
 
@@ -777,21 +783,42 @@ module GroongaQueryLog
           @old.ensure_database
           @new.ensure_database
 
+          ready_queue = Thread::Queue.new
+          wait_queue = Thread::Queue.new
           old_thread = Thread.new do
-            @old.run do
-              run_test
+            @old.run
+            begin
+              ready_queue.push(true)
+              wait_queue.pop
+              true
+            ensure
+              @old.shutdown
             end
           end
           new_thread = Thread.new do
-            @new.run do
-              run_test
+            @new.run
+            begin
+              ready_queue.push(true)
+              wait_queue.pop
+              true
+            ensure
+              @new.shutdown
             end
           end
+          test_thread = Thread.new do
+            ready_queue.pop
+            ready_queue.pop
+            success = run_test
+            wait_queue.push(true)
+            wait_queue.push(true)
+            success
+          end
 
           old_thread_success = old_thread.value
           new_thread_success = new_thread.value
+          test_thread_success = test_thread.value
 
-          old_thread_success and new_thread_success
+          old_thread_success and new_thread_success and test_thread_success
         end
 
         def n_executed_commands
@@ -800,10 +827,7 @@ module GroongaQueryLog
 
         private
         def run_test
-          @n_ready_waits -= 1
-          return true unless @n_ready_waits.zero?
-
-          same = true
+          success = true
           query_log_paths.each do |query_log_path|
             log_path = test_log_path(query_log_path)
             if @options[:skip_finished_queries] and log_path.exist?
@@ -828,24 +852,14 @@ module GroongaQueryLog
                 callback = nil
               end
               unless verify_server(log_path, query_log_path, &callback)
-                same = false
+                success = false
                 break if @stop_on_failure
               end
             rescue Interrupt
               puts("Interrupt: #{query_log_path}")
             end
           end
-
-          old_thread = Thread.new do
-            @old.shutdown
-          end
-          new_thread = Thread.new do
-            @new.shutdown
-          end
-          old_thread.join
-          new_thread.join
-
-          same
+          success
         end
 
         def verify_server(test_log_path, query_log_path, &callback)

data/lib/groonga-query-log/performance-verifier.rb

@@ -47,16 +47,16 @@ module GroongaQueryLog
       diff_ratio > @threshold_ratio
     end
 
-    def old_sorted_elapsed_times
-      collect_sorted_elapsed_times(@old_responses)
+    def old_elapsed_times
+      collect_elapsed_times(@old_responses)
     end
 
     def old_elapsed_time
       choose_target_elapsed_time(@old_responses)
     end
 
-    def new_sorted_elapsed_times
-      collect_sorted_elapsed_times(@new_responses)
+    def new_elapsed_times
+      collect_elapsed_times(@new_responses)
     end
 
     def new_elapsed_time
@@ -74,15 +74,14 @@ module GroongaQueryLog
       end
     end
 
-    def collect_sorted_elapsed_times(responses)
-      elapsed_times = responses.collect do |response|
+    def collect_elapsed_times(responses)
+      responses.collect do |response|
         response.elapsed_time
       end
-      elapsed_times.sort
     end
 
     def choose_target_elapsed_time(responses)
-      sorted_elapsed_times = collect_sorted_elapsed_times(responses)
+      sorted_elapsed_times = collect_elapsed_times(responses).sort
 
       strategy = @options.choose_strategy
       case strategy

data/lib/groonga-query-log/server-verifier.rb

@@ -188,11 +188,19 @@ module GroongaQueryLog
       end
 
       if @options.verify_performance?
-        verify_performance(command, response1, response2)
+        verify_performance(command,
+                           groonga1_client,
+                           groonga2_client,
+                           response1,
+                           response2)
       end
     end
 
-    def verify_performance(command, response1, response2)
+    def verify_performance(command,
+                           groonga1_client,
+                           groonga2_client,
+                           response1,
+                           response2)
       responses1 = [response1]
       responses2 = [response2]
       verifier = PerformanceVerifier.new(command,
@@ -203,23 +211,24 @@ module GroongaQueryLog
 
       n_tries = 4
       n_tries.times do
+        return if stop?
+
         responses1 << groonga1_client.execute(command)
         responses2 << groonga2_client.execute(command)
         verifier = PerformanceVerifier.new(command,
                                            responses1,
                                            responses2,
                                            @options.performance_verifier_options)
-        if verifier.slow?
-          @slow = true
-          @events.push([:slow,
-                        command,
-                        verifier.old_elapsed_time,
-                        verifier.new_elapsed_time,
-                        verifier.old_sorted_elapsed_time,
-                        verifier.new_sorted_elapsed_time])
-          return
-        end
+        return unless verifier.slow?
       end
+
+      @slow = true
+      @events.push([:slow,
+                    command,
+                    verifier.old_elapsed_time,
+                    verifier.new_elapsed_time,
+                    verifier.old_elapsed_times,
+                    verifier.new_elapsed_times])
     end
 
     def rewrite_filter(command, name)
@@ -251,14 +260,14 @@ module GroongaQueryLog
                     command,
                     old_elapsed_time,
                     new_elapsed_time,
-                    old_sorted_elapsed_times,
-                    new_sorted_elapsed_times)
+                    old_elapsed_times,
+                    new_elapsed_times)
       command_source = command.original_source || command.to_uri_format
       output.puts("command: #{command_source}")
       output.puts("elapsed_time_old: #{old_elapsed_time}")
       output.puts("elapsed_time_new: #{new_elapsed_time}")
-      output.puts("elapsed_times_old: #{old_sorted_elapsed_times.join(' ')}")
-      output.puts("elapsed_times_new: #{new_sorted_elapsed_times.join(' ')}")
+      output.puts("elapsed_times_old: #{old_elapsed_times.join(' ')}")
+      output.puts("elapsed_times_new: #{new_elapsed_times.join(' ')}")
       output.puts("elapsed_time_ratio: #{new_elapsed_time / old_elapsed_time}")
       output.flush
     end

data/lib/groonga-query-log/version.rb

@@ -15,5 +15,5 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
 module GroongaQueryLog
-  VERSION = "1.6.7"
+  VERSION = "1.7.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: groonga-query-log
 version: !ruby/object:Gem::Version
-  version: 1.6.7
+  version: 1.7.2
 platform: ruby
 authors:
 - Kouhei Sutou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-30 00:00:00.000000000 Z
+date: 2020-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: charty