groonga-query-log 1.6.5 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5491daf99859078f656e26f3f1445eadbef319899eda9dadf806415916e25e9d
-  data.tar.gz: '0192e216e446888ed26a5fd6372bdd62a56759eea24eac06bac441d5d133cb79'
+  metadata.gz: 137657847fe22ae9bd436e1a2a99467c93cc7134cde90f710451f1d6c205c083
+  data.tar.gz: 68455fe3c51c12a8b1ee1a5106d99ff86a52b14eebbd2077b2284523fe560498
 SHA512:
-  metadata.gz: 26a03dadf837f274d139c7743dc4682c28a2961348f7dd4d49674591fbfb879dcf928584b0e521800a3f97dc574e717b8ec6b9d2dc3a7fac596f6949ef2779d1
-  data.tar.gz: 75f4dfbf7010ed8d4e5db8c832eacc4274b8b62720ccbef4ea37ff0cb4b5ba138533c99328c33684c93adce8c23e459b4a906c95591f51b025d05128fa3890da
+  metadata.gz: baa54b40acddcb3c6b2fe46a4a7566eb402dc4f1be8327200832614ee3274e6de49116b644bf149c7d87dcc58f920e61ddb81a5c0486c4648164bc6a3503d4f9
+  data.tar.gz: 747d1d1fc84cbeabf2445882e7d70274c6b94994787ea056150c9a18f661992436a29acded2d19cb0a152a2159ef0d7c29dca9e0b8690f82564873f31f99ef35

data/doc/text/news.md

@@ -1,5 +1,49 @@
 # News
 
+## 1.7.0: 2020-05-31
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification
+    doesn't work.
+
+## 1.6.9: 2020-05-30
+
+### Fixes
+
+  * `server-verifier`: Fixed a bug that performance verification
+    doesn't work.
+
+## 1.6.8: 2020-05-30
+
+### Improvements
+
+  * `server-verifier`: Stopped sorting elapsed times.
+
+  * `run-regression-test`: Ensured killing Groonga server on start up
+    error.
+
+## 1.6.7: 2020-05-30
+
+### Improvements
+
+  * `extract`: Added support for no command request case such as `/`.
+
+  * `server-verifier`: Reduced the number of requests for performance
+    verification.
+
+  * `server-verifier`: Added all elapsed times on slow.
+
+  * `format-regression-test-logs`: Added support for all elapsed times
+    on slow.
+
+## 1.6.6: 2020-05-20
+
+### Fixes
+
+  * `run-regression-test`: Fixed a bug that
+    `--old-groonga-warm-up-command` is ignored.
+
 ## 1.6.5: 2020-05-19
 
 ### Improvements

data/lib/groonga-query-log/command/extract.rb

@@ -182,6 +182,8 @@ module GroongaQueryLog
       end
 
       def target?(command)
+        return false if command.nil?
+
         name = command.command_name
         target_commands = @options.commands
         exclude_commands = @options.exclude_commands

data/lib/groonga-query-log/command/format-regression-test-logs.rb

@@ -74,6 +74,8 @@ module GroongaQueryLog
         elapsed_time_old = nil
         elapsed_time_new = nil
         elapsed_time_ratio = nil
+        elapsed_times_old = nil
+        elapsed_times_new = nil
 
         input.each_line do |line|
           unless line.valid_encoding?
@@ -100,11 +102,21 @@ module GroongaQueryLog
             elapsed_time_old = Float($POSTMATCH.chomp)
           when /\Aelapsed_time_new: /
             elapsed_time_new = Float($POSTMATCH.chomp)
+          when /\Aelapsed_times_old: /
+            elapsed_times_old = $POSTMATCH.chomp.split.collect do |value|
+              Float(value)
+            end
+          when /\Aelapsed_times_new: /
+            elapsed_times_new = $POSTMATCH.chomp.split.collect do |value|
+              Float(value)
+            end
           when /\Aelapsed_time_ratio: /
             elapsed_time_ratio = Float($POSTMATCH.chomp)
             report_slow(command,
                         elapsed_time_old,
                         elapsed_time_new,
+                        elapsed_times_old,
+                        elapsed_times_new,
                         elapsed_time_ratio)
           end
         end
@@ -196,11 +208,21 @@ module GroongaQueryLog
       def report_slow(command,
                       elapsed_time_old,
                       elapsed_time_new,
+                      elapsed_times_old,
+                      elapsed_times_new,
                       elapsed_time_ratio)
         report_command(command)
+        elapsed_times_old ||= [elapsed_time_old]
+        elapsed_times_new ||= [elapsed_time_new]
         @output.puts("Slow:")
-        @output.puts("  Old: %s" % format_elapsed_time(elapsed_time_old))
-        @output.puts("  New: %s" % format_elapsed_time(elapsed_time_new))
+        @output.puts("  Old: %s (%s)" % [
+                       format_elapsed_time(elapsed_time_old),
+                       format_elapsed_times(elapsed_times_old),
+                     ])
+        @output.puts("  New: %s (%s)" % [
+                       format_elapsed_time(elapsed_time_new),
+                       format_elapsed_times(elapsed_times_new),
+                     ])
         @output.puts("  Ratio: +%.1f%%" % ((elapsed_time_ratio * 100) - 100))
       end
 

data/lib/groonga-query-log/command/run-regression-test.rb

@@ -212,7 +212,7 @@ module GroongaQueryLog
           @new_groonga_env[key] = value
         end
 
-        parser.on("--old-groonga-warm-up-commands=COMMAND",
+        parser.on("--new-groonga-warm-up-commands=COMMAND",
                   "Run COMMAND before running tests to warm new groonga up",
                   "You can specify this option multiple times",
                   "to specify multiple warm up commands",
@@ -559,6 +559,7 @@ module GroongaQueryLog
           @host = "127.0.0.1"
           @port = find_unused_port
           @options = options
+          @pid = nil
         end
 
         def run
@@ -579,25 +580,28 @@ module GroongaQueryLog
           spawn_args << @database_path.to_s
           @pid = spawn(*spawn_args)
 
-          n_retries = 10
           begin
-            send_command("status")
-          rescue SystemCallError
-            sleep(1)
-            n_retries -= 1
-            raise if n_retries.zero?
-            retry
-          end
+            n_retries = 60
+            begin
+              send_command("status")
+            rescue SystemCallError
+              sleep(1)
+              n_retries -= 1
+              raise if n_retries.zero?
+              retry
+            end
 
-          if @options[:warm_up]
-            send_command("dump?dump_records=no")
-            warm_up_commands = @options[:warm_up_commands] || []
-            warm_up_commands.each do |command|
-              send_command(command)
+            if @options[:warm_up]
+              send_command("dump?dump_records=no")
+              warm_up_commands = @options[:warm_up_commands] || []
+              warm_up_commands.each do |command|
+                send_command(command)
+              end
             end
+          rescue
+            shutdown
+            raise
           end
-
-          yield if block_given?
         end
 
         def ensure_database
@@ -688,11 +692,14 @@ module GroongaQueryLog
         end
 
         def shutdown
+          return if @pid.nil?
           begin
             send_command("shutdown")
           rescue SystemCallError
+            Process.kill(:KILL, @pid)
           end
           Process.waitpid(@pid)
+          @pid = nil
         end
 
         def n_leaked_objects
@@ -769,7 +776,6 @@ module GroongaQueryLog
           @n_clients = options[:n_clients] || 1
           @stop_on_failure = options[:stop_on_failure]
           @options = options
-          @n_ready_waits = 2
           @n_executed_commands = 0
         end
 
@@ -777,21 +783,39 @@ module GroongaQueryLog
           @old.ensure_database
           @new.ensure_database
 
+          ready_queue = Thread::Queue.new
+          wait_queue = Thread::Queue.new
           old_thread = Thread.new do
-            @old.run do
-              run_test
+            @old.run
+            begin
+              ready_queue.push(true)
+              wait_queue.pop
+            ensure
+              @old.shutdown
             end
           end
           new_thread = Thread.new do
-            @new.run do
-              run_test
+            @new.run
+            begin
+              ready_queue.push(true)
+              wait_queue.pop
+            ensure
+              @new.shutdown
             end
           end
+          test_thread = Thread.new do
+            ready_queue.pop
+            ready_queue.pop
+            run_test
+            wait_queue.push(true)
+            wait_queue.push(true)
+          end
 
           old_thread_success = old_thread.value
           new_thread_success = new_thread.value
+          test_thread_success = test_thread.value
 
-          old_thread_success and new_thread_success
+          old_thread_success and new_thread_success and test_thread_success
         end
 
         def n_executed_commands
@@ -800,9 +824,6 @@ module GroongaQueryLog
 
         private
         def run_test
-          @n_ready_waits -= 1
-          return true unless @n_ready_waits.zero?
-
           same = true
           query_log_paths.each do |query_log_path|
             log_path = test_log_path(query_log_path)
@@ -835,16 +856,6 @@ module GroongaQueryLog
               puts("Interrupt: #{query_log_path}")
             end
           end
-
-          old_thread = Thread.new do
-            @old.shutdown
-          end
-          new_thread = Thread.new do
-            @new.shutdown
-          end
-          old_thread.join
-          new_thread.join
-
           same
         end
 

data/lib/groonga-query-log/formattable.rb

@@ -30,5 +30,12 @@ module GroongaQueryLog
         "%.1fmin" % (elapsed_time / 60)
       end
     end
+
+    def format_elapsed_times(elapsed_times)
+      formatted_epalsed_times = elapsed_times.collect do |elapsed_time|
+        format_elapsed_time(elapsed_time)
+      end
+      formatted_epalsed_times.join(" ")
+    end
   end
 end

data/lib/groonga-query-log/performance-verifier.rb

@@ -47,10 +47,18 @@ module GroongaQueryLog
       diff_ratio > @threshold_ratio
     end
 
+    def old_elapsed_times
+      collect_elapsed_times(@old_responses)
+    end
+
     def old_elapsed_time
       choose_target_elapsed_time(@old_responses)
     end
 
+    def new_elapsed_times
+      collect_elapsed_times(@new_responses)
+    end
+
     def new_elapsed_time
       choose_target_elapsed_time(@new_responses)
     end
@@ -66,18 +74,21 @@ module GroongaQueryLog
       end
     end
 
-    def choose_target_elapsed_time(responses)
-      elapsed_times = responses.collect do |response|
+    def collect_elapsed_times(responses)
+      responses.collect do |response|
         response.elapsed_time
       end
-      sorted_elapsed_times = elapsed_times.sort
+    end
+
+    def choose_target_elapsed_time(responses)
+      sorted_elapsed_times = collect_elapsed_times(responses).sort
 
       strategy = @options.choose_strategy
       case strategy
       when :fastest
         sorted_elapsed_times.first
       when :median
-        sorted_elapsed_times[elapsed_times.size / 2]
+        sorted_elapsed_times[sorted_elapsed_times.size / 2]
       else
         message =
           "choose strategy must be :fastest or :median: #{strategy.inspect}"

data/lib/groonga-query-log/server-verifier.rb

@@ -187,24 +187,46 @@ module GroongaQueryLog
         return
       end
 
-      return unless @options.verify_performance?
+      if @options.verify_performance?
+        verify_performance(command,
+                           groonga1_client,
+                           groonga2_client,
+                           response1,
+                           response2)
+      end
+    end
+
+    def verify_performance(command,
+                           groonga1_client,
+                           groonga2_client,
+                           response1,
+                           response2)
       responses1 = [response1]
       responses2 = [response2]
-      n_tries = 4
-      n_tries.times do
-        responses1 << groonga1_client.execute(command)
-        responses2 << groonga2_client.execute(command)
-      end
       verifier = PerformanceVerifier.new(command,
                                          responses1,
                                          responses2,
                                          @options.performance_verifier_options)
-      if verifier.slow?
-        @slow = true
-        @events.push([:slow,
-                      command,
-                      verifier.old_elapsed_time,
-                      verifier.new_elapsed_time])
+      return unless verifier.slow?
+
+      n_tries = 4
+      n_tries.times do
+        responses1 << groonga1_client.execute(command)
+        responses2 << groonga2_client.execute(command)
+        verifier = PerformanceVerifier.new(command,
+                                           responses1,
+                                           responses2,
+                                           @options.performance_verifier_options)
+        if verifier.slow?
+          @slow = true
+          @events.push([:slow,
+                        command,
+                        verifier.old_elapsed_time,
+                        verifier.new_elapsed_time,
+                        verifier.old_elapsed_times,
+                        verifier.new_elapsed_times])
+          return
+        end
       end
     end
 
@@ -233,11 +255,18 @@ module GroongaQueryLog
       output.flush
     end
 
-    def report_slow(output, command, old_elapsed_time, new_elapsed_time)
+    def report_slow(output,
+                    command,
+                    old_elapsed_time,
+                    new_elapsed_time,
+                    old_elapsed_times,
+                    new_elapsed_times)
       command_source = command.original_source || command.to_uri_format
       output.puts("command: #{command_source}")
       output.puts("elapsed_time_old: #{old_elapsed_time}")
       output.puts("elapsed_time_new: #{new_elapsed_time}")
+      output.puts("elapsed_times_old: #{old_elapsed_times.join(' ')}")
+      output.puts("elapsed_times_new: #{new_elapsed_times.join(' ')}")
       output.puts("elapsed_time_ratio: #{new_elapsed_time / old_elapsed_time}")
       output.flush
     end

data/lib/groonga-query-log/version.rb

@@ -15,5 +15,5 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
 module GroongaQueryLog
-  VERSION = "1.6.5"
+  VERSION = "1.7.0"
 end

data/test/command/test-format-regression-test-logs.rb

@@ -109,14 +109,32 @@ Arguments:
   query: column_create
   table: Entries
 Slow:
-  Old: 174.8usec
-  New: 201.7usec
+  Old: 174.8usec (174.8usec)
+  New: 201.7usec (201.7usec)
   Ratio: +15.4%
     OUTPUT
     assert_equal([true, output],
                  run_command([fixture_path("slow.log")]))
   end
 
+  def test_slow_elapsed_times
+    output = <<-OUTPUT
+Command:
+/d/select?match_columns=description&query=column_create&table=Entries
+Name: select
+Arguments:
+  match_columns: description
+  query: column_create
+  table: Entries
+Slow:
+  Old: 174.8usec (174.8usec 184.8usec)
+  New: 201.7usec (201.7usec 211.7usec)
+  Ratio: +15.4%
+    OUTPUT
+    assert_equal([true, output],
+                 run_command([fixture_path("slow-elapsed-times.log")]))
+  end
+
   sub_test_case(".new") do
     def setup
     end

data/test/fixtures/regression-test-logs/slow-elapsed-times.log

@@ -0,0 +1,6 @@
+command: /d/select?match_columns=description&query=column_create&table=Entries
+elapsed_time_old: 0.0001747608184814453
+elapsed_time_new: 0.0002017021179199219
+elapsed_times_old: 0.0001747608184814453 0.0001847608184814453
+elapsed_times_new: 0.0002017021179199219 0.0002117021179199219
+elapsed_time_ratio: 1.154160982264666

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: groonga-query-log
 version: !ruby/object:Gem::Version
-  version: 1.6.5
+  version: 1.7.0
 platform: ruby
 authors:
 - Kouhei Sutou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-18 00:00:00.000000000 Z
+date: 2020-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: charty
@@ -272,6 +272,7 @@ files:
 - test/fixtures/query.log
 - test/fixtures/regression-test-logs/command-format.log
 - test/fixtures/regression-test-logs/error.log
+- test/fixtures/regression-test-logs/slow-elapsed-times.log
 - test/fixtures/regression-test-logs/slow.log
 - test/fixtures/regression-test-logs/url-format.log
 - test/fixtures/reporter/console.expected
@@ -345,6 +346,7 @@ test_files:
 - test/fixtures/query.log
 - test/fixtures/regression-test-logs/command-format.log
 - test/fixtures/regression-test-logs/error.log
+- test/fixtures/regression-test-logs/slow-elapsed-times.log
 - test/fixtures/regression-test-logs/slow.log
 - test/fixtures/regression-test-logs/url-format.log
 - test/fixtures/reporter/console.expected