grizzly-rb 1.0.0

data/conversion/spec/cops/array_initialization_spec.rb

@@ -0,0 +1,154 @@
+require "spec_helper"
+
+module RuboCop
+  module Cop
+    module Style
+      describe ArrayInitialization, :config do
+        include RuboCop::RSpec::ExpectOffense
+
+        before do
+          cop_config['InitializeArrayWith'] = 'AnotherClass'
+        end
+
+        it 'registers an offense for @origin = [true, false]' do
+          expect_offense(<<~RUBY)
+            @origin = [true, false]
+                      ^^^^^^^^^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @origin = AnotherClass.new([true, false])
+          RUBY
+        end
+
+        it 'registers an offense when using #to_a constructor' do
+          expect_offense(<<~RUBY)
+            a = (1..3).to_a
+                ^^^^^^^^^^^ an Array should not be initialized with #to_a
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new((1..3).to_a)
+          RUBY
+        end
+
+        it 'registers an offense when using #to_a constructor on a chained method' do
+          expect_offense(<<~RUBY)
+            a = @array.combination(3).to_a
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^ an Array should not be initialized with #to_a
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new(@array.combination(3).to_a)
+          RUBY
+        end
+
+        it 'registers an offense when using [] literal constructor' do
+          expect_offense(<<~RUBY)
+            a = [1,2,3]
+                ^^^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+        end
+
+        it 'registers an offense when using an Array initialization' do
+          expect_offense(<<~RUBY)
+            a = Array.new([1, 2, 3])
+                ^^^^^^^^^^^^^^^^^^^^ an Array should not be initialized with .new
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new([1, 2, 3])
+          RUBY
+        end
+
+        it 'registers an offense when Array is instantiated with a length' do
+          expect_offense(<<~RUBY)
+            a = Array.new(1) {}
+                ^^^^^^^^^^^^ an Array should not be initialized with .new
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new(1) {}
+          RUBY
+        end
+
+        it 'registers an offense when Array is instantiated with a length and a default value' do
+          expect_offense(<<~RUBY)
+            a = Array.new(99, "something")
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^ an Array should not be initialized with .new
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new(99, "something")
+          RUBY
+        end
+
+        it 'registers an offense when Array is instantiated with two variables' do
+          expect_offense(<<~RUBY)
+            a = Array.new(a, b)
+                ^^^^^^^^^^^^^^^ an Array should not be initialized with .new
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new(a, b)
+          RUBY
+        end
+
+        it 'does not register an offense when doing a spec check' do
+          expect_no_offenses(<<~RUBY)
+            a == [1,2,3]
+          RUBY
+        end
+
+        it 'corrects the offense by wrapping the array initialization with a class of choice' do
+          expect_offense(<<~RUBY)
+            a = [1,2,3]
+                ^^^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new([1, 2, 3])
+          RUBY
+        end
+
+        it 'corrects the offense that does not use the [] constrcution' do
+          expect_offense(<<~RUBY)
+            a = 1,2,3
+                ^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new([1, 2, 3])
+          RUBY
+        end
+
+        it 'corrects the offense that uses %w() construction' do
+          expect_offense(<<~RUBY)
+            a = %w(1 2 3)
+                ^^^^^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = AnotherClass.new(["1", "2", "3"])
+          RUBY
+        end
+
+        it 'corrects the offense with the constant configured in rubocop file' do
+          old_config = cop_config['InitializeArrayWith'].dup
+          cop_config['InitializeArrayWith'] = 'Collection'
+
+          expect_offense(<<~RUBY)
+            a = [1,2,3]
+                ^^^^^^^ an Array should not be initialized with the literal constructor []
+          RUBY
+
+          expect_correction(<<~RUBY)
+            a = Collection.new([1, 2, 3])
+          RUBY
+
+          cop_config['InitializeArrayWith'] = old_config
+        end
+      end
+    end
+  end
+end

data/conversion/spec/cops/enumerator_initialization_spec.rb

@@ -0,0 +1,105 @@
+require "spec_helper"
+
+module RuboCop
+  module Cop
+    module Style
+      describe EnumeratorInitialization, :config do
+        include RuboCop::RSpec::ExpectOffense
+
+        before do
+          cop_config['InitializeEnumeratorWith'] = 'AnotherEnumerator'
+        end
+
+        it 'registers an offense for chained to_enum' do
+          expect_offense(<<~RUBY)
+            @enum = EnumeratorSpecs::Feed.new.to_enum(:each)
+                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #to_enum initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @enum = AnotherEnumerator.new(EnumeratorSpecs::Feed.new.to_enum(:each))
+          RUBY
+        end
+
+        it 'registers an offense for simple case' do
+          expect_offense(<<~RUBY)
+            @e = o.to_enum
+                 ^^^^^^^^^ #to_enum initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(o.to_enum)
+          RUBY
+        end
+
+        it 'registers an offense for simple case with args' do
+          expect_offense(<<~RUBY)
+            @enum_with_arguments = object_each_with_arguments.to_enum(:each_with_arguments, :arg0, :arg1, :arg2)
+                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #to_enum initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @enum_with_arguments = AnotherEnumerator.new(object_each_with_arguments.to_enum(:each_with_arguments, :arg0, :arg1, :arg2))
+          RUBY
+        end
+
+        it 'registers an offense for Enumerator initialized with blocks' do
+          expect_offense(<<~RUBY)
+            @e = Enumerator.new {|y| y.yield :ok}
+                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #new Enumerator initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(Enumerator.new {|y| y.yield :ok})
+          RUBY
+        end
+
+        it 'registers an offense for Enumerator initialized with blocks and arguments' do
+          expect_offense(<<~RUBY)
+            @e = Enumerator.new(100) {}
+                 ^^^^^^^^^^^^^^^^^^^^^^ #new Enumerator initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(Enumerator.new(100) {})
+          RUBY
+        end
+
+        it 'registers an offense for Enumerator initialized with arguments (ruby 2.7)' do
+          # Enumerator.new(1, :upto, 3)
+
+          expect_offense(<<~RUBY)
+            @e = Enumerator.new(1, :upto, 3)
+                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ #new Enumerator initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(Enumerator.new(1, :upto, 3))
+          RUBY
+
+          # Enumerator.new(1..2)
+
+          expect_offense(<<~RUBY)
+            @e = Enumerator.new(1..2)
+                 ^^^^^^^^^^^^^^^^^^^^ #new Enumerator initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(Enumerator.new(1..2))
+          RUBY
+
+          # Enumerator.new(1..2, :each)
+
+          expect_offense(<<~RUBY)
+            @e = Enumerator.new(1..2, :each)
+                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ #new Enumerator initialization needs to be wrapped
+          RUBY
+
+          expect_correction(<<~RUBY)
+            @e = AnotherEnumerator.new(Enumerator.new(1..2, :each))
+          RUBY
+        end
+      end
+    end
+  end
+end

data/conversion/spec/cops/grep_implementation_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+
+module RuboCop
+  module Cop
+    module Style
+      describe GrepImplementation, :config do
+        include RuboCop::RSpec::ExpectOffense
+
+        before { cop_config['GrepSupportRubyVersion'] = '3.3' }
+
+        it 'registers an offense for grep specs' do
+          expect_offense(<<~RUBY)
+            describe "Enumerable#grep" do
+            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #grep and grep_v cannot be implemented
+              before :each do
+                @a = EnumerableSpecs::EachDefiner.new( 2, 4, 6, 8, 10)
+              end
+            end
+          RUBY
+
+          expect_correction(<<~RUBY)
+            ruby_bug '#11808', ''...'3.3' do
+            describe "Enumerable#grep" do
+              before :each do
+                @a = EnumerableSpecs::EachDefiner.new( 2, 4, 6, 8, 10)
+              end
+            end
+            end
+
+          RUBY
+        end
+
+        it 'registers an offense for grep_v specs' do
+          expect_offense(<<~RUBY)
+            describe "Enumerable#grep_v" do
+            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #grep and grep_v cannot be implemented
+              before :each do
+                @a = EnumerableSpecs::EachDefiner.new( 2, 4, 6, 8, 10)
+              end
+            end
+          RUBY
+
+          expect_correction(<<~RUBY)
+            ruby_bug '#11808', ''...'3.3' do
+            describe "Enumerable#grep_v" do
+              before :each do
+                @a = EnumerableSpecs::EachDefiner.new( 2, 4, 6, 8, 10)
+              end
+            end
+            end
+
+          RUBY
+        end
+      end
+    end
+  end
+end

data/conversion/spec/cops/instance_of_array_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+module RuboCop
+  module Cop
+    module Style
+      describe InstanceOfArray, :config do
+        include RuboCop::RSpec::ExpectOffense
+
+        before do
+          cop_config['NewInstanceOf'] = 'Grizzly::Collection'
+        end
+
+        it 'registers an offense when using instance_of(Array)' do
+          expect_offense(<<~RUBY)
+            be_an_instance_of(Array)
+            ^^^^^^^^^^^^^^^^^^^^^^^^ instance_of should not be of Array
+          RUBY
+
+          expect_correction(<<~RUBY)
+            be_an_instance_of(Grizzly::Collection)
+          RUBY
+        end
+
+        it 'does not register an offense when for a random line' do
+          expect_no_offenses(<<~RUBY)
+            a.untrusted?.should be_true
+          RUBY
+        end
+
+        it 'does not register an offense for other constant than Array' do
+          expect_no_offenses(<<~RUBY)
+            be_an_instance_of(Enumerator)
+          RUBY
+        end
+      end
+    end
+  end
+end

data/conversion/spec/cops/subclass_initialization_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+module RuboCop
+  module Cop
+    module Style
+      describe SubclassInitialization, :config do
+        include RuboCop::RSpec::ExpectOffense
+
+        before do
+          cop_config['InitializeArrayWith'] = 'Grizzly::Collection'
+        end
+
+        it 'registers an offense when using instance_of(Array)' do
+          expect_offense(<<~RUBY)
+            MyModule::MyArray[1,2,3]
+            ^^^^^^^^^^^^^^^^^^^^^^^^ instance_of should not be of Array
+          RUBY
+
+          expect_correction(<<~RUBY)
+            Grizzly::Collection.new([1, 2, 3])
+          RUBY
+        end
+      end
+    end
+  end
+end

data/conversion/spec/spec_helper.rb

@@ -0,0 +1,104 @@
+require "byebug"
+require "rubocop"
+require "rubocop/rspec/support"
+require_relative "../lib/cops"
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  # config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  # https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode
+  # config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  # config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  # if config.files_to_run.one?
+  #   # Use the documentation formatter for detailed output,
+  #   # unless a formatter has already been configured
+  #   # (e.g. via a command-line flag).
+  #   config.default_formatter = "doc"
+  # end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+
+end