grempe-amazon-ec2 0.3.2 → 0.3.3

data/README.rdoc

@@ -141,12 +141,6 @@ If you're not in front of a terminal shell now (perhaps you’re browsing this s
         >> @ec2.describe_images.imagesSet.item[0] (an OpenStruct of a single item in that array)
         >> @ec2.describe_images.imagesSet.item[0].to_s (a String representation of that OpenStruct item)
 
-        returns : an XML representation of all images
-        >> puts @ec2.describe_images.xml
-
-        returns : an XML representation of all images owned by Amazon
-        >> puts @ec2.describe_images(:owner_id => 'amazon').xml
-
   >> @ec2.describe_images.imagesSet.item[0].to_s
   => "#<EC2::Response:0x100A465B4 imageId=\"ami-018e6b68\" imageLocation=\"rbuilder-online/phonehome-1.5.6-x86_10132.img.manifest.xml\" imageOwnerId=\"099034111737\" imageState=\"available\" isPublic=\"true\" parent=#<EC2::Response:0x100A469A6 ...>>"
 
@@ -240,10 +234,7 @@ Try out the following bit of code. This should walk through each image returned
 
 === Important notes regarding the structure of EC2::Response Objects
 
-One of the key benefits of this new version of the library is that all responses from EC2 are bundled up in a real data structure and no longer require parsing of text. EC2::Response inherits from the OpenStruct class and we populate it directly from the XML given to us by EC2 in response to any command we issue. This means that future changes to the API and what is returned by EC2 will largely be handled transparently by the gem. This is a huge benefit. What this means though, is that you may have to do a little homework on what actually gets returned by EC2 as XML. For example, when you make a #describe_images call in 'ec2sh' what you will get back will look like:
-
-  $ ec2sh
-  >> puts @ec2.describe_images(:owner_id => 'amazon').xml
+One of the key benefits of this new version of the library is that all responses from EC2 are bundled up in a real data structure and no longer require parsing of text. The hash returned is populated directly from the XML given to us by EC2 in response to any command we issue. This means that future changes to the API and what is returned by EC2 will largely be handled transparently by the gem. This is a huge benefit. What this means though, is that you may have to do a little homework on what actually gets returned by EC2 as XML. For example, when you make a #describe_images call in 'ec2sh' what AWS returns behind the scenes looks like:
 
   <?xml version="1.0"?>
   <DescribeImagesResponse xmlns="http://ec2.amazonaws.com/doc/2007-01-19/">
@@ -293,14 +284,14 @@ One of the key benefits of this new version of the library is that all responses
       </imagesSet>
   </DescribeImagesResponse>
 
-You can see in the XML the structure that you will need to follow when constructing queries for information and parsing responses from EC2.
+You can see here the XML the structure that you will need to follow when constructing queries for information and parsing responses from EC2.
 
 So, for example, if you wanted to get the image ID of the third image listed in the response above you would need to do:
 
   >> puts @ec2.describe_images(:owner_id => 'amazon').imagesSet.item[2].imageId
   ami-23b6534a
 
-EC2 will typically return sets of things (imagesSet, reservationSet, etc.) which we map to ruby Arrays (.imagesSet.item in the example above). If you want to iterate over a response set you will need to iterate over this array. The Arrays will typically contain additional EC2::Response objects that represent each individual item. You’ll find that you can use the 'ec2sh' to help you understand the structure more completely if you try issuing commands there as a way to practice seeing what will be returned and making sure you get exactly what you want. You can always call the EC2::Response#xml method like I did above to see the exact XML returned which allows you to easily derive the structure for the Ruby OpenStruct object.
+EC2 will typically return sets of things (imagesSet, reservationSet, etc.) which we map to ruby Arrays (.imagesSet.item in the example above). If you want to iterate over a response set you will need to iterate over this array. The Arrays will typically contain additional EC2::Response objects that represent each individual item. You’ll find that you can use the 'ec2sh' to help you understand the structure more completely if you try issuing commands there as a way to practice seeing what will be returned and making sure you get exactly what you want.
 
 
 == Additional Resources

data/bin/ec2sh

@@ -9,15 +9,15 @@
 # Home::      http://github.com/grempe/amazon-ec2/tree/master
 #++
 
-# CREDITS : Credit for this bit of shameful ripoff coolness 
+# CREDITS : Credit for this bit of shameful ripoff coolness
 # goes to Marcel Molina and his AWS::S3 gem.  Thanks!
 
-# Usage : running this starts up an irb session and 
+# Usage : running this starts up an irb session and
 # sets up the connection to EC2 as a class variable called
-# '@ec2'.  So just do something like the following on the 
+# '@ec2'.  So just do something like the following on the
 # shell command line:
 
-#   macbook-pro:~ glenn$ ec2sh 
+#   macbook-pro:~ glenn$ ec2sh
 #   >> @ec2.describe_images
 #   => [#<EC2::Item image_location...
 
@@ -26,46 +26,35 @@ setup = File.dirname(__FILE__) + '/setup'
 irb_name = RUBY_PLATFORM =~ /mswin32/ ? 'irb.bat' : 'irb'
 
 if ( ENV['AMAZON_ACCESS_KEY_ID'] && ENV['AMAZON_SECRET_ACCESS_KEY'] )
-  
+
   welcome_message = <<-MESSAGE
-  
+
   'ec2sh' usage :
-  This is an interactive 'irb' command shell that allows you to use all 
+  This is an interactive 'irb' command shell that allows you to use all
   commands available to the amazon-ec2 gem.  You'll find this to be a
   great tool to help you debug issues and practice running commands
   against the live EC2 servers prior to putting them in your code.
-  
-  The EC2 connection is wired to the class instance '@ec2'.  Make method calls 
-  on this to execute commands on EC2.  Adding a #to_s 
+
+  The EC2 connection is wired to the class instance '@ec2'.  Make method calls
+  on this to execute commands on EC2.  Adding a #to_s
   at the end of any command should give you a full String representation of the
-  response.  The #xml data is available for each response
-  which allows you to view the full and complete XML response returned by
-  EC2 without any parsing applied.  This is useful for viewing the 
-  hierarchy of an entire response in a friendly way (if XML is friendly
-  to you!).  Understanding the hierarchy of the XML response is critical
-  to making effective use of this library.
-    
+  response.
+
     Examples to try:
-      
+
       returns : all ec2 public methods
       >> @ec2.methods.sort
-      
+
       returns : a string representation of ALL images
       >> @ec2.describe_images.to_s
-      
+
       returns : an Array of EC2::Response objects, each an EC2 image and its data
       >> @ec2.describe_images.imagesSet.item
       >> @ec2.describe_images.imagesSet.item[0] (an OpenStruct of a single item in that array)
       >> @ec2.describe_images.imagesSet.item[0].to_s (a String representation of that OpenStruct item)
-      
-      returns : an XML representation of all images
-      >> puts @ec2.describe_images.xml
-      
-      returns : an XML representation of all images owned by Amazon
-      >> puts @ec2.describe_images(:owner_id => 'amazon').xml
-    
+
   MESSAGE
-  
+
   puts welcome_message
   exec "#{irb_name} -r #{ec2_lib} -r #{setup} --simple-prompt"
 else

data/lib/EC2/responses.rb

@@ -47,7 +47,7 @@ module EC2
     def self.parse(options = {})
       options = {
         :xml => "",
-        :parse_options => { 'ForceArray' => ['item'], 'SuppressEmpty' => nil }
+        :parse_options => { 'forcearray' => ['item'], 'suppressempty' => nil, 'keeproot' => false }
       }.merge(options)
 
       # NOTE: Parsing the response as a nested set of Response objects was extremely

data/test/test_EC2_instances.rb

@@ -91,13 +91,13 @@ context "EC2 instances " do
                 <name>running</name>
               </instanceState>
               <privateDnsName>domU-12-31-35-00-1E-01.z-2.compute-1.internal</privateDnsName>
-        <dnsName>ec2-72-44-33-4.z-2.compute-1.amazonaws.com</dnsName>
+              <dnsName>ec2-72-44-33-4.z-2.compute-1.amazonaws.com</dnsName>
               <keyName>example-key-name</keyName>
               <productCodesSet>
                 <item><productCode>774F4FF8</productCode></item>
               </productCodesSet>
               <instanceType>m1.small</instanceType>
-        <launchTime>2007-08-07T11:54:42.000Z</launchTime>
+              <launchTime>2007-08-07T11:54:42.000Z</launchTime>
             </item>
           </instancesSet>
         </item>

data/test/test_EC2_s3_xmlsimple.rb

@@ -0,0 +1,80 @@
+#--
+# Amazon Web Services EC2 Query API Ruby library
+#
+# Ruby Gem Name::  amazon-ec2
+# Author::    Glenn Rempe  (mailto:glenn@rempe.us)
+# Copyright:: Copyright (c) 2007-2008 Glenn Rempe
+# License::   Distributes under the same terms as Ruby
+# Home::      http://github.com/grempe/amazon-ec2/tree/master
+#++
+
+require File.dirname(__FILE__) + '/test_helper.rb'
+
+# NOTE : These tests exercise amazon-ec2 when used with the aws/s3 gem
+# which was demonstrating some breaking behavior.  The fix was to
+# add the XmlSimple option "'keeproot' => false" in responses.rb
+
+context "EC2 aws-s3 compat test" do
+
+  setup do
+    @ec2 = EC2::Base.new( :access_key_id => "not a key", :secret_access_key => "not a secret" )
+
+    @describe_instances_response_body = <<-RESPONSE
+    <DescribeInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2007-08-29">
+      <reservationSet>
+        <item>
+          <reservationId>r-44a5402d</reservationId>
+          <ownerId>UYY3TLBUXIEON5NQVUUX6OMPWBZIQNFM</ownerId>
+          <groupSet>
+            <item>
+              <groupId>default</groupId>
+            </item>
+          </groupSet>
+          <instancesSet>
+            <item>
+              <instanceId>i-28a64341</instanceId>
+              <imageId>ami-6ea54007</imageId>
+              <instanceState>
+                <code>0</code>
+                <name>running</name>
+              </instanceState>
+              <privateDnsName>domU-12-31-35-00-1E-01.z-2.compute-1.internal</privateDnsName>
+              <dnsName>ec2-72-44-33-4.z-2.compute-1.amazonaws.com</dnsName>
+              <keyName>example-key-name</keyName>
+              <productCodesSet>
+                <item><productCode>774F4FF8</productCode></item>
+              </productCodesSet>
+              <instanceType>m1.small</instanceType>
+              <launchTime>2007-08-07T11:54:42.000Z</launchTime>
+            </item>
+          </instancesSet>
+        </item>
+      </reservationSet>
+    </DescribeInstancesResponse>
+    RESPONSE
+
+ end
+
+ specify "should be able to be described and return the correct Ruby response class" do
+   @ec2.stubs(:make_request).with('DescribeInstances', {}).
+     returns stub(:body => @describe_instances_response_body, :is_a? => true)
+   @ec2.describe_instances.should.be.an.instance_of Hash
+   response = @ec2.describe_instances
+   response.reservationSet.item[0].reservationId.should.equal "r-44a5402d"
+ end
+
+ specify "should be able to be described and return the correct Ruby response class when the aws/s3 lib is required" do
+   begin
+     require 'aws/s3s'
+     @ec2.stubs(:make_request).with('DescribeInstances', {}).
+       returns stub(:body => @describe_instances_response_body, :is_a? => true)
+     @ec2.describe_instances.should.be.an.instance_of Hash
+     response = @ec2.describe_instances
+     response.reservationSet.item[0].reservationId.should.equal "r-44a5402d"
+   rescue LoadError
+     # do nothing.  no aws/s3 gem installed to test against
+   end
+ end
+
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: grempe-amazon-ec2
 version: !ruby/object:Gem::Version 
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors: 
 - Glenn Rempe
@@ -9,7 +9,7 @@ autorequire: EC2
 bindir: bin
 cert_chain: []
 
-date: 2008-10-27 00:00:00 -07:00
+date: 2009-01-11 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -112,6 +112,7 @@ test_files:
 - test/test_EC2_keypairs.rb
 - test/test_EC2_products.rb
 - test/test_EC2_responses.rb
+- test/test_EC2_s3_xmlsimple.rb
 - test/test_EC2_security_groups.rb
 - test/test_EC2_snapshots.rb
 - test/test_EC2_volumes.rb