green_flag 0.2.0 → 0.3.0

data/CONTRIBUTING.md

@@ -0,0 +1,28 @@
+# Contributing to GreenFlag
+
+## Developing
+
+We're following a pretty standard process for a Github hosted project:
+
+- Fork the project (core team members can skip this and work directly in this repo)
+- Clone to your local machine
+- Create a branch for your changes
+- Push your branch to Github
+- Submit a PR to master.
+- After code review, your PR will be merged into master for inclusion in the next release.
+
+## Release
+
+The `gem-release` gem is included as a development dependency.  Documented here is the "normal release" process using that gem.  More options can be found here: https://github.com/svenfuchs/gem-release
+
+- You should be on the `master` branch, with all of the releasable code merged in.
+- Run `rake spec` to make sure the specs pass.
+- Run this command: `gem bump --version minor --tag`
+  - That's for a "minor" version.  You can also use "major" or "patch".
+  - This does the following:
+    - Increments the version in `lib/green_flag/version.rb` and commits that change
+    - Creates a tag for the new version
+    - Pushes the commits and tag to Github
+- Run this command: `gem release`
+  - This actually pushes the gem to RubyGems.
+- In your project that uses GreenFlag, update to the latest: `bundle update green_flag`

data/app/assets/javascripts/green_flag/admin/feature-deletion.js

@@ -0,0 +1,3 @@
+$(function() {
+  $('.tooltip-wrapper').tooltip({position: 'bottom'});
+});

data/app/assets/javascripts/green_flag/admin/features.js

@@ -350,4 +350,4 @@ GreenFlag.DecisionsView = Backbone.Marionette.ItemView.extend({
     this.model.save({ forget_disabled: true });
   },
 
-});
+});

data/app/assets/stylesheets/green_flag/admin/features.css.scss

@@ -37,4 +37,8 @@ ul.decisions-made-summary {
     font-weight: 500;
     font-size: 24px;
   }
-}
+}
+
+.tooltip-wrapper {
+  display: inline-block;
+}

data/app/controllers/green_flag/admin/features_controller.rb

@@ -1,16 +1,29 @@
 class GreenFlag::Admin::FeaturesController < ApplicationController
-
   layout 'green_flag/application'
+  helper_method :flash_class
 
   def index
     @features = GreenFlag::Feature.order(:created_at).all
   end
 
   def show
-    @feature = GreenFlag::Feature.find(params[:id])
+    @feature = GreenFlag::Feature.where(id: params[:id]).first
+
     @visitor_groups = GreenFlag::VisitorGroup.all.map { |group| { key: group.key, description: group.description } }
   end
 
+  def destroy
+    @feature = GreenFlag::Feature.where(id: params[:id]).first
+
+    if @feature.present?
+      destroy_feature
+    else
+      flash[:error] = "The feature could not be found."
+    end
+
+    redirect_to action: :index
+  end
+
   def current_visitor_status
     @feature = GreenFlag::Feature.find(params[:id])
     fd = GreenFlag::FeatureDecision.for_feature(@feature.id).where(site_visitor_id: current_site_visitor.id).first
@@ -19,6 +32,13 @@ class GreenFlag::Admin::FeaturesController < ApplicationController
 
 private
 
+  def destroy_feature
+    flash[:notice] = "Feature \"#{@feature.code}\" has been successfully deleted."
+
+    @feature.delete_associated_data
+    @feature.destroy
+  end
+
   def status_text(feature_decison)
     if feature_decison.nil? || feature_decison.undecided?
       "Undecided"

data/app/helpers/green_flag/application_helper.rb

@@ -2,3 +2,4 @@ module GreenFlag
   module ApplicationHelper
   end
 end
+

data/app/models/green_flag/feature.rb

@@ -61,7 +61,19 @@ class GreenFlag::Feature < ActiveRecord::Base
   def fully_disabled?
     rules.count == 0 || rules.all? { |rule| rule.percentage == 0 }
   end
-  
+
+  def destroyable?
+    fully_enabled? || fully_disabled?
+  end
+
+  def delete_associated_data
+    GreenFlag::Feature.transaction do
+      GreenFlag::Rule.where(feature_id: id).delete_all
+      GreenFlag::FeatureDecision.where(feature_id: id).delete_all
+      GreenFlag::FeatureEvent.where(feature_id: id).delete_all
+    end
+  end
+
   private
 
   def decide_feature_decision(feature_decision)

data/app/views/green_flag/admin/features/_delete_flag_button.html.erb

@@ -0,0 +1,18 @@
+<%
+  button_class = @feature.destroyable? ? 'btn btn-danger' : 'btn btn-danger disabled'
+
+  confirmation_message = "Are you sure? The feature and all associated rules and \
+decisions will be permanently deleted."
+%>
+
+<% unless @feature.destroyable? %>
+  <div class="tooltip-wrapper" data-title="For deletion, the rules must be set to
+  100% or 0% for all groups. After setting the rule percentages, refresh this page.">
+<% end %>
+
+<%= link_to "Delete Flag", admin_feature_path(@feature.id), class: button_class,
+   data: { confirm: confirmation_message }, method: :delete %>
+
+<% unless @feature.destroyable? %>
+  </div>
+<% end %>

data/app/views/green_flag/admin/features/index.html.erb

@@ -1,3 +1,8 @@
+<% flash.each do |key, value| %>
+  <div class="alert alert-info">
+    <%= value %>
+  </div>
+<% end %>
 
 <div class="header clearfix">
   <h1><%= link_to 'Green Flag', admin_features_path %></h1>

data/app/views/green_flag/admin/features/show.html.erb

@@ -103,8 +103,6 @@
     </ul>
 
   </div>
-
-
 </script>
 
 <%# Templates - white list %>
@@ -134,8 +132,12 @@
   <h2>Your Status <span class="label {{labelClass}}">{{status}}</span></h2>
 </script>
 
+<%= render 'delete_flag_button' %>
+
 <%# Javascript kickstart %>
 <%= javascript_include_tag 'green_flag/admin/features' %>
+<%= javascript_include_tag 'green_flag/admin/feature-deletion' %>
+
 <script>
   GreenFlag.FeatureEditor.start({
     feature: <%= @feature.to_json.html_safe %>,

data/green_flag.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_dependency "activerecord-concurrent-index"
   s.add_dependency "sass-rails"
 
-  s.add_development_dependency 'rspec-rails'
+  s.add_development_dependency 'rspec-rails', "~> 2"
   s.add_development_dependency 'factory_girl_rails'
   s.add_development_dependency 'capybara'
   s.add_development_dependency 'gem-release'

data/lib/green_flag/version.rb

@@ -1,3 +1,3 @@
 module GreenFlag
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/controllers/admin/features_controller_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe GreenFlag::Admin::FeaturesController do
-
   let(:feature) { GreenFlag::Feature.create(code: 'foo') }
 
   describe '#index' do
@@ -16,6 +15,56 @@ describe GreenFlag::Admin::FeaturesController do
       get :show, :id => feature.id
       expect(response).to be_success
     end
-  end  
+  end
+
+  describe "#destroy" do
+    subject { delete :destroy, id: feature.id }
+
+    it "redirects to the index action" do
+      expect(subject).to redirect_to action: :index
+    end
+
+    context "when the feature can be deleted" do
+      before(:each) do
+        5.times do
+          FactoryGirl.create(:green_flag_rule, feature_id: feature.id)
+          FactoryGirl.create(:green_flag_feature_event, feature_id: feature.id)
+          FactoryGirl.create(:green_flag_feature_decision, feature_id: feature.id)
+        end
+
+        subject
+      end
+
+      it "deletes the feature" do
+        expect(GreenFlag::Feature.find_by_id(feature.id)).to be_nil
+      end
 
+      it "deletes the feature's rules" do
+        expect(GreenFlag::Rule.where(feature_id: feature.id)).to eq []
+      end
+
+      it "deletes the feature's events" do
+        expect(GreenFlag::FeatureEvent.where(feature_id: feature.id)).to eq []
+      end
+
+      it "deletes the feature's feature decisions" do
+        expect(GreenFlag::FeatureDecision.where(feature_id: feature.id)).to eq []
+      end
+
+      it "sets a successful flash notice" do
+        expect(flash[:notice]).to eq "Feature \"#{feature.code}\" has been \
+successfully deleted."
+      end
+    end
+
+    context "when the feature cannot be found" do
+      it "sets a flash error indicating the error" do
+        feature.destroy
+
+        subject
+
+        expect(flash[:error]).to eq "The feature could not be found."
+      end
+    end
+  end
 end