RubyGems - green_flag - Versions diffs - 0.1.0 - Mend

green_flag 0.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (136) hide show

data/spec/dummy/public/404.html ADDED Viewed

@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The page you were looking for doesn't exist (404)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/404.html -->
+  <div class="dialog">
+    <h1>The page you were looking for doesn't exist.</h1>
+    <p>You may have mistyped the address or the page may have moved.</p>
+  </div>
+</body>
+</html>

data/spec/dummy/public/422.html ADDED Viewed

@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The change you wanted was rejected (422)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/422.html -->
+  <div class="dialog">
+    <h1>The change you wanted was rejected.</h1>
+    <p>Maybe you tried to change something you didn't have access to.</p>
+  </div>
+</body>
+</html>

data/spec/dummy/public/500.html ADDED Viewed

@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>We're sorry, but something went wrong (500)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/500.html -->
+  <div class="dialog">
+    <h1>We're sorry, but something went wrong.</h1>
+  </div>
+</body>
+</html>

data/spec/dummy/public/favicon.ico ADDED Viewed

File without changes

data/spec/dummy/script/rails ADDED Viewed

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require File.expand_path('../../config/boot',  __FILE__)
+require 'rails/commands'

data/spec/dummy/tmp/cache/assets/C47/3D0/sprockets%2F8f17c33229239b023190617bf2e915a3 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/C81/770/sprockets%2Fdbcf34796b062155788f0b550808541a ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/C89/D60/sprockets%2F73cd073739a0655341b7278fae57518f ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/CB6/8F0/sprockets%2F5ea0f1f2583683678e122a9a9391a80f ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/CD8/370/sprockets%2F357970feca3ac29060c1e3861e2c0953 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/CE7/FF0/sprockets%2Fe45f3a7675a8c5a5b064117792bf5e28 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D07/670/sprockets%2F761d03a66b753d628feccd12072c814c ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D10/860/sprockets%2F4582878dbb5b72bfa76615d31b34ed51 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D13/270/sprockets%2F701a30cd450ae3cfa114092bafc16004 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D15/C10/sprockets%2F6f42f843c916d7864a0dfa912fb3194a ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D18/860/sprockets%2Fce00769800ae939cebb28501947ea96f ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D32/A10/sprockets%2F13fe41fee1fe35b49d145bcc06610705 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D4A/970/sprockets%2F2a7d3b403cbdd8b59d57d26964ea5768 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D4E/1B0/sprockets%2Ff7cbd26ba1d28d48de824f0e94586655 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D59/090/sprockets%2F88788ba6a64e6279624e5c2ff7eead53 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D5A/EA0/sprockets%2Fd771ace226fc8215a3572e0aa35bb0d6 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D5C/330/sprockets%2Fd1b1c9a53f4a8a5827e5b02bf0e100e8 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D68/760/sprockets%2Fea24808c41a3dff75b995b0f090e1a6a ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/D6A/580/sprockets%2F18c12847aa1bb46ce9b5661f0e9e5fb0 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/DA1/210/sprockets%2F25a2979e392c8bc3adce7075cf19ab4b ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/DA9/2C0/sprockets%2Ff95d82b2bbb6db8ffe1a87f67b415291 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/DB2/0C0/sprockets%2F95cf35cd3e97774df3c41ee0ef564a8d ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/DDC/400/sprockets%2Fcffd775d018f68ce5dba1ee0d951a994 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/E04/890/sprockets%2F2f5173deea6c795b8fdde723bb4b63af ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/E07/200/sprockets%2F82a8ce7f5bcfb07f773df4cbfeb04762 ADDED Viewed

Binary file

data/spec/dummy/tmp/cache/assets/E34/D30/sprockets%2F99c2d0bbd78f1b867beeb3a2eefda618 ADDED Viewed

Binary file

data/spec/factories/green_flag/feature.rb ADDED Viewed

@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :green_flag_feature, class: GreenFlag::Feature do
+    code          'feature_code'
+    description   'Feature Description'
+    version_number 1
+  end
+end

data/spec/factories/green_flag/rule.rb ADDED Viewed

@@ -0,0 +1,9 @@
+FactoryGirl.define do
+  factory :green_flag_rule, class: GreenFlag::Rule do
+    group_key      'Factory Test Group'
+    feature_id     1
+    order_by       1
+    percentage     100
+    version_number 1
+  end
+end

data/spec/features/admin_spec.rb ADDED Viewed

@@ -0,0 +1,16 @@
+require "spec_helper"
+feature 'Editing a feature in the admin system' do
+  let(:feature) { FactoryGirl.create(:green_flag_feature) }
+  scenario 'view edit page' do
+    code = feature.code
+    visit '/green_flag/admin/features'
+    expect(page).to have_text(code)
+    click_link code
+    expect(page).to have_text(code)
+  end
+end

data/spec/features/visitor_spec.rb ADDED Viewed

@@ -0,0 +1,36 @@
+require "spec_helper"
+feature 'Visiting a page that checks for a feature' do
+  let(:feature) { FactoryGirl.create(:green_flag_feature, code: 'test_feature') }
+  scenario 'when the feature does not exist' do
+    visit '/feature_checks'
+    expect(page).to have_text("NOT ENABLED")
+  end
+  scenario 'when the feature exists, and is closed' do
+    feature
+    visit '/feature_checks'
+    expect(page).to have_text("NOT ENABLED")
+  end
+  scenario 'when the feature exists, and is closed, but the user is whitelisted' do
+    visit '/feature_checks'
+    expect(page).to have_text("NOT ENABLED")
+    # manually enable the feature for the visitor
+    fd = GreenFlag::FeatureDecision.order(:created_at).last
+    fd.enabled = true
+    fd.save!
+    visit '/feature_checks'
+    expect(page).to have_text("IS ENABLED")
+  end
+  scenario 'when the feature exists, and is open' do
+    pending "Set up a rule with everyone 100% open"
+  end
+end

data/spec/models/green_flag/feature_decision_spec.rb ADDED Viewed

@@ -0,0 +1,102 @@
+require 'spec_helper'
+describe GreenFlag::FeatureDecision do
+  let(:feature) { GreenFlag::Feature.create(code: 'test_feature_code') }
+  let(:site_visitor) { GreenFlag::SiteVisitor.create(visitor_code: '123') }
+  describe '.feature_enabled?' do
+    subject { GreenFlag::FeatureDecision.feature_enabled?(:test_feature_code, site_visitor.id) }
+    it "creates the Feature when it doesn't exist" do
+      expect { subject }.to change { GreenFlag::Feature.count }.by(1)
+    end
+    context 'when the FeatureDecision does not exist' do
+      it 'is false by default' do
+        expect(subject).to be_false
+      end
+      it 'creates a new FeatureDecision' do
+        expect { subject }.to change { GreenFlag::FeatureDecision.count }.by(1)
+      end
+    end
+    context 'when the FeatureDecision exists' do
+      let!(:feature_decision) {
+        GreenFlag::FeatureDecision.create(
+          feature_id: feature.id,
+          site_visitor_id: site_visitor.id,
+          enabled: false)
+      }
+      it 'is false when FeatureDecision is not enabled' do
+        feature_decision.update_attribute(:enabled, false)
+        expect(subject).to be_false
+      end
+      it 'is true when FeatureDecision is enabled' do
+        feature_decision.update_attribute(:enabled, true)
+        expect(subject).to be_true
+      end
+    end
+  end
+  describe '.ensure_feature_enabled' do
+    let(:user) { double(id: 1) }
+    subject { GreenFlag::FeatureDecision.ensure_feature_enabled(feature.code, user) }
+    context 'when the user has no SiteVisitor' do
+      it 'creates a SiteVisitor for the user' do
+        expect { subject }.to change { GreenFlag::SiteVisitor.count }.by(1)
+      end
+    end
+    context 'when the FeatureDecision does not exist' do
+      it 'creates a new FeatureDecision' do
+        expect { subject }.to change { GreenFlag::FeatureDecision.count }.by(1)
+      end
+      it { should be_enabled }
+      it { should_not be_manual }
+    end
+    context 'when the FeatureDecision already exits' do
+      let!(:site_visitor) { GreenFlag::SiteVisitor.create(visitor_code: '123', user_id: user.id) }
+      let!(:feature_decision) { GreenFlag::FeatureDecision.create(feature: feature, site_visitor: site_visitor) }
+      it 'does not creates a new FeatureDecision' do
+        expect { subject }.to_not change { GreenFlag::FeatureDecision.count }
+      end
+      it { should be_enabled }
+      it { should_not be_manual }
+    end
+  end
+  describe 'safe_save!' do
+    let(:feature_id)      { 1 }
+    let(:site_visitor_id) { 1 }
+    context 'when the database already contains a feature decision with the site visitor ID and feature ID' do
+      before(:each) do
+        @existing_fd = GreenFlag::FeatureDecision.create!(feature_id: feature.id, site_visitor_id: site_visitor_id, enabled: false)
+        @new_fd      = GreenFlag::FeatureDecision.new(feature_id: feature.id, site_visitor_id: site_visitor_id, enabled: false)
+      end
+      it 'returns the matching feature decision that was already stored' do
+        expect(@new_fd.safe_save!).to eq @existing_fd
+      end
+    end
+    context 'when the database not already contain a feature decision with the site visitor ID and feature ID' do
+      let(:feature_decision) { GreenFlag::FeatureDecision.new(feature_id: 2, site_visitor_id: 2, enabled: false) }
+      it 'saves the record' do
+        expect(feature_decision).to receive(:save!)
+        feature_decision.safe_save!
+      end
+      it 'returns true' do
+        expect(feature_decision.safe_save!).to eq true
+      end
+    end
+  end
+end

data/spec/models/green_flag/feature_event_spec.rb ADDED Viewed

@@ -0,0 +1,4 @@
+require 'spec_helper'
+describe GreenFlag::FeatureEvent do
+end

data/spec/models/green_flag/feature_spec.rb ADDED Viewed

@@ -0,0 +1,135 @@
+require 'spec_helper'
+  describe GreenFlag::Feature do
+    describe '.for_code!' do
+      subject { GreenFlag::Feature.for_code!('foo') }
+      it 'when feature does not exist, creates a feature' do
+        expect{ subject }.to change { GreenFlag::Feature.count }.by(1)
+      end
+      it 'when feature does exists, does not create a feature' do
+        FactoryGirl.create(:green_flag_feature, code: 'foo')
+        expect{ subject }.to_not change { GreenFlag::Feature.count }
+      end
+    end
+    describe '#decide_if_enabled_for_visitor' do
+      let(:feature)          { GreenFlag::Feature.create(code: 'big_font') }
+      let(:site_visitor_id)  { 1 }
+      let(:non_applying_rule) { double(id: 1, applies_to?: false, decision?: true)  }
+      let(:true_rule)         { double(id: 2, applies_to?: true,  decision?: true)  }
+      let(:false_rule)        { double(id: 3, applies_to?: true,  decision?: false) }
+      context 'there are no rules' do
+        it 'returns a feature decision with the correct attributes' do
+          feature_decision = feature.decide_if_enabled_for_visitor(site_visitor_id)
+          expect(feature_decision.rule_id).to be_nil
+          expect(feature_decision.enabled).to be_nil
+        end
+      end
+      context 'the first applying rule is true' do
+        it 'returns a feature decision with the correct attributes' do
+          feature.stub(rules: [non_applying_rule, true_rule])
+          feature_decision = feature.decide_if_enabled_for_visitor(site_visitor_id)
+          expect(feature_decision.rule_id).to eq true_rule.id
+          expect(feature_decision.enabled).to eq true
+        end
+      end
+      context 'the first applying rule is false' do
+        it 'returns a feature decision with the correct attributes' do
+          feature.stub(rules: [false_rule, true_rule])
+          feature_decision = feature.decide_if_enabled_for_visitor(site_visitor_id)
+          expect(feature_decision.rule_id).to eq false_rule.id
+          expect(feature_decision.enabled).to eq false
+        end
+      end
+    end
+    describe '#forget_non_manual_decisions!' do
+      let(:feature) { GreenFlag::Feature.create(code: 'big_font') }
+      let(:enabled) { true }
+      context 'when there are no decisions' do
+        subject { feature.forget_non_manual_decisions!(enabled) }
+        it 'should not attempt to delete non-manual decisions' do
+          expect(GreenFlag::FeatureDecision.non_manual).to receive(:delete_all).never
+        end
+        it 'should not create a feature event' do
+         expect(GreenFlag::FeatureEvent.count).to eq 0
+       end
+     end
+     context 'when there are manual decisions' do
+       subject { feature.forget_non_manual_decisions!(enabled) }
+       before(:each) do
+         @manual_fd = GreenFlag::FeatureDecision.create!(feature_id: feature.id, manual: true, site_visitor_id: 1)
+       end
+       it 'should not delete the manual decisions' do
+         expect(GreenFlag::FeatureDecision.find_by_id(@manual_fd.id)).to be_present
+       end
+       it 'should not create a feature event' do
+         expect(GreenFlag::FeatureEvent.count).to eq 0
+       end
+     end
+     context 'when there are automatic decisions' do
+       before(:each) do
+         @feature2 = GreenFlag::Feature.create!(code: 'huge_banner_ad')
+         @auto_fd = GreenFlag::FeatureDecision.create!(feature_id: @feature2.id, manual: false, enabled: true, site_visitor_id: 1)
+         @feature2.forget_non_manual_decisions!(enabled)
+       end
+       it 'should delete the automatic decisions' do
+         @feature2.forget_non_manual_decisions!(enabled)
+         expect(GreenFlag::FeatureDecision.find_by_id(@auto_fd)).to be_nil
+       end
+       it 'should create a feature event with the correct attributes' do
+         feature_event = GreenFlag::FeatureEvent.last
+         expect(feature_event).to be_present
+         expect(feature_event.feature_id).to eq @feature2.id
+         expect(feature_event.event_type_code).to eq GreenFlag::FeatureEvent::ENABLED_DECISIONS_FORGOTTEN
+         expect(feature_event.count).to eq 1
+       end
+     end
+   end
+   describe 'latest_version' do
+     let(:feature) { FactoryGirl.create(:green_flag_feature, version_number: 1) }
+     subject { feature.latest_version }
+     context 'when there are rules' do
+       before(:each) do
+         @latest_version_number = 15
+         (0...3).each do |i|
+           FactoryGirl.create(:green_flag_rule, feature_id: feature.id, version_number: @latest_version_number - i)
+         end
+       end
+       it 'returns the version number of the last rule' do
+         expect(subject).to eq @latest_version_number
+       end
+     end
+     context 'when there are no rules' do
+      it 'returns the current version number of the feature' do
+        expect(subject).to eq feature.version_number
+      end
+    end
+  end
+end

data/spec/models/green_flag/rule_spec.rb ADDED Viewed

@@ -0,0 +1,107 @@
+require 'spec_helper'
+describe GreenFlag::Rule do
+  describe '.set_rules!' do
+    let(:feature) { FactoryGirl.create(:green_flag_feature, version_number: 1) }
+    subject { GreenFlag::Rule.set_rules!(feature.id, rules_array) }
+    context 'with no rules in rules_array' do
+      let(:rules_array) { [] }
+      it { should be_empty }
+    end
+    context 'with rules in rules_array' do
+      let(:rules_array) { [{"created_at"=>"2015-02-18T18:30:56Z",
+        "feature_id"=>2,
+        "group_key"=>"Pre-existing Visitors",
+        "id"=>14,
+        "order_by"=>0,
+        "percentage"=>22,
+        "updated_at"=>"2015-02-18T18:30:56Z",
+        "version_number"=>7},
+        {"group_key"=>"Everyone", "percentage"=>"40", "order_by"=>1}]
+      }
+      it 'increments the feature version' do
+        subject
+        expect(feature.reload.version_number).to eq 2
+      end
+      it 'creates the correct number of new rules' do
+        expect { subject }.to change { GreenFlag::Rule.count }.by(2)
+      end
+      it 'creates new rules with the correct attributes' do
+        subject
+        feature.reload
+        rule1 = feature.rules.first
+        rule2 = feature.rules.last
+        expect(rule1.group_key).to      eq 'Pre-existing Visitors'
+        expect(rule1.order_by).to       eq 0
+        expect(rule1.percentage).to     eq 22
+        expect(rule1.version_number).to eq feature.version_number
+        expect(rule2.group_key).to      eq 'Everyone'
+        expect(rule2.order_by).to       eq 1
+        expect(rule2.percentage).to     eq 40
+        expect(rule2.version_number).to eq feature.version_number
+      end
+      it 'returns the newly-created rules' do
+        actual_return_value   = subject
+        feature.reload
+        expected_return_value = [feature.rules.first, feature.rules.last]
+        expect(actual_return_value).to eq expected_return_value
+      end
+    end
+    context 'when the feature is not on the current version due to it having been reverted' do
+      let(:rules_array) { [{"created_at"=>"2015-02-18T18:30:56Z",
+        "feature_id"=>2,
+        "group_key"=>"Pre-existing Visitors",
+        "id"=>14,
+        "order_by"=>0,
+        "percentage"=>22,
+        "updated_at"=>"2015-02-18T18:30:56Z",
+        "version_number"=>7},
+        {"group_key"=>"Everyone", "percentage"=>"40", "order_by"=>1}]
+      }
+      before(:each) do
+        @latest_feature_version = 10
+        FactoryGirl.create(:green_flag_rule, feature_id: feature.id, version_number: @latest_feature_version)
+      end
+      it 'increments the feature version to a higher number than the latest version' do
+        GreenFlag::Rule.set_rules!(feature.id, rules_array)
+        expect(feature.reload.version_number).to eq @latest_feature_version + 1
+      end
+    end
+  end
+  describe '#decision?' do
+    it 'is always false when percentage is 0' do
+      rule = GreenFlag::Rule.new(percentage: 0)
+      10000.times do
+        expect(rule.decision?).to be_false
+      end
+    end
+    it 'is always true when percentage is 100' do
+      rule = GreenFlag::Rule.new(percentage: 100)
+      10000.times do
+        expect(rule.decision?).to be_true
+      end
+    end
+  end
+end