greater_less 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0fc99744d44e587e0d2318b922c499635c9fbc6a
-  data.tar.gz: 1556230bfdbb9f2c1925268292d19b5a6bd2a6ad
+  metadata.gz: 4337084f5e7185bd0e0993401a20bf9f52b1ddef
+  data.tar.gz: 5b5aabce36eae9f2ced08aee0138239fd7258942
 SHA512:
-  metadata.gz: abcc7c867a4678bc6ff1ba99ec1862c59b47aa6cb6343472b1607c3616a94b31ca3cbb8917c060e707fe1715f5e56a07876745910e87104a9f59454beaa1c9d5
-  data.tar.gz: 376abc512619a5810c860ce2fc136ef59b3688d20f2bd48387f62f70527b2f56e2613f199e2601f5e1a2fe150360859a0b6f267fcef3f391ec9a5751c478d43b
+  metadata.gz: 7ad3ad15e0160c1f8521e3b884651f03d2a957151691f50d25f50df91a4f7dbedb5c823a1f971572e87cd777c63a15e12a7fb6c1f8333ca9490bc4c85c3eb3ec
+  data.tar.gz: 7bade3aedfe72d61ffc5c7cce0a138d37c73d3274678bdac96970fde9cf6487dece7b2d8add3aede3d67ec00355e173e0bed1044d32aab67e05b6b8ab441ce1f

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 1.1.0 / 2018-11-14
+
+* Added GreaterLess.parse, which does strict parsing like Float() and Integer() do.
+* Improved whitespace handling for passed strings, strings may now start and end with whitespace, like Float() and Integer() would accept. 
+
 ### 1.0.0 / 2016-09-28
 
 * Dropped support for ruby < 2.2

data/greater_less.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "greater_less"
-  s.version = "1.0.0"
+  s.version = "1.1.0"
 
   s.required_ruby_version = '>= 2.2.0'
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=

data/lib/greater_less.rb

@@ -25,6 +25,9 @@
 # Of course you can opt to create GreaterLess objects using +initialize+ directly, like so:
 # 
 #  value = GreaterLess.new("> 3.45")
+#
+# If you prefer strict string parsing, like Float() and Integer() do for numbers, use `GreaterLess.parse('> 3.3')`.
+# This method will raise an ArgumentRrror if the content is not number like preceded optionally by a < or > sign.
 # 
 # A GreaterLess object can be compared to a Float (or other numeric) as if it were a
 # Float itself. For instance one can do the following:
@@ -91,7 +94,7 @@
 require 'delegate'
 
 class GreaterLess < Delegator
-  GREATER_LESS = /^[<>] ?/
+  GREATER_LESS = /\A\s*[<>] ?/
 
   #:nodoc:
   class << self
@@ -104,16 +107,27 @@ class GreaterLess < Delegator
         content.to_f
       end
     end
+
+    def parse(content)
+      # split the string on the rightmost [<>], if it is not a string, raising nomethod is fine
+      _part_before_sign, _sign, part_after_sign = content.rpartition(GREATER_LESS)
+      # raises if the part after sign (or the whole string) is not numeric
+      Float(part_after_sign)
+      # checks passed, should always be numeric possibly prepended with a [<>]
+      new(content)
+    rescue StandardError
+      raise ArgumentError, "invalid value for GreaterLess.parse: #{content.inspect}"
+    end
   end
 
   def initialize(content)
     if content.is_a? String
-      if content =~ /^>/
+      if content =~ /\A\s*>/
         @sign = ">"
-      elsif content =~ /^</
+      elsif content =~ /\A\s*</
         @sign = "<"
       end
-      @float = content.gsub(/^[<>] ?/, "").to_f
+      @float = content.gsub(GREATER_LESS, "").to_f
     elsif content.is_a? Numeric
       @float = content.to_f
     else

data/spec/greater_less_spec.rb

@@ -315,4 +315,42 @@ describe GreaterLess do
       end
     end
   end
+  describe '.parse' do
+    context 'float string with sign' do
+      subject { GreaterLess.parse(' > 4.5') }
+      it 'returns a GreaterLess object' do
+        expect(subject).to eq(GreaterLess.new('> 4.5'))
+      end
+    end
+    context 'float string with sign and cruft' do
+      subject { GreaterLess.parse('> 4.5 oid') }
+      it 'raises ArgumentError' do
+        expect{subject}.to raise_exception(ArgumentError)
+      end
+    end
+    context 'non float string' do
+      subject { GreaterLess.parse('something') }
+      it 'raises ArgumentError' do
+        expect{subject}.to raise_exception(ArgumentError)
+      end
+    end
+    context 'float string' do
+      subject { GreaterLess.parse('4.5') }
+      it 'returns a GreaterLess object' do
+        expect(subject).to eq(GreaterLess.new('4.5'))
+      end
+    end
+    context 'float string with cruft' do
+      subject { GreaterLess.parse('4.5 oid') }
+      it 'raises ArgumentError' do
+        expect{subject}.to raise_exception(ArgumentError)
+      end
+    end
+    context 'passing nil' do
+      subject { GreaterLess.parse(nil) }
+      it 'raises ArgumentError' do
+        expect{subject}.to raise_exception(ArgumentError)
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: greater_less
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Samuel Esposito
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-28 00:00:00.000000000 Z
+date: 2018-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake