great_pretender 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: eb62253be2761441bf8ea8afce272f260d2a2bb6
-  data.tar.gz: 150374a364f75f88ef4d501e4c8aae17d4314c1c
+SHA256:
+  metadata.gz: 7b0e378c0f00624232fc1ce26fb82fd0ddc54741434d198d93e3b8d9fe15bbb2
+  data.tar.gz: 4577baa21f8a73b61afbad15fbe2c8ecaf66224e52cac0b8f860ff28459b6018
 SHA512:
-  metadata.gz: 2e93f794863f798c0acd61d114bb702f1324d9986e3e29b71cf7a4f9a49071b9b0b5b3db168d346b4d223042d77ac2bb27cc0ab9a3ba3c40b489b284e41199db
-  data.tar.gz: a71df485d09157758175644eea9485ca2ff02e6dd50179dc5771b3bbbf85ddfa9a59fd9d7399193f5338e1f4bd589b55b2af03ffce024c3eb6d17034ab2c88d7
+  metadata.gz: 7862990ed9cf842ae00e97cd2fb6a43305210abd6e871169ded5d14fed1809f9b024cdd168f721016951907145702fab20d18b0ca183f45b1df8f428129ca29b
+  data.tar.gz: acf2e01cfd5ee083b2f814b11689e8900e0a3dc4493237b82ca4e17b6f3c032f505243515aed797d1af08fce07b075d0bab7edf4a79620bc434346a2c8ea2658

data/.rubocop.yml

@@ -0,0 +1,184 @@
+require:
+  - rubocop-ordered_methods
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+  - rubocop-rails
+  - standard
+
+inherit_gem:
+  rubocop-ordered_methods:
+    - config/default.yml
+  rubocop-performance:
+    - config/default.yml
+  rubocop-rails:
+    - config/default.yml
+  rubocop-rspec:
+    - config/default.yml
+  standard:
+    - config/ruby-2.7.yml
+
+AllCops:
+  TargetRubyVersion: 2.7.6
+  NewCops: enable
+  Exclude:
+    - "bin/**/*"
+    - "coverage/**/*"
+    - "db/migrate/*"
+    - "db/schema.rb"
+    - "lib/enum_migration.rb"
+    - "log/**/*"
+    - "node_modules/**/*"
+    - "public/**/*"
+    - "tmp/**/*"
+    - "vendor/**/*"
+
+Layout/FirstHashElementLineBreak:
+  Enabled: true
+
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: true
+
+Layout/HashAlignment:
+  Enabled: true
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+  EnforcedLastArgumentHashStyle: always_inspect
+
+Layout/MultilineArrayLineBreaks:
+  Enabled: true
+
+Layout/MultilineArrayBraceLayout:
+  Enabled: true
+  EnforcedStyle: symmetrical
+
+Layout/MultilineHashBraceLayout:
+  Enabled: true
+  EnforcedStyle: new_line
+
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+  EnforcedStyle: new_line
+
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: true
+
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: true
+
+Layout/ParameterAlignment:
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+
+Layout/RescueEnsureAlignment:
+  Enabled: false
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+# Yo ... `to_i` is gonna have to suffice for now because `Integer(possibly_nil, 10)` explodes, like,
+# all the time
+Lint/NumberConversion:
+  Enabled: false
+
+Rails/DynamicFindBy:
+  Enabled: true
+  AllowedMethods:
+    - find_by_short_id
+    - find_by_slug # Generated by Slugify fairly often
+    - find_by_slug! # Samesies
+    - find_by_variant_slug
+
+Rails/FilePath:
+  EnforcedStyle: arguments
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Rails/RakeEnvironment:
+  Enabled: false
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+Rails/UnknownEnv:
+  Enabled: true
+  Environments:
+    - development
+    - test
+    - production
+    - staging
+
+RSpec/Capybara/FeatureMethods:
+  Enabled: true
+  EnabledMethods:
+    - scenario
+
+RSpec/ContextWording:
+  Enabled: false
+
+RSpec/DescribeClass:
+  Enabled: true
+  Exclude:
+    - spec/system/**/*
+
+RSpec/Dialect:
+  Enabled: false
+  # PreferredMethods:
+  #   context: describe
+
+RSpec/ExampleLength:
+  # Reasoning here is that, let's be honest, this is arbitrary AF. If the specs get out of control,
+  # we'll switch it back on and figure something out. Until then, when you're running assertions
+  # against large multi-line hashes, I'd rather have it be readable rather than arbitrarily short.
+  Enabled: false
+
+RSpec/Focus:
+  AutoCorrect: false
+  Enabled: true
+
+RSpec/MultipleExpectations:
+  Exclude:
+    - spec/controllers/**/*
+    - spec/system/**/*
+  Max: 6
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: true
+  Exclude:
+    - spec/system/**/*
+  Max: 8
+
+RSpec/NestedGroups:
+  Max: 5 # TODO: lower this again someday, but AFTER we pull the letter logic
+
+RSpec/SharedExamples:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  AutoCorrect: true
+  Enabled: true
+  Exclude:
+    - db/data_schema.rb
+
+Style/MissingRespondToMissing:
+  Enabled: false # TODO: I dunno; maybe we do this. But for right now it's a pain in the neck
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+  Enabled: true
+
+Style/SymbolArray:
+  Enabled: true
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/WordArray:
+  Enabled: true

data/Gemfile

@@ -1,10 +1,19 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+ruby "2.7.6"
 
 # Specify your gem's dependencies in great_pretender.gemspec
 gemspec
 
 group :test do
-  gem "rspec-rails"
   gem "codeclimate-test-reporter", require: false
+  gem "rubocop", require: false
+  gem "rubocop-ordered_methods", require: false
+  gem "rubocop-performance", require: false
+  gem "rubocop-rails", require: false
+  gem "rubocop-rspec", require: false
   gem "simplecov", require: false
+  gem "standard", ">= 1.0", require: false
 end

data/README.md

@@ -15,7 +15,6 @@
 - Installs in 2 minutes as a Rails engine
 - Can be mixed in to other controllers for access control or whatever else you want to add
 - Configurable mockups folder name and default layout
-- Dances with wolves
 
 ## Install
 
@@ -75,13 +74,10 @@ If that's the case, you can create your own controller that uses Great Pretender
 
 	```ruby
 	class Admin::MockupsController < Admin::ApplicationController
-
 	  include GreatPretender::Controller
 
 	  before_action :require_admin_user! # or whatever
-
 	  layout 'admin' # or whatever
-
 	end
 	```
 
@@ -163,13 +159,23 @@ A lot of the time you'll want to emulate real data in your views. In those cases
 
 Pretender objects can be any class. They can accept a single argument in `initialize`, which will be the the mockup being rendered, **or** they can skip it entirely.
 
-Any public method you add to a pretender object will be available to the view, just like helper methods.
+An instance of every pretender will be available inside your templates. So for, e.g., a `user_pretender.rb` that defines:
 
-### Load order
+```
+class UserPretender
+	def name
+		"Gary Sinese"
+	end
+end
+```
 
-Pretenders, like layouts, are loaded based on the name of your mockup file. For example, a mockup named "users/login" would look for `app/pretenders/user(s)_pretender.rb` and `app/pretenders/login_pretender.rb`. **Please note** that plurally named templates will support a singular pretender, but singularly named templates will only load singular pretenders.
+You would reference a `user` helper method (or `user_pretender` if `user` is already defined):
 
-Pretenders are delegated to in order of most specific (`LoginPretender`) to least specific (`UserPretender`). So if `LoginPretender` and `UserPretender` both define method `name`, the `LoginPretender`'s implementation will be used.
+```erb
+<%= user.name %> <!-- Outputs "Gary Sinese" -->
+or
+<%= user_pretender.name %> <!-- Outputs same -->
+```
 
 ### Example
 
@@ -181,7 +187,6 @@ Here's an example using the excellent [Faker gem](https://github.com/stympy/fake
 require "faker"
 
 class UserPretender
-
   def login
     Faker::Internet.user_name
   end
@@ -189,7 +194,6 @@ class UserPretender
   def email
     Faker::Internet.email
   end
-
 end
 ```
 
@@ -198,13 +202,12 @@ end
 
 ```slim
 header
-  | Welome back, #{login}!
-  | Your email is set to #{email}
+  | Welome back, #{user.login}!
+  | Your email is set to #{user.email}
 
   / The remainder of your login form mockup...
 ```
 
-
 ## The end!
 
 Thanks for using Great Pretender! I hope it helps you like it's helped us!

data/Rakefile

@@ -1,2 +1,3 @@
-require "bundler/gem_tasks"
+# frozen_string_literal: true
 
+require "bundler/gem_tasks"

data/app/controllers/great_pretender/mockups_controller.rb

@@ -1,9 +1,9 @@
-require 'great_pretender/controller'
+# frozen_string_literal: true
+
+require "great_pretender/controller"
 
 module GreatPretender
   class MockupsController < GreatPretender.config.base_controller
-
     include GreatPretender::Controller
-
   end
 end

data/app/helpers/great_pretender/mockups_helper.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 module GreatPretender
   module MockupsHelper
-
     def great_pretender_mockup_path(mockup)
       if controller.is_a?(GreatPretender::MockupsController)
         great_pretender_engine.mockup_path(mockup)
@@ -8,24 +9,43 @@ module GreatPretender
         path_helper = controller_path.split("/")
         path_helper = path_helper.join("_")
         path_helper = path_helper.singularize
-        path_helper << '_url'
+        path_helper << "_url"
         begin
           send(path_helper, mockup)
-        rescue NoMethodError => error
+        rescue NoMethodError => e
           error_message_subs = [controller_path, path_helper]
-          error_message = I18n.t('great_pretender.missing_helper_methods') % error_message_subs
-          raise MissingPathHelperError.new(error_message, error)
+          error_message = I18n.t("great_pretender.missing_helper_methods") % error_message_subs
+          raise MissingPathHelperError.new(error_message, e)
         end
       end
     end
 
+    private
+
+    # Trap calls to pretenders' names
+    def method_missing(name, *args, &block)
+      prefix = name.to_s.chomp("_pretender")
+      if args.empty? && !block && (class_name = "#{prefix.classify}Pretender").safe_constantize
+        class_eval <<-EOM, __FILE__, __LINE__ + 1
+        def #{prefix}
+          @great_pretender_pretender_#{prefix} ||= begin
+            init = #{class_name}.instance_method(:initialize)
+            init.arity == 1 ? #{class_name}.new(mockup) : #{class_name}.new
+          end
+        end
+        EOM
+
+        return send(prefix)
+      end
+
+      super
+    end
   end
 
   class MissingPathHelperError < StandardError
     def initialize(message, error)
       super(message)
-      @original_error = error
+      @original_error = error # rubocop:disable Rails/HelperInstanceVariable
     end
   end
-
 end

data/app/views/great_pretender/_index.html.erb

@@ -0,0 +1,29 @@
+<% if mockup_locator.mockups.any? %>
+  <table id="mockups">
+    <thead>
+      <tr>
+        <th>Template</th>
+        <th>Last Updated</th>
+      </tr>
+    </thead>
+    <tbody>
+      <% mockup_locator.mockups.each do |mockup| %>
+        <tr>
+          <td>
+            <strong>
+              <%= link_to mockup.name, great_pretender_mockup_path(mockup) %>
+            </strong>
+          </td>
+          <td>
+            <%= time_ago_in_words(mockup.updated_at) %> ago
+          </td>
+        </tr>
+      <% end %>
+    </tbody>
+  </table>
+<% else %>
+  <p>
+    No mockups found. Add a template file to <code><%= mockup_root %></code> to
+    see it listed here.
+  </p>
+<% end %>

data/app/views/great_pretender/index.html.erb

@@ -1,30 +1 @@
-<% if mockups.any? %>
-  <table id="mockups">
-    <thead>
-      <tr>
-        <th>Template</th>
-        <th>Last Updated</th>
-      </tr>
-    </thead>
-    <tbody>
-      <% mockups.each do |mockup| %>
-        <tr>
-          <td>
-            <strong>
-              <%= link_to mockup.name, great_pretender_mockup_path(mockup) %>
-            </strong>
-          </td>
-          <td>
-            <%= time_ago_in_words(mockup.updated_at) %> ago
-          </td>
-        </tr>
-      <% end %>
-    </tbody>
-  </table>
-<% else %>
-  <p>
-    No mockups found. Add a template file to <code><%= mockup_root %></code> to
-    see it listed here.
-  </p>
-<% end %>
-
+<%= render "/great_pretender/index" %>

data/config/routes.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 GreatPretender::Engine.routes.draw do
-  root to: 'great_pretender/mockups#index', as: :mockups
-  get '*id', to: 'great_pretender/mockups#show', as: :mockup
+  root to: "great_pretender/mockups#index", as: :mockups
+  get "*id", to: "great_pretender/mockups#show", as: :mockup
 end

data/great_pretender.gemspec

@@ -1,23 +1,23 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'great_pretender/version'
+require "great_pretender/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "great_pretender"
-  spec.version       = GreatPretender::VERSION
-  spec.authors       = ["Flip Sasser"]
-  spec.email         = ["flip@inthebackforty.com"]
-  spec.summary       = %q{Ridiculously easy-to-use Rails mockups for those enlightened individuals who design in-browser}
-  spec.description   = %q{Use Great Pretender to easily add layout-specific mockups in a Rails app without having to recreate the mockup wheel. Your design should be happening in-browser; this will help you get there.}
-  spec.homepage      = "https://github.com/BackForty/great_pretender"
-  spec.license       = "MIT"
+  spec.name = "great_pretender"
+  spec.version = GreatPretender::VERSION
+  spec.authors = ["Flip Sasser"]
+  spec.email = ["flip@inthebackforty.com"]
+  spec.summary = "Ridiculously easy-to-use Rails mockups for those enlightened individuals who design in-browser"
+  spec.description = "Use Great Pretender to easily add layout-specific mockups in a Rails app without having to recreate the mockup wheel. Your design should be happening in-browser; this will help you get there."
+  spec.homepage = "https://github.com/BackForty/great_pretender"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files -z`.split("\x0")
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "bundler", "~> 2.3"
   spec.add_development_dependency "rake", "~> 10.0"
 end

data/lib/great_pretender/config.rb

@@ -1,14 +1,17 @@
-module GreatPretender
+# frozen_string_literal: true
 
+module GreatPretender
   class Config
-
     attr_accessor :default_layout, :path_separator, :view_path
-    attr_writer :base_controller
 
     def base_controller
-      @base_controller ||= ::ApplicationController
+      @base_controller ||= "::ApplicationController"
+      @base_controller.constantize
     end
 
+    def base_controller=(new_base_controller)
+      @base_controller = new_base_controller.to_s
+    end
   end
 
   def self.config
@@ -18,11 +21,10 @@ module GreatPretender
     end
     @config
   end
-
 end
 
 GreatPretender.config do |c|
-  c.default_layout = 'application'
-  c.path_separator = ' > '
-  c.view_path = 'mockups'
+  c.default_layout = "application"
+  c.path_separator = " > "
+  c.view_path = "mockups"
 end

data/lib/great_pretender/controller.rb

@@ -1,24 +1,24 @@
+# frozen_string_literal: true
+
 require "great_pretender/mockup_locator"
-require "great_pretender/pretender"
 
 module GreatPretender
   module Controller
-
     def self.included(base)
-      base.helper_method :mockups
-      base.helper_method :mockup_root
       base.helper GreatPretender::MockupsHelper
+      base.helper_method :mockup_locator
+      base.helper_method :mockup_root
     end
 
     def index
-      render template: 'great_pretender/index', layout: GreatPretender.config.default_layout
+      render template: "great_pretender/index", layout: GreatPretender.config.default_layout
     end
 
     def show
       if mockup
         render template: mockup.template, layout: mockup.layout
       else
-        error_message = I18n.t('great_pretender.not_found') % params[:id]
+        error_message = I18n.t("great_pretender.not_found") % params[:id]
         raise ActiveRecord::RecordNotFound.new(error_message)
       end
     end
@@ -26,11 +26,8 @@ module GreatPretender
     private
 
     def mockup
-      @great_pretender_mockup ||= mockup_locator.find(params[:id])
-    end
-
-    def mockups
-      @great_pretender_mockups ||= mockup_locator.mockups
+      return @great_pretender_mockup if defined? @great_pretender_mockup
+      @great_pretender_mockup = mockup_locator.find(params[:id])
     end
 
     def mockup_locator
@@ -40,16 +37,5 @@ module GreatPretender
     def mockup_root
       @great_pretender_mockup_root ||= mockup_locator.view_paths.first.join(GreatPretender.config.view_path)
     end
-
-    def pretender
-      @great_pretender_pretender ||= Pretender.new(mockup)
-    end
-
-    def view_context
-      super.tap do |view_context|
-        view_context.extend pretender.to_module if mockup
-      end
-    end
-
   end
 end

data/lib/great_pretender/engine.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module GreatPretender
   class Engine < ::Rails::Engine
     config.generators do |g|
       g.test_framework :rspec
     end
 
-    config.autoload_paths.push(Pathname.new('').join('app', 'pretenders').expand_path.to_s)
+    config.autoload_paths.push(Pathname.new("").join("app", "pretenders").expand_path.to_s)
   end
 end

data/lib/great_pretender/mockup.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/string/inflections"
 require "great_pretender/config"
 
 module GreatPretender
   class Mockup
-
     attr_accessor :layout, :path, :slug, :template
 
-    alias :to_param :slug
+    alias_method :to_param, :slug
 
     def initialize(path)
       @file = Pathname.new(path)
@@ -14,9 +15,9 @@ module GreatPretender
 
     def name
       return @name if defined? @name
-      name = slug.split('/').map { |s| s.titleize }.join(GreatPretender.config.path_separator)
-      if slug =~ /^_/
-        name << ' (partial)'
+      name = slug.split("/").map { |s| s.titleize }.join(GreatPretender.config.path_separator)
+      if /^_/.match?(slug)
+        name << " (partial)"
       end
       @name = name.strip
     end
@@ -24,6 +25,5 @@ module GreatPretender
     def updated_at
       @file.mtime
     end
-
   end
 end

data/lib/great_pretender/mockup_locator.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
+
 require "great_pretender/config"
 require "great_pretender/mockup"
 
 module GreatPretender
   class MockupLocator
-
     attr_reader :view_paths
 
     def find(slug)
-      mockups.find {|mockup| mockup.slug == slug}
+      mockups.find { |mockup| mockup.slug == slug }
     end
 
     def mockups
@@ -36,12 +37,12 @@ module GreatPretender
     def extensions
       return @extensions if defined? @extensions
       extensions = ActionView::Template.template_handler_extensions
-      extensions = extensions.map(&:to_s).join(',')
+      extensions = extensions.map(&:to_s).join(",")
       @extensions = "{#{extensions}}"
     end
 
     def layout_for(slug)
-      if File.basename(slug) =~ /^_/
+      if /^_/.match?(File.basename(slug))
         # Partials (named like "_template_name") don't render inside a layout.
         # This way they can be used w/Ajax requests, etc.
         nil
@@ -49,12 +50,12 @@ module GreatPretender
         # Mockups can have a layout by being in a folder named after that
         # layout; for example, "app/views/mockups/admin/index" will look for an
         # "admin" template
-        layout = slug.split('/')
+        layout = slug.split("/")
         layout.pop
-        layout = layout.join('/')
+        layout = layout.join("/")
         if layout && layout.length > 0
           @view_paths.each do |view_path|
-            layout_path = view_path.join('layouts')
+            layout_path = view_path.join("layouts")
             layout_path = layout_path.join("#{layout}.*#{extensions}")
             return layout if Dir[layout_path].any?
           end
@@ -64,9 +65,12 @@ module GreatPretender
     end
 
     def mockup_for(view_path, root, path)
+      slug = slug_for(root, path)
+      return if slug == "index" # Don't render an index wireframe at the root of our wireframes folder
+
       mockup = Mockup.new(path)
       mockup.path = path
-      mockup.slug = slug_for(root, path)
+      mockup.slug = slug
       mockup.layout = layout_for(mockup.slug)
       mockup.template = template_for(view_path, root, mockup.slug)
       mockup
@@ -75,15 +79,15 @@ module GreatPretender
     def mockups_for(view_path)
       root = view_path.join(GreatPretender.config.view_path)
       templates = Dir[root.join("**/*.#{extensions}")]
-      templates.map do |path|
+      templates.filter_map do |path|
         mockup_for(view_path, root, path)
       end
     end
 
     def slug_for(root, path)
-      slug = path.to_s.gsub(%r{^#{root.to_s}/}, '')
+      slug = path.to_s.gsub(%r{^#{root}/}, "")
       while (ext = File.extname(slug)).length > 0
-        slug = slug.gsub(/#{ext}$/, '')
+        slug = slug.gsub(/#{ext}$/, "")
       end
       slug
     end
@@ -92,6 +96,5 @@ module GreatPretender
       template_root = root.relative_path_from(view_path)
       template_root.join(slug).to_s
     end
-
   end
 end

data/lib/great_pretender/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GreatPretender
-  VERSION = "0.1.4"
+  VERSION = "0.2.0"
 end

data/lib/great_pretender.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "great_pretender/config"
 require "great_pretender/controller"
 require "great_pretender/version"

data/spec/controllers/great_pretender/mockups_controller_spec.rb

@@ -1,7 +1,9 @@
-require 'spec_helper'
-#require 'rspec/rails'
-#require 'great_pretender/mockups_controller'
+# frozen_string_literal: true
 
-#describe GreatPretender::MockupsController do
+require "spec_helper"
+# require 'rspec/rails'
+# require 'great_pretender/mockups_controller'
 
-#end
+# describe GreatPretender::MockupsController do
+
+# end

data/spec/lib/great_pretender/config_spec.rb

@@ -1,39 +1,35 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 module GreatPretender; end
 
 describe GreatPretender do
-
-  context ".config" do
-
+  describe ".config" do
     before { load("great_pretender/config.rb") }
 
     context "default configuration values" do
-
       it "has 'application' as the default layout" do
-        expect(GreatPretender.config.default_layout).to eq("application")
+        expect(described_class.config.default_layout).to eq("application")
       end
 
       it "has 'mockups' as the default view path" do
-        expect(GreatPretender.config.view_path).to eq("mockups")
+        expect(described_class.config.view_path).to eq("mockups")
       end
-
     end
 
     it "accepts a block" do
-      GreatPretender.config do |c|
+      described_class.config do |c|
         c.default_layout = "another_layout"
         c.view_path = "somewhere"
       end
-      expect(GreatPretender.config.default_layout).to eq("another_layout")
-      expect(GreatPretender.config.view_path).to eq("somewhere")
+      expect(described_class.config.default_layout).to eq("another_layout")
+      expect(described_class.config.view_path).to eq("somewhere")
     end
 
     it "can be used for direct setting of configuration options" do
-      GreatPretender.config.default_layout = "a_third_layout"
-      expect(GreatPretender.config.default_layout).to eq("a_third_layout")
+      described_class.config.default_layout = "a_third_layout"
+      expect(described_class.config.default_layout).to eq("a_third_layout")
     end
-
   end
-
 end

data/spec/lib/great_pretender/mockup_locator_spec.rb

@@ -1,25 +1,26 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-require 'great_pretender/mockup_locator'
-require 'pathname'
-require_relative '../../support/mockup_helpers'
+require "spec_helper"
+
+require "great_pretender/mockup_locator"
+require "pathname"
+require_relative "../../support/mockup_helpers"
 
 module ActionView
   module Template
     def self.template_handler_extensions
-      %w(erb slim haml)
+      %w[erb slim haml]
     end
   end
 end
 
 describe GreatPretender::MockupLocator do
-
   include MockupHelpers
 
-  let(:regular_mockup) { mockup_locator.mockups.find {|m| m.slug =~ /^processed/ } }
-  let(:partial_mockup) { mockup_locator.mockups.find {|m| m.slug =~ /^_/ } }
-  let(:admin_mockup) { mockup_locator.mockups.find {|m| m.slug =~ /admin/ } }
-  let(:nested_admin_mockup) { mockup_locator.mockups.find {|m| m.slug =~ /admin\/base/ } }
+  let(:regular_mockup) { mockup_locator.mockups.find { |m| m.slug =~ /^processed/ } }
+  let(:partial_mockup) { mockup_locator.mockups.find { |m| m.slug =~ /^_/ } }
+  let(:admin_mockup) { mockup_locator.mockups.find { |m| m.slug.include?("admin") } }
+  let(:nested_admin_mockup) { mockup_locator.mockups.find { |m| m.slug.include?("admin/base") } }
 
   context "::mockups" do
     it "returns all mockups in the pre-configured mockup directories" do

data/spec/lib/great_pretender/mockup_spec.rb

@@ -1,16 +1,17 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-require 'great_pretender/mockup'
-require_relative '../../support/mockup_helpers'
+require "spec_helper"
 
-describe GreatPretender::Mockup do
+require "great_pretender/mockup"
+require_relative "../../support/mockup_helpers"
 
+describe GreatPretender::Mockup do
   include MockupHelpers
 
-  let(:mockup) { mockup_locator.mockups.find {|m| m.slug =~ /admin/ } }
-  let(:partial) { mockup_locator.mockups.find {|m| m.slug =~ /^_/ } }
+  let(:mockup) { mockup_locator.mockups.find { |m| m.slug.include?("admin") } }
+  let(:partial) { mockup_locator.mockups.find { |m| m.slug =~ /^_/ } }
 
-  context ".name" do
+  describe ".name" do
     it "returns a human-readable name from its slug" do
       expect(mockup.name).to eq("Admin > Index")
     end
@@ -20,17 +21,16 @@ describe GreatPretender::Mockup do
     end
   end
 
-  context ".to_param" do
+  describe ".to_param" do
     it "returns the slug" do
       expect(mockup.to_param).to eq(mockup.slug)
     end
   end
 
-  context ".updated_at" do
+  describe ".updated_at" do
     it "returns the template file's mtime for its slug" do
       `touch #{mockup.path}`
       expect(mockup.updated_at.to_i).to eq(Time.now.to_i)
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 if ENV["CODECLIMATE_REPO_TOKEN"]
   require "codeclimate-test-reporter"
   CodeClimate::TestReporter.start
 else
   require "simplecov"
-  SimpleCov.start do
-    add_filter 'spec'
+  SimpleCov.start "rails" do
+    add_filter "spec"
   end
 end

data/spec/support/mockup_helpers.rb

@@ -1,19 +1,19 @@
+# frozen_string_literal: true
+
 require "ostruct"
 
 module MockupHelpers
   def self.included(base)
     base.class_eval do
-
       let(:paths) do
         [
           Pathname.new("spec/fixtures/view_path_a").expand_path,
           OpenStruct.new(to_path: "spec/fixtures/view_path_b"),
-          OpenStruct.new(to_s: "spec/fixtures/view_path_c")
+          OpenStruct.new(to_s: "spec/fixtures/view_path_c"),
         ]
       end
 
       let(:mockup_locator) { GreatPretender::MockupLocator.new(paths) }
-
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: great_pretender
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Flip Sasser
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-11-20 00:00:00.000000000 Z
+date: 2022-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -49,12 +49,14 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - app/controllers/great_pretender/mockups_controller.rb
 - app/helpers/great_pretender/mockups_helper.rb
+- app/views/great_pretender/_index.html.erb
 - app/views/great_pretender/index.html.erb
 - config/locales/en.yml
 - config/routes.rb
@@ -65,7 +67,6 @@ files:
 - lib/great_pretender/engine.rb
 - lib/great_pretender/mockup.rb
 - lib/great_pretender/mockup_locator.rb
-- lib/great_pretender/pretender.rb
 - lib/great_pretender/version.rb
 - spec/controllers/great_pretender/mockups_controller_spec.rb
 - spec/fixtures/view_path_a/.DS_Store
@@ -80,14 +81,13 @@ files:
 - spec/lib/great_pretender/config_spec.rb
 - spec/lib/great_pretender/mockup_locator_spec.rb
 - spec/lib/great_pretender/mockup_spec.rb
-- spec/lib/great_pretender/pretender_spec.rb
 - spec/spec_helper.rb
 - spec/support/mockup_helpers.rb
 homepage: https://github.com/BackForty/great_pretender
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -102,26 +102,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Ridiculously easy-to-use Rails mockups for those enlightened individuals
   who design in-browser
-test_files:
-- spec/controllers/great_pretender/mockups_controller_spec.rb
-- spec/fixtures/view_path_a/.DS_Store
-- spec/fixtures/view_path_a/layouts/admin.html.slim
-- spec/fixtures/view_path_a/layouts/admin/base.html.slim
-- spec/fixtures/view_path_a/mockups/_partial.haml
-- spec/fixtures/view_path_a/mockups/no_processed.slim
-- spec/fixtures/view_path_a/mockups/processed.html.erb
-- spec/fixtures/view_path_b/mockups/_partial.html.haml
-- spec/fixtures/view_path_b/mockups/admin/base/nested_layout.html.slim
-- spec/fixtures/view_path_b/mockups/admin/index.html.erb
-- spec/lib/great_pretender/config_spec.rb
-- spec/lib/great_pretender/mockup_locator_spec.rb
-- spec/lib/great_pretender/mockup_spec.rb
-- spec/lib/great_pretender/pretender_spec.rb
-- spec/spec_helper.rb
-- spec/support/mockup_helpers.rb
+test_files: []

data/lib/great_pretender/pretender.rb

@@ -1,68 +0,0 @@
-require "active_support/core_ext/string/inflections"
-
-module GreatPretender
-  class Pretender
-
-    def initialize(mockup)
-      @mockup = mockup
-    end
-
-    def to_module
-      pretenders = load_pretenders
-
-      Module.new do
-        define_method(:method_missing) do |method_name, *args, &block|
-          pretender = pretenders.find { |p| p.respond_to?(method_name) }
-
-          if pretender
-            if defined? Rails
-              deprecation_warning = I18n.t('great_pretender.deprecated_pretender')
-              deprecation_warning_args = [method_name, pretender.class.name.underscore.gsub(/_pretender$/, ''), method_name]
-              Rails.logger.debug deprecation_warning % deprecation_warning_args
-            end
-            pretender.send(method_name, *args, &block)
-          else
-            super(method_name, *args, &block)
-          end
-        end
-      end
-    end
-
-    private
-
-    def load_pretender(class_name)
-      class_name = class_name + 'Pretender'
-      begin
-        klass = class_name.constantize
-      rescue NameError
-        return nil
-      end
-
-      initialize = klass.instance_method(:initialize)
-
-      if initialize.arity == 1
-        klass.new(@mockup)
-      else
-        klass.new
-      end
-    end
-
-    def load_pretenders
-      pretenders = []
-      @mockup.slug.split("/").each do |pretender_name|
-        # Given a mockup named something like 'social_contents',
-        # support pretenders named 'SocialContentsPretender' AND 'SocialContentPretender'
-        singular_class = pretender_name.classify
-        plural_class = singular_class.pluralize
-
-        [singular_class, plural_class].each do |class_name|
-          if instance = load_pretender(class_name)
-            pretenders.push(instance)
-          end
-        end
-      end
-      pretenders.reverse
-    end
-
-  end
-end

data/spec/lib/great_pretender/pretender_spec.rb

@@ -1,92 +0,0 @@
-require 'spec_helper'
-
-require 'great_pretender/pretender'
-require 'i18n'
-require 'ostruct'
-
-module Rails
-  def self.logger
-    @logger ||= Class.new do
-      def debug(msg)
-        puts msg
-      end
-    end.new
-  end
-end
-
-class PrefixSlugPretender
-  def say_hello
-    "Hello, guest!"
-  end
-
-  def name
-    "Flip"
-  end
-end
-
-class TestSlugsPretender
-  attr_reader :mockup
-
-  def initialize(mockup)
-    @mockup = mockup
-  end
-
-  def ohai
-    "ohai"
-  end
-
-  def name
-    "Avery"
-  end
-end
-
-
-I18n.load_path = Dir['config/locales/*.yml']
-I18n.enforce_available_locales = false
-
-describe GreatPretender::Pretender do
-
-  let(:mockup) { OpenStruct.new(slug: "prefix_slug/test_slug") }
-  let(:pretender) { GreatPretender::Pretender.new(mockup) }
-  let(:recipient) do
-    mod = pretender.to_module
-    Class.new { include mod }.new
-  end
-
-  let(:deprecation_warning) { }
-
-  before do |example, options|
-    if example.metadata[:deprecations]
-      deprecation_warning = I18n.t('great_pretender.deprecated_pretender')
-      deprecation_warning = deprecation_warning % example.metadata[:deprecations]
-      expect(Rails.logger).to receive(:debug).with(deprecation_warning)
-    end
-  end
-
-  it "delegates methods to pretenders named after mockups", deprecations: %w(ohai test_slugs ohai) do
-    expect(recipient.ohai).to eq("ohai")
-  end
-
-  it "delegates methods to pretenders in the slug chain", deprecations: %w(say_hello prefix_slug say_hello) do
-    expect(recipient.say_hello).to eq("Hello, guest!")
-  end
-
-  it "delegates methods to the most specific responder", deprecations: %w(name test_slugs name) do
-    expect(recipient.name).to eq("Avery")
-  end
-
-  it "passes the mockup to pretenders that accept an initialization argument" do
-    expect(TestSlugsPretender).to receive(:new).with(mockup)
-    recipient
-  end
-
-  it "correctly calls super when a method doesn't exist" do
-    expect(-> { recipient.foobar }).to raise_error(NoMethodError)
-  end
-
-  it "quietly flunks mockups without pretenders" do
-    pretenderless_mockup = OpenStruct.new(slug: "no_pretender_mockup")
-    expect(-> { GreatPretender::Pretender.new(pretenderless_mockup) } ).not_to raise_error
-  end
-
-end