gratitude 0.1.0 → 0.2.0

data/spec/gratitude/statistics_spec.rb

@@ -35,18 +35,18 @@ describe Gratitude::Statistics do
               punc
               statements
               this_thursday
-              tip_distribution_json
+              tip_distribution
               tip_n
               total_backed_tips
               transfer_volume
-              )
+            )
           )
       end
     end
 
     describe "#average_tip_amount" do
       it "returns a float" do
-        expect(stats.average_tip_amount.class).to be(Float)
+        expect(stats.average_tip_amount).to be_a(Float)
       end
 
       it "returns the same value as its alias: #average_tip" do
@@ -56,7 +56,7 @@ describe Gratitude::Statistics do
 
     describe "#average_number_of_tippees" do
       it "returns a fixnum" do
-        expect(stats.average_number_of_tippees.class).to be(Fixnum)
+        expect(stats.average_number_of_tippees).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #average_tippees" do
@@ -66,7 +66,7 @@ describe Gratitude::Statistics do
 
     describe "#amount_in_escrow" do
       it "returns a float" do
-        expect(stats.amount_in_escrow.class).to be(Float)
+        expect(stats.amount_in_escrow).to be_a(Float)
       end
 
       it "returns the same value as its alias: #escrow" do
@@ -76,13 +76,13 @@ describe Gratitude::Statistics do
 
     describe "#last_thursday" do
       it "returns a string" do
-        expect(stats.last_thursday.class).to be(String)
+        expect(stats.last_thursday).to be_a(String)
       end
     end
 
     describe "#number_of_achs" do
       it "returns a fixnum" do
-        expect(stats.number_of_ach_credits.class).to be(Fixnum)
+        expect(stats.number_of_ach_credits).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #nach" do
@@ -96,7 +96,7 @@ describe Gratitude::Statistics do
 
     describe "#number_of_active_users" do
       it "returns a fixnum" do
-        expect(stats.number_of_active_users.class).to be(Fixnum)
+        expect(stats.number_of_active_users).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #nactive" do
@@ -106,7 +106,7 @@ describe Gratitude::Statistics do
 
     describe "#number_of_credit_cards" do
       it "returns a fixnum" do
-        expect(stats.number_of_credit_cards.class).to be(Fixnum)
+        expect(stats.number_of_credit_cards).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #ncc" do
@@ -116,7 +116,7 @@ describe Gratitude::Statistics do
 
     describe "#number_of_givers" do
       it "returns a fixnum" do
-        expect(stats.number_of_givers.class).to be(Fixnum)
+        expect(stats.number_of_givers).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #ngivers" do
@@ -126,7 +126,7 @@ describe Gratitude::Statistics do
 
     describe "#number_who_give_and_receive" do
       it "returns a fixnum" do
-        expect(stats.number_who_give_and_receive.class).to be(Fixnum)
+        expect(stats.number_who_give_and_receive).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #noverlap" do
@@ -136,7 +136,7 @@ describe Gratitude::Statistics do
 
     describe "#number_of_receivers" do
       it "returns a fixnum" do
-        expect(stats.number_of_receivers.class).to be(Fixnum)
+        expect(stats.number_of_receivers).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #nreceivers" do
@@ -146,13 +146,13 @@ describe Gratitude::Statistics do
 
     describe "#other_people" do
       it "returns a string" do
-        expect(stats.other_people.class).to be(String)
+        expect(stats.other_people).to be_a(String)
       end
     end
 
     describe "#percentage_of_users_with_credit_cards" do
       it "returns a string" do
-        expect(stats.percentage_of_users_with_credit_cards.class).to be(String)
+        expect(stats.percentage_of_users_with_credit_cards).to be_a(String)
       end
 
       it "returns the same value as its alias: #pcc" do
@@ -162,7 +162,7 @@ describe Gratitude::Statistics do
 
     describe "#punctuation" do
       it "returns a string" do
-        expect(stats.punctuation.class).to be(String)
+        expect(stats.punctuation).to be_a(String)
       end
 
       it "returns the same value as its alias: #pcc" do
@@ -172,7 +172,7 @@ describe Gratitude::Statistics do
 
     describe "#statements" do
       it "returns an array" do
-        expect(stats.statements.class).to be(Array)
+        expect(stats.statements).to be_a(Array)
       end
 
       it "contain the currect number of elements in the array" do
@@ -180,7 +180,7 @@ describe Gratitude::Statistics do
       end
 
       it "has a hash for each element in the array" do
-        expect(stats.statements.first.class).to be(Hash)
+        expect(stats.statements.first).to be_a(Hash)
       end
 
       it "has statement as a key in each hash element" do
@@ -198,19 +198,23 @@ describe Gratitude::Statistics do
 
     describe "#this_thursday" do
       it "returns a string" do
-        expect(stats.this_thursday.class).to be(String)
+        expect(stats.this_thursday).to be_a(String)
       end
     end
 
-    describe "#tip_distribution_json" do
+    describe "#tip_distribution" do
       it "returns a hash" do
-        expect(stats.tip_distribution_json.class).to be(Hash)
+        expect(stats.tip_distribution).to be_a(Hash)
+      end
+
+      it "returns the same value as its alias: #tip_distribution_json" do
+        expect(stats.tip_distribution).to eq(stats.tip_distribution_json)
       end
     end
 
     describe "#number_of_tips" do
       it "returns a fixnum" do
-        expect(stats.number_of_tips.class).to be(Fixnum)
+        expect(stats.number_of_tips).to be_a(Fixnum)
       end
 
       it "returns the same value as its alias: #tip_n" do
@@ -220,7 +224,7 @@ describe Gratitude::Statistics do
 
     describe "#value_of_total_backed_tips" do
       it "returns a float" do
-        expect(stats.value_of_total_backed_tips.class).to be(Float)
+        expect(stats.value_of_total_backed_tips).to be_a(Float)
       end
 
       it "returns the same value as its alias: #total_backed_tips" do
@@ -230,7 +234,7 @@ describe Gratitude::Statistics do
 
     describe "#transfer_volume" do
       it "returns a float" do
-        expect(stats.transfer_volume.class).to be(Float)
+        expect(stats.transfer_volume).to be_a(Float)
       end
     end
   end

data/spec/gratitude/tips_spec.rb

@@ -14,11 +14,11 @@ describe Gratitude::Client::Tips do
   let(:current_tips) do
     [
       { "amount" => "1.00",
-        "platform" => "gittip",
+        "platform" => "gratipay",
         "username" => "whit537"
       },
       { "amount" => "0.25",
-        "platform" => "gittip",
+        "platform" => "gratipay",
         "username" => "JohnKellyFerguson"
       }
     ]
@@ -61,17 +61,17 @@ describe Gratitude::Client::Tips do
       let(:multiple_tips) do
         [
           { "amount" => "1.00",
-            "platform" => "gittip",
+            "platform" => "gratipay",
             "username" => "whit537"
           },
           { "amount" => "0.25",
-            "platform" => "gittip",
+            "platform" => "gratipay",
             "username" => "JohnKellyFerguson"
           },
           {
             "amount" => "1.00",
-            "platform" => "gittip",
-            "username" => "Gittip"
+            "platform" => "gratipay",
+            "username" => "Gratipay"
           }
         ]
       end
@@ -93,22 +93,22 @@ describe Gratitude::Client::Tips do
           [
             {
               "amount" => "1.00",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "not_a_user_so_fake"
             },
             {
               "amount" => "0.25",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "lol_this_will_be_an_error"
             },
             {
               "amount" => "1.00",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "whit537"
             },
             {
               "amount" => "0.25",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "JohnKellyFerguson"
             }
           ]
@@ -135,12 +135,12 @@ describe Gratitude::Client::Tips do
         [
           {
             "amount" => "1.00",
-            "platform" => "gittip",
+            "platform" => "gratipay",
             "username" => "whit537"
           },
           {
             "amount" => "0.25",
-            "platform" => "gittip",
+            "platform" => "gratipay",
             "username" => "JohnKellyFerguson"
           }
         ]
@@ -153,17 +153,17 @@ describe Gratitude::Client::Tips do
           [
             {
               "amount" => "1.00",
-              "platform" => "gittip",
-              "username" => "Gittip"
+              "platform" => "gratipay",
+              "username" => "Gratipay"
             },
             {
               "amount" => "1.00",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "whit537"
             },
             {
               "amount" => "0.25",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "JohnKellyFerguson"
             }
           ]
@@ -183,12 +183,12 @@ describe Gratitude::Client::Tips do
         let(:incorrect_tips) do
           [
             { "amount" => "1.00",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "not_a_user_so_fake"
             },
             {
               "amount" => "0.25",
-              "platform" => "gittip",
+              "platform" => "gratipay",
               "username" => "will_be_an_error"
             }
           ]

data/spec/gratitude/user_chart_spec.rb

@@ -20,31 +20,31 @@ describe Gratitude::UserChart do
     before(:each) { Gratitude::UserChart::USER_CHARTS = [] }
     describe "#all_for_user" do
       it "returns an array" do
-        expect(Gratitude::UserChart.all_for_user("Gittip").class)
+        expect(Gratitude::UserChart.all_for_user("Gratipay").class)
           .to be(Array)
       end
 
-      context "when the requested Gittip user exists" do
+      context "when the requested Gratipay user exists" do
         it "updates the USER_CHARTS constant when it is empty" do
-          expect { Gratitude::UserChart.all_for_user("Gittip") }
+          expect { Gratitude::UserChart.all_for_user("Gratipay") }
             .to change { Gratitude::UserChart::USER_CHARTS.size }.from(0)
         end
 
         it "its array should be comprised of User_Chart objects" do
-          Gratitude::UserChart.all_for_user("Gittip").each do |user_chart|
+          Gratitude::UserChart.all_for_user("Gratipay").each do |user_chart|
             expect(user_chart.class).to eq(Gratitude::UserChart)
           end
         end
 
         it "only includes charts for a given username" do
           Gratitude::UserChart.all_for_user("whit537")
-          Gratitude::UserChart.all_for_user("Gittip").each do |user_chart|
-            expect(user_chart.username).to eq("Gittip")
+          Gratitude::UserChart.all_for_user("Gratipay").each do |user_chart|
+            expect(user_chart.username).to eq("Gratipay")
           end
         end
       end
 
-      context "when the requested Gittip user does not exist" do
+      context "when the requested Gratipay user does not exist" do
         before { VCR.insert_cassette "user_chart_not_found" }
         after { VCR.eject_cassette }
 
@@ -55,25 +55,21 @@ describe Gratitude::UserChart do
       end
     end
 
-    describe "#sort_by_date_for_user" do
-      it "places the newest user chart before the oldest user chart" do
-        expect(Gratitude::UserChart.sort_by_date_for_user("Gittip").first.date)
-          .to be >
-            (Gratitude::UserChart.sort_by_date_for_user("Gittip").last.date)
-      end
-    end
-
     describe "#newest_for" do
       it "returns the most recent payday" do
-        expect(Gratitude::UserChart.newest_for("Gittip"))
-          .to eq(Gratitude::UserChart.sort_by_date_for_user("Gittip").first)
+        expect(Gratitude::UserChart.newest_for("Gratipay"))
+          .to eq(
+            Gratitude::UserChart.send(:sort_by_date_for_user, "Gratipay").first
+          )
       end
     end
 
     describe "#oldest" do
       it "returns the oldest payday" do
-        expect(Gratitude::UserChart.oldest_for("Gittip"))
-          .to eq(Gratitude::UserChart.sort_by_date_for_user("Gittip").last)
+        expect(Gratitude::UserChart.oldest_for("Gratipay"))
+          .to eq(
+            Gratitude::UserChart.send(:sort_by_date_for_user, "Gratipay").last
+          )
       end
     end
   end
@@ -87,7 +83,7 @@ describe Gratitude::UserChart do
 
     let(:user_chart) do
       Gratitude::UserChart.new(
-          "username" => "Gittip",
+          "username" => "Gratipay",
           "date" => "2014-03-27",
           "npatrons" => 137,
           "receipts" => 416.94
@@ -96,7 +92,7 @@ describe Gratitude::UserChart do
 
     describe "#username" do
       it "sets the correct username" do
-        expect(user_chart.username).to eq("Gittip")
+        expect(user_chart.username).to eq("Gratipay")
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gratitude
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - John Kelly Ferguson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-17 00:00:00.000000000 Z
+date: 2014-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -80,7 +80,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A simple Ruby wrapper for the Gittip API.
+description: A simple Ruby wrapper for the Gratipay API.
 email:
 - hello@johnkellyferguson.com
 executables: []
@@ -159,7 +159,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: A simple Ruby wrapper for the Gittip API.
+summary: A simple Ruby wrapper for the Gratipay API.
 test_files:
 - spec/cassettes/charts.json
 - spec/cassettes/current_tips.json