gratitude 0.0.9 → 0.0.10

data/spec/gratitude/payday_spec.rb

@@ -3,30 +3,23 @@ require "spec_helper"
 describe Gratitude::Payday do
 
   describe "default attributes" do
-
-    it "should include httparty methods" do
-      Gratitude::Payday.should include(HTTParty)
+    it "includes httparty methods" do
+      expect(Gratitude::Payday).to include(HTTParty)
     end
 
-    it "should have the base uri set to gittip's payday api endpoint" do
-      expect(Gratitude::Payday.base_uri).to eq("https://www.gittip.com/about/paydays.json")
+    it "has the base uri set to gittip's payday api endpoint" do
+      expect(Gratitude::Payday.base_uri)
+        .to eq("https://www.gittip.com/about/paydays.json")
     end
 
-    it "should have the PAYDAYS constant initially set to an empty array" do
+    it "initially sets the PAYDAYS constant to an empty array" do
       expect(Gratitude::Payday::PAYDAYS).to eq([])
     end
-
-  end # default attributes
+  end
 
   describe "class methods" do
-
-    before do
-      VCR.insert_cassette "paydays"
-    end
-
-    after do
-      VCR.eject_cassette
-    end
+    before { VCR.insert_cassette "paydays" }
+    after { VCR.eject_cassette }
 
     describe "#get_paydays_from_gittip" do
       it "returns an array" do
@@ -39,7 +32,7 @@ describe Gratitude::Payday do
     end
 
     describe "#collect_paydays" do
-      it "creates all payday objects and puts them in the PAYDAYS constant" do
+      it "creates all payday objects and stores them in the PAYDAYS constant" do
         expect {
           Gratitude::Payday.collect_paydays
         }.to change { Gratitude::Payday::PAYDAYS.size }.from(0).to(68)
@@ -47,9 +40,7 @@ describe Gratitude::Payday do
     end
 
     describe "#all" do
-      before do
-        Gratitude::Payday::PAYDAYS = []
-      end
+      before { Gratitude::Payday::PAYDAYS = [] }
 
       it "returns an array" do
         expect(Gratitude::Payday.all.class).to be(Array)
@@ -90,7 +81,7 @@ describe Gratitude::Payday do
 
   describe "initialization and instance methods" do
 
-    it "should add the initialized object to the PAYDAYS constant" do
+    it "adds the initialized object to the PAYDAYS constant" do
       expect { Gratitude::Payday.new( {
         'ts_end' => "2013-09-12T14:01:41.848587+00:00",
         'ts_start' => "2013-09-12T12:36:52.967371+00:00"
@@ -118,168 +109,167 @@ describe Gratitude::Payday do
     }
 
     describe "#ach_fees_volume" do
-      it "should return the correct ach fees volume" do
+      it "returns the correct ach fees volume" do
         expect(payday.ach_fees_volume).to eq(0)
       end
     end
 
     describe "#ach_volume" do
-      it "should return the correct ach volume" do
+      it "returns the correct ach volume" do
         expect(payday.ach_volume).to eq(-2246.96)
       end
     end
 
     describe "#charge_fees_volume" do
-      it "should return the correct charge fees volume" do
+      it "returns the correct charge fees volume" do
         expect(payday.charge_fees_volume).to eq(216.09)
       end
     end
 
     describe "#charge_volume" do
-      it "should return the correct charge volume" do
+      it "returns the correct charge volume" do
         expect(payday.charge_volume).to eq(4583.22)
       end
     end
 
     describe "#number_of_ach_credits" do
-      it "should return the correct number of achs" do
+      it "returns the correct number of achs" do
         expect(payday.number_of_ach_credits).to eq(53)
       end
 
-
-      it "should return the same value as #nachs" do
+      it "returns the same value as #nachs" do
         expect(payday.number_of_ach_credits).to eq(payday.nachs)
       end
 
-      it "should return the same value as #number_of_achs" do
+      it "returns the same value as #number_of_achs" do
         expect(payday.number_of_ach_credits).to eq(payday.number_of_achs)
       end
     end
 
     describe "#number_of_active_users" do
-      it "should return the correct number active" do
+      it "returns the correct number active" do
         expect(payday.number_of_active_users).to eq(1719)
       end
 
-      it "should return the same value as #nactive" do
+      it "returns the same value as #nactive" do
         expect(payday.number_of_active_users).to eq(payday.nactive)
       end
 
-      it "should return the same value as #number_active" do
+      it "returns the same value as #number_active" do
         expect(payday.number_of_active_users).to eq(payday.number_active)
       end
     end
 
     describe "#number_of_failing_credit_cards" do
-      it "should return the correct number of failing credit cards" do
+      it "returns the correct number of failing credit cards" do
         expect(payday.number_of_failing_credit_cards).to eq(178)
       end
 
-      it "should return the same value as #ncc_failing" do
+      it "returns the same value as #ncc_failing" do
         expect(payday.number_of_failing_credit_cards).to eq(payday.ncc_failing)
       end
     end
 
     describe "#number_of_missing_credit_cards" do
-      it "should return the correct number of missing credit cards" do
+      it "returns the correct number of missing credit cards" do
         expect(payday.number_of_missing_credit_cards).to eq(1222)
       end
 
-      it "should return the same value as #ncc_missing" do
+      it "returns the same value as #ncc_missing" do
         expect(payday.number_of_missing_credit_cards).to eq(payday.ncc_missing)
       end
     end
 
     describe "#number_of_charges" do
-      it "should return the correct number of charges" do
+      it "returns the correct number of charges" do
         expect(payday.number_of_charges).to eq(276)
       end
 
-      it "should return the same value as #ncharges" do
+      it "returns the same value as #ncharges" do
         expect(payday.number_of_charges).to eq(payday.ncharges)
       end
     end
 
     describe "#number_of_participants" do
-      it "should return the correct number of participants" do
+      it "returns the correct number of participants" do
         expect(payday.number_of_participants).to eq(19567)
       end
 
-      it "should return the same value as #nparticipants" do
+      it "returns the same value as #nparticipants" do
         expect(payday.number_of_participants).to eq(payday.nparticipants)
       end
     end
 
     describe "#number_of_tippers" do
-      it "should respond to #number_of_tippers" do
+      it "returns the correct number of tippers" do
         expect(payday.number_of_tippers).to eq(1105)
       end
 
-      it "should return the same value as #ntippers" do
+      it "returns the same value as #ntippers" do
         expect(payday.number_of_tippers).to eq(payday.ntippers)
       end
     end
 
     describe "#number_of_transfers" do
-      it "should return the correct number of transfers" do
+      it "returns the correct number of transfers" do
         expect(payday.number_of_transfers).to eq(3309)
       end
 
-      it "should return the same value as #ntransfers" do
+      it "returns the same value as #ntransfers" do
         expect(payday.number_of_transfers).to eq(payday.ntransfers)
       end
     end
 
     describe "#transfer_volume" do
-      it "should respond to #transfer_volume" do
+      it "responsd to #transfer_volume" do
         expect(payday.transfer_volume).to eq(5464.38)
       end
     end
 
     describe "#transfer_end_time" do
-      it "should return a DateTime object" do
+      it "returns a DateTime object" do
         expect(payday.transfer_end_time.class).to eq(DateTime)
       end
 
-      it "should have the correct year" do
+      it "has the correct year" do
         expect(payday.transfer_end_time.year).to eq(2013)
       end
 
-      it "should have the correct month" do
+      it "has the correct month" do
         expect(payday.transfer_end_time.month).to eq(9)
       end
 
-      it "should have the correct date" do
+      it "has the correct date" do
         expect(payday.transfer_end_time.day).to eq(12)
       end
 
-      it "should return the same value as #ts_end" do
+      it "returns the same value as #ts_end" do
         expect(payday.transfer_end_time).to eq(payday.ts_end)
       end
     end
 
     describe "#transfer_start_time" do
-      it "should return a DateTime object" do
+      it "returns a DateTime object" do
         expect(payday.transfer_start_time.class).to eq(DateTime)
       end
 
-      it "should have the correct year" do
+      it "has the correct year" do
         expect(payday.transfer_start_time.year).to eq(2013)
       end
 
-      it "should have the correct month" do
+      it "has the correct month" do
         expect(payday.transfer_start_time.month).to eq(9)
       end
 
-      it "should have the correct date" do
+      it "has the correct date" do
         expect(payday.transfer_start_time.day).to eq(12)
       end
 
-      it "should return the same value as #ts_start" do
+      it "returns the same value as #ts_start" do
         expect(payday.transfer_start_time).to eq(payday.ts_start)
       end
     end
 
   end # initialization and instance methods
 
-end
+end

data/spec/gratitude/profile_spec.rb

@@ -3,37 +3,26 @@ require "spec_helper"
 describe Gratitude::Profile do
 
   describe "default attributes" do
-
-    it "should include httparty methods" do
-      Gratitude::Profile.should include(HTTParty)
+    it "includes httparty methods" do
+      expect(Gratitude::Profile).to include(HTTParty)
     end
 
-    it "should have the base uri set to the API endpoint" do
+    it "sets the base uri equal to the API endpoint" do
       expect(Gratitude::Profile.base_uri).to eq("https://www.gittip.com")
     end
 
-    it "should have the correct uri suffix" do
+    it "has the correct uri suffix" do
       expect(Gratitude::Profile::URI_SUFFIX).to eq("/public.json")
     end
-
-  end # default attributes
+  end
 
   describe "instance methods" do
 
     context "a fully completed profile" do
-
-      before do
-        VCR.insert_cassette "complete_profile"
-      end
-
-      after do
-        VCR.eject_cassette
-      end
-
+      before { VCR.insert_cassette "complete_profile" }
+      after { VCR.eject_cassette }
       let(:complete_profile) { Gratitude::Profile.new("whit537") }
 
-      subject { :complete_profile }
-
       it "should set the correct username" do
         expect(complete_profile.username).to eq("whit537")
       end
@@ -43,183 +32,181 @@ describe Gratitude::Profile do
       end
 
       describe "#avatar_url" do
-        it "should return the correct avatar url" do
-          expect(complete_profile.avatar_url).to eq("https://www.gravatar.com/avatar/fb054b407a6461e417ee6b6ae084da37.jpg?s=128")
+        it "returns the correct avatar url" do
+          expect(complete_profile.avatar_url)
+            .to eq("https://www.gravatar.com/avatar/fb054b407a6461e417ee6b6ae084da37.jpg?s=128")
         end
 
-        it "should return the same value as its alias: #avatar" do
+        it "returns the same value as its alias: #avatar" do
           expect(complete_profile.avatar_url).to eq(complete_profile.avatar)
         end
       end
 
       describe "#bitbucket_api_url" do
-        it "should return the correct bitbucket api url" do
-          expect(complete_profile.bitbucket_api_url).to eq("https://bitbucket.org/api/1.0/users/whit537")
+        it "returns the correct bitbucket api url" do
+          expect(complete_profile.bitbucket_api_url)
+            .to eq("https://bitbucket.org/api/1.0/users/whit537")
         end
 
-        it "should return the same value as its alias: #bitbucket" do
+        it "returns the same value as its alias: #bitbucket" do
           expect(complete_profile.bitbucket_api_url).to eq(complete_profile.bitbucket)
         end
       end
 
       describe "#bitbucket_username" do
-        it "should return the correct bitbucket username" do
+        it "returns the correct bitbucket username" do
           expect(complete_profile.bitbucket_username).to eq("whit537")
         end
       end
 
       describe "#bountysource_api_url" do
-        it "should return the correct bountysource api url" do
-          expect(complete_profile.bountysource_api_url).to eq("https://api.bountysource.com/users/whit537")
+        it "returns the correct bountysource api url" do
+          expect(complete_profile.bountysource_api_url)
+            .to eq("https://api.bountysource.com/users/whit537")
         end
       end
 
       describe "#bountysource_username" do
-        it "should return the correct bountysource username" do
+        it "returns the correct bountysource username" do
           expect(complete_profile.bountysource_username).to eq("whit537")
         end
       end
 
       describe "#github_api_url" do
-        it "should return the correct github api url" do
-          expect(complete_profile.github_api_url).to eq("https://api.github.com/users/whit537")
+        it "returns the correct github api url" do
+          expect(complete_profile.github_api_url)
+            .to eq("https://api.github.com/users/whit537")
         end
 
-        it "should return the same value as its alias: #github" do
+        it "returns the same value as its alias: #github" do
           expect(complete_profile.github_api_url).to eq(complete_profile.github)
         end
       end
 
       describe "#github_username" do
-        it "should return the correct github username" do
+        it "returns the correct github username" do
           expect(complete_profile.github_username).to eq("whit537")
         end
       end
 
       describe "#twitter_api_url" do
-        it "should return the correct twitter api url" do
-          expect(complete_profile.twitter_api_url).to eq("https://api.twitter.com/1.1/users/show.json?id=34175404&include_entities=1")
+        it "returns the correct twitter api url" do
+          expect(complete_profile.twitter_api_url)
+            .to eq("https://api.twitter.com/1.1/users/show.json?id=34175404&include_entities=1")
         end
 
-        it "should return the same value as its alias: #twitter" do
+        it "returns the same value as its alias: #twitter" do
           expect(complete_profile.twitter_api_url).to eq(complete_profile.twitter)
         end
       end
 
       describe "#twitter_username" do
-        it "should return nil" do
+        it "returns nil" do
           expect(complete_profile.twitter_username).to be(nil)
         end
       end
 
       describe "#amount_giving" do
-        it "should be a float" do
+        it "returns a float" do
           expect(complete_profile.amount_giving.class).to be(Float)
         end
 
-        it "should return the correct amount giving" do
+        it "returns the correct amount giving" do
           expect(complete_profile.amount_giving).to eq(101.41)
         end
 
-        it "should return the same value as its alias: #giving" do
+        it "returns the same value as its alias: #giving" do
           expect(complete_profile.amount_giving).to eq(complete_profile.giving)
         end
       end
 
       describe "#amount_receiving" do
-        it "should be a float" do
+        it "returns a float" do
           expect(complete_profile.amount_receiving.class).to be(Float)
         end
 
-        it "should return the correct amount amount receiving" do
+        it "returns the correct amount amount receiving" do
           expect(complete_profile.amount_receiving).to eq(434.25)
         end
 
-        it "should return the same value as its alias: #receiving" do
-          expect(complete_profile.amount_receiving).to eq(complete_profile.receiving)
+        it "returns the same value as its alias: #receiving" do
+          expect(complete_profile.amount_receiving)
+            .to eq(complete_profile.receiving)
         end
       end
 
       describe "#goal" do
-        it "should return the correct goal" do
+        it "returns the correct goal" do
           expect(complete_profile.goal).to be(nil)
         end
       end
 
       describe "#account_type" do
-        it "should return the correct account_type" do
+        it "returns the correct account_type" do
           expect(complete_profile.account_type).to eq("singular")
         end
 
-        it "should return the same value as its alias: #number" do
+        it "returns the same value as its alias: #number" do
           expect(complete_profile.account_type).to eq(complete_profile.number)
         end
       end
 
       describe "#id" do
-        it "should be a fixnum" do
+        it "returns a fixnum" do
           expect(complete_profile.id.class).to be(Fixnum)
         end
 
-        it "should return the correct id number" do
+        it "returns the correct id number" do
           expect(complete_profile.id).to eq(1451)
         end
       end
 
     end # a fully completed profile
 
-    context "an account that registered through twitter and linked no other accounts" do
-
-      before do
-        VCR.insert_cassette "incomplete_profile"
-      end
-
-      after do
-        VCR.eject_cassette
-      end
-
+    context "an account with only twitter as a linked account" do
+      before { VCR.insert_cassette "incomplete_profile" }
+      after { VCR.eject_cassette }
       let(:incomplete_profile) { Gratitude::Profile.new("gratitude_test") }
 
-
       describe "#bitbucket_api_url" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.bitbucket_api_url).to be(nil)
         end
       end
 
       describe "#bitbucket_username" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.bitbucket_username).to be(nil)
         end
       end
 
       describe "#bountysource_api_url" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.bountysource_api_url).to be(nil)
         end
       end
 
       describe "#bountysource_username" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.bountysource_username).to be(nil)
         end
       end
 
       describe "#github_api_url" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.github_api_url).to be(nil)
         end
       end
 
       describe "#github_username" do
-        it "should return nil" do
+        it "returns nil" do
           expect(incomplete_profile.github_username).to be(nil)
         end
       end
 
       describe "#goal" do
         context "a user who has defined themselves as a patron" do
-          it "should return nil" do
+          it "returns nil" do
             expect(incomplete_profile.goal).to eq(nil)
           end
         end
@@ -228,25 +215,17 @@ describe Gratitude::Profile do
     end # an incomplete profile
 
     context "a profile that has defined a gittip goal" do
-
-      before do
-        VCR.insert_cassette "goal_profile"
-      end
-
-      after do
-        VCR.eject_cassette
-      end
-
+      before { VCR.insert_cassette "goal_profile" }
+      after { VCR.eject_cassette }
       let(:goal_profile) { Gratitude::Profile.new("johnkellyferguson") }
 
       describe "#goal" do
-        it "should return the correct goal amount" do
+        it "returns the correct goal amount" do
           expect(goal_profile.goal).to eq(5.00)
         end
       end
-
     end # a profile with a gittip goal
 
   end # instance methods
 
-end
+end