gratitude 0.0.10 → 0.0.11

data/spec/gratitude/statistics_spec.rb

@@ -3,13 +3,8 @@ require "spec_helper"
 describe Gratitude::Statistics do
 
   describe "default attributes" do
-    it "includes httparty methods" do
-      expect(Gratitude::Statistics).to include(HTTParty)
-    end
-
-    it "sets the base uri equal to gittip's payday api endpoint" do
-      expect(Gratitude::Statistics.base_uri)
-        .to eq("https://www.gittip.com/about/stats.json")
+    it "includes Gratitude::Connection" do
+      expect(Gratitude::Statistics).to include(Gratitude::Connection)
     end
   end
 
@@ -18,15 +13,36 @@ describe Gratitude::Statistics do
     after { VCR.eject_cassette }
     let(:stats) { Gratitude::Statistics.current }
 
-    it "responds to #repsonse" do
-      expect(stats).to respond_to(:response)
+    describe "json response" do
+      it "returns the correct keys in the json hash" do
+        expect(stats.send(:response_body).keys)
+          .to eq(
+            [
+              "average_tip",
+              "average_tippees",
+              "escrow",
+              "last_thursday",
+              "nach",
+              "nactive",
+              "ncc",
+              "ngivers",
+              "noverlap",
+              "nreceivers",
+              "other_people",
+              "pcc",
+              "punc",
+              "statements",
+              "this_thursday",
+              "tip_distribution_json",
+              "tip_n",
+              "total_backed_tips",
+              "transfer_volume"
+              ]
+          )
+      end
     end
 
     describe "#average_tip_amount" do
-      it "returns the correct average tip amount" do
-        expect(stats.average_tip_amount).to eq(1.2348237280979524)
-      end
-
       it "returns a float" do
         expect(stats.average_tip_amount.class).to be(Float)
       end
@@ -37,10 +53,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#average_number_of_tippees" do
-      it "returns the correct average number of tippees" do
-        expect(stats.average_number_of_tippees).to eq(3)
-      end
-
       it "returns a fixnum" do
         expect(stats.average_number_of_tippees.class).to be(Fixnum)
       end
@@ -51,10 +63,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#amount_in_escrow" do
-      it "returns the correct amount in escrow" do
-        expect(stats.amount_in_escrow).to eq(50441.17)
-      end
-
       it "returns a float" do
         expect(stats.amount_in_escrow.class).to be(Float)
       end
@@ -65,20 +73,12 @@ describe Gratitude::Statistics do
     end
 
     describe "#last_thursday" do
-      it "returns the correct value for last thursday" do
-        expect(stats.last_thursday).to eq("last Thursday")
-      end
-
       it "returns a string" do
         expect(stats.last_thursday.class).to be(String)
       end
     end
 
     describe "#number_of_achs" do
-      it "returns the correct number of ach credits" do
-        expect(stats.number_of_ach_credits).to eq(299)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_ach_credits.class).to be(Fixnum)
       end
@@ -93,10 +93,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_of_active_users" do
-      it "returns the correct number of active users" do
-        expect(stats.number_of_active_users).to eq(1719)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_active_users.class).to be(Fixnum)
       end
@@ -107,10 +103,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_of_credit_cards" do
-      it "returns the correct number of credit cards on file" do
-        expect(stats.number_of_credit_cards).to eq(1496)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_credit_cards.class).to be(Fixnum)
       end
@@ -121,10 +113,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_of_givers" do
-      it "returns the correct number of givers" do
-        expect(stats.number_of_givers).to eq(1113)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_givers.class).to be(Fixnum)
       end
@@ -135,10 +123,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_who_give_and_receive" do
-      it "returns the correct number of users who both give and receive" do
-        expect(stats.number_who_give_and_receive).to eq(301)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_who_give_and_receive.class).to be(Fixnum)
       end
@@ -149,10 +133,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_of_receivers" do
-      it "returns the correct number of receivers" do
-        expect(stats.number_of_receivers).to eq(907)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_receivers.class).to be(Fixnum)
       end
@@ -163,20 +143,12 @@ describe Gratitude::Statistics do
     end
 
     describe "#other_people" do
-      it "returns the correct value for #other_people" do
-        expect(stats.other_people).to eq("three other people")
-      end
-
       it "returns a string" do
         expect(stats.other_people.class).to be(String)
       end
     end
 
     describe "#percentage_of_users_with_credit_cards" do
-      it "returns the correct value for #percentage_of_users_with_credit_cards" do
-        expect(stats.percentage_of_users_with_credit_cards).to eq("7.6")
-      end
-
       it "returns a string" do
         expect(stats.percentage_of_users_with_credit_cards.class).to be(String)
       end
@@ -187,10 +159,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#punctuation" do
-      it "returns the correct value for #punctuation" do
-        expect(stats.punctuation).to eq(".")
-      end
-
       it "returns a string" do
         expect(stats.punctuation.class).to be(String)
       end
@@ -214,19 +182,19 @@ describe Gratitude::Statistics do
       end
 
       it "has statement as a key in each hash element" do
-        expect(stats.statements.first.has_key?("statement")).to be(true)
+        stats.statements.each do |statement|
+          expect(statement.has_key?("statement")).to be(true)
+        end
       end
 
       it "has username as a key in each hash element" do
-        expect(stats.statements.first.has_key?("username")).to be(true)
+        stats.statements.each do  |statement|
+          expect(statement.has_key?("username")).to be(true)
+        end
       end
     end
 
     describe "#this_thursday" do
-      it "returns the correct value for this thursday" do
-        expect(stats.this_thursday).to eq("this Thursday")
-      end
-
       it "returns a string" do
         expect(stats.this_thursday.class).to be(String)
       end
@@ -239,10 +207,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#number_of_tips" do
-      it "returns the correct number of tips" do
-        expect(stats.number_of_tips).to eq(4710)
-      end
-
       it "returns a fixnum" do
         expect(stats.number_of_tips.class).to be(Fixnum)
       end
@@ -253,10 +217,6 @@ describe Gratitude::Statistics do
     end
 
     describe "#value_of_total_backed_tips" do
-      it "returns the correct value of total backed tips" do
-        expect(stats.value_of_total_backed_tips).to eq(5849.36)
-      end
-
       it "returns a float" do
         expect(stats.value_of_total_backed_tips.class).to be(Float)
       end
@@ -267,14 +227,10 @@ describe Gratitude::Statistics do
     end
 
     describe "#transfer_volume" do
-      it "returns the correct transfer volume" do
-        expect(stats.transfer_volume).to eq(5464.38)
-      end
-
       it "returns a float" do
         expect(stats.transfer_volume.class).to be(Float)
       end
     end
   end
 
-end
+end

data/spec/gratitude/tips_spec.rb

@@ -8,7 +8,7 @@ describe Gratitude::Client::Tips do
   end
 
   describe "GET Requests" do
-    before { VCR.insert_cassette "get_tips" }
+    before { VCR.insert_cassette "current_tips" }
     after { VCR.eject_cassette }
     let(:current_tips) do
       [
@@ -32,63 +32,45 @@ describe Gratitude::Client::Tips do
 
   describe "POST Requests" do
     describe "#update_tips" do
-      context "when updating a single tip" do
-        before { VCR.insert_cassette "post_single_tip" }
-        after { VCR.eject_cassette }
-        let(:single_tip_response) do
-          [{"amount"=>"5", "platform"=>"gittip", "username"=>"whit537"}]
-        end
-
-        it "updates the correct tip information" do
-          expect(
-            client.update_tips(
-              [{ :username => "whit537", :amount => "5" }]
-              ).parsed_response).to eq(single_tip_response)
-        end
-      end #update_tips
-
-      context "when updating multiple tips" do
-        before { VCR.insert_cassette "post_multiple_tips" }
-        after { VCR.eject_cassette }
-
-        let(:multi_tip_response) do
-          [
-            {"amount"=>"10", "platform"=>"gittip", "username"=>"whit537"},
-            {"amount"=>"4", "platform"=>"gittip", "username"=>"JohnKellyFerguson"}
-          ]
-        end
+      before { VCR.insert_cassette "update_tips" }
+      after { VCR.eject_cassette }
 
-        it "updates the correct tip information" do
-          expect(
-            client.update_tips(
-              [{ :username => "whit537", :amount => "10" },
-               { :username => "JohnKellyFerguson", :amount => "4"}]
-              ).parsed_response).to eq(multi_tip_response)
-        end
-      end # updating multiple tips
+      let(:multiple_tips) do
+        [
+          {"amount"=>"1.00", "platform"=>"gittip", "username"=>"whit537"},
+          {"amount"=>"0.25", "platform"=>"gittip", "username"=>"JohnKellyFerguson"},
+          {"amount"=>"1.00", "platform"=>"gittip", "username"=>"Gittip"}
+        ]
+      end
 
+      it "updates the correct tip information" do
+        expect(client.update_tips(multiple_tips)).to eq(multiple_tips)
+      end
     end #update_tips
 
     describe "#update_tips_and_prune" do
+      before { VCR.insert_cassette "update_and_prune" }
+      after { VCR.eject_cassette }
+
       let(:previous_tips) do
         [
           {"amount"=>"1.00", "platform"=>"gittip", "username"=>"whit537"},
-          {"amount"=>"0.25", "platform"=>"gittip", "username"=>"JohnKellyFerguson"}
+          {"amount"=>"0.25", "platform"=>"gittip", "username"=>"JohnKellyFerguson"},
+          {"amount"=>"1.00", "platform"=>"gittip", "username"=>"Gittip"}
         ]
       end
       let(:pruned_tips) do
-        [{ "amount"=>"1.00", "platform"=>"gittip", "username"=>"whit537" }]
+        [
+          {"amount"=>"1.00", "platform"=>"gittip", "username"=>"whit537"},
+          {"amount"=>"0.25", "platform"=>"gittip", "username"=>"JohnKellyFerguson"}
+        ]
       end
 
-      before { VCR.insert_cassette "update_and_prune" }
-      after { VCR.eject_cassette }
-
       it "removes tips that were not part of the request" do
         expect { client.update_tips_and_prune(pruned_tips) }
           .to change { client.current_tips }
-          .from(previous_tips).to(pruned_tips)
+          .to(pruned_tips)
       end
-
     end
 
   end #POST Requests

data/spec/spec_helper.rb

@@ -16,4 +16,5 @@ VCR.configure do |c|
   c.cassette_library_dir = 'spec/cassettes'
   c.hook_into :webmock
   c.default_cassette_options = { record: :new_episodes, serialize_with: :json }
+  c.default_cassette_options = { re_record_interval: 604800 }
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: gratitude
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - John Kelly Ferguson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2014-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: faraday_middleware
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -78,6 +92,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -85,22 +100,20 @@ files:
 - gratitude.gemspec
 - lib/gratitude.rb
 - lib/gratitude/client.rb
+- lib/gratitude/connection.rb
 - lib/gratitude/payday.rb
 - lib/gratitude/profile.rb
 - lib/gratitude/statistics.rb
 - lib/gratitude/tips.rb
 - lib/gratitude/version.rb
-- spec/cassettes/complete_profile.json
-- spec/cassettes/get_tips.json
-- spec/cassettes/goal_profile.json
-- spec/cassettes/incomplete_profile.json
+- spec/cassettes/current_tips.json
 - spec/cassettes/paydays.json
-- spec/cassettes/post_multiple_tips.json
-- spec/cassettes/post_single_tip.json
-- spec/cassettes/post_tip_error.json
+- spec/cassettes/profiles.json
 - spec/cassettes/statistics.json
 - spec/cassettes/update_and_prune.json
+- spec/cassettes/update_tips.json
 - spec/gratitude/client_spec.rb
+- spec/gratitude/connection_spec.rb
 - spec/gratitude/payday_spec.rb
 - spec/gratitude/profile_spec.rb
 - spec/gratitude/statistics_spec.rb
@@ -132,17 +145,14 @@ signing_key:
 specification_version: 4
 summary: A simple Ruby wrapper for the Gittip API.
 test_files:
-- spec/cassettes/complete_profile.json
-- spec/cassettes/get_tips.json
-- spec/cassettes/goal_profile.json
-- spec/cassettes/incomplete_profile.json
+- spec/cassettes/current_tips.json
 - spec/cassettes/paydays.json
-- spec/cassettes/post_multiple_tips.json
-- spec/cassettes/post_single_tip.json
-- spec/cassettes/post_tip_error.json
+- spec/cassettes/profiles.json
 - spec/cassettes/statistics.json
 - spec/cassettes/update_and_prune.json
+- spec/cassettes/update_tips.json
 - spec/gratitude/client_spec.rb
+- spec/gratitude/connection_spec.rb
 - spec/gratitude/payday_spec.rb
 - spec/gratitude/profile_spec.rb
 - spec/gratitude/statistics_spec.rb