graphql_devise 0.11.0 → 0.12.0

data/spec/requests/mutations/login_spec.rb

@@ -6,12 +6,13 @@ RSpec.describe 'Login Requests' do
   let(:password) { '12345678' }
 
   context 'when using the user model' do
-    let(:user) { create(:user, :confirmed, password: password) }
+    let!(:user) { create(:user, :confirmed, password: password, email: 'vvega@wallaceinc.com') }
+    let(:email) { user.email }
     let(:query) do
       <<-GRAPHQL
         mutation {
           userLogin(
-            email: "#{user.email}",
+            email: "#{email}",
             password: "#{password}"
           ) {
             user { email name signInCount }
@@ -40,6 +41,17 @@ RSpec.describe 'Login Requests' do
           )
           expect(json_response[:errors]).to be_nil
         end
+
+        context 'when email address uses different casing' do
+          let(:email) { 'vVeGa@wallaceinc.com' }
+
+          it 'honors devise configuration for case insensitive fields' do
+            expect(response).to include_auth_headers
+            expect(json_response[:data][:userLogin]).to include(
+              user: { email: user.email, name: user.name, signInCount: 1 }
+            )
+          end
+        end
       end
 
       context 'when credentials are invalid' do

data/spec/requests/mutations/resend_confirmation_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 RSpec.describe 'Resend confirmation' do
   include_context 'with graphql query request'
 
-  let(:user)     { create(:user, confirmed_at: nil) }
+  let!(:user)    { create(:user, confirmed_at: nil, email: 'mwallace@wallaceinc.com') }
   let(:email)    { user.email }
   let(:id)       { user.id }
   let(:redirect) { Faker::Internet.url }
@@ -28,20 +28,20 @@ RSpec.describe 'Resend confirmation' do
     it 'sends an email to the user with confirmation url and returns a success message' do
       expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by(1)
       expect(json_response[:data][:userResendConfirmation]).to include(
+        message:         'You will receive an email with instructions for how to confirm your email address in a few minutes.',
         authenticatable: {
-          id: id,
+          id:    id,
           email: email
-        },
-        message: "You will receive an email with instructions for how to confirm your email address in a few minutes."
+        }
       )
-      
+
       email = Nokogiri::HTML(ActionMailer::Base.deliveries.last.body.encoded)
       link  = email.css('a').first
       confirm_link_msg_text = email.css('p')[1].inner_html
       confirm_account_link_text = link.inner_html
 
-      expect(confirm_link_msg_text).to eq("You can confirm your account email through the link below:")
-      expect(confirm_account_link_text).to eq("Confirm my account")
+      expect(confirm_link_msg_text).to eq('You can confirm your account email through the link below:')
+      expect(confirm_account_link_text).to eq('Confirm my account')
 
       # TODO: Move to feature spec
       expect do
@@ -50,6 +50,21 @@ RSpec.describe 'Resend confirmation' do
       end.to change(user, :confirmed_at).from(NilClass).to(ActiveSupport::TimeWithZone)
     end
 
+    context 'when email address uses different casing' do
+      let(:email) { 'mWallace@wallaceinc.com' }
+
+      it 'honors devise configuration for case insensitive fields' do
+        expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by(1)
+        expect(json_response[:data][:userResendConfirmation]).to include(
+          message:         'You will receive an email with instructions for how to confirm your email address in a few minutes.',
+          authenticatable: {
+            id:    id,
+            email: user.email
+          }
+        )
+      end
+    end
+
     context 'when the user has already been confirmed' do
       before { user.confirm }
 
@@ -58,7 +73,7 @@ RSpec.describe 'Resend confirmation' do
         expect(json_response[:data][:userResendConfirmation]).to be_nil
         expect(json_response[:errors]).to contain_exactly(
           hash_including(
-            message: "Email was already confirmed, please try signing in",
+            message:    'Email was already confirmed, please try signing in',
             extensions: { code: 'USER_ERROR' }
           )
         )
@@ -74,7 +89,7 @@ RSpec.describe 'Resend confirmation' do
       expect(json_response[:data][:userResendConfirmation]).to be_nil
       expect(json_response[:errors]).to contain_exactly(
         hash_including(
-          message: "Unable to find user with email '#{email}'.",
+          message:    "Unable to find user with email '#{email}'.",
           extensions: { code: 'USER_ERROR' }
         )
       )

data/spec/requests/mutations/send_password_reset_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 RSpec.describe 'Send Password Reset Requests' do
   include_context 'with graphql query request'
 
-  let(:user)         { create(:user, :confirmed) }
+  let!(:user)        { create(:user, :confirmed, email: 'jwinnfield@wallaceinc.com') }
   let(:email)        { user.email }
   let(:redirect_url) { Faker::Internet.url }
   let(:query) do
@@ -36,6 +36,14 @@ RSpec.describe 'Send Password Reset Requests' do
     end
   end
 
+  context 'when email address uses different casing' do
+    let(:email) { 'jWinnfield@wallaceinc.com' }
+
+    it 'honors devise configuration for case insensitive fields' do
+      expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by(1)
+    end
+  end
+
   context 'when user email is not found' do
     let(:email) { 'nothere@gmail.com' }
 

data/spec/requests/mutations/sign_up_spec.rb

@@ -55,6 +55,16 @@ RSpec.describe 'Sign Up process' do
           user.reload
         end.to change { user.active_for_authentication? }.to(true)
       end
+
+      context 'when email address uses different casing' do
+        let(:email) { 'miaWallace@wallaceinc.com' }
+
+        it 'honors devise configuration for case insensitive fields' do
+          expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by(1)
+          expect(User.last.email).to eq('miawallace@wallaceinc.com')
+          expect(json_response[:data][:userSignUp]).to include(user: { email: 'miawallace@wallaceinc.com', name: name })
+        end
+      end
     end
 
     context 'when required params are missing' do

data/spec/requests/user_controller_spec.rb

@@ -1,40 +1,196 @@
 require 'rails_helper'
 
-RSpec.describe 'Integrations with the user controller' do
+RSpec.describe "Integrations with the user's controller" do
   include_context 'with graphql query request'
 
   let(:user) { create(:user, :confirmed) }
-  let(:query) do
-    <<-GRAPHQL
-      query {
-        user(
-          id: #{user.id}
-        ) {
-          id
-          email
+
+  describe 'publicField' do
+    let(:query) do
+      <<-GRAPHQL
+        query {
+          publicField
+        }
+      GRAPHQL
+    end
+
+    context 'when using a regular schema' do
+      before { post_request('/api/v1/graphql') }
+
+      it 'does not require authentication' do
+        expect(json_response[:data][:publicField]).to eq('Field does not require authentication')
+      end
+    end
+
+    context 'when using an interpreter schema' do
+      before { post_request('/api/v1/interpreter') }
+
+      it 'does not require authentication' do
+        expect(json_response[:data][:publicField]).to eq('Field does not require authentication')
+      end
+    end
+  end
+
+  describe 'privateField' do
+    let(:query) do
+      <<-GRAPHQL
+        query {
+          privateField
         }
-      }
-    GRAPHQL
+      GRAPHQL
+    end
+
+    context 'when using a regular schema' do
+      before { post_request('/api/v1/graphql') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
+
+        it 'allow to perform the query' do
+          expect(json_response[:data][:privateField]).to eq('Field will always require authentication')
+        end
+      end
+
+      context 'when user is not authenticated' do
+        it 'returns a must sign in error' do
+          expect(json_response[:errors]).to contain_exactly(
+            hash_including(message: 'privateField field requires authentication', extensions: { code: 'USER_ERROR' })
+          )
+        end
+      end
+    end
+
+    context 'when using an interpreter schema' do
+      before { post_request('/api/v1/interpreter') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
+
+        it 'allow to perform the query' do
+          expect(json_response[:data][:privateField]).to eq('Field will always require authentication')
+        end
+      end
+
+      context 'when user is not authenticated' do
+        it 'returns a must sign in error' do
+          expect(json_response[:errors]).to contain_exactly(
+            hash_including(message: 'privateField field requires authentication', extensions: { code: 'USER_ERROR' })
+          )
+        end
+      end
+    end
   end
 
-  before { post_request('/api/v1/graphql') }
+  describe 'dummyMutation' do
+    let(:query) do
+      <<-GRAPHQL
+        mutation {
+          dummyMutation
+        }
+      GRAPHQL
+    end
+
+    context 'when using a regular schema' do
+      before { post_request('/api/v1/graphql') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
 
-  context 'when user is authenticated' do
-    let(:headers) { user.create_new_auth_token }
+        it 'allow to perform the query' do
+          expect(json_response[:data][:dummyMutation]).to eq('Necessary so GraphQL gem does not complain about empty mutation type')
+        end
+      end
 
-    it 'allow to perform the query' do
-      expect(json_response[:data][:user]).to match(
-        email: user.email,
-        id:    user.id
-      )
+      context 'when user is not authenticated' do
+        it 'returns a must sign in error' do
+          expect(json_response[:errors]).to contain_exactly(
+            hash_including(message: 'dummyMutation field requires authentication', extensions: { code: 'USER_ERROR' })
+          )
+        end
+      end
+    end
+
+    context 'when using an interpreter schema' do
+      before { post_request('/api/v1/interpreter') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
+
+        it 'allow to perform the query' do
+          expect(json_response[:data][:dummyMutation]).to eq('Necessary so GraphQL gem does not complain about empty mutation type')
+        end
+      end
+
+      context 'when user is not authenticated' do
+        it 'returns a must sign in error' do
+          expect(json_response[:errors]).to contain_exactly(
+            hash_including(message: 'dummyMutation field requires authentication', extensions: { code: 'USER_ERROR' })
+          )
+        end
+      end
     end
   end
 
-  context 'when user is not authenticated' do
-    it 'returns a must sign in error' do
-      expect(json_response[:errors]).to contain_exactly(
-        'You need to sign in or sign up before continuing.'
-      )
+  describe 'user' do
+    let(:query) do
+      <<-GRAPHQL
+        query {
+          user(
+            id: #{user.id}
+          ) {
+            id
+            email
+          }
+        }
+      GRAPHQL
+    end
+
+    context 'when using a regular schema' do
+      before { post_request('/api/v1/graphql') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
+
+        it 'allow to perform the query' do
+          expect(json_response[:data][:user]).to match(
+            email: user.email,
+            id:    user.id
+          )
+        end
+      end
+
+      context 'when user is not authenticated' do
+        it 'returns a must sign in error' do
+          expect(json_response[:errors]).to contain_exactly(
+            hash_including(message: 'user field requires authentication', extensions: { code: 'USER_ERROR' })
+          )
+        end
+      end
+    end
+
+    context 'when using an interpreter schema' do
+      before { post_request('/api/v1/interpreter') }
+
+      context 'when user is authenticated' do
+        let(:headers) { user.create_new_auth_token }
+
+        it 'allow to perform the query' do
+          expect(json_response[:data][:user]).to match(
+            email: user.email,
+            id:    user.id
+          )
+        end
+      end
+
+      context 'when user is not authenticated' do
+        # Interpreter schema fields are public unless specified otherwise (plugin setting)
+        it 'allow to perform the query' do
+          expect(json_response[:data][:user]).to match(
+            email: user.email,
+            id:    user.id
+          )
+        end
+      end
     end
   end
 end

data/spec/services/mount_method/operation_preparer_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe GraphqlDevise::MountMethod::OperationPreparer do
   describe '#call' do
     subject(:prepared_operations) do
       described_class.new(
-        resource:              resource,
+        mapping_name:          mapping,
         selected_operations:   selected,
         preparer:              preparer,
         custom:                custom,
@@ -13,7 +13,7 @@ RSpec.describe GraphqlDevise::MountMethod::OperationPreparer do
     end
 
     let(:logout_class) { Class.new(GraphQL::Schema::Resolver) }
-    let(:resource)     { 'User' }
+    let(:mapping)      { :user }
     let(:selected)     { { login: double(:login_default), logout: logout_class } }
     let(:preparer)     { double(:preparer, call: logout_class) }
     let(:custom)       { { login: double(:custom_login, graphql_name: nil) } }

data/spec/services/mount_method/operation_preparers/custom_operation_preparer_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe GraphqlDevise::MountMethod::OperationPreparers::CustomOperationPr
 
     let(:login_operation)  { double(:confirm_operation, graphql_name: nil) }
     let(:logout_operation) { double(:sign_up_operation, graphql_name: nil) }
-    let(:mapping_name)     { 'user' }
+    let(:mapping_name)     { :user }
     let(:operations)       { { login: login_operation, logout: logout_operation, invalid: double(:invalid) } }
     let(:selected_keys)    { [:login, :logout, :sign_up, :confirm] }
 

data/spec/services/mount_method/operation_preparers/default_operation_preparer_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe GraphqlDevise::MountMethod::OperationPreparers::DefaultOperationP
     let(:sign_up_operation) { double(:sign_up_operation, graphql_name: nil) }
     let(:login_operation)   { double(:confirm_operation, graphql_name: nil) }
     let(:logout_operation)  { double(:sign_up_operation, graphql_name: nil) }
-    let(:mapping_name)      { 'user' }
+    let(:mapping_name)      { :user }
     let(:preparer)          { double(:preparer) }
     let(:operations)        { { login: login_operation, logout: logout_operation, sign_up: sign_up_operation, confirm: confirm_operation } }
     let(:custom_keys)       { [:login, :logout] }

data/spec/services/mount_method/operation_preparers/resource_name_setter_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe GraphqlDevise::MountMethod::OperationPreparers::ResourceNameSette
     subject(:prepared_operation) { described_class.new(mapping_name).call(operation) }
 
     let(:operation)    { double(:operation) }
-    let(:mapping_name) { 'user' }
+    let(:mapping_name) { :user }
 
     it 'sets a gql name to the operation' do
       expect(prepared_operation.instance_variable_get(:@resource_name)).to eq(:user)

data/spec/services/resource_loader_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::ResourceLoader do
+  describe '#call' do
+    subject(:loader) { described_class.new(resource, options, routing).call(query, mutation) }
+
+    let(:query)    { class_double(GraphQL::Schema::Object) }
+    let(:mutation) { class_double(GraphQL::Schema::Object) }
+    let(:routing)  { false }
+    let(:mounted)  { false }
+    let(:resource) { 'User' }
+    let(:options)  { { only: [:login, :confirm_account] } }
+
+    before do
+      allow(GraphqlDevise).to receive(:add_mapping).with(:user, resource)
+      allow(GraphqlDevise).to receive(:resource_mounted?).with(:user).and_return(mounted)
+      allow(GraphqlDevise).to receive(:mount_resource).with(:user)
+    end
+
+    it 'loads operations into the provided types' do
+      expect(query).to             receive(:field).with(:user_confirm_account, resolver: instance_of(Class), authenticate: false)
+      expect(mutation).to          receive(:field).with(:user_login, mutation: instance_of(Class), authenticate: false)
+      expect(GraphqlDevise).to     receive(:add_mapping).with(:user, resource)
+      expect(GraphqlDevise).not_to receive(:mount_resource)
+
+      returned = loader
+
+      expect(returned).to be_a(Struct)
+    end
+
+    context 'when mutation is nil' do
+      let(:mutation) { nil }
+
+      it 'raises an error' do
+        expect { loader }.to raise_error(
+          GraphqlDevise::Error,
+          'You need to provide a mutation type unless all mutations are skipped'
+        )
+      end
+    end
+
+    context 'when query is nil' do
+      let(:query) { nil }
+
+      before { allow(mutation).to receive(:field) }
+
+      it 'raises an error' do
+        expect { loader }.to raise_error(
+          GraphqlDevise::Error,
+          'You need to provide a query type unless all queries are skipped'
+        )
+      end
+    end
+
+    context 'when invoked from router' do
+      let(:routing) { true }
+
+      before do
+        allow(query).to    receive(:field)
+        allow(mutation).to receive(:field)
+      end
+
+      it 'adds mappings' do
+        expect(GraphqlDevise).to receive(:add_mapping).with(:user, resource)
+        expect(GraphqlDevise).to receive(:mount_resource).with(:user)
+
+        loader
+      end
+
+      context 'when resource was already mounted' do
+        before { allow(GraphqlDevise).to receive(:resource_mounted?).with(:user).and_return(true) }
+
+        it 'skips schema loading' do
+          expect(query).not_to         receive(:field)
+          expect(mutation).not_to      receive(:field)
+          expect(GraphqlDevise).not_to receive(:add_mapping).with(:user, resource)
+          expect(GraphqlDevise).not_to receive(:mount_resource)
+        end
+      end
+    end
+  end
+end